[opensource-dev] Question about DD philosophy.

[Lee ponzu]

I have sometimes wondered why this is not more automagic, or maybe why the
magic approach doesn't work well enough.

Suppose my DD is set to 256.  Upon detecting a poor FPS, the viewer could
remember the DD, and then reduce it temporarily to 32.  As FPS becomes
acceptable, it increases it little by little until it is 256 again.  Is
there not code sort of like that already in there?  (I know, I could go
look, but I have fallen way behind on the source code and the builds, so all
I do now is kvetch from the outside).

A similar approach would be to slowly adjust the DD to keep FPS acceptable.

It seems like these DD slider changes are exactly giving the user a manual
way to do this. Why not just have the viewer do it?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Question about DD philosophy.

[Marine Kelley]

I think (correct me if I'm wrong) that everytime you increase your
draw distance, your viewer requests all the prims to rez from the
sim... Which means a lot more network traffic if it changes all the
time (which would be the case if it were automatic).

Besides I like to keep control over my draw distance. I vote for
keeping it manual.

Marine

On 16/06/2011, Lee ponzu  wrote:
> I have sometimes wondered why this is not more automagic, or maybe why the
> magic approach doesn't work well enough.
>
> Suppose my DD is set to 256.  Upon detecting a poor FPS, the viewer could
> remember the DD, and then reduce it temporarily to 32.  As FPS becomes
> acceptable, it increases it little by little until it is 256 again.  Is
> there not code sort of like that already in there?  (I know, I could go
> look, but I have fallen way behind on the source code and the builds, so all
> I do now is kvetch from the outside).
>
> A similar approach would be to slowly adjust the DD to keep FPS acceptable.
>
> It seems like these DD slider changes are exactly giving the user a manual
> way to do this. Why not just have the viewer do it?
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Question about DD philosophy.

[Jonathan Welch]

At yesterday's meeting with Oz having a FPS auto-tune system was
discussed.  I am going to try to write up a description of how this
could be implemented and once it is fleshed out will post it here for
comments.

-jonathan
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1320 Create a 3p-libndofdev-linux repo based on version 0.3 of Jan Ciger's linux libndofdev.

[Log Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/340/
---

Review request for Viewer, Oz Linden, Boroondas Gupte, and Altair Memo.


Summary
---

Checked in version 0.3 of Jan Ciger's libndofdev drop-in replacement for linux.
* Added cmake build configuration.
* Added autobuild package configuration.
* Created libndofdev.txt license file from ndofdev.c file header.
* Added README to explain that this is only for use in the linux viewer.

BUGFIXES:
* OPEN-21 STORM-312 This version of libndofdev supports kernel versions >= 
2.6.33.

When reviewing, please provide extra scrutiny to autobuild.xml and 
CMakeLists.txt, since those are the files I actually edited.


This addresses bugs OPEN-21, STORM-1320 and STORM-312.
http://jira.secondlife.com/browse/OPEN-21
http://jira.secondlife.com/browse/STORM-1320
http://jira.secondlife.com/browse/STORM-312


Diffs
-

  autobuild.xml PRE-CREATION 
  libndofdev/CHANGELOG PRE-CREATION 
  libndofdev/CMakeLists.txt PRE-CREATION 
  libndofdev/LICENSES/libndofdev.txt PRE-CREATION 
  libndofdev/README PRE-CREATION 
  libndofdev/include/ndofdev_external.h PRE-CREATION 
  libndofdev/ndofdev.c PRE-CREATION 

Diff: http://codereview.secondlife.com/r/340/diff


Testing
---

This built successfully on TeamCity and the packaged library worked correctly 
when I extracted it into the packages directory of the viewer build tree ( 
build-linux-i686/packages ).  My spacenavigator, which hasn't worked in six 
months, started working with the new build.


Thanks,

Log

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/341/
---

Review request for Viewer.


Summary
---

Apparently, a nearby chat toast got somehow destroyed while still remaining in 
the list of active toasts.
Attempt to sort active toasts in showToastsBottom() then triggered the crash.

I don't know how to reproduce the crash, i.e. force destroying a toast in a way 
that its onClose() method (which would remove references to the toast) isn't 
called.
So we'll just remove references to the toast whenever it's destroyed.


This addresses bug STORM-1352.
http://jira.secondlife.com/browse/STORM-1352


Diffs
-

  indra/newview/llnearbychathandler.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/341/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1320 Create a 3p-libndofdev-linux repo based on version 0.3 of Jan Ciger's linux libndofdev.

[Altair Memo]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/340/#review758
---

Ship it!


- Altair


On June 16, 2011, 1:32 p.m., Log Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/340/
> ---
> 
> (Updated June 16, 2011, 1:32 p.m.)
> 
> 
> Review request for Viewer, Oz Linden, Boroondas Gupte, and Altair Memo.
> 
> 
> Summary
> ---
> 
> Checked in version 0.3 of Jan Ciger's libndofdev drop-in replacement for 
> linux.
> * Added cmake build configuration.
> * Added autobuild package configuration.
> * Created libndofdev.txt license file from ndofdev.c file header.
> * Added README to explain that this is only for use in the linux viewer.
> 
> BUGFIXES:
> * OPEN-21 STORM-312 This version of libndofdev supports kernel versions >= 
> 2.6.33.
> 
> When reviewing, please provide extra scrutiny to autobuild.xml and 
> CMakeLists.txt, since those are the files I actually edited.
> 
> 
> This addresses bugs OPEN-21, STORM-1320 and STORM-312.
> http://jira.secondlife.com/browse/OPEN-21
> http://jira.secondlife.com/browse/STORM-1320
> http://jira.secondlife.com/browse/STORM-312
> 
> 
> Diffs
> -
> 
>   autobuild.xml PRE-CREATION 
>   libndofdev/CHANGELOG PRE-CREATION 
>   libndofdev/CMakeLists.txt PRE-CREATION 
>   libndofdev/LICENSES/libndofdev.txt PRE-CREATION 
>   libndofdev/README PRE-CREATION 
>   libndofdev/include/ndofdev_external.h PRE-CREATION 
>   libndofdev/ndofdev.c PRE-CREATION 
> 
> Diff: http://codereview.secondlife.com/r/340/diff
> 
> 
> Testing
> ---
> 
> This built successfully on TeamCity and the packaged library worked correctly 
> when I extracted it into the packages directory of the viewer build tree ( 
> build-linux-i686/packages ).  My spacenavigator, which hasn't worked in six 
> months, started working with the new build.
> 
> 
> Thanks,
> 
> Log
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/341/
---

(Updated June 16, 2011, 1:52 p.m.)


Review request for Viewer.


Changes
---

Added NULL checks to the sort functor.


Summary
---

Apparently, a nearby chat toast got somehow destroyed while still remaining in 
the list of active toasts.
Attempt to sort active toasts in showToastsBottom() then triggered the crash.

I don't know how to reproduce the crash, i.e. force destroying a toast in a way 
that its onClose() method (which would remove references to the toast) isn't 
called.
So we'll just remove references to the toast whenever it's destroyed.


This addresses bug STORM-1352.
http://jira.secondlife.com/browse/STORM-1352


Diffs (updated)
-

  indra/newview/llnearbychathandler.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/341/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/341/#review759
---



indra/newview/llnearbychathandler.cpp


This function's return type should be changed to bool, if it's intended for 
use with std::sort. (And that's how it's being used currently.)


- Boroondas


On June 16, 2011, 1:52 p.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/341/
> ---
> 
> (Updated June 16, 2011, 1:52 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Apparently, a nearby chat toast got somehow destroyed while still remaining 
> in the list of active toasts.
> Attempt to sort active toasts in showToastsBottom() then triggered the crash.
> 
> I don't know how to reproduce the crash, i.e. force destroying a toast in a 
> way that its onClose() method (which would remove references to the toast) 
> isn't called.
> So we'll just remove references to the toast whenever it's destroyed.
> 
> 
> This addresses bug STORM-1352.
> http://jira.secondlife.com/browse/STORM-1352
> 
> 
> Diffs
> -
> 
>   indra/newview/llnearbychathandler.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/341/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1320 Create a 3p-libndofdev-linux repo based on version 0.3 of Jan Ciger's linux libndofdev.

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/340/#review760
---


Tested: I can produce a package with:

autobuild install
autobuild build
autobuild package

Haven't tested the resulting package, but it's content looks reasonable.


autobuild.xml


I guess it's not a problem that the paths in the package will collide with 
the paths of the non-linux libndofdev package, or is it?

(If they were built from the same source, they'd collide too, wouldn't 
they?)



libndofdev/CMakeLists.txt


Jan Ciger's libndofdev comes with a Makefile. Why not use that?

This lib is linux-specific, so we don't need a cross-platform build 
configuration for it.



libndofdev/CMakeLists.txt


If these flags are added unconditionally, how would one do a 64-bit build? 
Maybe check for WORD_SIZE, like the viewer build does.



libndofdev/CMakeLists.txt


Might be worth mentioning the non-linux libndofdev (and where to find it) 
in the error message.


- Boroondas


On June 16, 2011, 1:32 p.m., Log Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/340/
> ---
> 
> (Updated June 16, 2011, 1:32 p.m.)
> 
> 
> Review request for Viewer, Oz Linden, Boroondas Gupte, and Altair Memo.
> 
> 
> Summary
> ---
> 
> Checked in version 0.3 of Jan Ciger's libndofdev drop-in replacement for 
> linux.
> * Added cmake build configuration.
> * Added autobuild package configuration.
> * Created libndofdev.txt license file from ndofdev.c file header.
> * Added README to explain that this is only for use in the linux viewer.
> 
> BUGFIXES:
> * OPEN-21 STORM-312 This version of libndofdev supports kernel versions >= 
> 2.6.33.
> 
> When reviewing, please provide extra scrutiny to autobuild.xml and 
> CMakeLists.txt, since those are the files I actually edited.
> 
> 
> This addresses bugs OPEN-21, STORM-1320 and STORM-312.
> http://jira.secondlife.com/browse/OPEN-21
> http://jira.secondlife.com/browse/STORM-1320
> http://jira.secondlife.com/browse/STORM-312
> 
> 
> Diffs
> -
> 
>   autobuild.xml PRE-CREATION 
>   libndofdev/CHANGELOG PRE-CREATION 
>   libndofdev/CMakeLists.txt PRE-CREATION 
>   libndofdev/LICENSES/libndofdev.txt PRE-CREATION 
>   libndofdev/README PRE-CREATION 
>   libndofdev/include/ndofdev_external.h PRE-CREATION 
>   libndofdev/ndofdev.c PRE-CREATION 
> 
> Diff: http://codereview.secondlife.com/r/340/diff
> 
> 
> Testing
> ---
> 
> This built successfully on TeamCity and the packaged library worked correctly 
> when I extracted it into the packages directory of the viewer build tree ( 
> build-linux-i686/packages ).  My spacenavigator, which hasn't worked in six 
> months, started working with the new build.
> 
> 
> Thanks,
> 
> Log
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1320 Create a 3p-libndofdev-linux repo based on version 0.3 of Jan Ciger's linux libndofdev.

[Jonathan Yap]

> On June 16, 2011, 4:59 p.m., Boroondas Gupte wrote:
> > libndofdev/CMakeLists.txt, lines 27-30
> > 
> >
> > Might be worth mentioning the non-linux libndofdev (and where to find 
> > it) in the error message.

On windows I already get 4 lines such as: 
package pcre has no installation information configured for platform windows
which is plenty of information for a package I have no need of; let's not put 
too much unnecessary text on the screen.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/340/#review760
---


On June 16, 2011, 1:32 p.m., Log Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/340/
> ---
> 
> (Updated June 16, 2011, 1:32 p.m.)
> 
> 
> Review request for Viewer, Oz Linden, Boroondas Gupte, and Altair Memo.
> 
> 
> Summary
> ---
> 
> Checked in version 0.3 of Jan Ciger's libndofdev drop-in replacement for 
> linux.
> * Added cmake build configuration.
> * Added autobuild package configuration.
> * Created libndofdev.txt license file from ndofdev.c file header.
> * Added README to explain that this is only for use in the linux viewer.
> 
> BUGFIXES:
> * OPEN-21 STORM-312 This version of libndofdev supports kernel versions >= 
> 2.6.33.
> 
> When reviewing, please provide extra scrutiny to autobuild.xml and 
> CMakeLists.txt, since those are the files I actually edited.
> 
> 
> This addresses bugs OPEN-21, STORM-1320 and STORM-312.
> http://jira.secondlife.com/browse/OPEN-21
> http://jira.secondlife.com/browse/STORM-1320
> http://jira.secondlife.com/browse/STORM-312
> 
> 
> Diffs
> -
> 
>   autobuild.xml PRE-CREATION 
>   libndofdev/CHANGELOG PRE-CREATION 
>   libndofdev/CMakeLists.txt PRE-CREATION 
>   libndofdev/LICENSES/libndofdev.txt PRE-CREATION 
>   libndofdev/README PRE-CREATION 
>   libndofdev/include/ndofdev_external.h PRE-CREATION 
>   libndofdev/ndofdev.c PRE-CREATION 
> 
> Diff: http://codereview.secondlife.com/r/340/diff
> 
> 
> Testing
> ---
> 
> This built successfully on TeamCity and the packaged library worked correctly 
> when I extracted it into the packages directory of the viewer build tree ( 
> build-linux-i686/packages ).  My spacenavigator, which hasn't worked in six 
> months, started working with the new build.
> 
> 
> Thanks,
> 
> Log
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges