Re: [opensource-dev] More proposals for draw distance slider icon (Mike Chase)

[Opensource Obscure]

On Wed, Jun 15, 2011 at 02:38, Carlo Wood  wrote:
> On Tue, 14 Jun 2011 13:49:30 -0500
> Daniel  wrote:
>
>> For the icon, label it "DD" for draw distance.  That will fit in
>> 16x16 pixels, and not conflict with other symbols.
>
> I like this idea. Made an icon for it:

unclear.

Opensource Obscure
--
http://twitter.com/oobscure - http://opensourceobscure.com/lol
discuss Second Life Viewer 2: http://j.mp/slv2group
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] More proposals for draw distance slider icon (Mike Chase)

[Marine Kelley]

How about a pair of round glasses in orthographic view, seen from a
quarter profile ?

Something like this (forgive the lack of alignment on non-fixed fonts) :

/ /
O-O

This icon is not used anywhere and has no special meaning, if you put
them on you see better that if you remove them (if you're
short-sighted that is), it would not be confused with search (as a
magnifying glass or a pair of binoculars would) or the world map (as a
globe would), and would be easy to draw in 16x16 because there is no
filling to do, just thin strokes.

Just my L$5

Marine

On 15/06/2011, Opensource Obscure  wrote:
> On Wed, Jun 15, 2011 at 02:38, Carlo Wood  wrote:
>> On Tue, 14 Jun 2011 13:49:30 -0500
>> Daniel  wrote:
>>
>>> For the icon, label it "DD" for draw distance.  That will fit in
>>> 16x16 pixels, and not conflict with other symbols.
>>
>> I like this idea. Made an icon for it:
>
> unclear.
>
> Opensource Obscure
> --
> http://twitter.com/oobscure - http://opensourceobscure.com/lol
> discuss Second Life Viewer 2: http://j.mp/slv2group
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24889: When a bake texture upload fails, retry instead of giving up.

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/152/#review747
---

Ship it!


- Oz


On June 13, 2011, 2:39 p.m., Thickbrick Sleaford wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/152/
> ---
> 
> (Updated June 13, 2011, 2:39 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> When a bake upload fails, the viewer doesn't retry it, and subsequently 
> doesn't send a AgentSetAppearance message. This can happen without the user 
> being aware, leaving the avatar looking good on their screen, but not updated 
> to the same outfit on other people's screens. The avatar will remain in that 
> state until the user does something that causes a rebake (manually rebake or 
> change outfit.) The solution here is to retry the upload after a small delay.
> 
> What this diff changes: when a full-res upload fails, retry to upload it 
> after a 5s delay, up to 5 times (in case the cap is available, last attempt 
> is via the old asset store.) Also, some clearer log messages. This implements 
> an old *FIX: comment:
> // *FIX: retry upload after n seconds, asset server could be busy
> 
> This isn't needed for low res uploads, because they don't block subsequent 
> full-res uploads (mNeedsUpload isn't set to FALSE in 
> LLTexLayerSetBuffer::doUpload in low-res uploads.)
> 
> 
> This addresses bug VWR-24889.
> http://jira.secondlife.com/browse/VWR-24889
> 
> 
> Diffs
> -
> 
>   indra/newview/llassetuploadresponders.h df4801993ea4 
>   indra/newview/llassetuploadresponders.cpp df4801993ea4 
>   indra/newview/lltexlayer.h df4801993ea4 
>   indra/newview/lltexlayer.cpp df4801993ea4 
> 
> Diff: http://codereview.secondlife.com/r/152/diff
> 
> 
> Testing
> ---
> 
> Attempted outfit changes using a problematic connection (not recently used 
> outfits to avoid using cached bakes). Looked for "Baked full res texture 
> upload for  failed" log messages, observed the subsequent 
> retries and successful upload for that region. Observed that eventually the 
> fully-baked avatar is visible to other users.
> 
> 
> Thanks,
> 
> Thickbrick
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/326/#review748
---

Ship it!


- Oz


On June 7, 2011, 2:32 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/326/
> ---
> 
> (Updated June 7, 2011, 2:32 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> 1. Launch viewer, change language to German for example.
> 2. Re-login, open COF for edit.
> 3. Open 'Attachments' accordion, delete all objects.
> ===>
> Actual: 'No attachments worn' text appears in English.
> 
> 
> This addresses bug STORM-899.
> http://jira.secondlife.com/browse/STORM-899
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt c0c940514b74 
>   indra/newview/llcofwearables.cpp c0c940514b74 
>   indra/newview/skins/default/xui/en/panel_cof_wearables.xml c0c940514b74 
>   indra/newview/skins/default/xui/en/strings.xml c0c940514b74 
> 
> Diff: http://codereview.secondlife.com/r/326/diff
> 
> 
> Testing
> ---
> 
> Opened this tab with the viewer in English and also in French.  I saw the 
> same message, but that is because there is no translation for French, but it 
> shows the call for a translation is working.
> 
> What I am not sure of is if I made fix in the right way.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-787 Mute Gestures Button

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/336/#review749
---

Ship it!


- Oz


On June 12, 2011, 1:09 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/336/
> ---
> 
> (Updated June 12, 2011, 1:09 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Added a checkbox control in Preferences->Sound and Media (see attached image 
> in jira) to enable/disable sounds coming from gestures.
> 
> There is a long writeup in the jira for reasons to have this.
> 
> This control is linked to 1) the master volume control and 2) the sound 
> effects control.  If either of these is disabled (speaker has a red line 
> through it) the checkbox is disabled.
> 
> 
> This addresses bug STORM-787.
> http://jira.secondlife.com/browse/STORM-787
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 6a3e7e403bd1 
>   indra/newview/app_settings/settings.xml 6a3e7e403bd1 
>   indra/newview/llfloaterpreference.h 6a3e7e403bd1 
>   indra/newview/llfloaterpreference.cpp 6a3e7e403bd1 
>   indra/newview/llviewermessage.cpp 6a3e7e403bd1 
>   indra/newview/skins/default/xui/en/panel_preferences_sound.xml 6a3e7e403bd1 
> 
> Diff: http://codereview.secondlife.com/r/336/diff
> 
> 
> Testing
> ---
> 
> Tested per test plan in jira.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1339 Crash in LLPanelPlaces::onTeleportButtonClicked

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/339/
---

Review request for Viewer.


Summary
---

I could not reproduce the crash, so just adding NULL pointer checks in a couple 
of suspicious places.


This addresses bug STORM-1339.
http://jira.secondlife.com/browse/STORM-1339


Diffs
-

  indra/newview/llpanellandmarks.cpp UNKNOWN 
  indra/newview/llpanelplaces.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/339/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1339 Crash in LLPanelPlaces::onTeleportButtonClicked

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/339/#review750
---

Ship it!


- Oz


On June 15, 2011, 8:50 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/339/
> ---
> 
> (Updated June 15, 2011, 8:50 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> I could not reproduce the crash, so just adding NULL pointer checks in a 
> couple of suspicious places.
> 
> 
> This addresses bug STORM-1339.
> http://jira.secondlife.com/browse/STORM-1339
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanellandmarks.cpp UNKNOWN 
>   indra/newview/llpanelplaces.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/339/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/326/#review751
---


See minor points below.


indra/newview/llcofwearables.cpp


I suppose this can be done once in postBuild(), because the textbox only 
gets visible when the list is empty.



indra/newview/skins/default/xui/en/strings.xml


The section this string is in seems inappropriate.


- Vadim


On June 7, 2011, 2:32 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/326/
> ---
> 
> (Updated June 7, 2011, 2:32 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> 1. Launch viewer, change language to German for example.
> 2. Re-login, open COF for edit.
> 3. Open 'Attachments' accordion, delete all objects.
> ===>
> Actual: 'No attachments worn' text appears in English.
> 
> 
> This addresses bug STORM-899.
> http://jira.secondlife.com/browse/STORM-899
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt c0c940514b74 
>   indra/newview/llcofwearables.cpp c0c940514b74 
>   indra/newview/skins/default/xui/en/panel_cof_wearables.xml c0c940514b74 
>   indra/newview/skins/default/xui/en/strings.xml c0c940514b74 
> 
> Diff: http://codereview.secondlife.com/r/326/diff
> 
> 
> Testing
> ---
> 
> Opened this tab with the viewer in English and also in French.  I saw the 
> same message, but that is because there is no translation for French, but it 
> shows the call for a translation is working.
> 
> What I am not sure of is if I made fix in the right way.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

[Jonathan Yap]

> On June 15, 2011, 9:11 a.m., Vadim ProductEngine wrote:
> > indra/newview/skins/default/xui/en/strings.xml, line 2095
> > 
> >
> > The section this string is in seems inappropriate.

I've moved this a bit farther down and created its own section, as per Vadim's 
jira comment other similar flatlist fixes may be necessary.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/326/#review751
---


On June 7, 2011, 2:32 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/326/
> ---
> 
> (Updated June 7, 2011, 2:32 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> 1. Launch viewer, change language to German for example.
> 2. Re-login, open COF for edit.
> 3. Open 'Attachments' accordion, delete all objects.
> ===>
> Actual: 'No attachments worn' text appears in English.
> 
> 
> This addresses bug STORM-899.
> http://jira.secondlife.com/browse/STORM-899
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt c0c940514b74 
>   indra/newview/llcofwearables.cpp c0c940514b74 
>   indra/newview/skins/default/xui/en/panel_cof_wearables.xml c0c940514b74 
>   indra/newview/skins/default/xui/en/strings.xml c0c940514b74 
> 
> Diff: http://codereview.secondlife.com/r/326/diff
> 
> 
> Testing
> ---
> 
> Opened this tab with the viewer in English and also in French.  I saw the 
> same message, but that is because there is no translation for French, but it 
> shows the call for a translation is working.
> 
> What I am not sure of is if I made fix in the right way.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/326/
---

(Updated June 15, 2011, 10:04 a.m.)


Review request for Viewer.


Changes
---

Made changes per Vadim's comments.


Summary
---

1. Launch viewer, change language to German for example.
2. Re-login, open COF for edit.
3. Open 'Attachments' accordion, delete all objects.
===>
Actual: 'No attachments worn' text appears in English.


This addresses bug STORM-899.
http://jira.secondlife.com/browse/STORM-899


Diffs (updated)
-

  doc/contributions.txt c0c940514b74 
  indra/newview/llcofwearables.cpp c0c940514b74 
  indra/newview/skins/default/xui/en/panel_cof_wearables.xml c0c940514b74 
  indra/newview/skins/default/xui/en/strings.xml c0c940514b74 

Diff: http://codereview.secondlife.com/r/326/diff


Testing
---

Opened this tab with the viewer in English and also in French.  I saw the same 
message, but that is because there is no translation for French, but it shows 
the call for a translation is working.

What I am not sure of is if I made fix in the right way.


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/326/#review755
---

Ship it!


Thanks.

- Vadim


On June 15, 2011, 10:04 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/326/
> ---
> 
> (Updated June 15, 2011, 10:04 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> 1. Launch viewer, change language to German for example.
> 2. Re-login, open COF for edit.
> 3. Open 'Attachments' accordion, delete all objects.
> ===>
> Actual: 'No attachments worn' text appears in English.
> 
> 
> This addresses bug STORM-899.
> http://jira.secondlife.com/browse/STORM-899
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt c0c940514b74 
>   indra/newview/llcofwearables.cpp c0c940514b74 
>   indra/newview/skins/default/xui/en/panel_cof_wearables.xml c0c940514b74 
>   indra/newview/skins/default/xui/en/strings.xml c0c940514b74 
> 
> Diff: http://codereview.secondlife.com/r/326/diff
> 
> 
> Testing
> ---
> 
> Opened this tab with the viewer in English and also in French.  I saw the 
> same message, but that is because there is no translation for French, but it 
> shows the call for a translation is working.
> 
> What I am not sure of is if I made fix in the right way.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/326/#review757
---



indra/newview/skins/default/xui/en/strings.xml


Is it intentional that each of these 3 lines is indented differently?


- Boroondas


On June 15, 2011, 10:04 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/326/
> ---
> 
> (Updated June 15, 2011, 10:04 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> 1. Launch viewer, change language to German for example.
> 2. Re-login, open COF for edit.
> 3. Open 'Attachments' accordion, delete all objects.
> ===>
> Actual: 'No attachments worn' text appears in English.
> 
> 
> This addresses bug STORM-899.
> http://jira.secondlife.com/browse/STORM-899
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt c0c940514b74 
>   indra/newview/llcofwearables.cpp c0c940514b74 
>   indra/newview/skins/default/xui/en/panel_cof_wearables.xml c0c940514b74 
>   indra/newview/skins/default/xui/en/strings.xml c0c940514b74 
> 
> Diff: http://codereview.secondlife.com/r/326/diff
> 
> 
> Testing
> ---
> 
> Opened this tab with the viewer in English and also in French.  I saw the 
> same message, but that is because there is no translation for French, but it 
> shows the call for a translation is working.
> 
> What I am not sure of is if I made fix in the right way.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/326/
---

(Updated June 15, 2011, 12:50 p.m.)


Review request for Viewer.


Changes
---

Changed tab to space per Boroondas' comment.


Summary
---

1. Launch viewer, change language to German for example.
2. Re-login, open COF for edit.
3. Open 'Attachments' accordion, delete all objects.
===>
Actual: 'No attachments worn' text appears in English.


This addresses bug STORM-899.
http://jira.secondlife.com/browse/STORM-899


Diffs (updated)
-

  doc/contributions.txt c0c940514b74 
  indra/newview/llcofwearables.cpp c0c940514b74 
  indra/newview/skins/default/xui/en/panel_cof_wearables.xml c0c940514b74 
  indra/newview/skins/default/xui/en/strings.xml c0c940514b74 

Diff: http://codereview.secondlife.com/r/326/diff


Testing
---

Opened this tab with the viewer in English and also in French.  I saw the same 
message, but that is because there is no translation for French, but it shows 
the call for a translation is working.

What I am not sure of is if I made fix in the right way.


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges