Re: [opensource-dev] Review Request: Update autobuilds default VC version to 2010

2011-06-03 Thread Oz Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/305/
---

(Updated June 3, 2011, 7:43 a.m.)


Review request for Viewer.


Changes
---

adding link back to jira


Summary
---

Autobuild defaults to VC 2005 if the environment variable AUTOBUILD_VSVER is 
unset. Now that LL have moved to VC 2010 completely, shouldn't this become the 
default version?


This addresses bug open-66.
http://jira.secondlife.com/browse/open-66


Diffs
-

  autobuild/autobuild_tool_source_environment.py 2a560b1d8f95 

Diff: http://codereview.secondlife.com/r/305/diff


Testing
---


Thanks,

Ima

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Viewer cache size increase to 10GB.

2011-06-03 Thread Log Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/318/
---

Review request for Viewer.


Summary
---

This patch increases the maximum and default viewer cache size values. Due to 
limitations in the size of the VFS, the 80/20 texture cache/VFS split is 
maintained up to 5GB, then the remaining cache size is given to the texture 
cache. This caps the VFS size at 1GB ( up from .2 GB ).  I made corresponding 
changes to the XUI to allow the slider to increase to the new cache size 
maximum.

Bugfixes:
* The reset cache location button will no longer tell the user that the cache 
will be cleared if the cache is already in the default location.  Only the 
notification was suppressed, the cache was never cleared by this button unless 
the location changed.
* The reset cache location button will now correctly clear the old cache when 
it is reset back to the default location. 
* I fixed an order of operation programming error in an llerrs log message in 
the lltexturecache.cpp. This was showing wildly incorrect texture cache size 
during a purge.
* Code convention cleanup in llappviewer.cpp in initCache() and 
lltexturecache.cpp


This addresses bugs er-767, er-883 and er-883.
http://jira.secondlife.com/browse/er-767
http://jira.secondlife.com/browse/er-883
http://jira.secondlife.com/browse/er-883


Diffs
-

  indra/newview/llappviewer.cpp 9c0506d10226 
  indra/newview/llfloaterpreference.cpp 9c0506d10226 
  indra/newview/lltexturecache.cpp 9c0506d10226 
  indra/newview/skins/default/xui/en/panel_preferences_setup.xml 9c0506d10226 

Diff: http://codereview.secondlife.com/r/318/diff


Testing
---

I have built and tested on all three platforms.  The log files indicate that 
the caches are being initialised with the correct sizes.


Thanks,

Log

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Viewer cache UI improvements.

2011-06-03 Thread Log Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/321/
---

Review request for Viewer.


Summary
---

This is mostly a UI change in support of the viewer cache improvements I have 
been making. The XUI changes were mocked up and approved by Wolf.

* Moved viewer cache controls to the advanced tab of the preferences menu.
* Changed the cache size control to a spinner.
* Relabeled the reset button to "Default Location" to clarify the purpose.
* Readded a clear cache button.
* Increased the minimum cache size to 64MB and set the max to 9984MB.  The 
increment in the spinner is 64 and both the min, max and default are multiples 
of 64. Wolf suggested using a high 4 digit number to allow the 4 digit wide 
spinner text box to suggest the maximum size of the cache.


Diffs
-

  indra/newview/skins/default/xui/en/panel_preferences_advanced.xml 
9c0506d10226 
  indra/newview/skins/default/xui/en/panel_preferences_setup.xml 9c0506d10226 
  indra/newview/skins/default/xui/en/notifications.xml 9c0506d10226 
  indra/newview/llappviewer.cpp 9c0506d10226 
  indra/newview/llfloaterpreference.h 9c0506d10226 
  indra/newview/llfloaterpreference.cpp 9c0506d10226 

Diff: http://codereview.secondlife.com/r/321/diff


Testing
---

I have built and tested all three platforms.  I also tried switching between a 
viewer with a lower max or min.  The value in the settings.xml file will be 
automatically clamped during the cache initialisation.  On older viewers, when 
a user opens the settings tab with the cache size slider, it will jump to 
within the old bounds.  When the user click ok in that preferences menu, the 
clamped value is saved in the settings file.  In the new viewer with the 
spinner, the old out of bounds value will appear in the spinner until the user 
changes it. This won't have an effect on the value being used, because of the 
clamp during init. 


Thanks,

Log

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] 3D connexion devices on linux

2011-06-03 Thread Sythos
linux resident with kernel 2.6.35 (or more) cannot use 3d mouse bc
NDOF0.2 don't support new "evdev" interface, NDOF 0.3 (released by same
author of previous one) support fine both old and new kernels, how can
somebody submit via HG or else the new code?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


[opensource-dev] Review Request: patch to let 3D connexion devices work on linux with kernel 2.6.35 or newer

2011-06-03 Thread Altair Memo

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/322/
---

Review request for Viewer.


Summary
---

fix for OPEN-21
added EVDEV layer for linux users on 2.6.35+ kernels

- added both personal 3P libs and indra subdir (and cmake NDOF.cmake file fix), 
first one less usefull, should be more better find a place where put prebuilt 
lib (jira affect only linux)


This addresses bug OPEN-21.
http://jira.secondlife.com/browse/OPEN-21


Diffs
-

  autobuild.xml d74fd886c8a6 
  indra/cmake/NDOF.cmake d74fd886c8a6 
  indra/llndof-linux/CMakeLists.txt PRE-CREATION 
  indra/llndof-linux/Makefile PRE-CREATION 
  indra/llndof-linux/ndofdev.c PRE-CREATION 
  indra/llndof-linux/ndofdev_external.h PRE-CREATION 

Diff: http://codereview.secondlife.com/r/322/diff


Testing
---

I suppose "on my linux system work" is a poor point, using prebuilt òlibs since 
long, the cmake and subdir work using autobuild with "ReleaseOS"


Thanks,

Altair

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: patch to let 3D connexion devices work on linux with kernel 2.6.35 or newer

2011-06-03 Thread Altair Memo

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/322/
---

(Updated June 3, 2011, 6:10 p.m.)


Review request for Viewer.


Changes
---

forgot contrib :-\


Summary
---

fix for OPEN-21
added EVDEV layer for linux users on 2.6.35+ kernels

- added both personal 3P libs and indra subdir (and cmake NDOF.cmake file fix), 
first one less usefull, should be more better find a place where put prebuilt 
lib (jira affect only linux)


This addresses bug OPEN-21.
http://jira.secondlife.com/browse/OPEN-21


Diffs (updated)
-

  autobuild.xml d74fd886c8a6 
  doc/contributions.txt d74fd886c8a6 
  indra/cmake/NDOF.cmake d74fd886c8a6 
  indra/llndof-linux/CMakeLists.txt PRE-CREATION 
  indra/llndof-linux/Makefile PRE-CREATION 
  indra/llndof-linux/ndofdev.c PRE-CREATION 
  indra/llndof-linux/ndofdev_external.h PRE-CREATION 

Diff: http://codereview.secondlife.com/r/322/diff


Testing
---

I suppose "on my linux system work" is a poor point, using prebuilt òlibs since 
long, the cmake and subdir work using autobuild with "ReleaseOS"


Thanks,

Altair

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges