date:20110509

Re: [opensource-dev] Review Request: CHOP-624 header dependency improvements for build time speedup

2011-05-09 Thread Brad Kittenbrink



> On May 6, 2011, 3:19 a.m., Boroondas Gupte wrote:
> > indra/newview/llviewerregion.cpp, lines 833-839
> > 
> >
> > > on further thought, is this a bug?
> > > should it be 0.5 * (mImpl->mLandp->getMinZ() + 
> > mImpl->mLandp->getMaxZ()) instead?
> > 
> > Oh, didn't notice that. Then again, I was merely verifying that you 
> > don't alter functionality, not whether the present functionality makes any 
> > sense.
> > 
> > Looking at the lines above the one in question and the method name, it 
> > might indeed well be that this is a bug and that mdV[VZ] should be set to 
> > the mean of the mLandp's minZ and maxZ. However,
> > 1) without explanatory code comments and/or a specification of this 
> > method, we cannot tell for sure.
> > 2) Even if this is a bug, relying code might to some hackary to 
> > compensate for it, which would lead to overcompensation if this is fixed 
> > only here. So this would need careful further examination, first. (If this 
> > is a bug and isn't compensated for elsewhere, would its effect be 
> > observable somehow? If so, how?)
> > 3) Even if this is a bug, fixing it is out of scope for CHOP-624 and 
> > should not delay/block it.
> > 
> > Conclusion: Good catch, but file a separate jira issue for tracking 
> > investigation and (if needed) fixing of that potential problem.
> 
> Brad Kittenbrink wrote:
> Totally agreed.
> 
> Boroondas Gupte wrote:
> Please link to that new jira once it's filed. I'm curious what'll become 
> of that topic.

finally got around to writing this up: 
https://jira.secondlife.com/browse/VWR-25719


- Brad


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/289/#review682
---


On May 5, 2011, 5:21 p.m., Brad Kittenbrink wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/289/
> ---
> 
> (Updated May 5, 2011, 5:21 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Sorry for the big diff here, but reworking a LOT of header dependencies to 
> reduce complexity and help build time.  Started moving stuff out of public 
> interfaces of classes to improve insulation (for example in llviewerregion.h 
> and llagent.h for the biggest examples).
> 
> 
> This addresses bug CHOP-624.
> http://jira.secondlife.com/browse/CHOP-624
> 
> 
> Diffs
> -
> 
>   indra/llcommon/llapp.cpp UNKNOWN 
>   indra/llui/llbutton.h UNKNOWN 
>   indra/llui/llfloaterreg.h UNKNOWN 
>   indra/llui/llfocusmgr.h UNKNOWN 
>   indra/llui/llfocusmgr.cpp UNKNOWN 
>   indra/llui/lliconctrl.h UNKNOWN 
>   indra/llui/lllineeditor.h UNKNOWN 
>   indra/llui/llloadingindicator.h UNKNOWN 
>   indra/llui/llmultislider.cpp UNKNOWN 
>   indra/llui/llpanel.h UNKNOWN 
>   indra/llui/llprogressbar.h UNKNOWN 
>   indra/llui/llprogressbar.cpp UNKNOWN 
>   indra/llui/llslider.h UNKNOWN 
>   indra/llui/llstyle.h UNKNOWN 
>   indra/llui/llstyle.cpp UNKNOWN 
>   indra/llui/lltransutil.cpp UNKNOWN 
>   indra/llui/llui.h UNKNOWN 
>   indra/llui/llview.h UNKNOWN 
>   indra/llui/llviewborder.cpp UNKNOWN 
>   indra/llui/llwindowshade.h UNKNOWN 
>   indra/llxuixml/lltrans.h UNKNOWN 
>   indra/llxuixml/lltrans.cpp UNKNOWN 
>   indra/llxuixml/llxuiparser.h UNKNOWN 
>   indra/newview/llagent.h UNKNOWN 
>   indra/newview/llagent.cpp UNKNOWN 
>   indra/newview/llappviewer.cpp UNKNOWN 
>   indra/newview/lleventnotifier.h UNKNOWN 
>   indra/newview/llfloaterland.h UNKNOWN 
>   indra/newview/llfloaterland.cpp UNKNOWN 
>   indra/newview/llfloatersnapshot.cpp UNKNOWN 
>   indra/newview/llfolderviewitem.h UNKNOWN 
>   indra/newview/lllocationhistory.h UNKNOWN 
>   indra/newview/lloutputmonitorctrl.h UNKNOWN 
>   indra/newview/llpanelavatar.cpp UNKNOWN 
>   indra/newview/llpanelgroupgeneral.cpp UNKNOWN 
>   indra/newview/llpanelgrouproles.cpp UNKNOWN 
>   indra/newview/llpreviewgesture.cpp UNKNOWN 
>   indra/newview/llsidepaneliteminfo.cpp UNKNOWN 
>   indra/newview/lltooldraganddrop.cpp UNKNOWN 
>   indra/newview/llviewerchat.cpp UNKNOWN 
>   indra/newview/llviewerkeyboard.h UNKNOWN 
>   indra/newview/llviewermenu.cpp UNKNOWN 
>   indra/newview/llviewerparcelmgr.cpp UNKNOWN 
>   indra/newview/llviewerprecompiledheaders.h UNKNOWN 
>   indra/newview/llviewerregion.h UNKNOWN 
>   indra/newview/llviewerregion.cpp UNKNOWN 
>   indra/newview/llviewertexturelist.h UNKNOWN 
>   indra/newview/llviewerwindow.h UNKNOWN 
>   indra/newview/llviewerwindow.cpp UNKNOWN 
>   indra/newview/llvoavatar.cpp UNKNOWN 
>   indra/newview/llvotree.cpp UNKNOWN 
>   indra/newview/llvovolume.cpp UNKNOWN 
>   indra/newview/llworld.cpp UNKNOWN 
>   indra/newview/tests/llremot

[opensource-dev] STORM-859 or "#define IDC_STATIC and stop #include(ing) old sample code"

2011-05-09 Thread Ardy Lay

Seems to me we should keep them ducks all in a row like this:

#define IDC_STATIC and stop #include(ing) old sample code

diff -r d596dec15189 -r 6574bf647d32 indra/newview/res/resource.h
--- a/indra/newview/res/resource.hMon May 09 14:39:23 2011 -0500
+++ b/indra/newview/res/resource.hMon May 09 14:39:23 2011 -0500
@@ -38,6 +38,7 @@
  #define IDC_CURSOR5 154
  #define IDI_LCD_LL_ICON 157
  #define IDC_CURSOR6 158
+#define IDC_STATIC  1000
  #define IDC_RADIO_561000
  #define IDC_RADIO_128   1001
  #define IDC_RADIO_256   1002
diff -r d596dec15189 -r 6574bf647d32 indra/newview/res/viewerRes.rc
--- a/indra/newview/res/viewerRes.rcMon May 09 14:39:23 2011 -0500
+++ b/indra/newview/res/viewerRes.rcMon May 09 14:39:23 2011 -0500
@@ -7,7 +7,7 @@
  //
  // Generated from the TEXTINCLUDE 2 resource.
  //
-#include "winres.h"
+#include "windows.h"


/
  #undef APSTUDIO_READONLY_SYMBOLS

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Cleaning up testing cmake macros to prepare for refactoring them to improve build time.

2011-05-09 Thread Brad Kittenbrink


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/301/
---

Review request for Viewer.


Summary
---

Consolidating all references to the LL_TESTS config var in one file to make the 
logic surrounding it more cohesive.


This addresses bug CHOP-609.
http://jira.secondlife.com/browse/CHOP-609


Diffs
-

  indra/cmake/LLAddBuildTest.cmake UNKNOWN 
  indra/cmake/LLTestCommand.cmake UNKNOWN 
  indra/llcharacter/CMakeLists.txt UNKNOWN 
  indra/llcommon/CMakeLists.txt UNKNOWN 
  indra/llimage/CMakeLists.txt UNKNOWN 
  indra/llinventory/CMakeLists.txt UNKNOWN 
  indra/llkdu/CMakeLists.txt UNKNOWN 
  indra/llmath/CMakeLists.txt UNKNOWN 
  indra/llmessage/CMakeLists.txt UNKNOWN 
  indra/llplugin/CMakeLists.txt UNKNOWN 
  indra/llprimitive/CMakeLists.txt UNKNOWN 
  indra/llui/CMakeLists.txt UNKNOWN 
  indra/llvfs/CMakeLists.txt UNKNOWN 
  indra/llxml/CMakeLists.txt UNKNOWN 
  indra/newview/CMakeLists.txt UNKNOWN 
  indra/viewer_components/login/CMakeLists.txt UNKNOWN 
  indra/viewer_components/updater/CMakeLists.txt UNKNOWN 

Diff: http://codereview.secondlife.com/r/301/diff


Testing
---

I've tested with LL_TESTS=ON, but I'd like some help from people who use this 
feature testing with LL_TESTS=OFF to make sure I haven't missed anything.


Thanks,

Brad

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: CHOP-658 moving panels and floaters into a new static library project viewer_components/viewerui

2011-05-09 Thread Brad Kittenbrink


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/302/
---

Review request for Viewer and Richard Nelson.


Summary
---

Started moving panel and floater classes into a new static library project in 
an effort to start promoting better insulation between model and view sections 
of the viewer codebase.  This is in preparation for further work breaking 
header dependencies along the lines of CHOP-624


This addresses bug CHOP-658.
http://jira.secondlife.com/browse/CHOP-658


Diffs
-

  indra/cmake/LLViewerUI.cmake PRE-CREATION 
  indra/newview/CMakeLists.txt UNKNOWN 
  indra/newview/llfloaterabout.h UNKNOWN 
  indra/newview/llfloaterabout.cpp UNKNOWN 
  indra/newview/llfloateranimpreview.h UNKNOWN 
  indra/newview/llfloateranimpreview.cpp UNKNOWN 
  indra/newview/llfloaterauction.h UNKNOWN 
  indra/newview/llfloaterauction.cpp UNKNOWN 
  indra/newview/llfloateravatarpicker.h UNKNOWN 
  indra/newview/llfloateravatarpicker.cpp UNKNOWN 
  indra/newview/llfloateravatartextures.h UNKNOWN 
  indra/newview/llfloateravatartextures.cpp UNKNOWN 
  indra/newview/llfloaterbeacons.h UNKNOWN 
  indra/newview/llfloaterbeacons.cpp UNKNOWN 
  indra/newview/llfloaterbuildoptions.h UNKNOWN 
  indra/newview/llfloaterbuildoptions.cpp UNKNOWN 
  indra/newview/llfloaterbulkpermission.h UNKNOWN 
  indra/newview/llfloaterbulkpermission.cpp UNKNOWN 
  indra/newview/llfloaterbump.h UNKNOWN 
  indra/newview/llfloaterbump.cpp UNKNOWN 
  indra/newview/llfloaterbuy.h UNKNOWN 
  indra/newview/llfloaterbuy.cpp UNKNOWN 
  indra/newview/llfloaterbuycontents.h UNKNOWN 
  indra/newview/llfloaterbuycontents.cpp UNKNOWN 
  indra/newview/llfloaterbuycurrency.h UNKNOWN 
  indra/newview/llfloaterbuycurrency.cpp UNKNOWN 
  indra/newview/llfloaterbuycurrencyhtml.h UNKNOWN 
  indra/newview/llfloaterbuycurrencyhtml.cpp UNKNOWN 
  indra/newview/llfloaterbuyland.h UNKNOWN 
  indra/newview/llfloaterbuyland.cpp UNKNOWN 
  indra/newview/llfloatercamera.h UNKNOWN 
  indra/newview/llfloatercamera.cpp UNKNOWN 
  indra/newview/llfloaterchat.h UNKNOWN 
  indra/newview/llfloaterchat.cpp UNKNOWN 
  indra/newview/llfloaterchatterbox.h UNKNOWN 
  indra/newview/llfloaterchatterbox.cpp UNKNOWN 
  indra/newview/llfloatercolorpicker.h UNKNOWN 
  indra/newview/llfloatercolorpicker.cpp UNKNOWN 
  indra/newview/llfloaterdaycycle.h UNKNOWN 
  indra/newview/llfloaterdaycycle.cpp UNKNOWN 
  indra/newview/llfloaterdisplayname.h UNKNOWN 
  indra/newview/llfloaterdisplayname.cpp UNKNOWN 
  indra/newview/llfloaterenvsettings.h UNKNOWN 
  indra/newview/llfloaterenvsettings.cpp UNKNOWN 
  indra/newview/llfloaterevent.h UNKNOWN 
  indra/newview/llfloaterevent.cpp UNKNOWN 
  indra/newview/llfloaterfonttest.h UNKNOWN 
  indra/newview/llfloaterfonttest.cpp UNKNOWN 
  indra/newview/llfloaterfriends.h UNKNOWN 
  indra/newview/llfloaterfriends.cpp UNKNOWN 
  indra/newview/llfloatergesture.h UNKNOWN 
  indra/newview/llfloatergesture.cpp UNKNOWN 
  indra/newview/llfloatergodtools.h UNKNOWN 
  indra/newview/llfloatergodtools.cpp UNKNOWN 
  indra/newview/llfloatergroupinvite.h UNKNOWN 
  indra/newview/llfloatergroupinvite.cpp UNKNOWN 
  indra/newview/llfloatergroups.h UNKNOWN 
  indra/newview/llfloatergroups.cpp UNKNOWN 
  indra/newview/llfloaterhandler.h UNKNOWN 
  indra/newview/llfloaterhandler.cpp UNKNOWN 
  indra/newview/llfloaterhardwaresettings.h UNKNOWN 
  indra/newview/llfloaterhardwaresettings.cpp UNKNOWN 
  indra/newview/llfloaterhelpbrowser.h UNKNOWN 
  indra/newview/llfloaterhelpbrowser.cpp UNKNOWN 
  indra/newview/llfloaterhud.h UNKNOWN 
  indra/newview/llfloaterhud.cpp UNKNOWN 
  indra/newview/llfloaterimagepreview.h UNKNOWN 
  indra/newview/llfloaterimagepreview.cpp UNKNOWN 
  indra/newview/llfloaterinspect.h UNKNOWN 
  indra/newview/llfloaterinspect.cpp UNKNOWN 
  indra/newview/llfloaterinventory.h UNKNOWN 
  indra/newview/llfloaterinventory.cpp UNKNOWN 
  indra/newview/llfloaterjoystick.h UNKNOWN 
  indra/newview/llfloaterjoystick.cpp UNKNOWN 
  indra/newview/llfloaterlagmeter.h UNKNOWN 
  indra/newview/llfloaterlagmeter.cpp UNKNOWN 
  indra/newview/llfloaterland.h UNKNOWN 
  indra/newview/llfloaterland.cpp UNKNOWN 
  indra/newview/llfloaterlandholdings.h UNKNOWN 
  indra/newview/llfloaterlandholdings.cpp UNKNOWN 
  indra/newview/llfloatermap.h UNKNOWN 
  indra/newview/llfloatermap.cpp UNKNOWN 
  indra/newview/llfloatermediabrowser.h UNKNOWN 
  indra/newview/llfloatermediabrowser.cpp UNKNOWN 
  indra/newview/llfloatermediasettings.h UNKNOWN 
  indra/newview/llfloatermediasettings.cpp UNKNOWN 
  indra/newview/llfloatermemleak.h UNKNOWN 
  indra/newview/llfloatermemleak.cpp UNKNOWN 
  indra/newview/llfloaternamedesc.h UNKNOWN 
  indra/newview/llfloaternamedesc.cpp UNKNOWN 
  indra/newview/llfloaternotificationsconsole.h UNKNOWN 
  indra/newview/llfloaternotificationsconsole.cpp UNKNOWN 
  indra/newview/llfl

Re: [opensource-dev] Review Request: CHOP-624 header dependency improvements for build time speedup

[opensource-dev] STORM-859 or "#define IDC_STATIC and stop #include(ing) old sample code"

[opensource-dev] Review Request: Cleaning up testing cmake macros to prepare for refactoring them to improve build time.

[opensource-dev] Review Request: CHOP-658 moving panels and floaters into a new static library project viewer_components/viewerui

4 matches

Site Navigation

Mail list logo

Footer information