[opensource-dev] Review Request: STORM-323: redundant popups

[Lance Corrimal]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/230/
---

Review request for Viewer.


Summary
---

Fixed the redundant "You have accepted suchandsuch from soandso" popups that 
had to actually be confirmed by clicking OK by changing the popup type to 
SystemMessageTip.


Diffs
-

  doc/contributions.txt 580ef56f84bd 
  indra/newview/llviewermessage.cpp 580ef56f84bd 

Diff: http://codereview.secondlife.com/r/230/diff


Testing
---

I have been using this patch in my V2 based TPV (Dolphin Viewer 2) since 
mid-december 2010 without any problems on Windows, Mac OS X and Linux. Does 
that count as testing? ;)


Thanks,

Lance

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-323: redundant popups

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/230/
---

(Updated March 24, 2011, 4:34 a.m.)


Review request for Viewer.


Changes
---

fixing link to jira


Summary
---

Fixed the redundant "You have accepted suchandsuch from soandso" popups that 
had to actually be confirmed by clicking OK by changing the popup type to 
SystemMessageTip.


This addresses bug storm-323.
http://jira.secondlife.com/browse/storm-323


Diffs
-

  doc/contributions.txt 580ef56f84bd 
  indra/newview/llviewermessage.cpp 580ef56f84bd 

Diff: http://codereview.secondlife.com/r/230/diff


Testing
---

I have been using this patch in my V2 based TPV (Dolphin Viewer 2) since 
mid-december 2010 without any problems on Windows, Mac OS X and Linux. Does 
that count as testing? ;)


Thanks,

Lance

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-323: redundant popups

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/230/#review493
---

Ship it!


- Oz


On March 24, 2011, 4:34 a.m., Lance Corrimal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/230/
> ---
> 
> (Updated March 24, 2011, 4:34 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fixed the redundant "You have accepted suchandsuch from soandso" popups that 
> had to actually be confirmed by clicking OK by changing the popup type to 
> SystemMessageTip.
> 
> 
> This addresses bug storm-323.
> http://jira.secondlife.com/browse/storm-323
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 580ef56f84bd 
>   indra/newview/llviewermessage.cpp 580ef56f84bd 
> 
> Diff: http://codereview.secondlife.com/r/230/diff
> 
> 
> Testing
> ---
> 
> I have been using this patch in my V2 based TPV (Dolphin Viewer 2) since 
> mid-december 2010 without any problems on Windows, Mac OS X and Linux. Does 
> that count as testing? ;)
> 
> 
> Thanks,
> 
> Lance
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-323: redundant popups

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/230/#review495
---

Ship it!


Looks good.

Not your fault, but I can't resist to mention the ...


indra/newview/llviewermessage.cpp


... exact (apart from indentation level) ...



indra/newview/llviewermessage.cpp


... code duplication.


- Boroondas


On March 24, 2011, 4:34 a.m., Lance Corrimal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/230/
> ---
> 
> (Updated March 24, 2011, 4:34 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fixed the redundant "You have accepted suchandsuch from soandso" popups that 
> had to actually be confirmed by clicking OK by changing the popup type to 
> SystemMessageTip.
> 
> 
> This addresses bug storm-323.
> http://jira.secondlife.com/browse/storm-323
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 580ef56f84bd 
>   indra/newview/llviewermessage.cpp 580ef56f84bd 
> 
> Diff: http://codereview.secondlife.com/r/230/diff
> 
> 
> Testing
> ---
> 
> I have been using this patch in my V2 based TPV (Dolphin Viewer 2) since 
> mid-december 2010 without any problems on Windows, Mac OS X and Linux. Does 
> that count as testing? ;)
> 
> 
> Thanks,
> 
> Lance
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/229/#review496
---


I think that pressing the Speak button or the fly-out button should hide the 
hint: this is the way how e.g. the Move button hint works.
Otherwise the hint obscures the NEARBY VOICE panel which looks pretty weird.


indra/newview/skins/default/xui/en/notifications.xml


I guess you meant that *voice* is enabled by default, not microphone.

Mic only gets enabled explicitly by pressing the Speak button or middle 
mouse button.


- Vadim


On March 23, 2011, 6:06 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/229/
> ---
> 
> (Updated March 23, 2011, 6:06 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> 1) Change Voice Enabled to Speak Button when you right click on the bottom 
> bar and get a menu.
> 
> 2) Eliminate the separator bar in this menu.
> 
> 3) Have a hint appear for the Speak button (see image in jira) the first time 
> you use the viewer, have voice on (the default), and successfully connect to 
> a voice server.
> 
> 
> This addresses bug STORM-1077.
> http://jira.secondlife.com/browse/STORM-1077
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt b761ed94eb26 
>   indra/newview/app_settings/ignorable_dialogs.xml b761ed94eb26 
>   indra/newview/llbottomtray.cpp b761ed94eb26 
>   indra/newview/llfirstuse.h b761ed94eb26 
>   indra/newview/llfirstuse.cpp b761ed94eb26 
>   indra/newview/skins/default/xui/en/menu_bottomtray.xml b761ed94eb26 
>   indra/newview/skins/default/xui/en/notifications.xml b761ed94eb26 
> 
> Diff: http://codereview.secondlife.com/r/229/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

[Jonathan Yap]

> On March 24, 2011, 6:04 a.m., Vadim ProductEngine wrote:
> > indra/newview/skins/default/xui/en/notifications.xml, line 6616
> > 
> >
> > I guess you meant that *voice* is enabled by default, not microphone.
> > 
> > Mic only gets enabled explicitly by pressing the Speak button or middle 
> > mouse button.

My message about the mic being on by default is correct.  I asked Q about this 
and he said it was a design decision.  Every new user has their mic on when 
they first start the viewer.  Then they wonder why no one writes back when they 
are using text chat; they have been muted.

See the xml code block that shows the mic is on by default in one of my jira 
comments for this issue.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/229/#review496
---


On March 23, 2011, 6:06 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/229/
> ---
> 
> (Updated March 23, 2011, 6:06 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> 1) Change Voice Enabled to Speak Button when you right click on the bottom 
> bar and get a menu.
> 
> 2) Eliminate the separator bar in this menu.
> 
> 3) Have a hint appear for the Speak button (see image in jira) the first time 
> you use the viewer, have voice on (the default), and successfully connect to 
> a voice server.
> 
> 
> This addresses bug STORM-1077.
> http://jira.secondlife.com/browse/STORM-1077
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt b761ed94eb26 
>   indra/newview/app_settings/ignorable_dialogs.xml b761ed94eb26 
>   indra/newview/llbottomtray.cpp b761ed94eb26 
>   indra/newview/llfirstuse.h b761ed94eb26 
>   indra/newview/llfirstuse.cpp b761ed94eb26 
>   indra/newview/skins/default/xui/en/menu_bottomtray.xml b761ed94eb26 
>   indra/newview/skins/default/xui/en/notifications.xml b761ed94eb26 
> 
> Diff: http://codereview.secondlife.com/r/229/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

[Vadim ProductEngine]

> On March 24, 2011, 6:04 a.m., Vadim ProductEngine wrote:
> > indra/newview/skins/default/xui/en/notifications.xml, line 6616
> > 
> >
> > I guess you meant that *voice* is enabled by default, not microphone.
> > 
> > Mic only gets enabled explicitly by pressing the Speak button or middle 
> > mouse button.
> 
> Jonathan Yap wrote:
> My message about the mic being on by default is correct.  I asked Q about 
> this and he said it was a design decision.  Every new user has their mic on 
> when they first start the viewer.  Then they wonder why no one writes back 
> when they are using text chat; they have been muted.
> 
> See the xml code block that shows the mic is on by default in one of my 
> jira comments for this issue.

Right, it says "EnableVoiceChat". This is not the same as "enable microphone".
The difference is that you can have voice chat enabled and thus hear others 
speak, but your mic will be off until you press Speak.

I tried wiping my Second Life settings (emulating first run) and made sure that 
by default voice chat is enabled while mic isn't.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/229/#review496
---


On March 23, 2011, 6:06 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/229/
> ---
> 
> (Updated March 23, 2011, 6:06 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> 1) Change Voice Enabled to Speak Button when you right click on the bottom 
> bar and get a menu.
> 
> 2) Eliminate the separator bar in this menu.
> 
> 3) Have a hint appear for the Speak button (see image in jira) the first time 
> you use the viewer, have voice on (the default), and successfully connect to 
> a voice server.
> 
> 
> This addresses bug STORM-1077.
> http://jira.secondlife.com/browse/STORM-1077
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt b761ed94eb26 
>   indra/newview/app_settings/ignorable_dialogs.xml b761ed94eb26 
>   indra/newview/llbottomtray.cpp b761ed94eb26 
>   indra/newview/llfirstuse.h b761ed94eb26 
>   indra/newview/llfirstuse.cpp b761ed94eb26 
>   indra/newview/skins/default/xui/en/menu_bottomtray.xml b761ed94eb26 
>   indra/newview/skins/default/xui/en/notifications.xml b761ed94eb26 
> 
> Diff: http://codereview.secondlife.com/r/229/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/229/
---

(Updated March 24, 2011, 9:10 a.m.)


Review request for Viewer.


Changes
---

Updated hint wording -- the speak button is NOT on by default.

Disable hint if speak or flyout button is pressed.


Summary
---

1) Change Voice Enabled to Speak Button when you right click on the bottom bar 
and get a menu.

2) Eliminate the separator bar in this menu.

3) Have a hint appear for the Speak button (see image in jira) the first time 
you use the viewer, have voice on (the default), and successfully connect to a 
voice server.


This addresses bug STORM-1077.
http://jira.secondlife.com/browse/STORM-1077


Diffs (updated)
-

  indra/newview/llcallfloater.cpp b761ed94eb26 
  indra/newview/llspeakbutton.cpp b761ed94eb26 
  indra/newview/skins/default/xui/en/notifications.xml b761ed94eb26 

Diff: http://codereview.secondlife.com/r/229/diff


Testing
---


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/229/#review499
---


Looks good now. I only have one question, see below.


indra/newview/llcallfloater.cpp


redundant change



indra/newview/llspeakbutton.cpp


Why do you do this again on mouse up as well?
Isn't it enough to dismiss the hint on mouse down only?


- Vadim


On March 24, 2011, 9:10 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/229/
> ---
> 
> (Updated March 24, 2011, 9:10 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> 1) Change Voice Enabled to Speak Button when you right click on the bottom 
> bar and get a menu.
> 
> 2) Eliminate the separator bar in this menu.
> 
> 3) Have a hint appear for the Speak button (see image in jira) the first time 
> you use the viewer, have voice on (the default), and successfully connect to 
> a voice server.
> 
> 
> This addresses bug STORM-1077.
> http://jira.secondlife.com/browse/STORM-1077
> 
> 
> Diffs
> -
> 
>   indra/newview/llcallfloater.cpp b761ed94eb26 
>   indra/newview/llspeakbutton.cpp b761ed94eb26 
>   indra/newview/skins/default/xui/en/notifications.xml b761ed94eb26 
> 
> Diff: http://codereview.secondlife.com/r/229/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/229/#review500
---


I deleted the line in the mouse-up speak button code that turns off the speak 
button hint.  That line was there when I incorrectly though the speak button 
might be on at viewer startup.  I could not get the diff to update so am 
commenting in here.

- Jonathan


On March 24, 2011, 9:10 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/229/
> ---
> 
> (Updated March 24, 2011, 9:10 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> 1) Change Voice Enabled to Speak Button when you right click on the bottom 
> bar and get a menu.
> 
> 2) Eliminate the separator bar in this menu.
> 
> 3) Have a hint appear for the Speak button (see image in jira) the first time 
> you use the viewer, have voice on (the default), and successfully connect to 
> a voice server.
> 
> 
> This addresses bug STORM-1077.
> http://jira.secondlife.com/browse/STORM-1077
> 
> 
> Diffs
> -
> 
>   indra/newview/llcallfloater.cpp b761ed94eb26 
>   indra/newview/llspeakbutton.cpp b761ed94eb26 
>   indra/newview/skins/default/xui/en/notifications.xml b761ed94eb26 
> 
> Diff: http://codereview.secondlife.com/r/229/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

[Jonathan Yap]

> On March 24, 2011, 11:04 a.m., Jonathan Yap wrote:
> > I deleted the line in the mouse-up speak button code that turns off the 
> > speak button hint.  That line was there when I incorrectly though the speak 
> > button might be on at viewer startup.  I could not get the diff to update 
> > so am commenting in here.

You can look at the bitbucket repo to see the change.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/229/#review500
---


On March 24, 2011, 9:10 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/229/
> ---
> 
> (Updated March 24, 2011, 9:10 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> 1) Change Voice Enabled to Speak Button when you right click on the bottom 
> bar and get a menu.
> 
> 2) Eliminate the separator bar in this menu.
> 
> 3) Have a hint appear for the Speak button (see image in jira) the first time 
> you use the viewer, have voice on (the default), and successfully connect to 
> a voice server.
> 
> 
> This addresses bug STORM-1077.
> http://jira.secondlife.com/browse/STORM-1077
> 
> 
> Diffs
> -
> 
>   indra/newview/llcallfloater.cpp b761ed94eb26 
>   indra/newview/llspeakbutton.cpp b761ed94eb26 
>   indra/newview/skins/default/xui/en/notifications.xml b761ed94eb26 
> 
> Diff: http://codereview.secondlife.com/r/229/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/229/#review502
---

Ship it!


No more objections. Thanks, Jonathan!

To avoid problems with uploading modified diffs, try using cumulative diffs, 
i.e. each uploaded diff includes all changes from the previous one.
Thus you can use Review Board to see differences between the diffs, and each 
diff is perfectly useful and self-contained.

- Vadim


On March 24, 2011, 9:10 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/229/
> ---
> 
> (Updated March 24, 2011, 9:10 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> 1) Change Voice Enabled to Speak Button when you right click on the bottom 
> bar and get a menu.
> 
> 2) Eliminate the separator bar in this menu.
> 
> 3) Have a hint appear for the Speak button (see image in jira) the first time 
> you use the viewer, have voice on (the default), and successfully connect to 
> a voice server.
> 
> 
> This addresses bug STORM-1077.
> http://jira.secondlife.com/browse/STORM-1077
> 
> 
> Diffs
> -
> 
>   indra/newview/llcallfloater.cpp b761ed94eb26 
>   indra/newview/llspeakbutton.cpp b761ed94eb26 
>   indra/newview/skins/default/xui/en/notifications.xml b761ed94eb26 
> 
> Diff: http://codereview.secondlife.com/r/229/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Good Job: Autobuild

[Brandon Husbands]

Compiled flawlessly. Now i can get back to helping =)
Dim.

-- 
---
This email is a private and confidential communication. Any use of email may
be subject to the laws and regulations of the United States. You may not
Repost, Distribute nor reproduce any content of this message.
---
---
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] PO Build available

[Philippe (Merov) Bossut]

Hi,

PO build of the day available at:
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/225012/index.html

Containing fixes/implementations for:
* STORM-399 : Users that has chatted within chat range of the user in-world
are not added to Recent tab
* STORM-1019 : Add ability to display beacons for Media on a Prim objects
* STORM-1021 : Viewer shows "L$300" instead of object IM details if object
sends an IM from another region
* STORM-1030 : Main menu change: 'Me->Change Outfit' to 'Me->My Appearance'
* STORM-1068 : Add optional range ring(s) to the mini-map -- one centered on
you with a radius of 20m to show local chat range
* STORM-1077 : Change "Voice Enabled/Disabled" to "Speak Button"
* STORM-1086 : Agent's own calling card created on startup is placed into
Friends/All folder instead of Calling Cards
* STORM-1095 :  Chat preferences > font size should increase size of input
text in the chat box

Cheers,
- Merov
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges