Re: [opensource-dev] streaming media on 64bit?

[Boroondas Gupte]

Hi Marc

On 02/05/2011 05:03 AM, Marc Adored wrote:
> I am on 64bit ubuntu and noticed that media on a prim works now even
> though I am using a 32bit viewer. I am assuming this is because it is
> a SLPlugin and not part of the viewer?
That's not the reason: The SLPlugin binary, while a separate process
than the viewer main binary, is also shipped only compiled for 32bit in
the official downloads and thus faces the same problem as the main
binary: it can only load 32bit libraries. The reason why it can display
web content anyway, is that the library used for rendering html is also
included (also in 32bit) in the download.

> I was wondering if the
> streaming audio/video that has not worked for 32bit viewers on 64bit
> systems could be reworked to work the same way?
For audio/video stream display, the GStreamer libraries are used, but
those aren't included in the download. So SLPlugin tries to load the
system-installed version (if any), which (if SLPlugin is compiled for
32bit) can only succeed if those libs are compiled for 32bit, too.

So the possibilities would be:

* Include 32bit GStreamer libraries in the official download (or in
  a separate download)
  o Around 17 MB including common plugins, but still excluding
any dependency libraries that might have to be added for
this to work, too
* Offer SPLugin (and maybe the whole viewer) compiled for 64bit, too
  o This would mean additional QA work for LL.
* Have Linux 64bit users install a 32bit GStreamer
  o Probably difficult on many distributions (because GStreamer
is usually not part of the 32bit compatibility bundles, such
as ia32-libs)

(I've gone into more detail about the options from the users' point of
view in past explanations
.)

> Is there plans for this?
I don't know of any specific one. There's a feature request for offering
official 64bit downloads: VWR-13793
.

>  I think that with the refusal to work on a 64bit viewer this
> would be a good compromise because that is the only reason I require a
> 64bit built viewer.
That would indeed make life much easier for non-technical Linux 64bit users.

> I just thought I would probe here first before messing with jiras :)
Although this has been discussed in the past, it's good that someone
brings it up again.

Cheers,
Boroondas
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/136/
---

(Updated Feb. 5, 2011, 3:25 a.m.)


Review request for Viewer.


Changes
---

fixing pointer to jira issue


Summary
---

This modification is a test case and applies to  -OpenSourceRelWithDebInfo only.

Configuration batch file content:
@echo
call c:\VC80\VC\bin\vcvars32.bat
C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c 
OpenSourceRelWithDebInfo

Build batch file content:
C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c 
OpenSourceRelWithDebInfo

This is a clean up of a discarded RB


This addresses bug open-1.
http://jira.secondlife.com/browse/open-1


Diffs
-

  autobuild.xml 00453191c1b9 

Diff: http://codereview.secondlife.com/r/136/diff


Testing
---

There is one post build re-configuration error related to devenv versus vcbuild 
parameter sequence.
However,C:\lindenhg\viewer-autobuild-express-wip\build-vc80\newview\RelWithDebInfo\LindenDeveloper.exe
 was built and
log on to aditi successful.


Thanks,

Nicky

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.

[Wolfpup Lowenhar]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/136/#review332
---



autobuild.xml


I can understand this is testing for right now but instead of changing an 
existing element why not create a new one by copy and pasting this one then 
change the name slightly and make the needed mode it that one so as to not 
break existing settings for those that they do work for.


- Wolfpup


On Feb. 5, 2011, 3:25 a.m., Nicky Perian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/136/
> ---
> 
> (Updated Feb. 5, 2011, 3:25 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This modification is a test case and applies to  -OpenSourceRelWithDebInfo 
> only.
> 
> Configuration batch file content:
> @echo
> call c:\VC80\VC\bin\vcvars32.bat
> C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c 
> OpenSourceRelWithDebInfo
> 
> Build batch file content:
> C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c 
> OpenSourceRelWithDebInfo
> 
> This is a clean up of a discarded RB
> 
> 
> This addresses bug open-1.
> http://jira.secondlife.com/browse/open-1
> 
> 
> Diffs
> -
> 
>   autobuild.xml 00453191c1b9 
> 
> Diff: http://codereview.secondlife.com/r/136/diff
> 
> 
> Testing
> ---
> 
> There is one post build re-configuration error related to devenv versus 
> vcbuild parameter sequence.
> However,C:\lindenhg\viewer-autobuild-express-wip\build-vc80\newview\RelWithDebInfo\LindenDeveloper.exe
>  was built and
> log on to aditi successful.
> 
> 
> Thanks,
> 
> Nicky
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] streaming media on 64bit?

[Marc Adored]

So maybe someone should provide a download of the needed 32bit
gstreamer libraries :) I think that if linden did this sort of like
Pheonix does with the SLVoice where the first launch it downloads any
extra libraries and puts them in the libs/bins folder. Is this a
practice linden might be interested in?

On Sat, Feb 5, 2011 at 5:47 AM, Boroondas Gupte
 wrote:
> Hi Marc
>
> On 02/05/2011 05:03 AM, Marc Adored wrote:
>
> I am on 64bit ubuntu and noticed that media on a prim works now even
> though I am using a 32bit viewer. I am assuming this is because it is
> a SLPlugin and not part of the viewer?
>
> That's not the reason: The SLPlugin binary, while a separate process than
> the viewer main binary, is also shipped only compiled for 32bit in the
> official downloads and thus faces the same problem as the main binary: it
> can only load 32bit libraries. The reason why it can display web content
> anyway, is that the library used for rendering html is also included (also
> in 32bit) in the download.
>
> I was wondering if the
> streaming audio/video that has not worked for 32bit viewers on 64bit
> systems could be reworked to work the same way?
>
> For audio/video stream display, the GStreamer libraries are used, but those
> aren't included in the download. So SLPlugin tries to load the
> system-installed version (if any), which (if SLPlugin is compiled for 32bit)
> can only succeed if those libs are compiled for 32bit, too.
>
> So the possibilities would be:
>
> Include 32bit GStreamer libraries in the official download (or in a separate
> download)
>
> Around 17 MB including common plugins, but still excluding any dependency
> libraries that might have to be added for this to work, too
>
> Offer SPLugin (and maybe the whole viewer) compiled for 64bit, too
>
> This would mean additional QA work for LL.
>
> Have Linux 64bit users install a 32bit GStreamer
>
> Probably difficult on many distributions (because GStreamer is usually not
> part of the 32bit compatibility bundles, such as ia32-libs)
>
> (I've gone into more detail about the options from the users' point of view
> in past explanations.)
>
> Is there plans for this?
>
> I don't know of any specific one. There's a feature request for offering
> official 64bit downloads: VWR-13793.
>
>  I think that with the refusal to work on a 64bit viewer this
> would be a good compromise because that is the only reason I require a
> 64bit built viewer.
>
> That would indeed make life much easier for non-technical Linux 64bit users.
>
> I just thought I would probe here first before messing with jiras :)
>
> Although this has been discussed in the past, it's good that someone brings
> it up again.
>
> Cheers,
> Boroondas
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters

[Kitty Barnett]

> On Feb. 3, 2011, 5:06 a.m., Oz Linden wrote:
> >

Is there any reason to "fix" this in getAvatars() rather than just "fixing" it 
when processing the CoarseLocationUpdate legacy region message (and when 
processing the still unused cap)?

The minimap for instance won't call getAvatars() but will rather access the 
position directly so it would still be broken for nearby avatars when >1000m.

Additionally, if the plan is to still enable the http cap at some point in the 
future then fixing the viewer's handling of that now would ideally mean that 
the problem is fixed for everyone as soon as it's enabled rather than having to 
wait another quarter for the next viewer release that contains the fix.


- Kitty


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/132/#review316
---


On Feb. 2, 2011, 3:39 p.m., Twisted Laws wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/132/
> ---
> 
> (Updated Feb. 2, 2011, 3:39 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This modifies the getAvatars function in llworld to also include any avatars 
> that are found within the range from the LLCharactes list as well (the list 
> of avatars that is in the viewer object list).  This should make sure that 
> anyone that you visually see within range shows up in the list.  Note that 
> changing it in this function also affects 
> LLFloaterAvatarPicker::populateNearMe, LLLocalSpeakerMgr::updateSpeakerList, 
> as well as the LLPanelPeople::updateNearbyList that was originally mentioned 
> in the Jira.  The region avatars lists only contain valid position data when 
> the avatars are below 1024m.  The comment that mentions about retrieving 
> uuids is based on the function, not the current uses.  No current calls in 
> the code are done with the avatar_ids argument NULL.  Duplicates in the 
> returned list need to be suppressed.
> 
> 
> This addresses bug VWR-17050.
> http://jira.secondlife.com/browse/VWR-17050
> 
> 
> Diffs
> -
> 
>   indra/newview/llworld.cpp ebd53632620a 
> 
> Diff: http://codereview.secondlife.com/r/132/diff
> 
> 
> Testing
> ---
> 
> Simple testing in sandboxes of this patch at 20m and 2000m heights with and 
> without avatars nearby.  Tested with varying the NearMeRange to insure it 
> does not show avatars beyond the range.  Testers need to understand that 
> RenderFarClip has an impact on the avatars that are actually in the viewer 
> object list, so setting NearMeRange to a great distance at high altitude 
> won't necessarily add avatars to the list.  Basically if you can see the 
> avatar and its within NearMeRange, the avatar should be in the nearby avatar 
> list in the people panel.
> 
> 
> Thanks,
> 
> Twisted
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] streaming media on 64bit?

[Marc Adored]

This is the error I get:

 pid:5205: (media plugin) grab_gst_syms:93: Found DSO: libgstreamer-0.10.so.0
 pid:5205: (media plugin) grab_gst_syms:107: Found DSO: libgstvideo-0.10.so.0

(:5205): GStreamer-WARNING **: Failed to load plugin
'/usr/lib32/gstreamer-0.10/libgstspc.so': libopenspc.so.0: cannot open
shared object file: No such file or directory
 pid:5205: (media plugin) MediaPluginGStreamer010:170:
MediaPluginGStreamer010 constructor - my PID=5205
 pid:5205: (media plugin) receiveMessage:1000: GStreamer010 media
instance failed to set up
2011-02-05T15:04:29Z INFO: LLPluginProcessParent::receiveMessage:
plugin version string: GStreamer010 media plugin, GStreamer version
0.10.30.0 (runtime), 0.10.6.0 (headers)
 pid:5205: (media plugin) receiveMessage:1216:
MediaPluginGStreamer010::receiveMessage: unknown message class:
media_browser
 pid:5205: (media plugin) receiveMessage:1216:
MediaPluginGStreamer010::receiveMessage: unknown message class:
media_browser
 pid:5205: (media plugin) receiveMessage:1216:
MediaPluginGStreamer010::receiveMessage: unknown message class:
media_browser
 pid:5205: (media plugin) receiveMessage:1216:
MediaPluginGStreamer010::receiveMessage: unknown message class:
media_browser
 pid:5205: (media plugin) receiveMessage:1216:
MediaPluginGStreamer010::receiveMessage: unknown message class:
media_browser
 pid:5205: (media plugin) receiveMessage:1027:
MediaPluginGStreamer010::receiveMessage: shared memory added, name:
/LL5174_3, size: 8, address: 0xf732e000
 pid:5205: (media plugin) receiveMessage:1107: >Got size change
instruction from application with shm name: /LL5174_3 - size is 1 x 1
 pid:5205: (media plugin) receiveMessage:1123: *** Got size change
with matching shm, new size is 1 x 1
 pid:5205: (media plugin) receiveMessage:1124: *** Got size change
with matching shm, texture size size is 1 x 1


I have copied the gstreamer-0.10 from my wifes 32bit ubuntu to
/usr/lib32/gstreamer-0.10 but it still cant find the file
/usr/lib32/gstreamer-0.10/libgstspc.so. I have verified it is there so
I am not sure why it can't find it. I also put all the gstreamer libs
into the lib of sl folder and it still can not find it :/ I know she
has all the proper gstreamer plugins installed also because streaming
media works for her so theoretically it should work for me. From that
message it just looks like its not finding the files...
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Copying GStreamer from a 32bit system to a 64bit one (was: streaming media on 64bit?)

[Boroondas Gupte]

On 02/05/2011 04:15 PM, Marc Adored wrote:
> (:5205): GStreamer-WARNING **: Failed to load plugin
> '/usr/lib32/gstreamer-0.10/libgstspc.so': libopenspc.so.0: cannot open
> shared object file: No such file or directory
>
> [...]
>
> I have copied the gstreamer-0.10 from my wifes 32bit ubuntu to
> /usr/lib32/gstreamer-0.10 but it still cant find the file
> /usr/lib32/gstreamer-0.10/libgstspc.so.
GStreamer is not failing to find libgstspc.so ... ratherlibgstspc.so is
failing to find libopenspc.so.0 ...

GStreamer is not self-contained: It (or its plugins) uses a lot of
shared libraries that aren't part of GStreamer itself (and thus not in
its directory but somewhere else on the system).

Cheers,
Boroondas
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] streaming media on 64bit?

[Sythos]

On Sat, 5 Feb 2011 10:15:35 -0500
Marc Adored  wrote:

> I have copied the gstreamer-0.10 from my wifes 32bit ubuntu to

very bad idea

> /usr/lib32/gstreamer-0.10 but it still cant find the file
> /usr/lib32/gstreamer-0.10/libgstspc.so. I have verified it is there so
> I am not sure why it can't find it. I also put all the gstreamer libs

you need to install ia32libs, this bundle a ot of 32bit libraries to
handle this kind of problems, install the package "linux32" too, may be
nice and usefull run the viewer within it
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] streaming media on 64bit?

[Marc Adored]

On Sat, Feb 5, 2011 at 10:48 AM, Altair Sythos  wrote:
> On Sat, 5 Feb 2011 10:15:35 -0500
> Marc Adored  wrote:
>
>> I have copied the gstreamer-0.10 from my wifes 32bit ubuntu to
>
> very bad idea

Not really I didn't overwrite my libs in /usr/lib i put them in
/usr/lib32 where they belong and its the same version/distro of ubuntu
so it should be fine.

>
>> /usr/lib32/gstreamer-0.10 but it still cant find the file
>> /usr/lib32/gstreamer-0.10/libgstspc.so. I have verified it is there so
>> I am not sure why it can't find it. I also put all the gstreamer libs
>
> you need to install ia32libs, this bundle a ot of 32bit libraries to
> handle this kind of problems, install the package "linux32" too, may be
> nice and usefull run the viewer within it

I have ia32libs installed but it doesnt install a 32bit gstreamer sadly.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Copying GStreamer from a 32bit system to a 64bit one (was: streaming media on 64bit?)

[Marc Adored]

SUCCESS! Ok so I found this wonderful program called getlibs. I've
used it before and I tried to get gstreamer stuff installed but failed
but I figured it out this time. I used this command to get a list of
all my 64bit gstreamer stuff installed:

apt-cache show gstreamer* |grep "Package: gstreamer"

With that command I got a list and ran this command:

getlibs -p gstreamer-tools gstreamer0.10-alsa gstreamer0.10-doc
gstreamer0.10-esd gstreamer0.10-gnonlin gstreamer0.10-gnonlin-dbg
gstreamer0.10-gnonlin-doc gstreamer0.10-nice
gstreamer0.10-plugins-base gstreamer0.10-plugins-base-apps
gstreamer0.10-plugins-base-dbg gstreamer0.10-plugins-base-doc
gstreamer0.10-plugins-good gstreamer0.10-plugins-good-dbg
gstreamer0.10-plugins-good-doc gstreamer0.10-pulseaudio
gstreamer0.10-tools gstreamer0.10-x gstreamer-dbus-media-service
gstreamer0.10-buzztard gstreamer0.10-buzztard-doc gstreamer0.10-ffmpeg
gstreamer0.10-ffmpeg-dbg gstreamer0.10-fluendo-mp3
gstreamer0.10-gnomevfs gstreamer0.10-packagekit
gstreamer0.10-plugins-bad gstreamer0.10-plugins-bad-dbg
gstreamer0.10-plugins-bad-doc gstreamer0.10-plugins-cutter
gstreamer0.10-plugins-ugly gstreamer0.10-plugins-ugly-dbg
gstreamer0.10-plugins-ugly-doc gstreamer0.10-pocketsphinx
gstreamer0.10-sdl gstreamer0.10-plugins-bad-multiverse
gstreamer0.10-plugins-bad-multiverse-dbg
gstreamer0.10-plugins-ugly-multiverse
gstreamer0.10-plugins-ugly-multiverse-dbg gstreamer0.10-packagekit
gstreamer0.10-fluendo-plugins-mp3-partner

Yeah its a long command and it takes awhile to execute. The only
package it failed to fetch was
gstreamer0.10-fluendo-plugins-mp3-partner_7.0.20100316-3_i386 which I
downloaded from

http://pkgs.org/download/ubuntu-10.04/canonical-partner-i386/gstreamer0.10-fluendo-plugins-mp3-partner_7.0.20100316-3_i386.deb.html

and then installed it like so:

getlibs -i gstreamer0.10-fluendo-plugins-mp3-partner_7.0.20100316-3_i386.deb

Then started secondlife and I had streaming audio!

Now I will say that that list above could be cleaned up to only
install what secondlife needs but I just did it all to get it working.
I am sure some of those packages are duplicates also. Anyone who cares
to clean it up go ahead I just got it working :P

Also you probably need to install the 32bit compatibility packages
first and of course you'll need to install getlibs. It used to be at
http://frozenfox.freehostia.com/cappy/ but that link is broke and I am
not sure if its in the default ubuntu repos :/ It shows up in mine but
I don't know if that is because the package was installed from that
link. I have had it on my machine for a long time.

Hope this helps everyone :)








On Sat, Feb 5, 2011 at 10:29 AM, Boroondas Gupte
 wrote:
> On 02/05/2011 04:15 PM, Marc Adored wrote:
>> (:5205): GStreamer-WARNING **: Failed to load plugin
>> '/usr/lib32/gstreamer-0.10/libgstspc.so': libopenspc.so.0: cannot open
>> shared object file: No such file or directory
>>
>> [...]
>>
>> I have copied the gstreamer-0.10 from my wifes 32bit ubuntu to
>> /usr/lib32/gstreamer-0.10 but it still cant find the file
>> /usr/lib32/gstreamer-0.10/libgstspc.so.
> GStreamer is not failing to find libgstspc.so ... ratherlibgstspc.so is
> failing to find libopenspc.so.0 ...
>
> GStreamer is not self-contained: It (or its plugins) uses a lot of
> shared libraries that aren't part of GStreamer itself (and thus not in
> its directory but somewhere else on the system).
>
> Cheers,
> Boroondas
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/139/
---

Review request for Viewer.


Summary
---

This is a request for help.  I am trying to learn more about c++ and how 
variables in one class are accessed from another.  For someone who knows what 
they are doing this is probably a pretty easy question.

I have been able to set the font size on the chat input box when it is created 
in llbottomtray.cpp.  I would like to do the same thing when someone clicks in 
that box to input text; it is possible they have changed the font setting and I 
would like to apply the size there as well, but I am stuck on how to do this.  
I think the right place to do this is in 
llchatbar.cpp/LLChatBar::onInputEditorGainFocus().

I have tried all kinds of wrong ways but at this point am stymied.

Exact steps on how to proceed would be appreciated.


This addresses bug vwr-0.
http://jira.secondlife.com/browse/vwr-0


Diffs
-

  indra/llui/lllineeditor.h 3d2e71443c58 
  indra/llui/lllineeditor.cpp 3d2e71443c58 
  indra/newview/llbottomtray.cpp 3d2e71443c58 
  indra/newview/llchatbar.cpp 3d2e71443c58 

Diff: http://codereview.secondlife.com/r/139/diff


Testing
---


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.

[Nicky Perian]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/136/#review334
---


WolfPup: I tried the adding a slightly different group  to autobuild.xml 
(OpenSourceRelWithDebInfoE)
and python scripts crash. Appears to perform actions based on the section title 
 in addition to the
section content. So, i think the LL Devs should work that one out.

Python error output:
C:\lindenhg\viewer-autobuild-wip>autobconf
ECHO is on.

C:\lindenhg\viewer-autobuild-wip>call c:\VC80\VC\bin\vcvars32.bat

C:\lindenhg\viewer-autobuild-wip>"C:\VC80\Common7\Tools\vsvars32.bat"
Setting environment for using Microsoft Visual Studio 2005 x86 tools.

C:\lindenhg\viewer-autobuild-wip>C:\lindenhg\autobuild-vcexpress-wip\bin\autobui
ld --debug configure -c OpenSourceRelWithDebInfoE
no configuration for build configuration 'OpenSourceRelWithDebInfoE'
Traceback (most recent call last):
  File "C:\lindenhg\autobuild-vcexpress-wip\autobuild\autobuild_tool_configure.p
y", line 106, in _configure_a_configuration
config.get_build_configuration(build_configuration.name, 'common')
  File "C:\lindenhg\autobuild-vcexpress-wip\autobuild\configfile.py", line 100,
in get_build_configuration
build_configuration_name)
ConfigurationError: no configuration for build configuration 'OpenSourceRelWithD
ebInfoE'
no common platform found
Traceback (most recent call last):
  File "C:\Python26\lib\logging\__init__.py", line 776, in emit
msg = self.format(record)
  File "C:\Python26\lib\logging\__init__.py", line 654, in format
return fmt.format(record)
  File "C:\Python26\lib\logging\__init__.py", line 436, in format
record.message = record.getMessage()
  File "C:\Python26\lib\logging\__init__.py", line 306, in getMessage
msg = msg % self.args
  File "C:\lindenhg\autobuild-vcexpress-wip\autobuild\executable.py", line 86, i
n __str__
return ' '.join(all_arguments)
TypeError: sequence item 0: expected string, NoneType found
no command specified
Traceback (most recent call last):
  File "C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild", line 47, in 

sys.exit( Autobuild().main(sys.argv[1:]) )
  File "C:\lindenhg\autobuild-vcexpress-wip\autobuild\autobuild_main.py", line 1
35, in main
tool_to_run.run(args)
  File "C:\lindenhg\autobuild-vcexpress-wip\autobuild\autobuild_tool_configure.p
y", line 81, in run
args.additional_options, args.dry_run)
  File "C:\lindenhg\autobuild-vcexpress-wip\autobuild\autobuild_tool_configure.p
y", line 123, in _configure_a_configuration
return configure_executable(extra_arguments)
  File "C:\lindenhg\autobuild-vcexpress-wip\autobuild\executable.py", line 72, i
n __call__
raise ExecutableError('no command specified')
ExecutableError: no command specified
ERROR: no command specified
For more information: try re-running your command with --verbose or --debug

- Nicky


On Feb. 5, 2011, 3:25 a.m., Nicky Perian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/136/
> ---
> 
> (Updated Feb. 5, 2011, 3:25 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This modification is a test case and applies to  -OpenSourceRelWithDebInfo 
> only.
> 
> Configuration batch file content:
> @echo
> call c:\VC80\VC\bin\vcvars32.bat
> C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c 
> OpenSourceRelWithDebInfo
> 
> Build batch file content:
> C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c 
> OpenSourceRelWithDebInfo
> 
> This is a clean up of a discarded RB
> 
> 
> This addresses bug open-1.
> http://jira.secondlife.com/browse/open-1
> 
> 
> Diffs
> -
> 
>   autobuild.xml 00453191c1b9 
> 
> Diff: http://codereview.secondlife.com/r/136/diff
> 
> 
> Testing
> ---
> 
> There is one post build re-configuration error related to devenv versus 
> vcbuild parameter sequence.
> However,C:\lindenhg\viewer-autobuild-express-wip\build-vc80\newview\RelWithDebInfo\LindenDeveloper.exe
>  was built and
> log on to aditi successful.
> 
> 
> Thanks,
> 
> Nicky
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/139/
---

(Updated Feb. 5, 2011, 3:08 p.m.)


Review request for Viewer.


Changes
---

Pay no attention to anything in llchatbar -- I am told that is dead code.

The font is set in bottomtray when the chat box is initially built.  I suspect 
that code can now be deleted as the font is set every time when the chat box is 
given focus in nearbychatbar.


Summary
---

This is a request for help.  I am trying to learn more about c++ and how 
variables in one class are accessed from another.  For someone who knows what 
they are doing this is probably a pretty easy question.

I have been able to set the font size on the chat input box when it is created 
in llbottomtray.cpp.  I would like to do the same thing when someone clicks in 
that box to input text; it is possible they have changed the font setting and I 
would like to apply the size there as well, but I am stuck on how to do this.  
I think the right place to do this is in 
llchatbar.cpp/LLChatBar::onInputEditorGainFocus().

I have tried all kinds of wrong ways but at this point am stymied.

Exact steps on how to proceed would be appreciated.


This addresses bug vwr-0.
http://jira.secondlife.com/browse/vwr-0


Diffs (updated)
-

  indra/llui/lllineeditor.h 3d2e71443c58 
  indra/llui/lllineeditor.cpp 3d2e71443c58 
  indra/newview/llbottomtray.cpp 3d2e71443c58 
  indra/newview/llchatbar.h 3d2e71443c58 
  indra/newview/llchatbar.cpp 3d2e71443c58 
  indra/newview/llnearbychatbar.cpp 3d2e71443c58 

Diff: http://codereview.secondlife.com/r/139/diff


Testing
---


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.

[Nicky Perian]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/136/
---

(Updated Feb. 5, 2011, 8:50 p.m.)


Review request for Viewer.


Changes
---

Updated per Wolfpup review. Restored OpenSourceRelWithDebInfo to devenv build.
Established OpenSourceRelWithDebInfoE for Express edition which uses 
vcbuild.exe.
autobconf.bat content--
@echo
call c:\VC80\VC\bin\vcvars32.bat
C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c 
OpenSourceRelWithDebInfoE

autobb.bat content--
C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c 
OpenSourceRelWithDebInfoE

Problem cited in my earlier entry was not considering the dual nature of 
autobuild.xml. That being sections for configuration and building.

Bottom line is this should work for Express without breaking Pro. If both Pro 
and Express are installed either method may be used. If only Pro is present 
either method my be used.


Summary
---

This modification is a test case and applies to  -OpenSourceRelWithDebInfo only.

Configuration batch file content:
@echo
call c:\VC80\VC\bin\vcvars32.bat
C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug configure -c 
OpenSourceRelWithDebInfo

Build batch file content:
C:\lindenhg\autobuild-vcexpress-wip\bin\autobuild --debug build -c 
OpenSourceRelWithDebInfo

This is a clean up of a discarded RB


This addresses bug open-1.
http://jira.secondlife.com/browse/open-1


Diffs (updated)
-

  autobuild.xml 00453191c1b9 

Diff: http://codereview.secondlife.com/r/136/diff


Testing
---

There is one post build re-configuration error related to devenv versus vcbuild 
parameter sequence.
However,C:\lindenhg\viewer-autobuild-express-wip\build-vc80\newview\RelWithDebInfo\LindenDeveloper.exe
 was built and
log on to aditi successful.


Thanks,

Nicky

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges