[opensource-dev] Daily Scrum Summary - Thursday, February 3

[Anya Kanevsky]

 Thursday, February 3 General Notes
--

   - Please do not pick up issues tagged with needs-design until the tag has
   been removed.
   - MMOTD: Merov
   - Please remember to move issues to current Sprint when a) starting work
   on them or b) accepting issues from the community

Team Status
--
 Merov Linden
--

*PAST*

   - More SNOW triaging: only a dozen left to go...
   - Merge Monkeying: push fixes in both viewer-beta and viewer-development,
   PO build
   - STORM-864 : APR memory pool : finished code review, did a test build,
   plenty of issues. Rejected review. See JIRA for details.

*FUTURE*

   - MM
   - STORM-864 : APR memory pool : waiting on Aleric, suspecting some apr
   bundling issues on Linux and Windows
   - STORM-955 : Massively duplicated objects : keep an eyes on this
   - STORM-746 : KDU Improvements: Compress j2c with precincts

*IMPEDIMENTS*

   - none

Oz Linden
--

*PAST*

   - Created 'Open Development' jira project
   - Non-Snowstorm activities
   - Started discussions about open data APIs

*FUTURE*

   - Review autobuild changes from NickyP
   - Document policies and test new jira project rules
   - PO Review
   - Internal Linden training session

*IMPEDIMENTS*

   - none

Q Linden
--

*PAST*

   - STORM-465
   - Triage tooling attempt (which sadly failed, but i have ideas)
   - OOO / Doctor
   - beta 3

*FUTURE*

   - beta 3
   - internal training session
   - OOO late today and all day tomorrow
   - spend time with wolf but probably not 'til monday

*IMPEDIMENTS*

   - none, other than time

Grumpity ProductEngine
--

*PAST*

   - prep for product tirage
   - a bit more jira cleanup
   - non-snowstorm stuff

*FUTURE*

   - PEQA deferred issues triage with Bambers
   - continue to prod others to resolve impediments
  - STORM-379, STORM-465

*IMPEDIMENTS*

   - we need more vwr triage - bug queue is getting empty

Paul ProductEngine
--

*PAST*

   - BUG STORM-680 (Avaline callers are added to the Recent list)
  - WIP. 90%. Estimate 2 hours. Implementing the solution.

*FUTURE*

   - Finish with BUG STORM-680 (Avaline callers are added to the Recent
   list)

*IMPEDIMENTS*

   - Today's progress is not very good because of headache. Today will go
   home a little bit earlier, feel bad.

Seth Productengine
--

*PAST*

   - BUG (STORM-433) Friendship offer shifted up and placed over "Second
   Life" text
  - Found that reshaping text editor with a friendship offer fixes its
  placement. Still looking for more precise reason of the problem

*FUTURE*

   - BUG (STORM-433) Friendship offer shifted up and placed over "Second
   Life" text
  - Estimated: 8-10 hours.

*IMPEDIMENTS*

   - BUG (STORM-379) Content permissions aren't refreshed in the "Buy copy
   of" floater.
  - Asked in JIRA whether the bug should be fixed in a way that may
  increase server load.

Vadim Productengine
--

*PAST*

   - Looked through high impact issues (in code familiar to me) from the
   recent Coverity report.
  - Haven't found anything dangerous (and even if I had found something,
  I don't know the process to handle such issues).
   - Story STORM-2 (Customizable viewer layouts):
  - Working on saving sidebar state. Stuck with handling minimization.
  - I remember Andrew mentioning a bug in LLFloaterReg which may cause
  it to misbehave. Will try consulting with him tomorrow.

*FUTURE*

   - Will work on STORM-2 at least till the end of week.

*IMPEDIMENTS*

   - none

Andrey ProductEngine
--

*PAST*

   - picked up Beta3 build#2 (r220251)
   - executed smoke and integrity tests on Windows, Linux and OSX. See
   IQA-80 for more details.
  - smoke on Linux has been failed but it looks like specific
  environment issue (?)
   - proceeded with v-d regression testing, see spreadsheet
   - reported 2 issues: VWR-24714 and VWR-24715

*FUTURE*

   - investigate VWR-24714
   - verify integrated STORM tickets against the latest v-d build *FUTURE*

*IMPEDIMENTS*

   - none

Wolfpup Lowenhar
--

*PAST*

   - Worked @ RL .
   - STORM-236 : began debuging issue with button layout resized issues.
   Also discussed this with Oz in IRC.

*FUTURE*

   - Work @ RL
   - STORM-941 : email Oz and Leyla concering posible areas that could be
   causeing the problem.

*IMPEDIMENTS*

   - STORM-236 : waiting for new graphics and name to call the panel.
   - Not enough time to actually work on code.
   - Computer repair Client that dose not know what non repairable means and
   keeps trying to have me fix a unit that is beyond repair.

Jonathan Yap
--

*PAST*

   - VWR-24628 (Descriptive text missing next to first checkbox in About
   Land/Acc

Re: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

[Boroondas Gupte]

> On Feb. 2, 2011, 6:30 p.m., Merov Linden wrote:
> > indra/llmessage/llpumpio.cpp, line 359
> > 
> >
> > An example where the use of operator() is particularly unsightly...
> 
> Aleric Inglewood wrote:
> And rightfully so! It should be "extremely unpleasant" for the user to 
> get to the underlaying apr_pool_t*.
> That this code hacks access is exactly that: a hack. One has to be very 
> careful when doing this.
> The reason I did it here is because 1) I know what I'm doing, so it's ok 
> in this case, 2) for this
> first introduction of LLAPRPool I tried to make minimal changes to the 
> actual functionality of
> existing code using apr pools (with the exception of LLAPRFile, the 
> rewrite of its API actually
> coming from SNOW-103 which already proved itself in snowglobe, imprudence 
> and other TPV's).
> The fact that this access here is needed actually signifies that this 
> code is not handling
> pools in a very safe way, but I consider(ed) it better to keep the code 
> "as-is" and hack around the
> *safity* of LLAPRPool (and as a result not changing anything!) than to 
> rewrite the interface at this
> point for this particular part of the code; changing things is more risk, 
> in this case, than not
> using the API of LLAPRPool as intended. It would be harder to find if 
> that rewrite would introduce
> some kind of bug we made lots of changes at the same time. I propose to 
> leave this as it is now
> and look at changing it later once everyone feels secure about the 
> stability of the current patch.
> 
> Okay, that sounded nice -- but the truth is that I have no idea (at this 
> point) if it is even
> possible to do what that code does without accessing the underlaying 
> apr_pool_t* like that (meaning,
> not passing it directly to an APR function, but storing it in a 
> structure). I just know that it
> should feel dangerous to do so, so it seems OK that code that does it 
> doesn't look very nice.
>

Then it should maybe be made even more obvious with a super-ugly name like 
getAPRPool_DO_NOT_CALL_THIS_DIRECTLY_use_LLAPRPool_instead()


- Boroondas


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/99/#review315
---


On Jan. 29, 2011, 9:10 a.m., Aleric Inglewood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/99/
> ---
> 
> (Updated Jan. 29, 2011, 9:10 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Please see http://jira.secondlife.com/browse/STORM-864
> 
> I made a mercurial repository available for testing here:
> 
> hg clone https://bitbucket.org/aleric/viewer-development-storm-864
> 
> From the commit message:
> 
> Introduces a LLThreadLocalData class that can be
> accessed through the static LLThread::tldata().
> Currently this object contains two (public) thread-local
> objects: a LLAPRRootPool and a LLVolatileAPRPool.
> 
> The first is the general memory pool used by this thread
> (and this thread alone), while the second is intended
> for short lived memory allocations (needed for APR).
> The advantages of not mixing those two is that the latter
> is used most frequently, and as a result of it's nature
> can be destroyed and reconstructed on a "regular" basis.
> 
> This patch adds LLAPRPool (completely replacing the old one),
> which is a wrapper around apr_pool_t* and has complete
> thread-safity checking.
> 
> Whenever an apr call requires memory for some resource,
> a memory pool in the form of an LLAPRPool object can
> be created with the same life-time as this resource;
> assuring clean up of the memory no sooner, but also
> not much later than the life-time of the resource
> that needs the memory.
> 
> Many, many function calls and constructors had the
> pool parameter simply removed (it is no longer the
> concern of the developer, if you don't write code
> that actually does an libapr call then you are no
> longer bothered with memory pools at all).
> 
> However, I kept the notion of short-lived and
> long-lived allocations alive (see my remark in
> the jira here: 
> https://jira.secondlife.com/browse/STORM-864?focusedCommentId=235356&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-235356
> which requires that the LLAPRFile API needs
> to allow the user to specify how long they
> think a file will stay open. By choosing
> 'short_lived' as default for the constructor
> that immediately opens a file, the number of
> instances where this needs to be specified is
> drastically reduced however (obviously, any
> automatic LLAPRFile is short lived).

Re: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

[Aleric Inglewood]

> On Feb. 2, 2011, 6:30 p.m., Merov Linden wrote:
> > indra/llmessage/llpumpio.cpp, line 359
> > 
> >
> > An example where the use of operator() is particularly unsightly...
> 
> Aleric Inglewood wrote:
> And rightfully so! It should be "extremely unpleasant" for the user to 
> get to the underlaying apr_pool_t*.
> That this code hacks access is exactly that: a hack. One has to be very 
> careful when doing this.
> The reason I did it here is because 1) I know what I'm doing, so it's ok 
> in this case, 2) for this
> first introduction of LLAPRPool I tried to make minimal changes to the 
> actual functionality of
> existing code using apr pools (with the exception of LLAPRFile, the 
> rewrite of its API actually
> coming from SNOW-103 which already proved itself in snowglobe, imprudence 
> and other TPV's).
> The fact that this access here is needed actually signifies that this 
> code is not handling
> pools in a very safe way, but I consider(ed) it better to keep the code 
> "as-is" and hack around the
> *safity* of LLAPRPool (and as a result not changing anything!) than to 
> rewrite the interface at this
> point for this particular part of the code; changing things is more risk, 
> in this case, than not
> using the API of LLAPRPool as intended. It would be harder to find if 
> that rewrite would introduce
> some kind of bug we made lots of changes at the same time. I propose to 
> leave this as it is now
> and look at changing it later once everyone feels secure about the 
> stability of the current patch.
> 
> Okay, that sounded nice -- but the truth is that I have no idea (at this 
> point) if it is even
> possible to do what that code does without accessing the underlaying 
> apr_pool_t* like that (meaning,
> not passing it directly to an APR function, but storing it in a 
> structure). I just know that it
> should feel dangerous to do so, so it seems OK that code that does it 
> doesn't look very nice.
>
> 
> Boroondas Gupte wrote:
> Then it should maybe be made even more obvious with a super-ugly name 
> like getAPRPool_DO_NOT_CALL_THIS_DIRECTLY_use_LLAPRPool_instead()

That is not possible, as operator() is definitely part of the normal API (it's 
just unfortunate that it has to exist).
Let me explain more about what is so "dangerous" about allowing access. Also, 
realize that before this patch
everything was completely open (accessible) and spread out through the code, so 
it's at least 1000 times better
this way -- just not 100% bullet proof).

Firstly, we can't use 
getAPRPool_DO_NOT_CALL_THIS_DIRECTLY_use_LLAPRPool_instead() instead of
operator()(void), because that would change perfectly legal code like (where 
mPool is a LLAPRPool):

 apr_thread_cond_create(&mAPRCondp, mPool());

into

 apr_thread_cond_create(&mAPRCondp, 
mPool.getAPRPool_DO_NOT_CALL_THIS_DIRECTLY_use_LLAPRPool_instead());

where mPool() is the same as mPool.operator()(), returning the underlaying 
apr_pool_t* to pass it to
the apr library call using it.

The reason that I call it "dangerous" that the user (that is, other developers 
that use this
LLAPRPool interface) can access the underlaying apr_pool_t* is because they 
might be tempted
to do something like:

 apr_pool_t* pool = mPool();
 // Use 'pool'.
 apr_pool_destroy(pool);

Fortunately, this would be easy detectable by grepping the source code for 
'apr_pool_t'.
Less obvious would be:

 some_apr_defined_struct.pool = mPool();
 // leave some_apr_defined_struct around for OTHER threads to use.

That would, obviously, defy the thread-safity checks of LLAPRPool, and we also 
wouldn't
find it by grepping for apr_pool_t because this struct is defined in a header 
of libapr.

I'd almost say that one could call it "far fetched" to assume that anyone would
do anything like this-- so the chance that anything wrong ever happening is 
indeed
very small. Nevertheless, to avoid all that, I made the 'rule of thumb' that the
operator() only be used WHEN passing the pool directly to an apr_* library call.

It would have been better if we could even drop that restriction (by getting 
rid of
the current possibility to corrupt things by getting access to the underlaying
apr_pool_t), but that is only possible if the operator() is removed completely
and we overload all apr_* functions that we use (making those friend of 
LLAPRPool,
so they can call the real libapr function with apr_pool_t* parameter). I didn't 
feel
that the remaining security risk warranted that though.

Nevertheless, if merov wants then I can do this. The only draw back would
be that 1) every source file would need to include the apr_pools.h (through
linden_common.h I presume), just to stop every source code from possibly
including that themselves and using apr pools directly. 2) Every time we want
to use a new APR library function that nee

[opensource-dev] What is it with these Build Numbers?

[CG Linden]

"Everybody thinks Release Engineering is like a bikeshed, so people go on
happily slapping paint onto it, not realizing that there is a nuclear
missile silo underneath."

Yes, this is one of those things... after all, how hard can it be to list
all the changes since the last release, or all the changes pending to go
into the current release?

To learn more about how we use build numbers, and why the build results
occasionally had links to this "codeticket" thing, read:
http://wiki.secondlife.com/wiki/Codeticket_Service
--
cg
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

[Oz Linden (Scott Lawrence)]

On 2011-02-03 21:36, Aleric Inglewood wrote:
>
> Can this patch please be added to viewer-development? It's getting really 
> annoying that I have to apply patches to the soruce tree before it even can 
> compile cleanly :(.

Adding comments merely to complain about progress or lack thereof is not 
helpful.  Please don't do it.


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] What is it with these Build Numbers?

[Latif Khalifa]

Very informative page, thank you very much!

On Fri, Feb 4, 2011 at 5:17 PM, CG Linden  wrote:
> "Everybody thinks Release Engineering is like a bikeshed, so people go on
> happily slapping paint onto it, not realizing that there is a nuclear
> missile silo underneath."
>
> Yes, this is one of those things... after all, how hard can it be to list
> all the changes since the last release, or all the changes pending to go
> into the current release?
>
> To learn more about how we use build numbers, and why the build results
> occasionally had links to this "codeticket" thing, read:
> http://wiki.secondlife.com/wiki/Codeticket_Service
> --
> cg
>
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: (STORM-433) Friendship offer shifted up and placed over "Second Life" text

[Seth ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/138/
---

Review request for Viewer.


Summary
---

Fixed reshaping notification panel with friendship offer when it is inserted 
into IM chat.


This addresses bug STORM-433.
http://jira.secondlife.com/browse/STORM-433


Diffs
-

  indra/newview/llchathistory.cpp 2fe9d48e5881 
  indra/newview/lltoastnotifypanel.cpp 2fe9d48e5881 

Diff: http://codereview.secondlife.com/r/138/diff


Testing
---


Thanks,

Seth

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-379) Content permissions aren't refreshed in the "Buy copy of" floater

[Seth ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/126/#review330
---


Closing this request for now because it is meant to be fix the other way. See 
STORM-379.

- Seth


On Jan. 27, 2011, 4:05 p.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/126/
> ---
> 
> (Updated Jan. 27, 2011, 4:05 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Changed displaying the permissions of inventory items inside an object to 
> show the permissions which will be granted to the next owner of the item.
> 
> The permissions affected by this issue can be seen in Content tab of Tools 
> floater which is open by selecting Edit in object's context menu. If agent 
> can't perform certain actions on the item a respective suffix will be added 
> to the item's name e.g. (no copy), (no modify) or(no transfer).
> 
> This issue affects viewer 1.23 too. Could it be expected behavior?
> 
> 
> This addresses bug STORM-379.
> http://jira.secondlife.com/browse/STORM-379
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelobjectinventory.cpp b542f8134a2b 
> 
> Diff: http://codereview.secondlife.com/r/126/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

[Merov Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/81/#review331
---

Ship it!


OK, did a merge and complete TC build on all platforms: no merge issue, no 
build error. Clear to go. 

- Merov


On Jan. 16, 2011, 5:53 a.m., Aleric Inglewood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/81/
> ---
> 
> (Updated Jan. 16, 2011, 5:53 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Turns out that most of my SNOW-800 patch was included in Viewer 2 (albeit 
> without crediting me).
> However, not everything was used and some more cleaning up was possible.
> 
> After this patch, and when compiling with optimization, there are no 
> duplicates left
> anymore that shouldn't be there in the first place: apart from the debug 
> stream
> iostream guard variable, there are several static variables with the same 
> name (r, r1,
> r2, etc) but that indeed actually different symbol objects. Then there are a 
> few
> constant POD arrays that are duplicated a hand full of times because they are
> accessed with a variable index (so optimizing them away is not possible). I 
> left them
> like that (although defining those as extern as well would have been more 
> consistent
> and not slower; in fact it would be faster theoretically because those arrays 
> could
> share the same cache page then). 
> 
> 
> This addresses bug VWR-24312.
> http://jira.secondlife.com/browse/VWR-24312
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 422f636c3343 
>   indra/llcharacter/llanimationstates.cpp 422f636c3343 
>   indra/llcommon/llavatarconstants.h 422f636c3343 
>   indra/llcommon/lllslconstants.h 422f636c3343 
>   indra/llcommon/llmetricperformancetester.h 422f636c3343 
>   indra/llmath/llcamera.h 422f636c3343 
>   indra/llmath/llcamera.cpp 422f636c3343 
>   indra/newview/llviewerobject.cpp 422f636c3343 
>   indra/newview/llvoavatar.cpp 422f636c3343 
>   indra/newview/llvosky.h 422f636c3343 
>   indra/newview/llvosky.cpp 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/81/diff
> 
> 
> Testing
> ---
> 
> Compiled with optimization and then running readelf on the executable to find 
> duplicated symbols.
> 
> 
> Thanks,
> 
> Aleric
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] streaming media on 64bit?

[Marc Adored]

I am on 64bit ubuntu and noticed that media on a prim works now even
though I am using a 32bit viewer. I am assuming this is because it is
a SLPlugin and not part of the viewer? I was wondering if the
streaming audio/video that has not worked for 32bit viewers on 64bit
systems could be reworked to work the same way? Is there plans for
this? I think that with the refusal to work on a 64bit viewer this
would be a good compromise because that is the only reason I require a
64bit built viewer.

I just thought I would probe here first before messing with jiras :)
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Beyond Storm-2

[Erin Mallory]

sooo I've been thinking allot, and I do mean allot about what else should be 
savable besides layout.

when saving the layouts I think there should be an option to save certain 
preferences. 
here's the ones I was thinking of:
All Graphics settings, all movement settings, and the preferences for chat 
notifications. 
and here is my reasoning:
depending on what you are doing you may either want kick ass all effects 
graphics or very basic, speed graphics, or somewhere in between.  And just 
moving the slider doesn't always really fit the graphics to whats needed. 
(for example if i'm on a date in a really great sim or doing photos i like to 
have local lights on, and much higher detail then i do when i'm say 
roleplaying, inventory sorting, building, or at a roller derby meet.  In fact I 
have very different settings I like for each activity.
likewise if im doing roller derby i like to have the wasd keys default to 
movement and for most other things i like them to be on typing.  Allot of other 
people I know do the same. 
also though i don't ever use the chat popups myself some people actually do at 
least for some things... but several of those people toggle them off for 
certain things so it might be good to go ahead and include those in too. 

If we really wanted to get fancy we could also save the rendering types (like 
volume, particles, etc)
I know this would be difficult but it would be worth it. 

One more thing that should be another option to save is the floater/search 
states... 
for example profiles should open to the same people its saved to if that's what 
the person wants.
likewise inventory windows could be saved to the same search (or not) thats 
entered into the floater.
for example when im sorting inventory i tend to have one with "saved," one with 
"duplicate," one with "not sure I like," and then two or three that i rotate 
the search field as needed.
so I really think this should be an option to save as well... 

just my $2L worth 
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges