Re: [opensource-dev] Review Request: VWR-10579: Fix NDOF.cmake to do the right thing on standalone.

[Aleric Inglewood]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/45/
---

(Updated 2010-12-20 06:04:05.704478)


Review request for Viewer.


Changes
---

This new patch addresses Boroondas -heh- preferences ;) it tries to find NDOF 
and when not found prints an error and the instructions to configure with 
-DNDOF:BOOL=OFF if you really don't want space navigator joystick support. This 
is indeed very simular to how FMOD works currently.

This new patch also adds indra/cmake/FindNDOF.cmake, which was erroneously 
missing from the first patch, oops!


Summary (updated)
---

On standalone, only define -DLIB_NDOF=1 when NDOF can be found.


This addresses bug VWR-10579.
http://jira.secondlife.com/browse/VWR-10579


Diffs (updated)
-

  indra/cmake/FindNDOF.cmake PRE-CREATION 
  indra/cmake/NDOF.cmake b0689af42a71 

Diff: http://codereview.secondlife.com/r/45/diff


Testing
---

I can't remember when I started using this, but it was long ago. I don't have 
libndofdev installed.
I just installed Michelle's debian package libndofdev-dev and then it found it:
-- Found NDOF: Library in '/usr/lib/libndofdev.so' and header in '/usr/include' 


Thanks,

Aleric

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24252: Find Qt4 with find_package on STANDALONE.

[Aleric Inglewood]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/46/
---

(Updated 2010-12-20 06:19:04.960312)


Review request for Viewer.


Changes
---

The new version is the same as the previous one, but it adds 
indra/cmake/FindLLQtWebkit.cmake that was erroneously missing in the previous 
patch.


Summary (updated)
---

This patch has only effect on standalone.
It searches for the Qt libs using the cmake provided FindQt4.cmake
and search for llqtwekbit using the new FindLLQtWebkit.cmake
and then uses the resulting LLQTWEBKIT_LIBRARY
and LLQTWEBKIT_INCLUDE_DIR in the right places.

I added an explicit test to check if QTDIR is set, it is set to
the correct value (even LL got this wrong on their wiki, so it's
apparently not obvious): As of Qt 4, Qt is found by calling qmake,
NOT by looking at QTDIR. So, if you set QTDIR then it better be
set to whatever qmake was "found" (using PATH as usual).

Finally, we also need to explicitly pass the Qt plugin libraries
in order to link with them, so part of this patch adds the rules
to do that (the foreach).

Note that if you installed your libs in a non-standard place, then
of course you still have to set LD_LIBRARY_PATH yourself before
running the viewer ;)


This addresses bug VWR-24252.
http://jira.secondlife.com/browse/VWR-24252


Diffs (updated)
-

  indra/cmake/FindLLQtWebkit.cmake PRE-CREATION 
  indra/cmake/WebKitLibPlugin.cmake b0689af42a71 
  indra/llplugin/CMakeLists.txt b0689af42a71 
  indra/media_plugins/webkit/CMakeLists.txt b0689af42a71 

Diff: http://codereview.secondlife.com/r/46/diff


Testing
---

I used this while working on adding plugin support to Imprudence, needing to 
debug into the Qt libs and llqtwebkit. I added support for multiple versions of 
llqtwebkit to imprudence (not just the one needed, but also newer versions of 
llqtwebkit). Needless to say that I needed this patch to work to find my 
(several) installations of Qt and llqtwebkit.


Thanks,

Aleric

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: VWR-24261: Configuration with cmake 2.8 is extremely slow

[Aleric Inglewood]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/49/
---

Review request for Viewer.


Summary
---

Work around for bug in cmake 2.8+ that causes the time to (re)configure the 
viewer to become 43 times slower.
This patch adds a FindZLIB.cmake that doesn't have the bug added in 2.8 (cmake 
is aware of it and will fix it in a future release, although there is no reason 
to stop using our own in the future). This FindZLIB is linux specific (we only 
need it for standalone), see the discussion in SNOW-751.


This addresses bug VWR-24261.
http://jira.secondlife.com/browse/VWR-24261


Diffs
-

  indra/cmake/CMakeLists.txt b0689af42a71 
  indra/cmake/FindZLIB.cmake PRE-CREATION 

Diff: http://codereview.secondlife.com/r/49/diff


Testing
---

Already added to Snowglobe 1.4 and 1.5. See 
http://jira.secondlife.com/browse/SNOW-751


Thanks,

Aleric

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Modify Viewer to statically link to KDU v6.4.1 if available

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/3/#review57
---

Ship it!


No significant objections. (I didn't actually review llimagej2c.cpp: it would 
take forever :-))

Tested x86 Linux build with USE_KDU set to ON and OFF. Works fine with the 
patch I attached to the ticket.


indra/cmake/Copy3rdPartyLibs.cmake


I didn't quite get why there are FMOD-related changes in this patch.



indra/llkdu/llkdumem.h


CS: mFirstCompIdx, mNumComponents, etc.


- Vadim


On 2010-12-15 22:21:41, Merov Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/3/
> ---
> 
> (Updated 2010-12-15 22:21:41)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This rather big patch accomplish the following:
> - makes llkdu public and open source: this contains decompression and 
> compression implementations using the KDU API
> - links the viewer to KDU v6.4.1 statically if USE_KDU set at build time (and 
> assuming you do have a licensed version of Kakadu)
> - links statically to OpenJpeg otherwise
> 
> 
> This addresses bug STORM-151.
> http://jira.secondlife.com/browse/STORM-151
> 
> 
> Diffs
> -
> 
>   indra/CMakeLists.txt 22c757e8246b 
>   indra/cmake/Copy3rdPartyLibs.cmake 22c757e8246b 
>   indra/cmake/LLKDU.cmake 22c757e8246b 
>   indra/integration_tests/llui_libtest/CMakeLists.txt 22c757e8246b 
>   indra/llimage/CMakeLists.txt 22c757e8246b 
>   indra/llimage/llimage.cpp 22c757e8246b 
>   indra/llimage/llimagej2c.h 22c757e8246b 
>   indra/llimage/llimagej2c.cpp 22c757e8246b 
>   indra/llkdu/CMakeLists.txt PRE-CREATION 
>   indra/llkdu/llimagej2ckdu.h PRE-CREATION 
>   indra/llkdu/llimagej2ckdu.cpp PRE-CREATION 
>   indra/llkdu/llkdumem.h PRE-CREATION 
>   indra/llkdu/llkdumem.cpp PRE-CREATION 
>   indra/newview/CMakeLists.txt 22c757e8246b 
>   indra/newview/viewer_manifest.py 22c757e8246b 
>   install.xml 22c757e8246b 
> 
> Diff: http://codereview.secondlife.com/r/3/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Merov
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24251: Fix -DLL_TESTS:BOOL=ON on standalone when Tut is installed in a non-standard directory.

[Brad Kittenbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/44/#review58
---

Ship it!


Looks good to me

- Brad


On 2010-12-19 07:18:51, Aleric Inglewood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/44/
> ---
> 
> (Updated 2010-12-19 07:18:51)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> If tut/tut.hpp isn't installed in a standard include directory all tests
> fail because the found include directory for tut isn't passed to the compiler.
> 
> This patch fixes this by passing it.
> Note that using include_directories() in a Find*.cmake file is bad practise.
> The correct way is to set an include dir variable and call
> include_directories() once. It certainly doesn't work for the tests anyway
> because the tests are all over the place and include_directories is on a
> per folder basis.  What is needed is to set it for each (test) target.
> 
> However, there is no TARGET_INCLUDE_DIRECTORIES. The closest thing that we
> have is to set the COMPILE_FLAGS property for a target.
> 
> Fortunately, standalone is only used for linux, so we can just use
> -I${TUT_INCLUDE_DIR} to get the effect we want.
> 
> 
> This addresses bug VWR-24251.
> http://jira.secondlife.com/browse/VWR-24251
> 
> 
> Diffs
> -
> 
>   indra/cmake/LLAddBuildTest.cmake b0689af42a71 
>   indra/cmake/Tut.cmake b0689af42a71 
>   indra/test/CMakeLists.txt b0689af42a71 
> 
> Diff: http://codereview.secondlife.com/r/44/diff
> 
> 
> Testing
> ---
> 
> Tested with standalone and tut.hpp installed in a non-standard place *after 
> applying VWR-24247* of course.
> All tests compile and pass (on linux 64bit).
> 
> 
> Thanks,
> 
> Aleric
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations

[Seth ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/32/
---

(Updated 2010-12-20 13:47:20.663157)


Review request for Viewer.


Changes
---

- Added supported glob wildcards matching description.
- Fixed leading '*' translation to regex to avoid matching leading '.' in file 
names.
- Fixed '?' escaping.
- Added incorrect braces usage handling. Added related test cases.
- Fixed character ranges complementation with '!'. Added related test cases.


Summary
---

Fixed LLDir unit test which failed for some complex wildcard combinations.
Added a class implementing directory entries iteration with pattern matching 
which is used in unit tests instead of LLDir::getNextFileInDir.

This code has been run on Linux only. It should be tested under other platforms 
and more test cases should be provided. For example changing directory contents 
while iterating through it.


This addresses bug STORM-550.
http://jira.secondlife.com/browse/STORM-550


Diffs (updated)
-

  indra/cmake/Boost.cmake 794ad1fc71d1 
  indra/llvfs/CMakeLists.txt 794ad1fc71d1 
  indra/llvfs/lldiriterator.h PRE-CREATION 
  indra/llvfs/lldiriterator.cpp PRE-CREATION 
  indra/llvfs/tests/lldir_test.cpp 794ad1fc71d1 

Diff: http://codereview.secondlife.com/r/32/diff


Testing
---


Thanks,

Seth

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-702 Make it possible to wear partial outfits

[Nyx Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/14/#review59
---


I have no technical objections to the code provided.
And in fact, the code provided *should* change the functionality back to what 
the users are reporting is their expectation of what the behavior should be.

The part that makes me nervous is that this enables an outfit operation for a 
class of folders that we have not allowed with the new outfit system 
previously. Based on other pieces on the code that would get called by this 
operation, I believe that the result will be that of the resident request to 
"revert" behavior (namely remove all clothing, remove body parts that are 
replaced by the new folder, leave old body parts that are necessary to display 
the avatar). 

That being said, we need a more comprehensive review of the role of incomplete 
outfits and how it fits with our technical architecture we've built up in our 
current outfits system. The code here should implement the correct behavior and 
I have no technical issues with it. But I want to make sure that we are aware 
of the risk of edge cases as we have not considered possibly popping up as a 
result of this patch.

- Nyx


On 2010-12-13 07:08:28, Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/14/
> ---
> 
> (Updated 2010-12-13 07:08:28)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Enabled the "Replace Current Outfit" option for incomplete outfits (i.e. 
> those that don't contain full set of body parts).
> 
> 
> This addresses bug STORM-702.
> http://jira.secondlife.com/browse/STORM-702
> 
> 
> Diffs
> -
> 
>   indra/newview/llappearancemgr.cpp 3d2e71443c58 
>   indra/newview/llinventoryfunctions.cpp 3d2e71443c58 
> 
> Diff: http://codereview.secondlife.com/r/14/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] LSL function wiki update (was Re: Daily Scrum Summary - Monday, December 20)

[Yoz Grahame]

> *FUTURE*
>
>- [long range]
>
> Update lsl wiki - Change Unsupported icon next to llTextBox to New Feature.
> As this is a locked page a Linden will have to do this.
>

Done - sorry about the delay here.

-- Yoz
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] grid-wide banners

[Glen Canaday]

zFire Xue's device has now identified linden build 2.4.0 (216989) for Linux as 
a copybot client. I know this is not the correct forum, but I need a hotline 
to get rid of this guy and this product. It has seriously messed with my 
enjoyment of SL by banning me from EVERY one of his customer's sims. ALL of 
them. That includes normally quiet public places, such as the Shelman Sandbox. 
Now I have no idea where I can go and cannot go - and my partner is now 
similarly affected.

I simply want rid of this guy and his "product." Does anyone know the proper 
forum for this? Does anyone know if an AR will ever cut it in this situation?

--GC
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] LSL function wiki update (was Re: Daily Scrum Summary - Monday, December 20)

[Strife Onizuka]

The contents of those lists can be found on
https://wiki.secondlife.com/wiki/Template:LSL_All_Functions/Name and
https://wiki.secondlife.com/wiki/Template:LSL_All_Functions/Number.  To aid
in keeping them up to date, there is the template
https://wiki.secondlife.com/wiki/Template:LSL_All_Functions/Generate which
produces the code for both templates. The two templates exist to simplify
localization, they contain nothing really language specific (except for the
"New") and the hovertext can be customized. It means all localizations of
the Portal are synced in this regard and provides a list of articles in need
of translation.

On Mon, Dec 20, 2010 at 7:04 PM, Yoz Grahame  wrote:

>
> *FUTURE*
>>
>>- [long range]
>>
>> Update lsl wiki - Change Unsupported icon next to llTextBox to New
>> Feature. As this is a locked page a Linden will have to do this.
>>
>
> Done - sorry about the delay here.
>
> -- Yoz
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Upgrade libcurl to 7.21.1

[Merov Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/52/
---

Review request for Viewer.


Summary
---

- Points the install.xml viewer to new libcurl binaries (7.21.1)
- Fixes cmake files so that it builds on all platforms


This addresses bug STORM-453.
http://jira.secondlife.com/browse/STORM-453


Diffs
-

  indra/cmake/CURL.cmake 0d2b3d8256a9 
  indra/mac_updater/CMakeLists.txt 0d2b3d8256a9 
  install.xml 0d2b3d8256a9 

Diff: http://codereview.secondlife.com/r/52/diff


Testing
---


Thanks,

Merov

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges