Re: [opensource-dev] Review Request: VWR-20962 CTRL-\ Last chatter

2010-12-14 Thread Vadim ProductEngine

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/16/#review23
---

Ship it!


Looks plausible and works for me.

- Vadim


On 2010-12-13 10:05:35, Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/16/
> ---
> 
> (Updated 2010-12-13 10:05:35)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> You have to push CTRL-\(there is a menu item for this too) twice to get the 
> last chatter function to work.  My fix unlocks the camera before moving it.
> 
> 
> Diffs
> -
> 
>   indra/newview/llagentcamera.cpp 3d2e71443c58 
> 
> Diff: http://codereview.secondlife.com/r/16/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-20962 CTRL-\ Last chatter

2010-12-14 Thread Oz Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/16/
---

(Updated 2010-12-14 07:03:25.753345)


Review request for Viewer.


Changes
---

added jira link


Summary
---

You have to push CTRL-\(there is a menu item for this too) twice to get the 
last chatter function to work.  My fix unlocks the camera before moving it.


This addresses bug vwr-20962.
http://jira.secondlife.com/browse/vwr-20962


Diffs
-

  indra/newview/llagentcamera.cpp 3d2e71443c58 

Diff: http://codereview.secondlife.com/r/16/diff


Testing
---


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Settings.xml: redundant entries and unnecessary tag

2010-12-14 Thread Jonathan Yap

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/18/
---

Review request for Viewer.


Summary
---

I wrote two programs that use settings.xml to produce this massive table:
http://wiki.secondlife.com/wiki/Debug_Settings

While doing this I found 4 places with duplicate entries and 1 entry that is 
repeated 4 times.  There is also a pair of unnecessary tags.

Having these cleaned out would make running my program, and thus updating the 
wiki table, easier.

I've erased all but the last entry for these redundant debug settings.


This addresses bug vwr-24100.
http://jira.secondlife.com/browse/vwr-24100


Diffs
-

  indra/newview/app_settings/settings.xml 46a990f8296f 

Diff: http://codereview.secondlife.com/r/18/diff


Testing
---


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Can anyone tell me how to get rid of these lol...

2010-12-14 Thread Malachi Prophit
i get hundreds of these stupid errors. And i have since i compiled the  
first client back on 1.18. They are harmless but very annoying.

they always look like this.
Warning 3   warning LNK4099: PDB 'apr-1_ib_1.pdb' was not found with  
'..\..\..\..\libraries\i686-win32\lib\release\apr-1.lib' or at  
'C:\Documents and  
Settings\Owner\Desktop\linden\indra\build-VC90\media_plugins\quicktime\Release\apr-1_ib_1.pdb';
  
linking object as if no debug info  apr-1.lib

I have no clue what they are or where to start ... thanks in advance.


-- 
Using Opera's revolutionary email client: http://www.opera.com/mail/
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] Can anyone tell me how to get rid of these lol...

2010-12-14 Thread WolfPup Lowenhar
Actualy in an open source environment you cannot get rid of those link
warnings they are the linker complaining about the fact that the debug
information for those files is missing and you will see those messages for
any lib files you get from LL when running in non-standalone build mode

 

From: opensource-dev-boun...@lists.secondlife.com
[mailto:opensource-dev-boun...@lists.secondlife.com] On Behalf Of Malachi
Prophit
Sent: Tuesday, December 14, 2010 10:23 PM
To: opensource-dev@lists.secondlife.com
Subject: [opensource-dev] Can anyone tell me how to get rid of these lol...

 

i get hundreds of these stupid errors. And i have since i compiled the 
first client back on 1.18. They are harmless but very annoying.

they always look like this.
Warning 3   warning LNK4099: PDB 'apr-1_ib_1.pdb' was not found with 
'..\..\..\..\libraries\i686-win32\lib\release\apr-1.lib' or at 
'C:\Documents and 
Settings\Owner\Desktop\linden\indra\build-VC90\media_plugins\quicktime\Relea
se\apr-1_ib_1.pdb'; 
linking object as if no debug info  apr-1.lib

I have no clue what they are or where to start ... thanks in advance.


--
Using Opera's revolutionary email client: http://www.opera.com/mail/
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting
privileges 

  _  

No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1170 / Virus Database: 426/3316 - Release Date: 12/14/10

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges