Re: [jfx17u] RFR: 8345870: Failed to compile test/javafx/scene/web/CSSRoundingTest.java after 8336798
On Tue, 10 Dec 2024 09:29:51 GMT, Sergey Chernyshev wrote: > Hi, > > this PR fixes the build failure after backporting JDK-8336798 [1]. > The test CSSRoundingTest.java uses multiline string literals, that are not > supported with -source 11. > > > [1] https://bugs.openjdk.org/browse/JDK-8336798 @johanvos Could you please take a look? - PR Comment: https://git.openjdk.org/jfx17u/pull/221#issuecomment-2561709586
Re: [jfx17u] RFR: 8345870: Failed to compile test/javafx/scene/web/CSSRoundingTest.java after 8336798
On Wed, 25 Dec 2024 08:19:31 GMT, Sergey Chernyshev wrote: >> Hi, >> >> this PR fixes the build failure after backporting JDK-8336798 [1]. >> The test CSSRoundingTest.java uses multiline string literals, that are not >> supported with -source 11. >> >> >> [1] https://bugs.openjdk.org/browse/JDK-8336798 > > @johanvos Could you please take a look? @sercher Thanks for spotting this -- makes sense indeed. I'll do a deeper review + tests later this week. - PR Comment: https://git.openjdk.org/jfx17u/pull/221#issuecomment-2561847990
