[Okular-devel] [okular] [Bug 341318] Save for every document whether it is viewed in continuous mode or not

2015-04-14 Thread felix_mauch
https://bugs.kde.org/show_bug.cgi?id=341318

felix_ma...@web.de changed:

   What|Removed |Added

 CC||felix_ma...@web.de

--- Comment #3 from felix_ma...@web.de ---
I totally agree, that this would be a cool features, as I think others might
think, as well. There exist numerous bugreports regarding this particular
feature or another view feature (such as 2page-facing):

https://bugs.kde.org/show_bug.cgi?id=295506
https://bugs.kde.org/show_bug.cgi?id=309808
https://bugs.kde.org/show_bug.cgi?id=200183

@t0mplar: Did you make any progress on this?

Cheers Felix

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 341318] Save for every document whether it is viewed in continuous mode or not

2015-04-14 Thread felix_mauch
https://bugs.kde.org/show_bug.cgi?id=341318

--- Comment #4 from felix_ma...@web.de ---
After some code browsing, I guess the following solution should work:

DocumentPrivate::loadViewsInfo seems to be a good starting point as it's the
xml parser. Following the function calls you end up in PageView::setCapability
where you could implement another switch case and then add another function to
pageview analog to the PageView::updateZoom function that handles other view
features.
Of course DocumentPrivate::saveViewsInfo needs to be adjusted, too. I didn't
look at the process pipeline there, but that should be rather simple, I guess,
since that's only grabbing available data and sending it to the XML-writer.

Basically, I think it's not too much work, so the main question is: Is there a
chance that this gets merged? Albert wasn't so clear about that ;)

@t0mplar: Would you like to implement this? Otherwise tell me then I'll try to
find some time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 341318] Save for every document whether it is viewed in continuous mode or not

2015-04-17 Thread felix_mauch
https://bugs.kde.org/show_bug.cgi?id=341318

--- Comment #6 from felix_ma...@web.de ---
Created attachment 92103
  --> https://bugs.kde.org/attachment.cgi?id=92103&action=edit
patch to solve the issue

I've made a first solution. Some things might be a bit hacky such as changing
the UI manually and calling the slots manually. Is there a better way to do
this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 341318] Save for every document whether it is viewed in continuous mode or not

2015-05-12 Thread felix_mauch
https://bugs.kde.org/show_bug.cgi?id=341318

--- Comment #8 from felix_ma...@web.de ---
I've created a review request (#123427 ) about two weeks ago, however there was
no reaction to it. Should I provide anything else?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel