[okular] [Bug 445842] Okular cannot open the same file twice in different tabs

2021-11-21 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=445842

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |NOT A BUG
 CC||aa...@kde.org
 Status|REPORTED|RESOLVED

--- Comment #1 from Albert Astals Cid  ---
You can change that behaviour in the settings dialog if you don't like it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 444990] Shortcut conflicts when filename contains number

2021-11-21 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=444990

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/kwidgetsaddons/commi
   ||t/294fe8ddc2f10d0a783bf9b80
   ||769c31ecc5922b1
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Albert Astals Cid  ---
Git commit 294fe8ddc2f10d0a783bf9b80769c31ecc5922b1 by Albert Astals Cid.
Committed on 21/11/2021 at 12:27.
Pushed by aacid into branch 'master'.

KAcceleratorManager: Take into account actions with Alt+X shortcuts

We need to mark those X labels as used, otherwise the accelerator
manager may decide to use X for an accelerator and when pressing Alt+X
we will have a conflict

M  +21   -0autotests/kacceleratormanagertest.cpp
M  +23   -7src/kacceleratormanager.cpp
M  +2-2src/kacceleratormanager_p.h

https://invent.kde.org/frameworks/kwidgetsaddons/commit/294fe8ddc2f10d0a783bf9b80769c31ecc5922b1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 445864] New: GUI Option to allow "login-only" (non graphical) signature

2021-11-21 Thread danitxu
https://bugs.kde.org/show_bug.cgi?id=445864

Bug ID: 445864
   Summary: GUI Option to allow "login-only" (non graphical)
signature
   Product: okular
   Version: 21.11.80
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: jdani...@gmail.com
  Target Milestone: ---

Sometimes it's not desired to have a graphical signature, e.g. when there is
not free space in the page to contain the rectangle for the graphical
signature, even small. Indeed [I think] in PDF "official" standard the
graphical signature is NOT a must.

One solution is to double click on a any point inside page, but maybe it's not
intuitive for general users. Another better option would be to include an
option (in Preferences > Configure Okular) with a check to enable or disable.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 407133] Copy text from rotated pdf gives rubbish

2021-11-21 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=407133

David Hurka  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=445851

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 445851] Don't copy newlines within paragraph

2021-11-21 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=445851

David Hurka  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=407133

--- Comment #1 from David Hurka  ---
> Newlines used to break the content are preserved:

This is not exactly what happens. The Okular user interface does not know about
newlines or paragraphs, it only knows about the positions of individual
letters. If a letter is below the previous one, it inserts a newline to the
selection.

Besides that, I think this should not be different, at least not for PDF. If
newlines are not copied, the selection will still contain hyphens. Like this:
Because every-thing is on one line, it will be diffi-cult to remove the hyphens
manual-ly afterwards.

;)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 445842] Okular cannot open the same file twice in different tabs

2021-11-21 Thread David
https://bugs.kde.org/show_bug.cgi?id=445842

--- Comment #2 from David  ---
(In reply to Albert Astals Cid from comment #1)
> You can change that behaviour in the settings dialog if you don't like it.

Got it, but why would you make that option the default? It's very common if you
are reading something like a scientific article to be constantly looking at
different sections of the document simultaneously (for example to see the
references and figures), and for me at least the only reason why I enable tabs
in okular is to have the same document openened many times.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 445868] New: Okular fills "number only" PDF forms fields with the wrong thousands separator.

2021-11-21 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=445868

Bug ID: 445868
   Summary: Okular fills "number only" PDF forms fields with the
wrong thousands separator.
   Product: okular
   Version: 21.08.3
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: tnem...@free.fr
  Target Milestone: ---

SUMMARY
In my locale (FR) the decimal separator is the comma and the thousands
separator is either none or space. In the US, the thousands separator is the
comma... When filling my tax information forms, when I want to put 1000, it
displays "1,000" which really means "1" locally.


STEPS TO REPRODUCE
1. Have a PDF with numbers only form fields and a locale that doesn't have ","
as thousands separator
2. Fill the form field with a big enough number
3. Close the form fields and look at the results.

OBSERVED RESULT
A field with the value "1000" inside displays "1,000".

EXPECTED RESULT
It should display "1 000".

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.23.3
KDE Frameworks Version:  5.86.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 445842] Okular cannot open the same file twice in different tabs

2021-11-21 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=445842

--- Comment #3 from Albert Astals Cid  ---
https://invent.kde.org/graphics/okular/-/merge_requests/370

> It's very common if you are reading something like a scientific article

Reading scientific articles is probably not the most common use case for Okular

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 445868] Okular fills "number only" PDF forms fields with the wrong thousands separator.

2021-11-21 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=445868

Albert Astals Cid  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||aa...@kde.org

--- Comment #1 from Albert Astals Cid  ---
Please attach such a PDF

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 445883] New: Okular crashes when trying to save a documents on a CIFS-backed mount

2021-11-21 Thread Lars Veldscholte
https://bugs.kde.org/show_bug.cgi?id=445883

Bug ID: 445883
   Summary: Okular crashes when trying to save a documents on a
CIFS-backed mount
   Product: okular
   Version: 21.11.80
  Platform: Archlinux Packages
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: l...@tuxplace.nl
  Target Milestone: ---

SUMMARY
When I edit and try to save a document on a SMB share mounted locally in /mnt/
using the CIFS driver, Okular crashes.

The document does end up being saved, but with `.part` added to its filename.
The document appears intact when removing the `.part` suffix from its filename
and opening it again.

STEPS TO REPRODUCE
1. Open a document from a CIFS-backed mount.
2. Edit it.
3. Try to save it.

OBSERVED RESULT
Okular crashes and the file is saved with `.part` appended to its filename.

EXPECTED RESULT
The file is saved as normal.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.2
Kernel Version: 5.15.2-zen1-1-zen (64-bit)
Graphics Platform: Wayland
Processors: 12 × AMD Ryzen 5 5600X 6-Core Processor
Memory: 15,5 GiB of RAM
Graphics Processor: AMD Radeon RX 480 Graphics

ADDITIONAL INFORMATION
Backtrace:

#0  0x7f20c5497d22 in raise () from /usr/lib/libc.so.6
#1  0x7f20c70563e0 in KCrash::defaultCrashHandler(int) () from
/usr/lib/libKF5Crash.so.5
#2  
#3  0x7f208cda5a7a in FormWidgetText::getContent() const () from
/usr/lib/libpoppler.so.115
#4  0x7f20bc17cb65 in Poppler::FormFieldText::text() const () from
/usr/lib/libpoppler-qt5.so.1
#5  0x7f20bd940603 in ?? () from
/usr/lib/qt/plugins/okular/generators/okularGenerator_poppler.so
#6  0x7f20be4b7322 in ?? () from /usr/lib/qt/plugins/okularpart.so
#7  0x7f20c5b2d7ab in ?? () from /usr/lib/libQt5Core.so.5
#8  0x7f20c5b2d7e0 in ?? () from /usr/lib/libQt5Core.so.5
#9  0x7f20c686481b in QWidgetTextControl::qt_metacall(QMetaObject::Call,
int, void**) () from /usr/lib/libQt5Widgets.so.5
#10 0x7f20c5b2d4f7 in ?? () from /usr/lib/libQt5Core.so.5
#11 0x7f20c6094c9e in QTextDocumentPrivate::finishEdit() () from
/usr/lib/libQt5Gui.so.5
#12 0x7f20c6861d06 in ?? () from /usr/lib/libQt5Widgets.so.5
#13 0x7f20c6857d1c in QWidgetTextControl::processEvent(QEvent*, QPointF
const&, QWidget*) () from /usr/lib/libQt5Widgets.so.5
#14 0x7f20c683718d in QTextEdit::inputMethodEvent(QInputMethodEvent*) ()
from /usr/lib/libQt5Widgets.so.5
#15 0x7f20c66a00be in QWidget::event(QEvent*) () from
/usr/lib/libQt5Widgets.so.5
#16 0x7f20c674f94f in QFrame::event(QEvent*) () from
/usr/lib/libQt5Widgets.so.5
#17 0x7f20c665cd62 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/libQt5Widgets.so.5
#18 0x7f20c5af63fa in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() from /usr/lib/libQt5Core.so.5
#19 0x7f20c3947f34 in ?? () from /usr/lib/libQt5WaylandClient.so.5
#20 0x7f20c66bcf8f in ?? () from /usr/lib/libQt5Widgets.so.5
#21 0x7f20c665cd62 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/libQt5Widgets.so.5
#22 0x7f20c5af63fa in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() from /usr/lib/libQt5Core.so.5
#23 0x7f20c5f5c4fe in
QGuiApplicationPrivate::processActivatedEvent(QWindowSystemInterfacePrivate::ActivatedWindowEvent*)
() from /usr/lib/libQt5Gui.so.5
#24 0x7f20c5f357d5 in
QWindowSystemInterface::sendWindowSystemEvents(QFlags)
() from /usr/lib/libQt5Gui.so.5
#25 0x7f20c39691e1 in ?? () from /usr/lib/libQt5WaylandClient.so.5
#26 0x7f20c40734dc in g_main_context_dispatch () from
/usr/lib/libglib-2.0.so.0
#27 0x7f20c40c7799 in ?? () from /usr/lib/libglib-2.0.so.0
#28 0x7f20c4070bc1 in g_main_context_iteration () from
/usr/lib/libglib-2.0.so.0
#29 0x7f20c5b4f026 in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib/libQt5Core.so.5
#30 0x7f20c5af4d6c in
QEventLoop::exec(QFlags) () from
/usr/lib/libQt5Core.so.5
#31 0x7f20c68713de in QDialog::exec() () from /usr/lib/libQt5Widgets.so.5
#32 0x7f20c6dbb040 in KMessageBox::createKMessageBox(QDialog*,
QDialogButtonBox*, QIcon const&, QString const&, QStringList const&, QString
const&, bool*, QFlags, QString const&, QMessageBox::Icon)
() from /usr/lib/libKF5WidgetsAddons.so.5
#33 0x7f20c6dbb631 in KMessageBox::createKMessageBox(QDialog*,
QDialogButtonBox*, QMessageBox::Icon, QString const&, QStringList const&,
QString const&, bool*, QFlags, QString const&) () from
/usr/lib/libKF5WidgetsAddons.so.5
#34 0x7f20c6dbf8c8 in ?? () from /usr/lib/libKF5WidgetsAddons.so.5
#35 0x7f20c6dc0050 in KMessageBox::error(QWidget*, QString const&, QString
const&, QFlags) () from /usr/lib/libKF5WidgetsAddons.so.5
#36 0x7f20be469613 in Okular::Part::openUrl(QUrl const&, bool) 

[okular] [Bug 445897] New: You can't highlight across pages

2021-11-21 Thread strangequark
https://bugs.kde.org/show_bug.cgi?id=445897

Bug ID: 445897
   Summary: You can't highlight across pages
   Product: okular
   Version: 21.08.3
  Platform: Neon Packages
OS: Linux
Status: REPORTED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: random1123581...@protonmail.com
  Target Milestone: ---

SUMMARY
There is currently no way to highlight across pages.

STEPS TO REPRODUCE
1. Try to highlight a paragraph that is located at the end of one page and
continues into the beginning of the next page 

OBSERVED RESULT
The highlight will not move on to the next page

EXPECTED RESULT
The highlight should be able to move on to the next page

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.23
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.3
Graphics Platform: X11

ADDITIONAL INFORMATION
none

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 445900] New: The icons for the annotation tools look off when compared to the general look of Okular icons

2021-11-21 Thread strangequark
https://bugs.kde.org/show_bug.cgi?id=445900

Bug ID: 445900
   Summary: The icons for the annotation tools look off when
compared to the general look of Okular icons
   Product: okular
   Version: 21.08.3
  Platform: Neon Packages
OS: Linux
Status: REPORTED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: random1123581...@protonmail.com
  Target Milestone: ---

SUMMARY
The icons for the annotation tools (Freehand Line, Highlighter, etc) look
ancient and out of place when compared to the icons for everything else
(Browse, Text selection, etc). Most other icons in the UI are monochromatic,
but the icons for these functions (in the main toolbar. In the annotation
toolbar they look fine) are very different and don't look good on low-res
displays either.
Moreover, when the Annotation Toolbar is shown (Menubar > Settings > Toolbars
Shown > Annotation Toolbar), the icons there are actually nice and monochrome
like the rest of the icons everywhere. This creates another visual discrepancy,
because now the icons *for the same function* are different in different
toolbars.
I guess my request is that colored icons are fine when an annotation tool
that's coloured is shown, but the paper at the back and the scribble line on
the icon look out of place.

OBSERVED RESULT
The icon looks off because of the paper at the back and the scribbling, while
the icon in the Annotation Toolbar looks fine.

EXPECTED RESULT
An icon more like the icons in the Annotation Toolbar, and maybe the icon can
be filled with color to show the color of the selected tool. But the paper at
the back looks bad.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.23
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.3

ADDITIONAL INFORMATION
none

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 445868] Okular fills "number only" PDF forms fields with the wrong thousands separator.

2021-11-21 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=445868

--- Comment #2 from tnem...@free.fr ---
Created attachment 143825
  --> https://bugs.kde.org/attachment.cgi?id=143825&action=edit
PDF with numbers only form fields

Numbers only form fields are, for example, in cases B1-6 and B1-8.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 445902] New: when the line breaks in the middle of the page, the line cannot be highlighted anymore from anywhere, you have to move to the place where the line broke to get it to recogni

2021-11-21 Thread strangequark
https://bugs.kde.org/show_bug.cgi?id=445902

Bug ID: 445902
   Summary: when the line breaks in the middle of the page, the
line cannot be highlighted anymore from anywhere, you
have to move to the place where the line broke to get
it to recognize the line as a part of the highlight
(sometimes works)
   Product: okular
   Version: 21.08.3
  Platform: Neon Packages
OS: Linux
Status: REPORTED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: random1123581...@protonmail.com
  Target Milestone: ---

SUMMARY
Pretty much the summary above


STEPS TO REPRODUCE
1. Try to highlight the ending of a paragraph where the text ends somewhere
near the middle of the line. Start the highlight from a couple lines above the
end of the paragraph.

OBSERVED RESULT
When the highlighter *is* over the end line, but it's at the right - beyond the
end of the text - it doesn't highlight that last line

EXPECTED RESULT
It should be able to highlight the text no matter where over the line it is.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.23
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.3

ADDITIONAL INFORMATION
This sometimes work, but it also sometimes doesn't, depending on the document

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 445903] New: Having a text selection and then switching to a highlight tool no longer allows you to deselect the text selection, not even Escape works.

2021-11-21 Thread strangequark
https://bugs.kde.org/show_bug.cgi?id=445903

Bug ID: 445903
   Summary: Having a text selection and then switching to a
highlight tool no longer allows you to deselect the
text selection, not even Escape works.
   Product: okular
   Version: 21.08.3
  Platform: Neon Packages
OS: Linux
Status: REPORTED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: random1123581...@protonmail.com
  Target Milestone: ---

SUMMARY
The summary above.

STEPS TO REPRODUCE
1. Select the 'Text selection' tool, and then select some lines in the
document.
2. Now, without deselecting your previous selection, go to the highlight tool
(has not been tested by me with other tools)
3. press Escape, or click elsewhere in the document to try and deselect the
selected text.

OBSERVED RESULT
You can't deselect the text in any way when the highlighter tool is enabled,
not even the keyboard shortcut for deselect works.

EXPECTED RESULT
You should be able to deselect by clicking Escape or by clicking on a part of
the document that's away from the selection.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.23
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.3
Graphics Platform: X11

ADDITIONAL INFORMATION
none

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 445904] New: Hitting escape when a text selection has been done does not deselect the text

2021-11-21 Thread strangequark
https://bugs.kde.org/show_bug.cgi?id=445904

Bug ID: 445904
   Summary: Hitting escape when a text selection has been done
does not deselect the text
   Product: okular
   Version: 21.08.3
  Platform: Neon Packages
OS: Linux
Status: REPORTED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: random1123581...@protonmail.com
  Target Milestone: ---

SUMMARY
Please make the Esc key deselect the text when text is selected. This is
probably expected by the user, since the Esc key mostly does this everywhere
else (eg. Kate)

STEPS TO REPRODUCE
1. Select some text using the Text Selection tool
2. Try to deselect it by pressing the Escape key 

OBSERVED RESULT
Nothing happens, the text remains selected

EXPECTED RESULT
The text should deselect

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.23
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.3
Graphics Platform: X11

ADDITIONAL INFORMATION
none

-- 
You are receiving this mail because:
You are the assignee for the bug.