[okular] [Bug 438882] Quick annotations toolbar button does nothing

2021-06-19 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=438882

--- Comment #2 from David Hurka  ---
Do you have “Quick annotation” tools defined? Check it in Settings -> Configure
Okular... -> Annotations. Because I don’t know right now which set of tools is
accessible from the button in the current version.

AFAIK the intention is to show the last used tool, or the first tool.

At least one distribution decided to delete the relevant configuration file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 438882] Quick annotations toolbar button does nothing

2021-06-19 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=438882

--- Comment #3 from Kai Uwe Broulik  ---
> If you open the dropdown and click on a tool, does the main button change to 
> show that tool?

There's just "show more annotation tools" and "configure annotations". When I
select a tool from the annotation toolbar, nothing changes, the "quick
annotations" button never changes and never does anything when clicked.

> Do you have “Quick annotation” tools defined?

Looks like I do not. At least in "configure annotations" the list is empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 398108] Annotation toolbar works only in Browse mode, not in e. g. Text Selection mode.

2021-06-19 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=398108

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/commit/230a68d5
   ||37a2f958f72dce162221555ef28
   ||5896f
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||21.08

--- Comment #6 from Albert Astals Cid  ---
Git commit 230a68d537a2f958f72dce162221555ef285896f by Albert Astals Cid, on
behalf of Simone Gaiarin.
Committed on 19/06/2021 at 14:12.
Pushed by aacid into branch 'master'.

Uncheck mouse mode action when annotation tool selected

When the annotation is unchecked the previous mouse mode is restored.

The slot slotMouseNormalToggled is changed back to its original version
of slotSetMouseNormal given that we needed to pass the checked state
only to detach the annotations, and we do it in the lambda now.
Related: bug 437377

FIXED-IN: 21.08

M  +11   -5autotests/annotationtoolbartest.cpp
M  +45   -15   part/pageview.cpp
M  +1-1part/pageview.h
M  +2-2part/pageviewannotator.cpp
M  +4-1part/pageviewannotator.h

https://invent.kde.org/graphics/okular/commit/230a68d537a2f958f72dce162221555ef285896f

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 437377] Leaving annotation mode with mouse is complicated

2021-06-19 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=437377

Albert Astals Cid  changed:

   What|Removed |Added

   Version Fixed In||21.08
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/commit/230a68d5
   ||37a2f958f72dce162221555ef28
   ||5896f
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Albert Astals Cid  ---
Git commit 230a68d537a2f958f72dce162221555ef285896f by Albert Astals Cid, on
behalf of Simone Gaiarin.
Committed on 19/06/2021 at 14:12.
Pushed by aacid into branch 'master'.

Uncheck mouse mode action when annotation tool selected

When the annotation is unchecked the previous mouse mode is restored.

The slot slotMouseNormalToggled is changed back to its original version
of slotSetMouseNormal given that we needed to pass the checked state
only to detach the annotations, and we do it in the lambda now.
Related: bug 398108

FIXED-IN: 21.08

M  +11   -5autotests/annotationtoolbartest.cpp
M  +45   -15   part/pageview.cpp
M  +1-1part/pageview.h
M  +2-2part/pageviewannotator.cpp
M  +4-1part/pageviewannotator.h

https://invent.kde.org/graphics/okular/commit/230a68d537a2f958f72dce162221555ef285896f

-- 
You are receiving this mail because:
You are the assignee for the bug.

KDE CI: Applications » okular » kf5-qt5 FreeBSDQt5.15 - Build # 297 - Still Unstable!

2021-06-19 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications/job/okular/job/kf5-qt5%20FreeBSDQt5.15/297/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Sat, 19 Jun 2021 15:59:39 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 21 test(s)Failed: projectroot.autotests.annotationtoolbartestName: projectroot.generators Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

Re: Mutlti-color highlighting

2021-06-19 Thread Simone Gaiarin
Hi Julius,
you can find 'highlighter' under 'text markup'. You can create multiple
highlighter quick annotation tools for different colors and access them
from the quick annotation drop down menu action in the main toolbar.

Bye



On Sat, Jun 19, 2021 at 1:16 PM Julius Hamilton  wrote:

> Hey everyone,
>
> How can I create keyboard shortcuts or options in a right-click drop down
> menu for multi-color highlighting, in Okular?
>
> I opened the "Configure annotations" menu and pressed "Add". It gives me
> different annotation tools I could add but for some reason, all of them
> except highlight.
>
> How could I enable multi-color highlighting in a convenient manner?
>
> Also, is there a keyboard shortcut with which I can jump down a half or
> quarter page, rather than a full page?
>
> Thanks very much,
> Julius Hamilton
>
>
>


[okular] [Bug 438923] New: PDF contents tab doesn't respect empty page label number style

2021-06-19 Thread Dani Pozo
https://bugs.kde.org/show_bug.cgi?id=438923

Bug ID: 438923
   Summary: PDF contents tab doesn't respect empty page label
number style
   Product: okular
   Version: 21.04.1
  Platform: Archlinux Packages
OS: Linux
Status: REPORTED
  Severity: minor
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: danip...@autistici.org
  Target Milestone: ---

SUMMARY
PDF contents tab doesn't respect empty page label number style

STEPS TO REPRODUCE
1. Take a PDF with empty page label number style,
which is common for the cover.
2. Open Okular, press F7 and open the Contents tab.

OBSERVED RESULT

The cover page number is displayed as 1.

EXPECTED RESULT

The cover page number is displayed as empty.


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 5.82.0-1
(available in About System)
KDE Plasma Version: 5.82.0-1
KDE Frameworks Version: 5.82.0-1
Qt Version: 5.15

ADDITIONAL INFORMATION

None

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-06-19 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=438923

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Albert Astals Cid  ---
Can you attach a PDF file in which you expect this to happen?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Mutlti-color highlighting

2021-06-19 Thread Julius Hamilton
Thanks very much.

I don't see a main toolbar in my Okular (attached photo), how could I
display it?

Is there any way to get the highlight options from a right click drop down
menu?

Is it possible to make a keyboard shortcut to delete whatever highlighted
region I then press? For example, I press "d", then click on one of my
highlights, and it's deleted.

Thanks very much,
Julius



On Sat, Jun 19, 2021, 18:45 Simone Gaiarin  wrote:

> Hi Julius,
> you can find 'highlighter' under 'text markup'. You can create multiple
> highlighter quick annotation tools for different colors and access them
> from the quick annotation drop down menu action in the main toolbar.
>
> Bye
>
>
>
> On Sat, Jun 19, 2021 at 1:16 PM Julius Hamilton 
> wrote:
>
>> Hey everyone,
>>
>> How can I create keyboard shortcuts or options in a right-click drop down
>> menu for multi-color highlighting, in Okular?
>>
>> I opened the "Configure annotations" menu and pressed "Add". It gives me
>> different annotation tools I could add but for some reason, all of them
>> except highlight.
>>
>> How could I enable multi-color highlighting in a convenient manner?
>>
>> Also, is there a keyboard shortcut with which I can jump down a half or
>> quarter page, rather than a full page?
>>
>> Thanks very much,
>> Julius Hamilton
>>
>>
>>


[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-06-19 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=438923

--- Comment #2 from David Hurka  ---
The Contents view needs to show something as page number. I guess, since the
PDF does not provide a page label, it shows the number of the page.

Should we somehow deemphasize the number, to avoid confusion? If the PDF
provides page labels for not all pages. The number could then be in brackets:
(1) or in a desaturated font?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-06-19 Thread Dani Pozo
https://bugs.kde.org/show_bug.cgi?id=438923

--- Comment #3 from Dani Pozo  ---
Created attachment 139526
  --> https://bugs.kde.org/attachment.cgi?id=139526&action=edit
Example PDF

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-06-19 Thread Dani Pozo
https://bugs.kde.org/show_bug.cgi?id=438923

--- Comment #4 from Dani Pozo  ---
(In reply to David Hurka from comment #2)
> The Contents view needs to show something as page number. I guess, since the
> PDF does not provide a page label, it shows the number of the page.

Does it need to show something always? As far as I can understand, for the case
in which the book page doesn't have a number, but it has a bookmark entry,
you can leave the page label style empty. Evince, for instance, shows no number
or letter in the tab analogous to the Contents tab.

> Should we somehow deemphasize the number, to avoid confusion? If the PDF
> provides page labels for not all pages. The number could then be in
> brackets: (1) or in a desaturated font?

As I'm not sure whether this Evince behaviour would break some other PDFs,
this could be an option too. I have been reading a bit on the PDF standard
(http://www.adobe.com/content/dam/Adobe/en/devnet/pdf/pdfs/PDF32000_2008.pdf),
and from Table 159 (page 375) I understand that the labels should be empty in
this case. This is an opinion supported only from looking briefly at the
standard, may easily be wrong.

(In reply to Albert Astals Cid from comment #1)
> Can you attach a PDF file in which you expect this to happen?

Sure, please see the attached PDF. The first two pages have no page label
style.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-06-19 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=438923

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.