[okular] [Bug 367940] docdata become 0 byte after laptop runs out of battery

2021-05-13 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=367940

--- Comment #1 from David Hurka  ---
Okular does not use docdata for annotations anymore, so this part of the issue
is fixed.

The remaining data in the docdata files are just the viewport, so if the
docdata is broken you only need to scroll back to your current page.

If I kill Okular with Ctrl+Alt+Esc, that doesn’t break the docdata file of the
open document.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 317856] [okular] saves opened file metadata in ~/.kde/share/apps/okular/docdata/ which can leak info, use hash instead

2021-05-13 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=317856

David Hurka  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=436738

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 436738] docdata duplicated each time pdf is edited

2021-05-13 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=436738

David Hurka  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=317856

--- Comment #10 from David Hurka  ---
In Bug 317856, it was requested to store the file name only as a hash.

Related, in the merge request
https://invent.kde.org/graphics/okular/-/merge_requests/422#note_238154 (Create
“Welcome screen” that replaces window where nearly all widgets are in disabled
state) Jiří Wolker writes:

> And there is also privacy risk – users sometimes do not want to store
> thumbnails of their documents. (Example: Home directory incl. config
> files is not encrypted, Documents is. When user opens file from Documents,
> the thumbnail gets stored in the home directory. This makes unencrypted
> image of part of the file.)

My idea would be to store docdata (maybe including thumbnails) hashed by the
file name/path/content, and encrypted with a hash of the file content, so they
can only be read with read access to the document file (or a copy of it).

To delete old docdata files, there could be a list of the last 5000 used
docdata files. This list is updated every time a file is opened/closed, and
those docdata not anymore in the list are deleted. Those docdata which are so
old that they leave the “Open Recent” list, are stripped from their thumbnail.

But this way, there wouldn’t be a reliable way to detect duplicate docdata
files.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 436086] PNG image in CBZ wrapper does not display correctly (but PNG itself does)

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=436086

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||21.04.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 437010] Windows build doesnt remember window size + location

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=437010

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

--- Comment #1 from Nate Graham  ---
We have this functionality provided by the combination of KXmlgui and KWin on
Linux/BSD with X11. Something about it must not be working on Windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 436086] PNG image in CBZ wrapper does not display correctly (but PNG itself does)

2021-05-13 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=436086

Albert Astals Cid  changed:

   What|Removed |Added

   Version Fixed In|21.04.1 |21.04.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 436990] Interactive PDF Forms with field validation cannot be filled due to repeating error window

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=436990

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 397463] Session management (named sessions, save/load sessions, auto-session-restore, etc) like in Kate

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In|1.9.0   |
  Latest Commit|https://invent.kde.org/kde/ |
   |okular/commit/a5a8d82fb3a25 |
   |670bc241d9b5f3f15e98ec7d475 |
Summary|okular session management   |Session management (named
   ||sessions, save/load
   ||sessions,
   ||auto-session-restore, etc)
   ||like in Kate
 Status|ASSIGNED|CONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 364680] Restore previous open documents

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=364680

Nate Graham  changed:

   What|Removed |Added

 Status|RESOLVED|REPORTED
Summary|feature request: restore|Restore previous open
   |previous session|documents
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 364680] Restore previous open documents

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=364680

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=397463
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 397463] Session management (named sessions, save/load sessions, auto-session-restore, etc) like in Kate

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=364680

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 407548] [Wish] Support save/restore session

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=407548

--- Comment #2 from Nate Graham  ---


*** This bug has been marked as a duplicate of bug 364680 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 364680] Restore previous open documents

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=364680

Nate Graham  changed:

   What|Removed |Added

 CC||ric.richte...@gmail.com

--- Comment #8 from Nate Graham  ---
*** Bug 407548 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408588] previousl opened documents

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408588

--- Comment #2 from Nate Graham  ---


*** This bug has been marked as a duplicate of bug 364680 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 364680] Restore previous open documents

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=364680

Nate Graham  changed:

   What|Removed |Added

 CC||lev...@gmx.net

--- Comment #9 from Nate Graham  ---
*** Bug 408588 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 364680] Restore previous open documents

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=364680

Nate Graham  changed:

   What|Removed |Added

 CC||jtam...@gmail.com

--- Comment #10 from Nate Graham  ---
*** Bug 426380 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 364680] Restore previous open documents

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=364680

Nate Graham  changed:

   What|Removed |Added

 CC||pb...@his.com

--- Comment #11 from Nate Graham  ---
*** Bug 436937 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 426380] Okular forgets the open documents when closed normally and reopened

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=426380

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

--- Comment #3 from Nate Graham  ---


*** This bug has been marked as a duplicate of bug 364680 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 436937] reopen files from previous session

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=436937

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||n...@kde.org
 Status|REPORTED|RESOLVED

--- Comment #1 from Nate Graham  ---


*** This bug has been marked as a duplicate of bug 364680 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 364680] Restore previous open documents

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=364680

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #12 from Nate Graham  ---
I am working on this. See
https://invent.kde.org/graphics/okular/-/merge_requests/247.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 436738] docdata duplicated each time pdf is edited

2021-05-13 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=436738

--- Comment #11 from Albert Astals Cid  ---
I fear that what you're suggesting would create too much I/O. Each time i open
a PDF i have never opened before i would have to read all the filenames in the
docdata folder in case some of them has a matching sha.

Doesn't sound like it would work fine at scale.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 437010] Windows build doesnt remember window size + location

2021-05-13 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=437010

Albert Astals Cid  changed:

   What|Removed |Added

   Platform|Other   |Microsoft Windows
 OS|Other   |Microsoft Windows
 CC||aa...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 436990] Interactive PDF Forms with field validation cannot be filled due to repeating error window

2021-05-13 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=436990

--- Comment #2 from Albert Astals Cid  ---
It's not errors, it's messagebox popped up by the Javascript of the document,
could very well be anything, so no they can't appear anyway else.

I have not checked the code at all, but my guess the problem here is, that the
file does:

 If the field has an won focus -> show messagebox saying what the field
contents has to be

But that makes it lose the focus to the messagebox and win it again, so 

 If the field has an won focus -> show messagebox saying what the field
contents has to be


etc. etc.

Would need time to check that is indeed the problem and make it realize that if
it's winning the focus and had it and was lost because a mesagebox was shown,
there's no need to show the messagebox again.

And also check what Adobe Reader does with the file, because it's super easy to
infinite loop firefox too

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 436710] Playing of Flash-free ("plain") Rich Media annotations

2021-05-13 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=436710

Bug Janitor Service  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #10 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/graphics/okular/-/merge_requests/426

-- 
You are receiving this mail because:
You are the assignee for the bug.