[okular] [Bug 321082] Certain Russian letters in a PDF are not displayed

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=321082

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 334343] when i open a PDF file an i make an annotation with the highlighter, i close the PDF file and i open again the same PDF all the pages are blank

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=334343

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 388615] PDf which does not display correctly

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=388615

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 387466] The option to print multiple pages on one sheet (n-up) is rather hidden

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=387466

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 383915] Okular crashes with a segfault on reload for some synctex files

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=383915

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 351849] Margins often cut when printing

2018-04-05 Thread Germano Massullo
https://bugs.kde.org/show_bug.cgi?id=351849

--- Comment #17 from Germano Massullo  ---
Created attachment 111855
  --> https://bugs.kde.org/attachment.cgi?id=111855&action=edit
d01250-001

Solved with 'PreserveJobFiles Yes' in '/etc/cups/cupsd.conf'

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 351849] Margins often cut when printing

2018-04-05 Thread Germano Massullo
https://bugs.kde.org/show_bug.cgi?id=351849

Germano Massullo  changed:

   What|Removed |Added

 Status|NEEDSINFO   |CONFIRMED
 Ever confirmed|0   |1
 Resolution|WAITINGFORINFO  |---

--- Comment #18 from Germano Massullo  ---
(In reply to Germano Massullo from comment #17)
> Created attachment 111855 [details]
> d01250-001
> 
> Solved with 'PreserveJobFiles Yes' in '/etc/cups/cupsd.conf'

I mean I managed to get the job file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389411] Okular and X unresponsive when resizing Okular's sidebar

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=389411

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 378130] Okular snap package fails to find libKF5Parts.so.5

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=378130

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 353401] Feature requst: "typewriter" annotation tool

2018-04-05 Thread Tobias Deiminger
https://bugs.kde.org/show_bug.cgi?id=353401

--- Comment #27 from Tobias Deiminger  ---
> Seems like an interesting idea to explore, just remember that you're going
> to need more layers of abstraction since okular core doesn't know anything
> about poppler
Yes, and I have to relate myself a bit. As this feature request is candidate
for a GSoC project, it's better to not put too much experimental ideas in here.
Forget about my generator rendered widgets for now. Such exploration still can
be done later, maybe together with bug 358061. Implementing an UI similar to
existing inline notes will be good for a start. There we use
QInputDialog::getMultiLineText for initial input, AnnotWindow for editing, and
let the generator render the annotation along with the page (which avoids
visual inconsistencies too).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 351849] Margins often cut when printing

2018-04-05 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=351849

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|CONFIRMED   |NEEDSINFO

--- Comment #19 from Michael Weghorn  ---
(In reply to Germano Massullo from comment #18)
> (In reply to Germano Massullo from comment #17)
> > Created attachment 111855 [details]
> > d01250-001
> > 
> > Solved with 'PreserveJobFiles Yes' in '/etc/cups/cupsd.conf'
> 
> I mean I managed to get the job file

Thanks for attaching the job file. This is actually the PostScript file that is
generated by Okular and passed to the printing system CUPS.
The file looks totally OK in my eyes; you can open it for viewing in Okular.

In my understanding, this suggests that the problem is only introduced during
the processing inside CUPS (the printing system, e.g. by one of the CUPS
filters or the printer itself). Unless Okular passes any "wrong" options, the
problem probably lies outside of Okular's responsibility.

In order to have a closer look at this, it would be necessary to see which
options are actually passed to CUPS.

Unfortunately those were not shown in the log output of comment 13. Was this
the output of the  command 'sudo journalctl _SYSTEMD_UNIT=cups.service'? If so,
could you please try to change the 'ErrorLog' directive in
'/etc/cups/cups-files.conf' to 'ErrorLog /var/log/cups/error_log', restart cups
('sudo systemctl restart cups.service'), print again and attach the log file
'/var/log/cups/error_log' that should have been created by then. (The mentioned
directive makes the output written to this file instead of syslog/journal, in
case the previous directive was 'ErrorLog syslog'.)

Some more thoughts:

How is the printer connected (e.g. a locally connected USB printer or a network
printer or a printer shared from another host)? Can you please post the output
of the command 'lpstat -v' (or 'lpstat -v | grep ')?

Is there any file '/etc/cups/lpoptions' or '$HOME/.cups/lpoptions' present?


What happens if you print the job file attached in comment 17 directly from the
command line using the command 'lp -d  d01250-001' from a
directory where this file is located? Is the output the same?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D11051: Remembering side navigation panel state

2018-04-05 Thread Albert Astals Cid
aacid added a comment.


  In D11051#239497 , @dileepsankhla 
wrote:
  
  > The state can be saved whenever a sidebar item is clicked in 
Sidebar::itemClicked but again as discussed earlier, it will be asymmetrical as 
to save in sidebar.cpp. Should I implement a signal slot mechanism in part.cpp 
to achieve so or should I find another way?
  
  
  Ok, let's try to move the code to Sidebar again if you think there is better.
  
  Also would be very nice if you could add autotests for this (and the sidebar 
visibility feature that is a sister feature) to make sure it doesn't break.
  
  Basically,
  open part, show sidebar, close part, open part, check sidebar is visible, 
hide part, open part, check sidebar is not visible
  open part, show sidebar, collapse sidebar, close part, open part, check 
sidebar is visible but collapsed
  and the same variants also opening files, specially files with toc, since the 
also had the problem that was uncollapsing the sidebar when opening files for 
no reason.

INLINE COMMENTS

> part.cpp:439
> +
> +// Setting current item as thumbsBox if the side navigation panel is 
> visible 
> +if ( !Okular::Settings::hideSideContainer() )

can you please change your nomenclarute of "side navigation panel is visible" 
in this and the other comments, because that is what F7 does, which is sabed 
with m_sidebar->setSidebarVisibility and what you're saving is the collapsed 
status.

Also the config option would probably make more sense to be named something 
like sidebarCollapsed defaulting to false.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11051

To: dileepsankhla, #okular, aacid
Cc: tobiasdeiminger, aacid, sander, #okular, michaelweghorn, ngraham


D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

2018-04-05 Thread Albert Astals Cid
aacid added a comment.


  In D11901#239734 , @ahmadosama 
wrote:
  
  > Oh yes this may break it, I am thinking of adding another Boolean parameter 
to the RotationJob::rotationMatrix function with a default value of false to 
either translate or not
  >  The function can be:
  >  RotationJob::rotationMatrix( Rotation from, Rotation to, bool translate = 
false )
  
  
  I don't think that's a good idea, also the translations are a bit "random", 
why are they only 0 or 1?, i guess because you know the HighlightAreaRect are 
from 0 to 1, but that's knowledge that it's a bit "extra" to the rotationMatrix 
function.
  
  Can you check if we simply should not be using RotationJob::rotationMatrix? 
the other objects in the loop above are transformed using a different matrix 
and those ones seem to work? Maybe you can use that one?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11901

To: ahmadosama, #okular
Cc: aacid, ngraham, #okular, michaelweghorn


[okular] [Bug 351849] Margins often cut when printing

2018-04-05 Thread Dario Bertero
https://bugs.kde.org/show_bug.cgi?id=351849

--- Comment #20 from Dario Bertero  ---
Just to clarify my experience while waiting for his response. It happened to me
some time ago with a certain configuration to a network printer managed outside
my control, and a certain printer driver (I cannot remember anymore). Only on
Okular, Evince and other softwares printed fine. After they have made some
obscure updates to the network printing system and changed the authenthication
(it is also possible I selected a different driver from CUPS list, there were
many applicable to the Hp P4015n), I have not experienced the bug anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 391385] Going to the presentation mode twice closes the document

2018-04-05 Thread Vidya Sagar
https://bugs.kde.org/show_bug.cgi?id=391385

--- Comment #3 from Vidya Sagar  ---
I am not able to reproduce the crash with when running as
 valgrind okular 
but i still have the issue when running as
 okular

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 344599] Thumbnails sidebar always open when okular starts

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=344599

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 207748] LTR languages searches text backwards

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=207748

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375506] Crashing when highlighting in long document

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=375506

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 59025] Okular should display feedback about the status of the current print job

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=59025

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 357526] Annotation can not be saved automatically for a specific PDF file.

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=357526

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 373388] allow user to have "merge highlighting and notes directly into pdf" as a setable option

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=373388

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 259303] Okular should not try to load files stored in tmp-directory on session-restauration

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=259303

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 387247] okular [12.17beta] crash upon highlighting text in pdfs

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=387247

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 387882] Presentation mode only ever uses non-continuous single page view

2018-04-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=387882

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.