Re: Can I work on an issue that is the basis of a GSoC project?

2018-02-14 Thread Oliver Sander
On 14.02.2018 03:22, Dileep Sankhla wrote:
> Thank you so much. Do you also mean I can send the proposal to the same 
> project while working on the same issue during this pre-application duration 
> and may also have sent a patch for the review? 

Again, I'd say you can.  If you have completed too much of the project by the 
time it starts,
will find additional stuff for you to do.

I wouldn't mind a second opinion on this, though.

> 
> 
> 
> ‌
> 
> On Wed, Feb 14, 2018 at 2:42 AM, Oliver Sander  > wrote:
> 
> Hi Dileep,
> 
> > Can I work on the issue beforehand?
> 
> I'd say: Sure you can!  If you are too quick and you solve the gsoc 
> project way
> before gsoc is over, then there are plenty of further interesting 
> annotation-related
> things to work on.  So start right away if you feel like it.
> 
> Best,
> Oliver
> 
> >
> > Thanks and Regards
> > Dileep
> >
> > ‌
> 
> 



smime.p7s
Description: S/MIME Cryptographic Signature


D10504: Bug 288042 - Option to reset forms

2018-02-14 Thread Ahmad Osama
ahmadosama created this revision.
ahmadosama added a project: Okular.
Restricted Application added a subscriber: Okular.
ahmadosama requested review of this revision.

REVISION SUMMARY
  These changes are done to add a button to Reset pdf forms when clicked.
  
  Changes are to the following files:
  
  - part.cpp: Just changing the text displayed to the user when the document 
has forms
  - pageview.cpp/pageview.h: add an action to reset forms just like the Show 
Form/Hide form (aToggleForm QAction)
  - formwidget.cpp/formwidger.h: add a virtual function 'clearWidgetContents()' 
to the parent class (FormWidgetIface) that clears the contents of the widget, 
then overriding this function in its children to clear the contents differently 
in each widget, ex. clearing the FormLineEditClass (that iherits from 
QLineEdit) is done by setting text to an empty string ("").
  
  - the clearWidgetContents() is called when the QAction associated with it is 
triggered.
  
  *the clearWidgetContent() is added to the FormLineEdit, radioButton, 
checkBoxEdit and KTextEdit

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10504

AFFECTED FILES
  part.cpp
  ui/formwidgets.cpp
  ui/formwidgets.h
  ui/pageview.cpp
  ui/pageview.h

To: ahmadosama
Cc: #okular, michaelweghorn, ngraham, simgunz, aacid


[okular] [Bug 288042] Option to reset forms (PDF)

2018-02-14 Thread Ahmad Osama
https://bugs.kde.org/show_bug.cgi?id=288042

--- Comment #7 from Ahmad Osama  ---
I have posted it here: https://phabricator.kde.org/D10504

I saw the comment now, it sounds that I have implemented almost the same idea!

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Can I work on an issue that is the basis of a GSoC project?

2018-02-14 Thread Dileep Sankhla
Thank you so much. It really helped.



‌

On Wed, Feb 14, 2018 at 2:33 PM, Oliver Sander 
wrote:

> On 14.02.2018 03:22, Dileep Sankhla wrote:
> > Thank you so much. Do you also mean I can send the proposal to the same
> project while working on the same issue during this pre-application
> duration and may also have sent a patch for the review?
>
> Again, I'd say you can.  If you have completed too much of the project by
> the time it starts,
> will find additional stuff for you to do.
>
> I wouldn't mind a second opinion on this, though.
>
> >
> >
> >
> > ‌
> >
> > On Wed, Feb 14, 2018 at 2:42 AM, Oliver Sander <
> oliver.san...@tu-dresden.de > wrote:
> >
> > Hi Dileep,
> >
> > > Can I work on the issue beforehand?
> >
> > I'd say: Sure you can!  If you are too quick and you solve the gsoc
> project way
> > before gsoc is over, then there are plenty of further interesting
> annotation-related
> > things to work on.  So start right away if you feel like it.
> >
> > Best,
> > Oliver
> >
> > >
> > > Thanks and Regards
> > > Dileep
> > >
> > > ‌
> >
> >
>
>


KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 60 - Fixed!

2018-02-14 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/60/
 Project:
Applications okular stable-kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 14 Feb 2018 16:51:29 +
 Build duration:
5 min 19 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report88%
(22/25)51%
(138/271)51%
(138/271)37%
(14676/39319)26%
(7017/27417)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(5/5)100%
(5/5)58%
(1075/1840)41%
(563/1361)autotests100%
(14/14)100%
(14/14)99%
(2298/2321)50%
(1470/2965)conf6%
(1/17)6%
(1/17)7%
(53/805)0%
(1/272)conf.autotests100%
(1/1)100%
(1/1)100%
(17/17)50%
(7/14)core85%
(41/48)85%
(41/48)54%
(5088/9397)39%
(2475/6307)core.script0%
(0/9)0%
(0/9)0%
(0/494)0%
(0/230)generators.comicbook29%
(2/7)29%
(2/7)3%
(10/397)0%
(0/430)generators.dvi2%
(1/46)2%
(1/46)0%
(10/3571)0%
(1/2423)generators.epub100%
(3/3)100%
(3/3)55%
(184/335)43%
(78/183)generators.fax17%
(1/6)17%
(1/6)2%
(7/432)0%
(0/585)generators.fictionbook60%
(3/5)60%
(3/5)3%
(16/531)0%
(2/454)generators.kimgio100%
(1/1)100%
(1/1)63%
(44/70)28%
(5/18)generators.kimgio.tests100%
(1/1)100%
(1/1)100%
(49/49)46%
(24/52)generators.mobipocket60%
(3/5)60%
(3/5)11%
(13/115)0%
(0/120)generators.ooo27%
(3/11)27%
(3/11)1%
(14/1125)0%
(0/736)generators.plucker100%
(1/1)100%
(1/1)4%
(4/98)0%
(0/36)generators.plucker.unpluck0%
(0/6)0%
(0/6)0%
(0/1652)0%
(0/876)generators.poppler60%
(3/5)60%
(3/5)52%
(707/1358)40%
 

D10504: Bug 288042 - Option to reset forms

2018-02-14 Thread Albert Astals Cid
aacid added a comment.


  Same as I asked Gilbert in reviewboard.
  
  Do you think you could do an autotest using formSamples.pdf ?

INLINE COMMENTS

> part.cpp:1548
>  {
> +/* original
>  m_formsMessage->setText( i18n( "This document has forms. Click on 
> the button to interact with them, or use View -> Show Forms." ) );

This is not how you do coding, you don't leave the old code commented around.

> formwidgets.cpp:552
> +// TODO:
> +setText("");
> +}

this is wrong, you want QString()

> formwidgets.h:160
>  
> +//ChangeHere
> +virtual void clearWidgetContents();

Remove all those markers, we can see the changes.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10504

To: ahmadosama
Cc: aacid, ngraham, #okular, michaelweghorn, simgunz


D10504: Bug 288042 - Option to reset forms

2018-02-14 Thread Albert Astals Cid
aacid requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10504

To: ahmadosama, aacid
Cc: aacid, ngraham, #okular, michaelweghorn, simgunz


[okular] [Bug 390477] New: Memory leaks at simple pages flipping

2018-02-14 Thread Kushnir Bogdan
https://bugs.kde.org/show_bug.cgi?id=390477

Bug ID: 390477
   Summary: Memory leaks at simple pages flipping
   Product: okular
   Version: 1.3.2
  Platform: Neon Packages
OS: Linux
Status: UNCONFIRMED
  Severity: critical
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: looriin...@gmail.com
  Target Milestone: ---

Okular doesn't free memory at pages scrolling. Works on pdf and djvu files.

Video describes the problem: https://youtu.be/E5QQ9hDXkyk

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377487] Find and List all instances of a searched word

2018-02-14 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=377487

--- Comment #6 from Christoph Feck  ---
Is bug 238123 a duplicate?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377487] Find and List all instances of a searched word

2018-02-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=377487

--- Comment #7 from Nate Graham  ---
Looks like it to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390477] Memory leaks at simple pages flipping

2018-02-14 Thread Kushnir Bogdan
https://bugs.kde.org/show_bug.cgi?id=390477

--- Comment #1 from Kushnir Bogdan  ---
Created attachment 110669
  --> https://bugs.kde.org/attachment.cgi?id=110669&action=edit
demonstration file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 388854] Okular uses a very large amount of RAM for caching

2018-02-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=388854

Nate Graham  changed:

   What|Removed |Added

 CC||looriin...@gmail.com

--- Comment #17 from Nate Graham  ---
*** Bug 390477 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390477] Memory leaks at simple pages flipping

2018-02-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=390477

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||n...@kde.org
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Nate Graham  ---
That's not a leak, it's just Okular using your available memory for caching. If
you want it to use less memory even though there's plenty available, you can
change it in Settings > Configure Okular > Performance.

*** This bug has been marked as a duplicate of bug 388854 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 387426] FB2 module do not display content inside tags

2018-02-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=387426

abogi...@gmail.com changed:

   What|Removed |Added

 CC||abogi...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 353299] Text search does not work in Arabic

2018-02-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=353299

abogi...@gmail.com changed:

   What|Removed |Added

 CC||abogi...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.