D8415: Soften correctness of image file open check
trufanov updated this revision to Diff 22327.
trufanov added a comment.
Wording of a warning message is changed.
With dot at sentence end.
A screenshot of warning appearance is
attached{https://phabricator.kde.org/F5491726}
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8415?vs=22254&id=22327
REVISION DETAIL
https://phabricator.kde.org/D8415
AFFECTED FILES
generators/kimgio/generator_kimgio.cpp
To: trufanov, ngraham, #okular, aacid
Cc: aacid, progwolff, ngraham
D8415: Soften correctness of image file open check
This revision was automatically updated to reflect the committed changes. Closed by commit R223:4b2ba6a7af25: Try to display a malformed image if feasible (authored by trufanov). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8415?vs=22327&id=22331 REVISION DETAIL https://phabricator.kde.org/D8415 AFFECTED FILES generators/kimgio/generator_kimgio.cpp To: trufanov, ngraham, #okular, aacid Cc: aacid, progwolff, ngraham
KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 5 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/5/ Project: Applications okular kf5-qt5 SUSEQt5.9 Date of build: Tue, 14 Nov 2017 11:43:11 + Build duration: 5 min 8 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.parttest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report88% (22/25)51% (138/271)51% (138/271)34% (13166/38464)23% (6059/26459)Coverage Breakdown by Package Name FilesClassesLinesConditionals100% (5/5)100% (5/5)54% (917/1685)36% (453/1263)autotests100% (14/14)100% (14/14)98% (1954/1984)48% (1189/2477)conf6% (1/17)6% (1/17)7% (53/805)0% (1/272)conf.autotests100% (1/1)100% (1/1)100% (17/17)50% (7/14)core85% (41/48)85% (41/48)49% (4461/9159)35% (2136/6031)core.script0% (0/9)0% (0/9)0% (0/494)0% (0/230)generators.comicbook29% (2/7)29% (2/7)3% (10/397)0% (0/430)generators.dvi2% (1/46)2% (1/46)0% (9/3571)0% (1/2423)generators.epub100% (3/3)100% (3/3)55% (184/335)43% (78/183)generators.fax17% (1/6)17% (1/6)2% (7/432)0% (0/585)generators.fictionbook60% (3/5)60% (3/5)3% (16/531)0% (2/454)generators.kimgio100% (1/1)100% (1/1)61% (41/67)28% (5/18)generators.kimgio.tests100% (1/1)100% (1/1)100% (49/49)46% (24/52)generators.mobipocket60% (3/5)60% (3/5)11% (13/115)0% (0/120)generators.ooo27% (3/11)27% (3/11)1% (14/1125)0% (0/736)generators.plucker100% (1/1)100% (1/1)4% (4/98)0% (0/36)generators.plucker.unpluck0% (0/6)0% (0/6)0% (0/1652)0% (0/876)generators.poppler60% (3/5)60% (3/5)49% (646/1317)37%
[okular] [Bug 385384] Some PNG files produced by acdsee can't be displayed
https://bugs.kde.org/show_bug.cgi?id=385384 Alexander Trufanov changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #3 from Alexander Trufanov --- https://phabricator.kde.org/R223:4b2ba6a7af2581660f6b1201991664d749e79b42 -- You are receiving this mail because: You are the assignee for the bug.
D8642: Rework saving of annotations and form data
aacid added a comment. In https://phabricator.kde.org/D8642#167371, @aacid wrote: > Still on the todo list: > > - syncing the modified bit to the undo/redo stack so if you add an annotation and then undo it, it's not marked as modified This is now done. > - Fixing the code in documentcommands.cpp suggested by Laurent This is now done. > - Bringing back the messagewidget on reload There's an issue with the KMessageWidget API, calling setVisible after it has been closed doesn't really make it visible again, i'll try to fix have a look but at this point I don't think we should block on this. > - Fixing duplicated code in swapBackingFile[Archive] This is now done > - Trying to have one warning dialog instead of two Given how close we are to the deadline and how tricky is to get all the if/else right i propose we live this for later > - padding improvements on the unsupported warning dialog This is a KMessageBox::warningYesNoCancelList nothing i can do to fix it in okular > - Poppler fix so that saving doesn't fail if the file is changed behind our feet This is ortogonal to this request, i'll work on it but again i dont' think we should block on it At this point it would be great if we could get it merged on thursday night. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8642 To: aacid, mlaurent Cc: rkflx, lueck, mlaurent, michaelweghorn, ngraham, #okular, aacid
D8642: Rework saving of annotations and form data
aacid updated this revision to Diff 22346. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8642?vs=21843&id=22346 REVISION DETAIL https://phabricator.kde.org/D8642 AFFECTED FILES autotests/data/file1-docdata.xml autotests/data/potato.jpg autotests/documenttest.cpp autotests/parttest.cpp core/document.cpp core/document.h core/document_p.h core/documentcommands.cpp core/documentcommands_p.h core/generator.cpp core/generator.h core/observer.h core/page.cpp core/page.h core/page_p.h doc/index.docbook generators/kimgio/generator_kimgio.cpp generators/kimgio/generator_kimgio.h generators/poppler/generator_pdf.cpp generators/poppler/generator_pdf.h part.cpp part.h part.rc shell/shell.cpp shell/shell.h ui/annotationmodel.cpp ui/annotwindow.cpp ui/annotwindow.h ui/bookmarklist.cpp ui/formwidgets.cpp ui/formwidgets.h ui/pageview.cpp ui/pageview.h ui/pageviewmouseannotation.cpp ui/pageviewmouseannotation.h ui/pageviewutils.cpp ui/pageviewutils.h To: aacid, mlaurent Cc: rkflx, lueck, mlaurent, michaelweghorn, ngraham, #okular, aacid
KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 6 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/6/ Project: Applications okular kf5-qt5 SUSEQt5.9 Date of build: Tue, 14 Nov 2017 21:27:58 + Build duration: 6 min 58 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.parttest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report88% (22/25)51% (138/271)51% (138/271)34% (13194/38464)23% (6067/26459)Coverage Breakdown by Package Name FilesClassesLinesConditionals100% (5/5)100% (5/5)54% (917/1685)36% (453/1263)autotests100% (14/14)100% (14/14)98% (1954/1984)48% (1187/2477)conf6% (1/17)6% (1/17)7% (53/805)0% (1/272)conf.autotests100% (1/1)100% (1/1)100% (17/17)50% (7/14)core85% (41/48)85% (41/48)49% (4460/9159)35% (2135/6031)core.script0% (0/9)0% (0/9)0% (0/494)0% (0/230)generators.comicbook29% (2/7)29% (2/7)3% (10/397)0% (0/430)generators.dvi2% (1/46)2% (1/46)0% (9/3571)0% (1/2423)generators.epub100% (3/3)100% (3/3)55% (184/335)43% (78/183)generators.fax17% (1/6)17% (1/6)2% (7/432)0% (0/585)generators.fictionbook60% (3/5)60% (3/5)3% (16/531)0% (2/454)generators.kimgio100% (1/1)100% (1/1)61% (41/67)28% (5/18)generators.kimgio.tests100% (1/1)100% (1/1)100% (49/49)46% (24/52)generators.mobipocket60% (3/5)60% (3/5)11% (13/115)0% (0/120)generators.ooo27% (3/11)27% (3/11)1% (14/1125)0% (0/736)generators.plucker100% (1/1)100% (1/1)4% (4/98)0% (0/36)generators.plucker.unpluck0% (0/6)0% (0/6)0% (0/1652)0% (0/876)generators.poppler60% (3/5)60% (3/5)49% (646/1317)37%
D8642: Rework saving of annotations and form data
rkflx accepted this revision.
rkflx added a comment.
Latest version is much improved, but still not there yet (see below). I'm
giving this my approval nevertheless, because I'm confident that you'll be able
to do the string changes now and fix the remaining problems in time for the RC
(you could pretend I found the crasher only when testing the Beta ;). Please
merge at your earliest convenience, I'll try to schedule another test run
before the RC.
24. Segfault: Add annotation, Save > Undo > Save. Introduced by
https://phabricator.kde.org/R223:055f2db76d58b559b8a215cd5713cdbd7265fddd.
Backtrace:
#0 0x7fffbf01c156 in Poppler::UnicodeParsedString (s1=0x2700ad) at
/home/user/poppler/qt5/src/poppler-private.cc:102
#1 0x7fffbeff8414 in Poppler::Annotation::uniqueName (this=) at /home/user/poppler/qt5/src/poppler-annotation.cc:1399
#2 0x7fffbf26d81d in PDFGenerator::save(QString const&,
QFlags, QString*) ()
from
/home/user/opt/lib64/plugins/okular/generators/okularGenerator_poppler.so
#3 0x7fffd6efd570 in Okular::Document::saveChanges(QString const&,
QString*) () from /home/user/okular/build/libOkular5Core.so.7
#4 0x7fffd727fde0 in Okular::Part::saveAs(QUrl const&,
QFlags) () from ./okularpart.so
#5 0x7fffd727f304 in Okular::Part::saveAs(QUrl const&) () from
./okularpart.so
#6 0x7fffd727ec62 in Okular::Part::saveFile() () from ./okularpart.so
#7 0x7fffd7275175 in
Okular::Part::setupActions()::{lambda()#1}::operator()() const () from
./okularpart.so
#8 0x7fffd7284e50 in QtPrivate::FunctorCall,
QtPrivate::List<>, void,
Okular::Part::setupActions()::{lambda()#1}>::call({lambda()#1}&, void**) ()
from ./okularpart.so
#9 0x7fffd7284e31 in void
QtPrivate::Functor::call, void>({lambda()#1}&, void*, {lambda()#1}&*) ()
from ./okularpart.so
#10 0x7fffd7284dff in
QtPrivate::QFunctorSlotObject, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*,
void**, bool*) () from ./okularpart.so
#11 0x731ee73c in QMetaObject::activate(QObject*, int, int, void**)
() from /usr/lib64/libQt5Core.so.5
#12 0x741bf982 in QAction::triggered(bool) () from
/usr/lib64/libQt5Widgets.so.5
#13 0x741c1e1c in QAction::activate(QAction::ActionEvent) () from
/usr/lib64/libQt5Widgets.so.5
#14 0x741c2625 in QAction::event(QEvent*) () from
/usr/lib64/libQt5Widgets.so.5
#15 0x741c5afc in QApplicationPrivate::notify_helper(QObject*,
QEvent*) () from /usr/lib64/libQt5Widgets.so.5
#16 0x741cceb4 in QApplication::notify(QObject*, QEvent*) () from
/usr/lib64/libQt5Widgets.so.5
#17 0x731c1128 in QCoreApplication::notifyInternal2(QObject*,
QEvent*) () from /usr/lib64/libQt5Core.so.5
#18 0x73a3e272 in QShortcutMap::dispatchEvent(QKeyEvent*) () from
/usr/lib64/libQt5Gui.so.5
#19 0x73a3e33a in QShortcutMap::tryShortcut(QKeyEvent*) () from
/usr/lib64/libQt5Gui.so.5
#20 0x739f0897 in
QWindowSystemInterface::handleShortcutEvent(QWindow*, unsigned long, int,
QFlags, unsigned int, unsigned int, unsigned int, QString
const&, bool, unsigned short) () from /usr/lib64/libQt5Gui.so.5
#21 0x73a0e9e7 in
QGuiApplicationPrivate::processKeyEvent(QWindowSystemInterfacePrivate::KeyEvent*)
() from /usr/lib64/libQt5Gui.so.5
#22 0x73a136e5 in
QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*)
() from /usr/lib64/libQt5Gui.so.5
#23 0x739ecf9b in
QWindowSystemInterface::sendWindowSystemEvents(QFlags)
() from /usr/lib64/libQt5Gui.so.5
#24 0x7fffe91fa420 in ?? () from /usr/lib64/libQt5XcbQpa.so.5
#25 0x7fffedd16f97 in g_main_context_dispatch () from
/usr/lib64/libglib-2.0.so.0
#26 0x7fffedd171d0 in ?? () from /usr/lib64/libglib-2.0.so.0
#27 0x7fffedd1725c in g_main_context_iteration () from
/usr/lib64/libglib-2.0.so.0
#28 0x7321723f in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib64/libQt5Core.so.5
#29 0x731bf73a in
QEventLoop::exec(QFlags) () from
/usr/lib64/libQt5Core.so.5
#30 0x731c7fc4 in QCoreApplication::exec() () from
/usr/lib64/libQt5Core.so.5
#31 0x0040d926 in main ()
25. `parttest` still fails (now requires to press button in dialog, then
crashes with similar backtrace to 24.)
26. Document is now named in warning dialog, but name includes full path.
Instead, it should only show the file name as in KWrite, LibreOffice and the
tab/window title. I guess it's just missing a `.fileName()`.
Regarding the file format warning:
- I now understand why we need Continue for Save As.
- 27. It is still very confusing when using Save, because for the user
Continue and Cancel are exactly the same. Can we special-case with a flag and
hide the last sentence and the button here? As Save is the m
D8642: Rework saving of annotations and form data
rkflx added a comment. One more thing: Please also grep the docbook for `&okular; archive`, still some `document` missing. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8642 To: aacid, mlaurent, rkflx Cc: rkflx, lueck, mlaurent, michaelweghorn, ngraham, #okular, aacid
KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 2 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/2/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Wed, 15 Nov 2017 02:28:08 + Build duration: 1 hr 35 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.parttest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report88% (22/25)51% (138/271)51% (138/271)34% (13192/38464)23% (6072/26459)Coverage Breakdown by Package Name FilesClassesLinesConditionals100% (5/5)100% (5/5)54% (917/1685)36% (453/1263)autotests100% (14/14)100% (14/14)98% (1954/1984)48% (1187/2477)conf6% (1/17)6% (1/17)7% (53/805)0% (1/272)conf.autotests100% (1/1)100% (1/1)100% (17/17)50% (7/14)core85% (41/48)85% (41/48)49% (4461/9159)35% (2139/6031)core.script0% (0/9)0% (0/9)0% (0/494)0% (0/230)generators.comicbook29% (2/7)29% (2/7)3% (10/397)0% (0/430)generators.dvi2% (1/46)2% (1/46)0% (9/3571)0% (1/2423)generators.epub100% (3/3)100% (3/3)55% (184/335)43% (78/183)generators.fax17% (1/6)17% (1/6)2% (7/432)0% (0/585)generators.fictionbook60% (3/5)60% (3/5)3% (16/531)0% (2/454)generators.kimgio100% (1/1)100% (1/1)61% (41/67)28% (5/18)generators.kimgio.tests100% (1/1)100% (1/1)100% (49/49)46% (24/52)generators.mobipocket60% (3/5)60% (3/5)11% (13/115)0% (0/120)generators.ooo27% (3/11)27% (3/11)1% (14/1125)0% (0/736)generators.plucker100% (1/1)100% (1/1)4% (4/98)0% (0/36)generators.plucker.unpluck0% (0/6)0% (0/6)0% (0/1652)0% (0/876)generators.poppler60% (3/5)60% (3/5)49% (646
