D8385: Set the columns in "Overview" mode to match the amount of pages if document is small
lexdem added a comment. Week already passed? :) I just waiting to continue coding and still didn't ruin the workflow for this commit :) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular, rkflx, ngraham Cc: ltoscano, aacid, rkflx, ngraham
[okular] [Bug 355283] Feature request: Less columns in overview mode if document has less pages
https://bugs.kde.org/show_bug.cgi?id=355283 Henrik Fehlauer changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/oku ||lar/d679b3c9f23d92e4fb7d4b0 ||154b0937402914a79 --- Comment #1 from Henrik Fehlauer --- Git commit d679b3c9f23d92e4fb7d4b0154b0937402914a79 by Henrik Fehlauer, on behalf of Alexey Demennikov. Committed on 28/10/2017 at 19:20. Pushed by rkflx into branch 'master'. Set the columns in "Overview" mode to match the amount of pages if document is small Summary: The principle is simple. This patch enables overriding the default columns for Overview mode, if the document is small. For example, if document has 1 or 2 pages and the default columns in Okular settings is 3, Overview mode will enable 1 or 2 columns for better UX Reviewers: #okular, rkflx, ngraham Reviewed By: rkflx, ngraham Subscribers: ltoscano, aacid, rkflx, ngraham Tags: #okular Differential Revision: https://phabricator.kde.org/D8385 M +3-0ui/pageview.cpp https://commits.kde.org/okular/d679b3c9f23d92e4fb7d4b0154b0937402914a79 -- You are receiving this mail because: You are the assignee for the bug.
D8385: Set the columns in "Overview" mode to match the amount of pages if document is small
This revision was automatically updated to reflect the committed changes. Closed by commit R223:d679b3c9f23d: Set the columns in "Overview" mode to match the amount of pages if document is… (authored by lexdem, committed by rkflx). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8385?vs=21091&id=21503 REVISION DETAIL https://phabricator.kde.org/D8385 AFFECTED FILES ui/pageview.cpp To: lexdem, #okular, rkflx, ngraham Cc: ltoscano, aacid, rkflx, ngraham
D8385: Set the columns in "Overview" mode to match the amount of pages if document is small
rkflx added a comment. I had this already prepared (look at the commit timestamp), and scheduled for tomorrow. But if you want it now, you get it now :) Thanks again for the patch, looking forward to more contributions. Just ask if you need ideas or help… REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular, rkflx, ngraham Cc: ltoscano, aacid, rkflx, ngraham
KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 45 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/45/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.9 Date of build: Sat, 28 Oct 2017 19:20:32 + Build duration: 7 min 53 sec and counting CONSOLE OUTPUT [...truncated 297.09 KB...]widgetannottools.cppwidgetconfigurationtoolsbase.cppwidgetdrawingtools.cppextensions.cppembeddedfilesdialog.cpp[ 36%] Building CXX object CMakeFiles/okularpart.dir/ui/annotwindow.cpp.objannotwindow.cpp[ 37%] Building CXX object CMakeFiles/okularpart.dir/ui/annotationmodel.cpp.objannotationmodel.cpp[ 37%] Building CXX object CMakeFiles/okularpart.dir/ui/annotationpopup.cpp.objannotationpopup.cpp[ 37%] Building CXX object CMakeFiles/okularpart.dir/ui/annotationpropertiesdialog.cpp.objannotationpropertiesdialog.cpp[ 38%] Building CXX object CMakeFiles/okularpart.dir/ui/annotationproxymodels.cpp.objannotationproxymodels.cpp[ 38%] Building CXX object CMakeFiles/okularpart.dir/ui/annotationtools.cpp.objannotationtools.cpp[ 38%] Building CXX object CMakeFiles/okularpart.dir/ui/annotationwidgets.cpp.objannotationwidgets.cpp[ 39%] Building CXX object CMakeFiles/okularpart.dir/ui/bookmarklist.cpp.objbookmarklist.cpp[ 39%] Building CXX object CMakeFiles/okularpart.dir/ui/debug_ui.cpp.objdebug_ui.cpp[ 40%] Building CXX object CMakeFiles/okularpart.dir/ui/fileprinterpreview.cpp.objfileprinterpreview.cpp[ 40%] Building CXX object CMakeFiles/okularpart.dir/ui/formwidgets.cpp.objformwidgets.cpp[ 41%] Building CXX object CMakeFiles/okularpart.dir/ui/guiutils.cpp.objguiutils.cpp[ 41%] Building CXX object CMakeFiles/okularpart.dir/ui/ktreeviewsearchline.cpp.objktreeviewsearchline.cpp[ 41%] Building CXX object CMakeFiles/okularpart.dir/ui/latexrenderer.cpp.objlatexrenderer.cpp[ 42%] Building CXX object CMakeFiles/okularpart.dir/ui/minibar.cpp.objminibar.cpp[ 42%] Building CXX object CMakeFiles/okularpart.dir/ui/okmenutitle.cpp.objokmenutitle.cpp[ 43%] Building CXX object CMakeFiles/okularpart.dir/ui/pagesizelabel.cpp.objpagesizelabel.cpp[ 43%] Building CXX object CMakeFiles/okularpart.dir/ui/pageviewmouseannotation.cpp.objpageviewmouseannotation.cpp[ 43%] Building CXX object CMakeFiles/okularpart.dir/ui/magnifierview.cpp.objmagnifierview.cpp[ 44%] Building CXX object CMakeFiles/okularpart.dir/ui/presentationsearchbar.cpp.objpresentationsearchbar.cpp[ 44%] Building CXX object CMakeFiles/okularpart.dir/ui/propertiesdialog.cpp.objpropertiesdialog.cpp[ 45%] Building CXX object CMakeFiles/okularpart.dir/ui/searchlineedit.cpp.objsearchlineedit.cpp[ 45%] Building CXX object CMakeFiles/okularpart.dir/ui/searchwidget.cpp.objsearchwidget.cpp[ 45%] Building CXX object CMakeFiles/okularpart.dir/ui/snapshottaker.cpp.objsnapshottaker.cpp[ 45%] Building CXX object CMakeFiles/okularpart.dir/ui/tocmodel.cpp.objtocmodel.cpp[ 45%] Building CXX object CMakeFiles/okularpart.dir/ui/toolaction.cpp.objtoolaction.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/ui/videowidget.cpp.objvideowidget.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/ui/tts.cpp.obj[ 46%] Building CXX object CMakeFiles/okularpart.dir/conf/preferencesdialog.cpp.objtts.cpppreferencesdialog.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/part.cpp.objpart.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/ui/findbar.cpp.objdrawingtoolactions.cppfindbar.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/ui/pageitemdelegate.cpp.objpageitemdelegate.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/ui/pagepainter.cpp.objpagepainter.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/ui/pageviewannotator.cpp.objpageviewannotator.cpp[ 47%] Building CXX object CMakeFiles/okularpart.dir/ui/pageview.cpp.objC:\CI\workspace\Applications okular kf5-qt5 WindowsMSVCQt5.9\ui\drawingtoolactions.cpp(50): warning C4566: character represented by universal-character-name '\u2713' cannot be represented in the current code page (1252)pageview.cpp[ 47%] Building CXX object CMakeFiles/okularpart.dir/ui/pageviewutils.cpp.objpageviewutils.cpp[ 47%] Building CXX object CMakeFiles/okularpart.dir/ui/presentationwidget.cpp.objC:\CI\WORKSP~1\APPLIC~1.9\INSTAL~1\include\KF5\PURPOS~1\purposewidgets/menu.h(21): fatal error C1083: Cannot open include file: 'purposewidgets_export.h': No such file or directoryjom: C:\CI\workspace\Applications okular kf5-qt5 WindowsMSVCQt5.9\build\CMakeFiles\okularpart.dir\build.make [CMakeFiles\okularpart.dir\part.cpp.obj] Error 2presentationwidget.cppC:\CI\workspace\Applications okular kf5-qt5 WindowsMSVCQt5.9\ui\pageview.cpp(99): warning C4838: conversion from 'double' to 'const float' requires a narrowing conversionC:\CI\workspace\Applications okular kf5-qt5 WindowsMSVCQt5.9\ui\pageview.cpp(99): warning C4305: 'initializing': truncation from 'double' to 'const float'C:\CI\workspace\Applications okular kf5-qt5 WindowsMSVCQt5.9\ui\pageview.cpp(3937): warning C4305: '=': truncation from 'double' to 'float'jom
D8385: Set the columns in "Overview" mode to match the amount of pages if document is small
lexdem added a comment. In https://phabricator.kde.org/D8385#161286, @rkflx wrote: > I had this already prepared (look at the commit timestamp), and scheduled for tomorrow. But if you want it now, you get it now :) > > Thanks again for the patch, looking forward to more contributions. Just ask if you need ideas or help… Thanks a lot for the commiting :) Sorry, didn't know, that delayed commit is possible :) Yep, "more questions" is about to happen. The main conversation happens in #kde-devel, right? Or there is chat in Phabricator too? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular, rkflx, ngraham Cc: ltoscano, aacid, rkflx, ngraham
D8385: Set the columns in "Overview" mode to match the amount of pages if document is small
rkflx added a comment. In https://phabricator.kde.org/D8385#161287, @lexdem wrote: > The main conversation happens in #kde-devel, right? Or there is chat in Phabricator too? While Phab has a chat (icon right to the bell icon next to the Phab logo), it is not used as far as I know. Just use IRC, but there are also project specific mailinglists (e.g. okular-devel for Okular). REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular, rkflx, ngraham Cc: ltoscano, aacid, rkflx, ngraham
D8385: Set the columns in "Overview" mode to match the amount of pages if document is small
lexdem added a comment. In https://phabricator.kde.org/D8385#161288, @rkflx wrote: > In https://phabricator.kde.org/D8385#161287, @lexdem wrote: > > > The main conversation happens in #kde-devel, right? Or there is chat in Phabricator too? > > > While Phab has a chat (icon right to the bell icon next to the Phab logo), it is not used as far as I know. Just use IRC, but there are also project specific mailinglists (e.g. okular-devel for Okular). Okay, thanks for the hint :) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular, rkflx, ngraham Cc: ltoscano, aacid, rkflx, ngraham
KDE CI: Applications okular kf5-qt5 FedoraQt5.8 - Build # 89 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FedoraQt5.8/89/ Project: Applications okular kf5-qt5 FedoraQt5.8 Date of build: Sat, 28 Oct 2017 19:20:32 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.mainshelltest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report88% (21/24)46% (124/268)46% (124/268)29% (10926/38013)19% (4969/26260)Coverage Breakdown by Package Name FilesClassesLinesConditionals80% (4/5)80% (4/5)48% (808/1679)29% (371/1267)autotests93% (13/14)93% (13/14)83% (1631/1976)39% (955/2477)conf6% (1/17)6% (1/17)7% (53/805)0% (1/272)conf.autotests100% (1/1)100% (1/1)100% (17/17)50% (7/14)core83% (40/48)83% (40/48)46% (4177/9133)34% (2017/6015)core.script0% (0/9)0% (0/9)0% (0/494)0% (0/230)generators.comicbook29% (2/7)29% (2/7)3% (10/397)0% (0/430)generators.dvi2% (1/46)2% (1/46)0% (9/3571)0% (1/2423)generators.fax17% (1/6)17% (1/6)2% (7/432)0% (0/585)generators.fictionbook60% (3/5)60% (3/5)3% (16/531)0% (2/454)generators.kimgio100% (1/1)100% (1/1)63% (41/65)31% (5/16)generators.kimgio.tests100% (1/1)100% (1/1)100% (49/49)46% (24/52)generators.mobipocket60% (3/5)60% (3/5)11% (13/115)0% (0/120)generators.ooo27% (3/11)27% (3/11)1% (14/1125)0% (0/736)generators.plucker100% (1/1)100% (1/1)4% (4/98)0% (0/36)generators.plucker.unpluck0% (0/6)0% (0/6)0% (0/1652)0% (0/876)generators.poppler60% (3/5)60% (3/5)44% (575/1311)35% (247/697)generators.tiff100% (1/1)100% (1/1)4% (10/226)0%
