[okular] [Bug 373133] 16.12.0 Okular duplex printing on but no duplex printing done
https://bugs.kde.org/show_bug.cgi?id=373133 Moritz Bunkus changed: What|Removed |Added CC||mor...@bunkus.org -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 273623] Horizontal icon bar in navigation panel
https://bugs.kde.org/show_bug.cgi?id=273623 azr...@googlemail.com changed: What|Removed |Added CC||azr...@googlemail.com -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 335189] save navigation panel mode across sessions
https://bugs.kde.org/show_bug.cgi?id=335189 azr...@googlemail.com changed: What|Removed |Added CC||azr...@googlemail.com --- Comment #4 from azr...@googlemail.com --- seems like a duplicate of https://bugs.kde.org/show_bug.cgi?id=342094 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 342094] State of side Navigation Panel is not not remembered
https://bugs.kde.org/show_bug.cgi?id=342094 azr...@googlemail.com changed: What|Removed |Added CC||azr...@googlemail.com -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 342094] State of side Navigation Panel is not not remembered
https://bugs.kde.org/show_bug.cgi?id=342094 --- Comment #4 from azr...@googlemail.com --- I'd be especially interested in the sidebar retaining its "no panel open" state across okular restarts. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 377688] No output to print for PDF since update to 1.0.3
https://bugs.kde.org/show_bug.cgi?id=377688 --- Comment #6 from Ian Newton --- All files I have tried open and print as expected with LibreOffice Draw. The print dialogue displays a scaled view of the document. Is this dialogue available to Okular or is it part of LibreOffice? It may be a good place to start by looking at the processing for print in Okular. Could these libraries be used? Just a thought? -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 377688] No output to print for PDF since update to 1.0.3
https://bugs.kde.org/show_bug.cgi?id=377688 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #7 from Oliver Sander --- I just printed the example file into a pdf file using the current Okular git master. That worked flawlessly, besides the fact that a few fonts got rasterized (which may be a feature). -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 377688] No output to print for PDF since update to 1.0.3
https://bugs.kde.org/show_bug.cgi?id=377688 --- Comment #8 from Oliver Sander --- BTW, printing still involves conversion to postscript and a call to gs, so your problem may be in that direction. Looking at the intermediate files may be interesting, but I do not know how to do that. There still is the 'pdfprintpdf' branch which removes the postscript indirection, but I do not know what state it is in. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 377688] No output to print for PDF since update to 1.0.3
https://bugs.kde.org/show_bug.cgi?id=377688 --- Comment #10 from Ian Newton --- Building branch pdfprintpdf to see what that does? -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 377688] No output to print for PDF since update to 1.0.3
https://bugs.kde.org/show_bug.cgi?id=377688 --- Comment #9 from Ian Newton --- Created attachment 104687 --> https://bugs.kde.org/attachment.cgi?id=104687&action=edit Another file which will not print I have just built from Git repo and now have v1.1.7 in place of 1.0.3 however this does not resolve printing. I'm attaching another apparently normal PDF manual which does not print. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 377688] No output to print for PDF since update to 1.0.3
https://bugs.kde.org/show_bug.cgi?id=377688 --- Comment #11 from Ian Newton --- OK the pdfprintpdf branch seems to make no difference. Builds as v1.0.7 -- You are receiving this mail because: You are the assignee for the bug.
Review Request 130043: Remove method FilePrinter::psPaperSize
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130043/ --- Review request for Okular. Repository: okular Description --- I was about to simplify the method FilePrinter::psPaperSize in the file fileprinter.cpp. As it turned out, this method is never called anywhere anyway. So this patch removes it. Diffs - core/fileprinter.h a60c2c0f core/fileprinter.cpp a27529e7 Diff: https://git.reviewboard.kde.org/r/130043/diff/ Testing --- Grepping for the method name doesn't return anything. Code still builds without the method. Thanks, Oliver Sander
Re: Review Request 130043: Remove method FilePrinter::psPaperSize
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130043/#review102934 --- This is not binary compatible (i.e. it removes a symbol from a publicly installed header). It should have been removed when we moved to KF5, but since it wasn't if there's no other reason that "we don't use it" I would prefer to keep it until we have some other forced binary compatibility break. - Albert Astals Cid On March 22, 2017, 3:20 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130043/ > --- > > (Updated March 22, 2017, 3:20 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > I was about to simplify the method FilePrinter::psPaperSize in the file > fileprinter.cpp. As it turned out, this method is never called anywhere > anyway. So this patch removes it. > > > Diffs > - > > core/fileprinter.h a60c2c0f > core/fileprinter.cpp a27529e7 > > Diff: https://git.reviewboard.kde.org/r/130043/diff/ > > > Testing > --- > > Grepping for the method name doesn't return anything. > > Code still builds without the method. > > > Thanks, > > Oliver Sander > >
[okular] [Bug 377688] No output to print for PDF since update to 1.0.3
https://bugs.kde.org/show_bug.cgi?id=377688 Albert Astals Cid changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |UNCONFIRMED --- Comment #12 from Albert Astals Cid --- Your bug seems very much like the bug where the broken gs interpreter breaks everything https://bugs.kde.org/show_bug.cgi?id=371887 -- You are receiving this mail because: You are the assignee for the bug.
Re: Review Request 129999: Allow to create bookmarks from the TOC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/ --- (Updated March 23, 2017, 12:23 a.m.) Status -- This change has been marked as submitted. Review request for Okular. Changes --- Submitted with commit a2aceadc13ea4917dff2c58f470dd6eb8bc2cf53 by Albert Astals Cid on behalf of Gilbert Assaf to branch Applications/17.04. Bugs: 190203 http://bugs.kde.org/show_bug.cgi?id=190203 Repository: okular Description --- If a bookmark is created from the TOC view, the text of the selected TOC item text is automatically used. Otherwise the behavior stays unchanged. Diffs - part.h f4c50ab part.cpp 198197a ui/toc.h 5e7fe2a ui/toc.cpp a205ad1 Diff: https://git.reviewboard.kde.org/r/12/diff/ Testing --- Thanks, Gilbert Assaf
[okular] [Bug 190203] Allow to create bookmarks from the "table of contents"
https://bugs.kde.org/show_bug.cgi?id=190203 Albert Astals Cid changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/oku ||lar/a2aceadc13ea4917dff2c58 ||f470dd6eb8bc2cf53 --- Comment #3 from Albert Astals Cid --- Git commit a2aceadc13ea4917dff2c58f470dd6eb8bc2cf53 by Albert Astals Cid, on behalf of Gilbert Assaf. Committed on 23/03/2017 at 00:22. Pushed by aacid into branch 'Applications/17.04'. Allow to create bookmarks from the TOC REVIEWS: 12 M +13 -2part.cpp M +2-0part.h M +12 -0ui/toc.cpp M +5-0ui/toc.h https://commits.kde.org/okular/a2aceadc13ea4917dff2c58f470dd6eb8bc2cf53 -- You are receiving this mail because: You are the assignee for the bug.
Jenkins-kde-ci: okular Applications-17.04 stable-kf5-qt5 » Linux,gcc - Build # 5 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/okular%20Applications-17.04%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 23 Mar 2017 00:24:17 + Build duration: 1 min 56 sec CHANGE SET Revision a2aceadc13ea4917dff2c58f470dd6eb8bc2cf53 by Albert Astals Cid: (Allow to create bookmarks from the TOC) change: edit ui/toc.h change: edit part.cpp change: edit ui/toc.cpp change: edit part.h
Jenkins-kde-ci: okular master kf5-qt5 » Linux,gcc - Build # 123 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/okular%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/123/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 23 Mar 2017 00:25:12 + Build duration: 6 min 51 sec CHANGE SET Revision 3df3c758c8349c5327591e0bd0b3e260642fb9b5 by Albert Astals Cid: (GIT_SILENT Upgrade KDE Applications version to 17.03.80.) change: edit CMakeLists.txt Revision a2aceadc13ea4917dff2c58f470dd6eb8bc2cf53 by Albert Astals Cid: (Allow to create bookmarks from the TOC) change: edit ui/toc.h change: edit ui/toc.cpp change: edit part.cpp change: edit part.h
Jenkins-kde-ci: okular master kf5-qt5 » Linux,gcc - Build # 124 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/okular%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/124/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 23 Mar 2017 00:35:02 + Build duration: 3 min 35 sec CHANGE SET Revision 3672c3222f8ccb54371a0191c6e709a199fe8c70 by Albert Astals Cid: (Compile++) change: edit part.h JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 24/26 (92%)FILES 140/274 (51%)CLASSES 140/274 (51%)LINE 12582/38848 (32%)CONDITIONAL 5544/25499 (22%) By packagesFILES 5/5 (100%)CLASSES 5/5 (100%)LINE 886/1669 (53%)CONDITIONAL 410/1177 (35%) autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1733/1753 (99%)CONDITIONAL 946/1772 (53%) conf FILES 1/17 (6%)CLASSES 1/17 (6%)LINE 54/835 (6%)CONDITIONAL 2/284 (1%) conf.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 17/17 (100%)CONDITIONAL 7/14 (50%) core FILES 41/48 (85%)CLASSES 41/48 (85%)LINE 4369/9238 (47%)CONDITIONAL 2016/5893 (34%) core.script FILES 0/9 (0%)CLASSES 0/9 (0%)LINE 0/497 (0%)CONDITIONAL 0/220 (0%) generators.comicbook FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 10/415 (2%)CONDITIONAL 0/424 (0%) generators.djvu FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 26/828 (3%)CONDITIONAL 3/572 (1%) generators.dvi FILES 1/47 (2%)CLASSES 1/47 (2%)LINE 10/3577 (0%)CONDITIONAL 1/2375 (0%) generators.epub FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 180/328 (55%)CONDITIONAL 78/185 (42%) generators.fax FILES 1/6 (17%)CLASSES 1/6 (17%)LINE 7/437 (2%)CONDITIONAL 0/589 (0%) generators.fictionbook FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 16/533 (3%)CONDITIONAL 4/432 (1%) generators.kimgio FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 41/66 (62%)CONDITIONAL 7/20 (35%) generators.kimgio.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 48/48 (100%)CONDITIONAL 23/50 (46%) generators.mobipocket FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 13/117 (11%)CONDITIONAL 2/116 (2%) generators.ooo FILES 3/11 (27%)CLASSES 3/11 (27%)LINE 14/1172 (1%)CONDITIONAL 3/669 (0%) generators.plucker FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 4/100 (4%)CONDITIONAL 0/40 (0%) generators.plucker.unpluck FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/1614 (0%)CONDITIONAL 0/871 (0%) generators.poppler FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 614/1204 (51%)CONDITIONAL 250/681 (37%) generators.spectre FILES 2/5 (40%)CLASSES 2/5 (40%)LINE 24/219 (11%)CONDITIONAL 3/121 (2%) generators.tiff FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 10/219 (5%)CONDITIONAL 0/121 (0%) generators.txt FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 13/48 (27%)CONDITIONAL 2/30 (7%) generators.xps FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 10/1258 (1%)CONDITIONAL 1/1213 (0%) interfaces FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 12/13 (92%)CONDITIONAL 8/16 (50%) shell FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 400/564 (71%)CONDITIONAL 225/424 (53%) ui FILES 37/57 (65%)CLASSES 37/57 (65%)LINE 4071/12079 (34%)CONDITIONAL 1553/7190 (22%)
Jenkins-kde-ci: okular master kf5-qt5 » Linux,gcc - Build # 124 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/okular%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/124/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 23 Mar 2017 00:35:02 + Build duration: 3 min 35 sec CHANGE SET Revision 3672c3222f8ccb54371a0191c6e709a199fe8c70 by Albert Astals Cid: (Compile++) change: edit part.h JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 24/26 (92%)FILES 140/274 (51%)CLASSES 140/274 (51%)LINE 12582/38848 (32%)CONDITIONAL 5544/25499 (22%) By packagesFILES 5/5 (100%)CLASSES 5/5 (100%)LINE 886/1669 (53%)CONDITIONAL 410/1177 (35%) autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1733/1753 (99%)CONDITIONAL 946/1772 (53%) conf FILES 1/17 (6%)CLASSES 1/17 (6%)LINE 54/835 (6%)CONDITIONAL 2/284 (1%) conf.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 17/17 (100%)CONDITIONAL 7/14 (50%) core FILES 41/48 (85%)CLASSES 41/48 (85%)LINE 4369/9238 (47%)CONDITIONAL 2016/5893 (34%) core.script FILES 0/9 (0%)CLASSES 0/9 (0%)LINE 0/497 (0%)CONDITIONAL 0/220 (0%) generators.comicbook FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 10/415 (2%)CONDITIONAL 0/424 (0%) generators.djvu FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 26/828 (3%)CONDITIONAL 3/572 (1%) generators.dvi FILES 1/47 (2%)CLASSES 1/47 (2%)LINE 10/3577 (0%)CONDITIONAL 1/2375 (0%) generators.epub FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 180/328 (55%)CONDITIONAL 78/185 (42%) generators.fax FILES 1/6 (17%)CLASSES 1/6 (17%)LINE 7/437 (2%)CONDITIONAL 0/589 (0%) generators.fictionbook FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 16/533 (3%)CONDITIONAL 4/432 (1%) generators.kimgio FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 41/66 (62%)CONDITIONAL 7/20 (35%) generators.kimgio.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 48/48 (100%)CONDITIONAL 23/50 (46%) generators.mobipocket FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 13/117 (11%)CONDITIONAL 2/116 (2%) generators.ooo FILES 3/11 (27%)CLASSES 3/11 (27%)LINE 14/1172 (1%)CONDITIONAL 3/669 (0%) generators.plucker FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 4/100 (4%)CONDITIONAL 0/40 (0%) generators.plucker.unpluck FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/1614 (0%)CONDITIONAL 0/871 (0%) generators.poppler FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 614/1204 (51%)CONDITIONAL 250/681 (37%) generators.spectre FILES 2/5 (40%)CLASSES 2/5 (40%)LINE 24/219 (11%)CONDITIONAL 3/121 (2%) generators.tiff FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 10/219 (5%)CONDITIONAL 0/121 (0%) generators.txt FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 13/48 (27%)CONDITIONAL 2/30 (7%) generators.xps FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 10/1258 (1%)CONDITIONAL 1/1213 (0%) interfaces FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 12/13 (92%)CONDITIONAL 8/16 (50%) shell FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 400/564 (71%)CONDITIONAL 225/424 (53%) ui FILES 37/57 (65%)CLASSES 37/57 (65%)LINE 4071/12079 (34%)CONDITIONAL 1553/7190 (22%)
Jenkins-kde-ci: okular Applications-17.04 stable-kf5-qt5 » Linux,gcc - Build # 6 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/okular%20Applications-17.04%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/6/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 23 Mar 2017 00:34:42 + Build duration: 16 min CHANGE SET Revision 3672c3222f8ccb54371a0191c6e709a199fe8c70 by Albert Astals Cid: (Compile++) change: edit part.h JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 24/26 (92%)FILES 140/274 (51%)CLASSES 140/274 (51%)LINE 12588/38845 (32%)CONDITIONAL 5550/25497 (22%) By packagesFILES 5/5 (100%)CLASSES 5/5 (100%)LINE 886/1669 (53%)CONDITIONAL 410/1177 (35%) autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1733/1753 (99%)CONDITIONAL 948/1772 (53%) conf FILES 1/17 (6%)CLASSES 1/17 (6%)LINE 54/835 (6%)CONDITIONAL 2/284 (1%) conf.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 17/17 (100%)CONDITIONAL 7/14 (50%) core FILES 41/48 (85%)CLASSES 41/48 (85%)LINE 4361/9238 (47%)CONDITIONAL 2013/5893 (34%) core.script FILES 0/9 (0%)CLASSES 0/9 (0%)LINE 0/497 (0%)CONDITIONAL 0/220 (0%) generators.comicbook FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 10/415 (2%)CONDITIONAL 0/424 (0%) generators.djvu FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 26/828 (3%)CONDITIONAL 3/572 (1%) generators.dvi FILES 1/47 (2%)CLASSES 1/47 (2%)LINE 10/3577 (0%)CONDITIONAL 1/2375 (0%) generators.epub FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 180/328 (55%)CONDITIONAL 78/185 (42%) generators.fax FILES 1/6 (17%)CLASSES 1/6 (17%)LINE 7/437 (2%)CONDITIONAL 0/589 (0%) generators.fictionbook FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 16/533 (3%)CONDITIONAL 4/432 (1%) generators.kimgio FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 41/66 (62%)CONDITIONAL 7/20 (35%) generators.kimgio.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 48/48 (100%)CONDITIONAL 23/50 (46%) generators.mobipocket FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 13/117 (11%)CONDITIONAL 2/116 (2%) generators.ooo FILES 3/11 (27%)CLASSES 3/11 (27%)LINE 14/1172 (1%)CONDITIONAL 2/669 (0%) generators.plucker FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 4/100 (4%)CONDITIONAL 0/40 (0%) generators.plucker.unpluck FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/1614 (0%)CONDITIONAL 0/871 (0%) generators.poppler FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 614/1201 (51%)CONDITIONAL 250/679 (37%) generators.spectre FILES 2/5 (40%)CLASSES 2/5 (40%)LINE 24/219 (11%)CONDITIONAL 3/121 (2%) generators.tiff FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 10/219 (5%)CONDITIONAL 0/121 (0%) generators.txt FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 13/48 (27%)CONDITIONAL 2/30 (7%) generators.xps FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 10/1258 (1%)CONDITIONAL 1/1213 (0%) interfaces FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 12/13 (92%)CONDITIONAL 8/16 (50%) shell FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 400/564 (71%)CONDITIONAL 225/424 (53%) ui FILES 37/57 (65%)CLASSES 37/57 (65%)LINE 4085/12079 (34%)CONDITIONAL 1561/7190 (22%)
Jenkins-kde-ci: okular Applications-17.04 stable-kf5-qt5 » Linux,gcc - Build # 6 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/okular%20Applications-17.04%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/6/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 23 Mar 2017 00:34:42 + Build duration: 16 min CHANGE SET Revision 3672c3222f8ccb54371a0191c6e709a199fe8c70 by Albert Astals Cid: (Compile++) change: edit part.h JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 24/26 (92%)FILES 140/274 (51%)CLASSES 140/274 (51%)LINE 12588/38845 (32%)CONDITIONAL 5550/25497 (22%) By packagesFILES 5/5 (100%)CLASSES 5/5 (100%)LINE 886/1669 (53%)CONDITIONAL 410/1177 (35%) autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1733/1753 (99%)CONDITIONAL 948/1772 (53%) conf FILES 1/17 (6%)CLASSES 1/17 (6%)LINE 54/835 (6%)CONDITIONAL 2/284 (1%) conf.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 17/17 (100%)CONDITIONAL 7/14 (50%) core FILES 41/48 (85%)CLASSES 41/48 (85%)LINE 4361/9238 (47%)CONDITIONAL 2013/5893 (34%) core.script FILES 0/9 (0%)CLASSES 0/9 (0%)LINE 0/497 (0%)CONDITIONAL 0/220 (0%) generators.comicbook FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 10/415 (2%)CONDITIONAL 0/424 (0%) generators.djvu FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 26/828 (3%)CONDITIONAL 3/572 (1%) generators.dvi FILES 1/47 (2%)CLASSES 1/47 (2%)LINE 10/3577 (0%)CONDITIONAL 1/2375 (0%) generators.epub FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 180/328 (55%)CONDITIONAL 78/185 (42%) generators.fax FILES 1/6 (17%)CLASSES 1/6 (17%)LINE 7/437 (2%)CONDITIONAL 0/589 (0%) generators.fictionbook FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 16/533 (3%)CONDITIONAL 4/432 (1%) generators.kimgio FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 41/66 (62%)CONDITIONAL 7/20 (35%) generators.kimgio.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 48/48 (100%)CONDITIONAL 23/50 (46%) generators.mobipocket FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 13/117 (11%)CONDITIONAL 2/116 (2%) generators.ooo FILES 3/11 (27%)CLASSES 3/11 (27%)LINE 14/1172 (1%)CONDITIONAL 2/669 (0%) generators.plucker FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 4/100 (4%)CONDITIONAL 0/40 (0%) generators.plucker.unpluck FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/1614 (0%)CONDITIONAL 0/871 (0%) generators.poppler FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 614/1201 (51%)CONDITIONAL 250/679 (37%) generators.spectre FILES 2/5 (40%)CLASSES 2/5 (40%)LINE 24/219 (11%)CONDITIONAL 3/121 (2%) generators.tiff FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 10/219 (5%)CONDITIONAL 0/121 (0%) generators.txt FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 13/48 (27%)CONDITIONAL 2/30 (7%) generators.xps FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 10/1258 (1%)CONDITIONAL 1/1213 (0%) interfaces FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 12/13 (92%)CONDITIONAL 8/16 (50%) shell FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 400/564 (71%)CONDITIONAL 225/424 (53%) ui FILES 37/57 (65%)CLASSES 37/57 (65%)LINE 4085/12079 (34%)CONDITIONAL 1561/7190 (22%)
Re: Review Request 130043: Remove method FilePrinter::psPaperSize
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130043/ --- (Updated March 23, 2017, 5:33 a.m.) Review request for Okular. Changes --- Keep the method, but simplify it by using QPageSize. Repository: okular Description --- I was about to simplify the method FilePrinter::psPaperSize in the file fileprinter.cpp. As it turned out, this method is never called anywhere anyway. So this patch removes it. Diffs (updated) - core/fileprinter.cpp a27529e7 Diff: https://git.reviewboard.kde.org/r/130043/diff/ Testing --- Grepping for the method name doesn't return anything. Code still builds without the method. Thanks, Oliver Sander
Re: Review Request 130043: Remove method FilePrinter::psPaperSize
> On March 22, 2017, 10:55 p.m., Albert Astals Cid wrote: > > This is not binary compatible (i.e. it removes a symbol from a publicly > > installed header). > > > > It should have been removed when we moved to KF5, but since it wasn't if > > there's no other reason that "we don't use it" I would prefer to keep it > > until we have some other forced binary compatibility break. Okay. So here is a new page that at least gets rid of that long list of hard-coded paper sizes. I know it is silly to clean up a method that is not used anyway; I am mainly improving my Qt skills. :-) Feel free to discard the patch. - Oliver --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130043/#review102934 --- On March 23, 2017, 5:33 a.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130043/ > --- > > (Updated March 23, 2017, 5:33 a.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > I was about to simplify the method FilePrinter::psPaperSize in the file > fileprinter.cpp. As it turned out, this method is never called anywhere > anyway. So this patch removes it. > > > Diffs > - > > core/fileprinter.cpp a27529e7 > > Diff: https://git.reviewboard.kde.org/r/130043/diff/ > > > Testing > --- > > Grepping for the method name doesn't return anything. > > Code still builds without the method. > > > Thanks, > > Oliver Sander > >
