Re: Review Request 129999: Allow to create bookmarks from the TOC

[Gilbert Assaf]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/12/
---

(Updated March 20, 2017, 3:37 p.m.)


Review request for Okular.


Changes
---

Ok I see your point. I rewrote my patch to use a right click context menu on 
the TOC items.


Bugs: 190203
http://bugs.kde.org/show_bug.cgi?id=190203


Repository: okular


Description
---

If a bookmark is created from the TOC view, the text of the selected TOC item 
text is automatically used. Otherwise the behavior stays unchanged.


Diffs (updated)
-

  part.h f4c50ab 
  part.cpp 198197a 
  ui/toc.h 5e7fe2a 
  ui/toc.cpp a205ad1 

Diff: https://git.reviewboard.kde.org/r/12/diff/


Testing
---


Thanks,

Gilbert Assaf

[okular] [Bug 377688] No output to print for PDF since update to 1.0.3

[Ian Newton]

https://bugs.kde.org/show_bug.cgi?id=377688

--- Comment #5 from Ian Newton  ---
DM200_UM_EN.pdf is the original and DM200_UM_EN_3.pdf is the re-saved version
from Libre Office

-- 
You are receiving this mail because:
You are the assignee for the bug.

Jenkins-kde-ci: okular Applications-17.04 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/okular%20Applications-17.04%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Mar 2017 22:21:48 +
Build duration: 4 min 34 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 
16 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 24/26 (92%)FILES 140/274 (51%)CLASSES 140/274 (51%)LINE 12591/38830 
(32%)CONDITIONAL 5550/25489 (22%)

By packages
  

FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 885/1660 
(53%)CONDITIONAL 410/1171 (35%)
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1733/1753 
(99%)CONDITIONAL 948/1772 (53%)
conf
FILES 1/17 (6%)CLASSES 1/17 (6%)LINE 54/835 (6%)CONDITIONAL 
2/284 (1%)
conf.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 17/17 (100%)CONDITIONAL 
7/14 (50%)
core
FILES 41/48 (85%)CLASSES 41/48 (85%)LINE 4361/9238 
(47%)CONDITIONAL 2013/5893 (34%)
core.script
FILES 0/9 (0%)CLASSES 0/9 (0%)LINE 0/497 (0%)CONDITIONAL 0/220 
(0%)
generators.comicbook
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 10/415 (2%)CONDITIONAL 
0/424 (0%)
generators.djvu
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 26/828 (3%)CONDITIONAL 
3/572 (1%)
generators.dvi
FILES 1/47 (2%)CLASSES 1/47 (2%)LINE 10/3577 (0%)CONDITIONAL 
1/2375 (0%)
generators.epub
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 180/328 (55%)CONDITIONAL 
78/185 (42%)
generators.fax
FILES 1/6 (17%)CLASSES 1/6 (17%)LINE 7/437 (2%)CONDITIONAL 
0/589 (0%)
generators.fictionbook
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 16/533 (3%)CONDITIONAL 
4/432 (1%)
generators.kimgio
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 41/66 (62%)CONDITIONAL 
7/20 (35%)
generators.kimgio.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 48/48 (100%)CONDITIONAL 
23/50 (46%)
generators.mobipocket
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 13/117 (11%)CONDITIONAL 
2/116 (2%)
generators.ooo
FILES 3/11 (27%)CLASSES 3/11 (27%)LINE 14/1172 (1%)CONDITIONAL 
3/669 (0%)
generators.plucker
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 4/100 (4%)CONDITIONAL 
0/40 (0%)
generators.plucker.unpluck
FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/1614 (0%)CONDITIONAL 0/871 
(0%)
generators.poppler
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 614/1201 (51%)CONDITIONAL 
250/679 (37%)
generators.spectre
FILES 2/5 (40%)CLASSES 2/5 (40%)LINE 24/219 (11%)CONDITIONAL 
3/121 (2%)
generators.tiff
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 10/219 (5%)CONDITIONAL 
0/121 (0%)
generators.txt
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 13/48 (27%)CONDITIONAL 
2/30 (7%)
generators.xps
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 10/1258 (1%)CONDITIONAL 
1/1213 (0%)
interfaces
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 12/13 (92%)CONDITIONAL 
8/16 (50%)
shell
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 400/564 (71%)CONDITIONAL 
225/424 (53%)
ui
FILES 37/57 (65%)CLASSES 37/57 (65%)LINE 4089/12073 
(34%)CONDITIONAL 1560/7188 (22%)