PDFium plugin

2017-01-17 Thread Gilbert Assaf

Hi all,

 

I worked on an okular pdf plugin using pdfium as a backend. At this point it is little more than a “proof-of-concept”. But you can already view simple pdf files.  


I would like to get some feedback on this: maybe somebody else is already working on an okular pdfium plugin? I am relatively new to KDE and don’t know all the development processes.
How do you normally proceed from here on? Reviewboard? A personal branch?

 

I attached a git patch file, if somebody would like to try it out.


A small warning: pdfium only works on x64 and at this point it is basically a mixture of static and shared libraries. So you definitely have to compile it yourself.

 

Thanks,
Gilbert


=== Install depot tools ===
Needed for fetching and building pdfium
See instructions:
https://www.chromium.org/developers/how-tos/install-depot-tools

 

=== Install pdfium ===
mkdir repo
cd repo
gclient config --unmanaged https://pdfium.googlesource.com/pdfium.git
gclient sync
cd pdfium
export PDFIUM_DIR=`pwd`
gn gen out/Debug --args="pdf_enable_xfa=false pdf_enable_v8=true use_sysroot=false is_debug=true"
ninja -C out/Debug pdfium


=== Compile Okular ===
cd 
cmake .. -DPDFIUM_ROOT_DIR=$PDFIUM_DIR

You probably have to add $PDFIUM_DIR dir to your LD_LIBRARY_PATH variable


pdfium.tar.gz
Description: Binary data


Re: PDFium plugin

2017-01-17 Thread Albert Astals Cid
El dimarts, 17 de gener de 2017, a les 17:30:29 CET, Gilbert Assaf va 
escriure:
> Hi all,

Hi
 
> I worked on an okular pdf plugin using pdfium as a backend. At this point it
> is little more than a “proof-of-concept”. But you can already view simple
> pdf files.  
> 
> I would like to get some feedback on this: maybe somebody else is already
> working on an okular pdfium plugin? I am relatively new to KDE and don’t
> know all the development processes. How do you normally proceed from here
> on? Reviewboard? A personal branch? 

I guess you can create a pdfium_generator branch or something in okular.

> I attached a git patch file, if somebody would like to try it out.
> 
> A small warning: pdfium only works on x64 and at this point it is basically
> a mixture of static and shared libraries. So you definitely have to compile
> it yourself. 

Doesn't seem very "user friendly" :/

Cheers,
  Albert

> Thanks,
> Gilbert
> 
> === Install depot tools ===
> Needed for fetching and building pdfium
> See instructions:
> https://www.chromium.org/developers/how-tos/install-depot-tools
>  
> === Install pdfium ===
> mkdir repo
> cd repo
> gclient config --unmanaged https://pdfium.googlesource.com/pdfium.git
> gclient sync
> cd pdfium
> export PDFIUM_DIR=`pwd`
> gn gen out/Debug --args="pdf_enable_xfa=false pdf_enable_v8=true
> use_sysroot=false is_debug=true" ninja -C out/Debug pdfium
> 
> === Compile Okular ===
> cd 
> cmake .. -DPDFIUM_ROOT_DIR=$PDFIUM_DIR
> You probably have to add $PDFIUM_DIR dir to your LD_LIBRARY_PATH variable




Re: PDFium plugin

2017-01-17 Thread Jonathan Schultz
Looks interesting. How does it compare (performance, features, etc.) 
with the Poppler plugin?


Any chance you could save us the bother of building ourselves and post a 
link to an executable?


Cheers,
Jonathan

On 18/01/17 03:30, Gilbert Assaf wrote:

Hi all,

I worked on an okular pdf plugin using pdfium as a backend. At this
point it is little more than a “proof-of-concept”. But you can already
view simple pdf files.

I would like to get some feedback on this: maybe somebody else is
already working on an okular pdfium plugin? I am relatively new to KDE
and don’t know all the development processes.
How do you normally proceed from here on? Reviewboard? A personal branch?

I attached a git patch file, if somebody would like to try it out.

A small warning: pdfium only works on x64 and at this point it is
basically a mixture of static and shared libraries. So you definitely
have to compile it yourself.

Thanks,
Gilbert

=== Install depot tools ===
Needed for fetching and building pdfium
See instructions:
https://www.chromium.org/developers/how-tos/install-depot-tools

=== Install pdfium ===
mkdir repo
cd repo
gclient config --unmanaged https://pdfium.googlesource.com/pdfium.git
gclient sync
cd pdfium
export PDFIUM_DIR=`pwd`
gn gen out/Debug --args="pdf_enable_xfa=false pdf_enable_v8=true
use_sysroot=false is_debug=true"
ninja -C out/Debug pdfium

=== Compile Okular ===
cd 
cmake .. -DPDFIUM_ROOT_DIR=$PDFIUM_DIR
You probably have to add $PDFIUM_DIR dir to your LD_LIBRARY_PATH variable




Re: PDFium plugin

2017-01-17 Thread Luigi Toscano
Albert Astals Cid ha scritto:
> El dimarts, 17 de gener de 2017, a les 17:30:29 CET, Gilbert Assaf va 
> escriure:
>> Hi all,
> 
> Hi
>  
>> I worked on an okular pdf plugin using pdfium as a backend. At this point it
>> is little more than a “proof-of-concept”. But you can already view simple
>> pdf files.  
>>
>> I would like to get some feedback on this: maybe somebody else is already
>> working on an okular pdfium plugin? I am relatively new to KDE and don’t
>> know all the development processes. How do you normally proceed from here
>> on? Reviewboard? A personal branch? 
> 
> I guess you can create a pdfium_generator branch or something in okular.

Or you can create a separate git repository. We have examples of plugins that
can be compiled as standalone, both in svn (but think about their root
directories as independent):
https://websvn.kde.org/trunk/playground/graphics/okular/
and in git (calligra):

https://commits.kde.org/calligra?path=extras/okularodpgenerator
https://commits.kde.org/calligra?path=extras/okularodtgenerator

> 
>> I attached a git patch file, if somebody would like to try it out.
>>
>> A small warning: pdfium only works on x64 and at this point it is basically
>> a mixture of static and shared libraries. So you definitely have to compile
>> it yourself. 
> 
> Doesn't seem very "user friendly" :/

That's bad indeed; if all libraries can be made static that would be good. But
the limitation on the architectures is a bit strong.


-- 
Luigi


[okular] [Bug 336192] Enable support for pdfium and favor it to poppler

2017-01-17 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=336192

--- Comment #6 from Christoph Feck  ---
For help, please ask in KDE developer forums, irc channels, or mailing lists.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 336192] Enable support for pdfium and favor it to poppler

2017-01-17 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=336192

--- Comment #7 from Christoph Feck  ---
Oh, pardon, I did read comment #5 incorrectly. I suggest to create a separate
Okular backend, instead of modifiying the existing PDF backend. This way we can
evaluate them both in parallel to see which is better in the long run.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375211] New: Table Select tool fails on large table

2017-01-17 Thread Mark Whitis
https://bugs.kde.org/show_bug.cgi?id=375211

Bug ID: 375211
   Summary: Table Select tool fails on large table
   Product: okular
   Version: 0.20.3
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: mark.whi...@gmail.com
  Target Milestone: ---

Table select tool fails to automatically identify rows and columns on a simple
table layout with large amounts of data.
http://www.qsl.net/sterling/VA_QSO_Party/2016_VQP/2016_VQP_MetaData.pdf
approx 22 columns
approx 180 rows per page
approx 414 total rows
3 pages

This requires over 500 near pixel accurate mouse clicks to convert.
This site has similar files for each year.
The following file is a bit more difficult as it is missing lines except on the
column heads on the first page.  okular finds the rows ok but not the columns.
http://www.qsl.net/sterling/VA_QSO_Party/2009_VQP/2009_VQP_MetaData.pdf

This is the latest version of okular packaged for this long term support
release of ubuntu.
Qt: 4.8.6
KDE Development Platform: 4.13.3
Okular: 0.19.3
Distributor ID: Ubuntu
Description:Ubuntu 14.04.4 LTS
Release:14.04
Codename:   trusty

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: PDFium plugin

2017-01-17 Thread Jonathan Schultz
Please excuse the silly comment about providing an executable - I see 
that you said that we'd have to build it ourselves.


So I just tried building, got most of the way without a hitch. I had to 
also use ninja build libfx_lpng.a and libfx_freetype.a to satisfy the 
dependencies in the okular Makefile. But once that was done it seems to 
work. I wasn't too sure that it was actually using pdfium, but when I 
moved the poppler generator out of the way I could see that it is 
working. Some small differences in appearance... So at least it works as 
a proof-of-concept...


On 18/01/17 10:14, Jonathan Schultz wrote:

Looks interesting. How does it compare (performance, features, etc.)
with the Poppler plugin?

Any chance you could save us the bother of building ourselves and post a
link to an executable?

Cheers,
Jonathan

On 18/01/17 03:30, Gilbert Assaf wrote:

Hi all,

I worked on an okular pdf plugin using pdfium as a backend. At this
point it is little more than a “proof-of-concept”. But you can already
view simple pdf files.

I would like to get some feedback on this: maybe somebody else is
already working on an okular pdfium plugin? I am relatively new to KDE
and don’t know all the development processes.
How do you normally proceed from here on? Reviewboard? A personal branch?

I attached a git patch file, if somebody would like to try it out.

A small warning: pdfium only works on x64 and at this point it is
basically a mixture of static and shared libraries. So you definitely
have to compile it yourself.

Thanks,
Gilbert

=== Install depot tools ===
Needed for fetching and building pdfium
See instructions:
https://www.chromium.org/developers/how-tos/install-depot-tools

=== Install pdfium ===
mkdir repo
cd repo
gclient config --unmanaged https://pdfium.googlesource.com/pdfium.git
gclient sync
cd pdfium
export PDFIUM_DIR=`pwd`
gn gen out/Debug --args="pdf_enable_xfa=false pdf_enable_v8=true
use_sysroot=false is_debug=true"
ninja -C out/Debug pdfium

=== Compile Okular ===
cd 
cmake .. -DPDFIUM_ROOT_DIR=$PDFIUM_DIR
You probably have to add $PDFIUM_DIR dir to your LD_LIBRARY_PATH variable