Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen

2016-10-02 Thread Martin Tobias Holmedahl Sandsmark

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128858/#review99709
---



maybe try with installEventFilter(qApp) in the presentation widget, override 
eventFilter() and check for the tablet events in PresentationWidget and call 
setCursor(Qt::BlankCursor) and unsetCursor().

you could also call setOverrideCursor() and unsetOverrideCursor() in your 
custom QApplication, but then it's tricky to track when the presentation widget 
is used and I'd prefer not having a new application class just for this.

- Martin Tobias Holmedahl Sandsmark


On Sept. 7, 2016, 8:18 p.m., Oliver Sander wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128858/
> ---
> 
> (Updated Sept. 7, 2016, 8:18 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> I am trying to fix the following papercut:  I regularly write on pdf files in 
> presentation mode, using the pen that comes with my Lenovo ThinkPad Yoga.  
> When I approach the screen with the pen, the cursor appears, and it follows 
> the pen tip during writing.  When I lift off the pen, the cursor stays on, 
> and auto-hides only a few seconds later (because of 
> Okular::Settings::EnumSlidesCursor::HiddenDelay).  As a consequence, the 
> cursor frequently hides the last bits of what I have just written.  This is a 
> nuisance, because I do this in front of an audience, and a lot of it is math 
> (where every detail matters).
> 
> Ideally, the cursor would auto-hide when I lift the pen off the screen.  
> Luckily, Qt has an event for this: QEvent::TabletLeaveProximity.  Unluckily, 
> the documentation says (http://doc.qt.io/qt-5/qtabletevent.html):
> 
> "TabletEnterProximity and TabletLeaveProximity events [...] are only sent to 
> QApplication"
> 
> Therefore, this patch introduces a new class TabletApplication, which 
> inherits from QApplication, and is used in main.cpp instead of QApplication.  
> The proximity events are really caught, and each time a short note is printed 
> on the console.
> 
> Unfortunately, at this point I am stuck and need some help.  Apparently, I 
> cannot control the cursor from a QApplication.  How do I get the information 
> that a TabletProximity has been caught to the presentation widget? Maybe the 
> answer is trivial, but I have very little Qt programming experience.  Thanks 
> for your help!
> 
> 
> Diffs
> -
> 
>   shell/CMakeLists.txt 84cbf2d 
>   shell/main.cpp 856d2b0 
>   shell/tabletapplication.h PRE-CREATION 
>   shell/tabletapplication.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128858/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>



Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-10-02 Thread Martin Tobias Holmedahl Sandsmark

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128821/#review99710
---



I tried to test with pinching on my touchpad, but apparently Qt doesn't handle 
the gestures from libinput or something.


ui/pageview.cpp (line 1496)


you need to call QAbstractScrollArea::event(), not QWidget::event(), 
otherwise you get an infinite recursion when scrolling.


- Martin Tobias Holmedahl Sandsmark


On Sept. 4, 2016, 7:48 p.m., Oliver Sander wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128821/
> ---
> 
> (Updated Sept. 4, 2016, 7:48 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 366781
> http://bugs.kde.org/show_bug.cgi?id=366781
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> The attached patch implements document zoom controlled by a two-finger pinch 
> gesture on a touch screen.
> 
> The actual zooming was done by copy'n'paste, I don't understand the full 
> details of how zooming works in okular, yet.  So a bit of review would be 
> appreciated.
> 
> 
> Diffs
> -
> 
>   ui/pageview.h 01c39bf 
>   ui/pageview.cpp cd53407 
> 
> Diff: https://git.reviewboard.kde.org/r/128821/diff/
> 
> 
> Testing
> ---
> 
> I tested it on my Lenovo Thinkpad Yoga, and it works nicely there.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>



Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-10-02 Thread Oliver Sander

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128821/
---

(Updated Okt. 2, 2016, 6:42 nachm.)


Review request for Okular.


Changes
---

Call QAbstractScrollArea::event instead of QWidget::event


Bugs: 366781
http://bugs.kde.org/show_bug.cgi?id=366781


Repository: okular


Description
---

The attached patch implements document zoom controlled by a two-finger pinch 
gesture on a touch screen.

The actual zooming was done by copy'n'paste, I don't understand the full 
details of how zooming works in okular, yet.  So a bit of review would be 
appreciated.


Diffs (updated)
-

  ui/pageview.h 7c43f51 
  ui/pageview.cpp 5fbabb2 

Diff: https://git.reviewboard.kde.org/r/128821/diff/


Testing
---

I tested it on my Lenovo Thinkpad Yoga, and it works nicely there.


Thanks,

Oliver Sander



Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-10-02 Thread Oliver Sander


> On Okt. 2, 2016, 12:54 nachm., Martin Tobias Holmedahl Sandsmark wrote:
> > I tried to test with pinching on my touchpad, but apparently Qt doesn't 
> > handle the gestures from libinput or something.

Touchpad pinching does not work for me, either.  Would you expect that to work 
with my patch?  Or is some extra code needed?


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128821/#review99710
---


On Sept. 4, 2016, 7:48 nachm., Oliver Sander wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128821/
> ---
> 
> (Updated Sept. 4, 2016, 7:48 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 366781
> http://bugs.kde.org/show_bug.cgi?id=366781
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> The attached patch implements document zoom controlled by a two-finger pinch 
> gesture on a touch screen.
> 
> The actual zooming was done by copy'n'paste, I don't understand the full 
> details of how zooming works in okular, yet.  So a bit of review would be 
> appreciated.
> 
> 
> Diffs
> -
> 
>   ui/pageview.h 01c39bf 
>   ui/pageview.cpp cd53407 
> 
> Diff: https://git.reviewboard.kde.org/r/128821/diff/
> 
> 
> Testing
> ---
> 
> I tested it on my Lenovo Thinkpad Yoga, and it works nicely there.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>



Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-10-02 Thread Martin Tobias Holmedahl Sandsmark

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128821/#review99717
---


Ship it!




Ship It!

- Martin Tobias Holmedahl Sandsmark


On Oct. 2, 2016, 6:42 p.m., Oliver Sander wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128821/
> ---
> 
> (Updated Oct. 2, 2016, 6:42 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 366781
> http://bugs.kde.org/show_bug.cgi?id=366781
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> The attached patch implements document zoom controlled by a two-finger pinch 
> gesture on a touch screen.
> 
> The actual zooming was done by copy'n'paste, I don't understand the full 
> details of how zooming works in okular, yet.  So a bit of review would be 
> appreciated.
> 
> 
> Diffs
> -
> 
>   ui/pageview.h 7c43f51 
>   ui/pageview.cpp 5fbabb2 
> 
> Diff: https://git.reviewboard.kde.org/r/128821/diff/
> 
> 
> Testing
> ---
> 
> I tested it on my Lenovo Thinkpad Yoga, and it works nicely there.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>



Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-10-02 Thread Martin Tobias Holmedahl Sandsmark


> On Oct. 2, 2016, 12:54 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > I tried to test with pinching on my touchpad, but apparently Qt doesn't 
> > handle the gestures from libinput or something.
> 
> Oliver Sander wrote:
> Touchpad pinching does not work for me, either.  Would you expect that to 
> work with my patch?  Or is some extra code needed?

it needs a patch in qt (I started on it here: http://ix.io/1sta).


- Martin Tobias Holmedahl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128821/#review99710
---


On Oct. 2, 2016, 6:42 p.m., Oliver Sander wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128821/
> ---
> 
> (Updated Oct. 2, 2016, 6:42 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 366781
> http://bugs.kde.org/show_bug.cgi?id=366781
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> The attached patch implements document zoom controlled by a two-finger pinch 
> gesture on a touch screen.
> 
> The actual zooming was done by copy'n'paste, I don't understand the full 
> details of how zooming works in okular, yet.  So a bit of review would be 
> appreciated.
> 
> 
> Diffs
> -
> 
>   ui/pageview.h 7c43f51 
>   ui/pageview.cpp 5fbabb2 
> 
> Diff: https://git.reviewboard.kde.org/r/128821/diff/
> 
> 
> Testing
> ---
> 
> I tested it on my Lenovo Thinkpad Yoga, and it works nicely there.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>



Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-10-02 Thread Oliver Sander


> On Okt. 2, 2016, 12:54 nachm., Martin Tobias Holmedahl Sandsmark wrote:
> > I tried to test with pinching on my touchpad, but apparently Qt doesn't 
> > handle the gestures from libinput or something.
> 
> Oliver Sander wrote:
> Touchpad pinching does not work for me, either.  Would you expect that to 
> work with my patch?  Or is some extra code needed?
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> it needs a patch in qt (I started on it here: http://ix.io/1sta).

Very nice.  All the best with it!


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128821/#review99710
---


On Okt. 2, 2016, 6:42 nachm., Oliver Sander wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128821/
> ---
> 
> (Updated Okt. 2, 2016, 6:42 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 366781
> http://bugs.kde.org/show_bug.cgi?id=366781
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> The attached patch implements document zoom controlled by a two-finger pinch 
> gesture on a touch screen.
> 
> The actual zooming was done by copy'n'paste, I don't understand the full 
> details of how zooming works in okular, yet.  So a bit of review would be 
> appreciated.
> 
> 
> Diffs
> -
> 
>   ui/pageview.h 7c43f51 
>   ui/pageview.cpp 5fbabb2 
> 
> Diff: https://git.reviewboard.kde.org/r/128821/diff/
> 
> 
> Testing
> ---
> 
> I tested it on my Lenovo Thinkpad Yoga, and it works nicely there.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>



Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-10-02 Thread Oliver Sander


> On Okt. 2, 2016, 8:02 nachm., Martin Tobias Holmedahl Sandsmark wrote:
> > Ship It!

My usual request: please ship it for me, I don't have commit rights.  

And thanks for your review!


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128821/#review99717
---


On Okt. 2, 2016, 6:42 nachm., Oliver Sander wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128821/
> ---
> 
> (Updated Okt. 2, 2016, 6:42 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 366781
> http://bugs.kde.org/show_bug.cgi?id=366781
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> The attached patch implements document zoom controlled by a two-finger pinch 
> gesture on a touch screen.
> 
> The actual zooming was done by copy'n'paste, I don't understand the full 
> details of how zooming works in okular, yet.  So a bit of review would be 
> appreciated.
> 
> 
> Diffs
> -
> 
>   ui/pageview.h 7c43f51 
>   ui/pageview.cpp 5fbabb2 
> 
> Diff: https://git.reviewboard.kde.org/r/128821/diff/
> 
> 
> Testing
> ---
> 
> I tested it on my Lenovo Thinkpad Yoga, and it works nicely there.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>



Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen

2016-10-02 Thread Albert Astals Cid


> On Oct. 2, 2016, 12:33 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > maybe try with installEventFilter(qApp) in the presentation widget, 
> > override eventFilter() and check for the tablet events in 
> > PresentationWidget and call setCursor(Qt::BlankCursor) and unsetCursor().
> > 
> > you could also call setOverrideCursor() and unsetOverrideCursor() in your 
> > custom QApplication, but then it's tricky to track when the presentation 
> > widget is used and I'd prefer not having a new application class just for 
> > this.

What sandsmark says try installing an event filter, the syntax of what he 
suggested is wrong, what you want is not installEventFilter(qApp) but 
qApp->installEventFilter(this), with this being the presentationwidget.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128858/#review99709
---


On Sept. 7, 2016, 8:18 p.m., Oliver Sander wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128858/
> ---
> 
> (Updated Sept. 7, 2016, 8:18 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> I am trying to fix the following papercut:  I regularly write on pdf files in 
> presentation mode, using the pen that comes with my Lenovo ThinkPad Yoga.  
> When I approach the screen with the pen, the cursor appears, and it follows 
> the pen tip during writing.  When I lift off the pen, the cursor stays on, 
> and auto-hides only a few seconds later (because of 
> Okular::Settings::EnumSlidesCursor::HiddenDelay).  As a consequence, the 
> cursor frequently hides the last bits of what I have just written.  This is a 
> nuisance, because I do this in front of an audience, and a lot of it is math 
> (where every detail matters).
> 
> Ideally, the cursor would auto-hide when I lift the pen off the screen.  
> Luckily, Qt has an event for this: QEvent::TabletLeaveProximity.  Unluckily, 
> the documentation says (http://doc.qt.io/qt-5/qtabletevent.html):
> 
> "TabletEnterProximity and TabletLeaveProximity events [...] are only sent to 
> QApplication"
> 
> Therefore, this patch introduces a new class TabletApplication, which 
> inherits from QApplication, and is used in main.cpp instead of QApplication.  
> The proximity events are really caught, and each time a short note is printed 
> on the console.
> 
> Unfortunately, at this point I am stuck and need some help.  Apparently, I 
> cannot control the cursor from a QApplication.  How do I get the information 
> that a TabletProximity has been caught to the presentation widget? Maybe the 
> answer is trivial, but I have very little Qt programming experience.  Thanks 
> for your help!
> 
> 
> Diffs
> -
> 
>   shell/CMakeLists.txt 84cbf2d 
>   shell/main.cpp 856d2b0 
>   shell/tabletapplication.h PRE-CREATION 
>   shell/tabletapplication.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128858/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>



[frameworks-kxmlgui] [Bug 368414] Align vertical toolbar items

2016-10-02 Thread Albert Astals Cid via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368414

Albert Astals Cid  changed:

   What|Removed |Added

Product|okular  |frameworks-kxmlgui
  Component|general |general
   Assignee|okular-devel@kde.org|kdelibs-b...@kde.org
 CC||aa...@kde.org

--- Comment #2 from Albert Astals Cid  ---
Not an okular issue, i guess it'd be kxmlgui that decides how to display the
actions.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

2016-10-02 Thread Albert Astals Cid via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=362038

--- Comment #10 from Albert Astals Cid  ---
(In reply to Ahmed Hussein from comment #9)
> Thank you, I will wait.
> I ask that question at IRC yesterday and today and no answer :D

Maybe you can show the code you have? 

I could not understand the problem you have by reading your previous question.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 368398] crash when moving pop-up note beyond page border

2016-10-02 Thread Albert Astals Cid via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368398

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org

--- Comment #1 from Albert Astals Cid  ---
I can't find what commit fixed this, but with the current version of okular
(the one you're using is almost 2 years old) i can't move the note outside the
page, hence no crash.

If you upgrade to Okular >= 0.24.2 and it still crashes please reopen this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 368151] Use with Xvnc and Xrdp causes immediate crash.

2016-10-02 Thread Albert Astals Cid via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368151

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |WORKSFORME

--- Comment #1 from Albert Astals Cid  ---
You're using a very old version of okular and libkscreen. This has been fixed
since, as a stop gap measure you can try removing KSC_XRandR11.so, but that's
always a bit dangerous of course.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 368402] Okular doesn't support SetOCGState links

2016-10-02 Thread Albert Astals Cid via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368402

Albert Astals Cid  changed:

   What|Removed |Added

Summary|Okular doesn't support  |Okular doesn't support
   |interactive PDF 1.5 link|SetOCGState links
 CC||aa...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 369654] New: Okular can't open ComicBook CBR files

2016-10-02 Thread João Vidal da Silva via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=369654

Bug ID: 369654
   Summary: Okular can't open ComicBook CBR files
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Comicbook backend
  Assignee: okular-devel@kde.org
  Reporter: joao.vidal.si...@gmail.com

Okular 0.26.0
Okular doesn't open ComicBook CBR files, showing the message 'Unknown ComicBook
format'.
I run Manjaro and use the AUR 'rar' (from rarlab).
I can open CBZs.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 369654] Okular can't open ComicBook CBR files

2016-10-02 Thread Luigi Toscano via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=369654

Luigi Toscano  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED
 CC||luigi.tosc...@tiscali.it

--- Comment #1 from Luigi Toscano  ---


*** This bug has been marked as a duplicate of bug 369078 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 369078] okular cannot open a cbr comic file

2016-10-02 Thread Luigi Toscano via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=369078

Luigi Toscano  changed:

   What|Removed |Added

 CC||joao.vidal.si...@gmail.com

--- Comment #8 from Luigi Toscano  ---
*** Bug 369654 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.