Re: [PR] OAK-11284: Greedy Reuse of cluster IDs may lead to synchronous LastRe… [jackrabbit-oak]
reschke commented on PR #1877: URL: https://github.com/apache/jackrabbit-oak/pull/1877#issuecomment-2514383220 well, it's opt-in... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (jackrabbit-oak): Workflow run "Build" failed!
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user reschke (triggered by reschke). Head commit for run: cf4c063a63fbc3af3df8a1701ed5b7eab2c1a9e9 / Julian Reschke OAK-11292: Remove usage of Guava ImmutableMap.copyOf() (#1886) * OAK-11292: Remove usage of Guava ImmutableMap.copyOf() - oak-store-document * OAK-11292: Remove usage of Guava ImmutableMap.copyOf() - oak-core-spi * OAK-11292: Remove usage of Guava ImmutableMap.copyOf() - oak-exercise * OAK-11292: Remove usage of Guava ImmutableMap.copyOf() - oak-jcr * OAK-11292: Remove usage of Guava ImmutableMap.copyOf() - oak-store-composite * OAK-11292: Remove usage of Guava ImmutableMap.copyOf() - oak-lucene * OAK-11292: Remove usage of Guava ImmutableMap.copyOf() - oak-security-spi * OAK-11292: Remove usage of Guava ImmutableMap.copyOf() - oak-security-spi Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/12137765410 With regards, GitHub Actions via GitBox
Re: [PR] OAK-11284: Greedy Reuse of cluster IDs may lead to synchronous LastRe… [jackrabbit-oak]
stefan-egli commented on PR #1877: URL: https://github.com/apache/jackrabbit-oak/pull/1877#issuecomment-2514344026 right, so this needs to be rolled out with care -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-11284: Greedy Reuse of cluster IDs may lead to synchronous LastRe… [jackrabbit-oak]
reschke commented on PR #1877: URL: https://github.com/apache/jackrabbit-oak/pull/1877#issuecomment-2514324905 @stefan-egli - that sort of is the point. It allows the user to trade conservative use of clusterIds with shorter startup time (which, in our case, was seen at around 10min when the server had been crashed and stayed off for a longer period of time) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-11267 - Upgrade Azure SDK V8 to V12 for oak-blob-azure [jackrabbit-oak]
ierandra commented on code in PR #1861: URL: https://github.com/apache/jackrabbit-oak/pull/1861#discussion_r1867594027 ## oak-blob-cloud-azure/src/test/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/UtilsTest.java: ## Review Comment: There should be a `UtilsTest.java` and a `UtilsV8Test.java` for both implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-11267 - Upgrade Azure SDK V8 to V12 for oak-blob-azure [jackrabbit-oak]
ierandra commented on code in PR #1861: URL: https://github.com/apache/jackrabbit-oak/pull/1861#discussion_r1867635198 ## oak-blob-cloud-azure/src/test/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureBlobStoreBackendTest.java: ## Review Comment: There should be a `AzureBlobStoreBackendTest.java` and a `AzureBlobStoreBackendV8Test.java` for both implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-11267 - Upgrade Azure SDK V8 to V12 for oak-blob-azure [jackrabbit-oak]
ierandra commented on code in PR #1861: URL: https://github.com/apache/jackrabbit-oak/pull/1861#discussion_r1867635198 ## oak-blob-cloud-azure/src/test/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureBlobStoreBackendTest.java: ## Review Comment: There should be a `AzureBlobStoreBackendTest.java` and a `AzureBlobStoreBackendV8Test.java` for both implementation. ## oak-blob-cloud-azure/src/test/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/UtilsTest.java: ## Review Comment: There should be a `UtilsTest.java` and a `UtilsV8Test.java` for both implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-11247: Migrated groovy test files to Java [jackrabbit-oak]
anchela merged PR #1851: URL: https://github.com/apache/jackrabbit-oak/pull/1851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (jackrabbit-oak): Workflow run "maven in /oak-parent for org.apache.derby:derby - Update #926871042" failed!
The GitHub Actions job "maven in /oak-parent for org.apache.derby:derby - Update #926871042" on jackrabbit-oak.git has failed. Run started by GitHub user dependabot[bot] (triggered by dependabot[bot]). Head commit for run: 711d3fa38970d492dbcdff549f5f83acb6eea751 / Alejandro Moratinos OAK-11247: Migrated groovy test files to Java (#1851) * OAK-11247: Migrated groovy test files to Java * OAK-11247: Removed groovy file after rebase Removed gmavenplus plugin from pom Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/12142374006 With regards, GitHub Actions via GitBox
[GH] (jackrabbit-oak): Workflow run "maven in /oak-parent for com.h2database:h2 - Update #926871045" failed!
The GitHub Actions job "maven in /oak-parent for com.h2database:h2 - Update #926871045" on jackrabbit-oak.git has failed. Run started by GitHub user dependabot[bot] (triggered by dependabot[bot]). Head commit for run: 711d3fa38970d492dbcdff549f5f83acb6eea751 / Alejandro Moratinos OAK-11247: Migrated groovy test files to Java (#1851) * OAK-11247: Migrated groovy test files to Java * OAK-11247: Removed groovy file after rebase Removed gmavenplus plugin from pom Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/12142374131 With regards, GitHub Actions via GitBox
[GH] (jackrabbit-oak): Workflow run "Build" failed!
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user Amoratinos (triggered by anchela). Head commit for run: ea433c27b71082e8b9e06281d9c69ca9fc7fce5c / Alejandro Moratinos OAK-10466: Change anonymous evaluation Configuration check moved to be performed when the disable method is called Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/12083723871 With regards, GitHub Actions via GitBox
Re: [PR] OAK-10466: Allow to configure anonymous user disablement [jackrabbit-oak]
anchela commented on PR #1882: URL: https://github.com/apache/jackrabbit-oak/pull/1882#issuecomment-2514935191 @joerghoh , can you take another look to see if your concerns are addressed? ty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-11291 Tree store: speed up merging, and concurrent indexing [jackrabbit-oak]
thomasmueller merged PR #1885: URL: https://github.com/apache/jackrabbit-oak/pull/1885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (jackrabbit-oak): Workflow run "Build" failed!
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user nfsantos (triggered by nfsantos). Head commit for run: e91faba20a1e88005d8f7e61f1d89db903629478 / Nuno Santos Remove tracking and logging of MERGE_NODE_STORE timings, as these were always 0. Track total indexing time for publish reindexing. Code cleanups in IndexImporter class Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/12135798104 With regards, GitHub Actions via GitBox
Re: [PR] OAK-11292: Remove usage of Guava ImmutableMap.copyOf() [jackrabbit-oak]
reschke merged PR #1886: URL: https://github.com/apache/jackrabbit-oak/pull/1886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-11284: Greedy Reuse of cluster IDs may lead to synchronous LastRe… [jackrabbit-oak]
reschke commented on code in PR #1877:
URL: https://github.com/apache/jackrabbit-oak/pull/1877#discussion_r1867485915
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/LastRevRecoveryAgent.java:
##
@@ -268,6 +273,11 @@ public int recover(final Iterable suspects,
if (nodeInfo != null && nodeInfo.isActive()) {
deadline = nodeInfo.getLeaseEndTime() -
ClusterNodeInfo.DEFAULT_LEASE_FAILURE_MARGIN_MILLIS;
}
+long now = System.currentTimeMillis();
+if (Long.MAX_VALUE - SYNC_RECOVERY_TIMEOUT_MILLIS.get() > now) {
+deadline = Math.min(deadline, now +
SYNC_RECOVERY_TIMEOUT_MILLIS.get());
+log.info("Adjusted deadline for synchronous recovery. New
deadline is {}", SimpleDateFormat.getDateTimeInstance().format(new
Date(deadline)));
+}
Review Comment:
a) Should not use the default locale.
b) Maybe also log the previous deadline?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] OAK-11290 - Improve logging of publish indexing job (WIP) [jackrabbit-oak]
nfsantos opened a new pull request, #1887: URL: https://github.com/apache/jackrabbit-oak/pull/1887 - Remove tracking and logging of MERGE_NODE_STORE timings, as these were always 0. - Track total indexing time for publish reindexing. - Code cleanups in IndexImporter class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-11267 - Upgrade Azure SDK V8 to V12 for oak-blob-azure [jackrabbit-oak]
ierandra commented on code in PR #1861:
URL: https://github.com/apache/jackrabbit-oak/pull/1861#discussion_r1867401720
##
oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureBlobStoreBackend.java:
##
@@ -1260,41 +1117,19 @@ protected T computeNext() {
private boolean loadItems() {
long start = System.currentTimeMillis();
-ClassLoader contextClassLoader =
currentThread().getContextClassLoader();
-try {
-
currentThread().setContextClassLoader(getClass().getClassLoader());
Review Comment:
why did you removed all this logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-11284: Greedy Reuse of cluster IDs may lead to synchronous LastRe… [jackrabbit-oak]
stefan-egli commented on PR #1877: URL: https://github.com/apache/jackrabbit-oak/pull/1877#issuecomment-2514279556 haven't thought much about impact of this but just wanted to state (the obvious) that we'd need to be careful to not cause higher cluster IDs to be used than previously. The more cluster IDs that have ever been used in a deployment, the higher some cost (RevisionVector getting larger, some operations iterating over all (ever existing) cluster IDs) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-11284: Greedy Reuse of cluster IDs may lead to synchronous LastRe… [jackrabbit-oak]
reschke commented on PR #1877:
URL: https://github.com/apache/jackrabbit-oak/pull/1877#issuecomment-2514263460
Minor changes:
1. simplify sys property access
2. use custom clock used by LRA
3. log in ISO format and only if deadline changed
4. add logging fot the case above
~~~
diff --git
a/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/LastRevRecoveryAgent.java
b/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/LastRevRecoveryAgent.java
index 0418751982..caa88e1b9a 100644
---
a/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/LastRevRecoveryAgent.java
+++
b/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/LastRevRecoveryAgent.java
@@ -29,11 +29,11 @@ import static
org.apache.jackrabbit.oak.plugins.document.util.Utils.PROPERTY_OR_
import static
org.apache.jackrabbit.oak.plugins.document.util.Utils.isCommitted;
import static
org.apache.jackrabbit.oak.plugins.document.util.Utils.resolveCommitRevision;
-import java.text.SimpleDateFormat;
+import java.time.LocalDateTime;
+import java.time.ZoneOffset;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
-import java.util.Date;
import java.util.List;
import java.util.Map;
import java.util.concurrent.TimeUnit;
@@ -82,7 +82,8 @@ public class LastRevRecoveryAgent {
private final Consumer afterRecovery;
-private static final SystemPropertySupplier
SYNC_RECOVERY_TIMEOUT_MILLIS =
SystemPropertySupplier.create("oak.syncRecoveryTimeoutMillis", Long.MAX_VALUE);
+private static final long SYNC_RECOVERY_TIMEOUT_MILLIS =
+SystemPropertySupplier.create("oak.syncRecoveryTimeoutMillis",
Long.MAX_VALUE).get();
private static final long LOGINTERVALMS = TimeUnit.MINUTES.toMillis(1);
@@ -272,11 +273,19 @@ public class LastRevRecoveryAgent {
ClusterNodeInfoDocument nodeInfo =
missingLastRevUtil.getClusterNodeInfo(clusterId);
if (nodeInfo != null && nodeInfo.isActive()) {
deadline = nodeInfo.getLeaseEndTime() -
ClusterNodeInfo.DEFAULT_LEASE_FAILURE_MARGIN_MILLIS;
+log.info("Deadline for synchronous recovery is {}.",
+LocalDateTime.ofEpochSecond(deadline, 0,
ZoneOffset.UTC));
}
-long now = System.currentTimeMillis();
-if (Long.MAX_VALUE - SYNC_RECOVERY_TIMEOUT_MILLIS.get() > now) {
-deadline = Math.min(deadline, now +
SYNC_RECOVERY_TIMEOUT_MILLIS.get());
-log.info("Adjusted deadline for synchronous recovery. New
deadline is {}", SimpleDateFormat.getDateTimeInstance().format(new
Date(deadline)));
+long now = revisionContext.getClock().millis();
+// defensive: make sure we don't get an overflow below
+if (Long.MAX_VALUE - SYNC_RECOVERY_TIMEOUT_MILLIS > now) {
+long prevDeadline = deadline;
+deadline = Math.min(deadline, now +
SYNC_RECOVERY_TIMEOUT_MILLIS);
+if (deadline != prevDeadline) {
+log.info("Adjusted deadline for synchronous recovery
from {} to {}.",
+LocalDateTime.ofEpochSecond(prevDeadline, 0,
ZoneOffset.UTC),
+LocalDateTime.ofEpochSecond(deadline, 0,
ZoneOffset.UTC));
+}
}
}
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (jackrabbit-oak): Workflow run "SonarCloud" is working again!
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has succeeded. Run started by GitHub user Amoratinos (triggered by anchela). Head commit for run: ce4d0146096b7e30d1c8fd0907f20e598c005d50 / Alejandro Moratinos OAK-11247: Removed groovy file after rebase Removed gmavenplus plugin from pom Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/11718091577 With regards, GitHub Actions via GitBox
[GH] (jackrabbit-oak): Workflow run "Build" failed!
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user reschke (triggered by reschke). Head commit for run: f82e1b833243b7b021065390efb34fa8f539aa01 / Julian Reschke OAK-11294: fix broken logging in ClusterNodeInfo Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/12139088673 With regards, GitHub Actions via GitBox
Re: [PR] OAK-11247: Migrated groovy test files to Java [jackrabbit-oak]
anchela commented on PR #1851: URL: https://github.com/apache/jackrabbit-oak/pull/1851#issuecomment-2514621403 yep -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (jackrabbit-oak): Workflow run "Build" failed!
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user nfsantos (triggered by nfsantos). Head commit for run: 28e3e9be2c0d9201b511488aa7d567fccb94bb84 / Nuno Santos Finished removing references to merge node store duration metric. Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/12141494651 With regards, GitHub Actions via GitBox
[GH] (jackrabbit-oak): Workflow run "Build" failed!
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user anchela (triggered by anchela). Head commit for run: 711d3fa38970d492dbcdff549f5f83acb6eea751 / Alejandro Moratinos OAK-11247: Migrated groovy test files to Java (#1851) * OAK-11247: Migrated groovy test files to Java * OAK-11247: Removed groovy file after rebase Removed gmavenplus plugin from pom Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/12142372130 With regards, GitHub Actions via GitBox
[PR] OAK-11298 Fix test IncrementalStoreTest [jackrabbit-oak]
thomasmueller opened a new pull request, #1888: URL: https://github.com/apache/jackrabbit-oak/pull/1888 * Ensure there is at most one property per node. * Fix compiler warnings about generics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (jackrabbit-oak): Workflow run "Build" failed!
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user thomasmueller (triggered by thomasmueller). Head commit for run: 0548176de7a1c832e81f8a3a2baeaea295ecbcb7 / Thomas Mueller OAK-11291 Tree store: speed up merging, and concurrent indexing (#1885) Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/12143223041 With regards, GitHub Actions via GitBox
[GH] (jackrabbit-oak): Workflow run "Build" failed!
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user thomasmueller (triggered by thomasmueller). Head commit for run: 0548176de7a1c832e81f8a3a2baeaea295ecbcb7 / Thomas Mueller OAK-11291 Tree store: speed up merging, and concurrent indexing (#1885) Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/12143223041 With regards, GitHub Actions via GitBox
[GH] (jackrabbit-oak): Workflow run "Build" failed!
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user mbaedke (triggered by mbaedke). Head commit for run: f4ad0f620c5e6669a139a4434b7f25af3da0850c / Manfred Baedke OAK-11284: Greedy Reuse of cluster IDs may lead to synchronous LastRevRecovery executions slowing down startup Redone from scratch. Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/12141342057 With regards, GitHub Actions via GitBox
[GH] (jackrabbit-oak): Workflow run "Build" failed!
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user mbaedke (triggered by mbaedke). Head commit for run: 2fa74acea83e85a15f403d1f3079793f68074705 / mbaedke Removed unused import. Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/12141735340 With regards, GitHub Actions via GitBox
