[GitHub] [shardingsphere] DreamSaddle opened a new pull request #10195: Fix exception message missing format in JDBCLockEngine
DreamSaddle opened a new pull request #10195: URL: https://github.com/apache/shardingsphere/pull/10195 Fixes #10191. Changes proposed in this pull request: - Fix exception message missing format in JDBCLockEngine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1874: Update elastic.cn.md
TeslaCN commented on pull request #1874: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1874#issuecomment-826521770 Hi @yuanrengu Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1874: Update elastic.cn.md
TeslaCN merged pull request #1874: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] SkyMoreStars commented on a change in pull request #1069: Consider about improvement of get IP address inaccurate
SkyMoreStars commented on a change in pull request #1069:
URL:
https://github.com/apache/shardingsphere-elasticjob/pull/1069#discussion_r619995613
##
File path:
elasticjob-infra/elasticjob-infra-common/src/main/java/org/apache/shardingsphere/elasticjob/infra/env/IpUtils.java
##
@@ -45,42 +52,93 @@ public static String getIp() {
if (null != cachedIpAddress) {
return cachedIpAddress;
}
-Enumeration netInterfaces;
+NetworkInterface networkInterface = findNetworkInterface();
+if (networkInterface != null) {
+Enumeration ipAddresses =
networkInterface.getInetAddresses();
+while (ipAddresses.hasMoreElements()) {
+InetAddress ipAddress = ipAddresses.nextElement();
+if (isValidAddress(ipAddress)) {
+cachedIpAddress = ipAddress.getHostAddress();
+return cachedIpAddress;
+}
+}
+}
+return null;
+}
+
+private static NetworkInterface findNetworkInterface() {
+Enumeration interfaces;
try {
-netInterfaces = NetworkInterface.getNetworkInterfaces();
+interfaces = NetworkInterface.getNetworkInterfaces();
} catch (final SocketException ex) {
throw new HostException(ex);
}
-String localIpAddress = null;
-while (netInterfaces.hasMoreElements()) {
-NetworkInterface netInterface = netInterfaces.nextElement();
-Enumeration ipAddresses =
netInterface.getInetAddresses();
-while (ipAddresses.hasMoreElements()) {
-InetAddress ipAddress = ipAddresses.nextElement();
-if (isPublicIpAddress(ipAddress)) {
-String publicIpAddress = ipAddress.getHostAddress();
-cachedIpAddress = publicIpAddress;
-return publicIpAddress;
-}
-if (isLocalIpAddress(ipAddress)) {
-localIpAddress = ipAddress.getHostAddress();
+List validNetworkInterfaces = new LinkedList<>();
+while (interfaces.hasMoreElements()) {
+NetworkInterface networkInterface = interfaces.nextElement();
+if (ignoreNetworkInterface(networkInterface)) {
+continue;
+}
+validNetworkInterfaces.add(networkInterface);
+}
+NetworkInterface networkInterface = null;
+for (NetworkInterface item : validNetworkInterfaces) {
+if (isPreferredNetworkInterface(item)) {
+networkInterface = item;
+break;
+}
+}
+if (networkInterface == null) {
+networkInterface =
getFirstNetworkInterface(validNetworkInterfaces);
+}
+return networkInterface;
Review comment:
execuse me ! i network first position is llw0 ,but default network
device is en0.so elastic-job can't find ipaddress.
```
"validNetworkInterfaces":["llw0","awdl0","en5","en0"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] yuanrengu opened a new pull request #1878: Update elastic.en.md
yuanrengu opened a new pull request #1878: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1878 Fixes #ISSUSE_ID. Changes proposed in this pull request: - we have 10 sharding items and there are 3 servers, the number of sharding items are server A = 0,1,2,9; server B = 3,4,5; server C = 6,7,8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1878: Update elastic.en.md
TeslaCN merged pull request #1878: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #10195: Fix exception message missing format in JDBCLockEngine
codecov-commenter commented on pull request #10195: URL: https://github.com/apache/shardingsphere/pull/10195#issuecomment-826538241 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#10195](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05ec63) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c5f300a8e94e6253c51c2e17b49bbcd4ec70b426?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f300a) will **not change** coverage. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master #10195 +/- ## = Coverage 68.08% 68.08% Complexity 680 680 = Files 1696 1696 Lines 2910829108 Branches 5216 5216 = Hits 1981719817 Misses 7772 7772 Partials 1519 1519 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...shardingsphere/driver/executor/JDBCLockEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10195/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9KREJDTG9ja0VuZ2luZS5qYXZh) | `37.14% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5f300a...a05ec63](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] 243006306 opened a new issue #10196: The following problems are found in the project transformation sharding-jdbc 4.1.1 scheme
243006306 opened a new issue #10196: URL: https://github.com/apache/shardingsphere/issues/10196 The following problems are found in the project transformation sharding-jdbc 4.1.1 scheme 1. Why does hint still need to go through the parsing process? Because my SQL is relatively complex (subquery, Union). Now if I find that the problem can not be resolved, I will randomly select a data source and do not enter the hash function of the hint algorithm. This makes me puzzled. I feel that if I can't resolve it, I can throw out the exception, A data source should not be randomly selected, and the hint mode should be able to skip the parsing process and merging process. 2. When I only split the database, the default partition rule does not take effect. I need to configure actual data nodes. I have hundreds of tables in a database. I think this is unreasonable. I should use wildcards, or if it is not configured by default, it is the whole database, or add and exclude some tables to configure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] zhujunxxxxx commented on issue #10136: [SQL Definition Collation][Oracle]Collate the SQL definition of ALTER SYNONYM
zhujunx commented on issue #10136: URL: https://github.com/apache/shardingsphere/issues/10136#issuecomment-826044757 @tristaZero I found `alter database` is not support, i will fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10165: Fix oracle grammar error
codecov-commenter edited a comment on pull request #10165: URL: https://github.com/apache/shardingsphere/pull/10165#issuecomment-825767082 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10165?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#10165](https://codecov.io/gh/apache/shardingsphere/pull/10165?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (97cfc7e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/218d4b19c279422046900af1a170e4177e4fae9a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (218d4b1) will **decrease** coverage by `0.07%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/shardingsphere/pull/10165?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #10165 +/- ## - Coverage 68.06% 67.99% -0.08% Complexity 680 680 Files 1695 1695 Lines 2906029060 Branches 5202 5202 - Hits 1978119759 -22 - Misses 7765 7788 +23 + Partials 1514 1513 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10165?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...sphere/scaling/core/job/schedule/JobScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/10165/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2Ivc2NoZWR1bGUvSm9iU2NoZWR1bGVyLmphdmE=) | `22.22% <0.00%> (-29.63%)` | `0.00% <0.00%> (ø%)` | | | [...re/scaling/core/executor/engine/ExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10165/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRvci9lbmdpbmUvRXhlY3V0ZUVuZ2luZS5qYXZh) | `88.88% <0.00%> (-11.12%)` | `0.00% <0.00%> (ø%)` | | | [...scaling/core/job/task/inventory/InventoryTask.java](https://codecov.io/gh/apache/shardingsphere/pull/10165/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbnZlbnRvcnkvSW52ZW50b3J5VGFzay5qYXZh) | `68.88% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | | | [...ing/core/job/task/incremental/IncrementalTask.java](https://codecov.io/gh/apache/shardingsphere/pull/10165/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbmNyZW1lbnRhbC9JbmNyZW1lbnRhbFRhc2suamF2YQ==) | `72.91% <0.00%> (-2.09%)` | `0.00% <0.00%> (ø%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10165?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10165?src=pr&el=footer&utm_
[GitHub] [shardingsphere] RaigorJiang commented on issue #10138: Transaction not rolled back
RaigorJiang commented on issue #10138: URL: https://github.com/apache/shardingsphere/issues/10138#issuecomment-826234958 Hi @zhoubonet , is this problem still exists? By default, ShardingSphere will affect local transactions, I can't tell more based on the information, sorry. Could you please provide a demo project on github? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] huanghao495430759 closed pull request #10158: fix drop columns exception.
huanghao495430759 closed pull request #10158: URL: https://github.com/apache/shardingsphere/pull/10158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #10177: fix error of encrypt alter table when drop columns.
codecov-commenter commented on pull request #10177: URL: https://github.com/apache/shardingsphere/pull/10177#issuecomment-826071434 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10177?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#10177](https://codecov.io/gh/apache/shardingsphere/pull/10177?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c5b17a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b967e3150eab2931b3a996514204b436e0aa7135?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b967e31) will **increase** coverage by `0.06%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/shardingsphere/pull/10177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #10177 +/- ## + Coverage 68.00% 68.06% +0.06% Complexity 680 680 Files 1694 1695 +1 Lines 2905229061 +9 Branches 5201 5204 +3 + Hits 1975719781 +24 + Misses 7783 7766 -17 - Partials 1512 1514 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...enerator/impl/EncryptAlterTableTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/10177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0QWx0ZXJUYWJsZVRva2VuR2VuZXJhdG9yLmphdmE=) | `98.78% <100.00%> (+1.21%)` | `0.00 <0.00> (ø)` | | | [...end/postgresql/err/PostgreSQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/10177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9lcnIvUG9zdGdyZVNRTEVyclBhY2tldEZhY3RvcnkuamF2YQ==) | `55.00% <0.00%> (-37.31%)` | `0.00% <0.00%> (ø%)` | | | [.../packet/generic/PostgreSQLReadyForQueryPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/10177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvZ2VuZXJpYy9Qb3N0Z3JlU1FMUmVhZHlGb3JRdWVyeVBhY2tldC5qYXZh) | `75.00% <0.00%> (-25.00%)` | `0.00% <0.00%> (ø%)` | | | [...dl/impl/CreateShardingTableRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/10177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvQ3JlYXRlU2hhcmRpbmdUYWJsZVJ1bGVCYWNrZW5kSGFuZGxlci5qYXZh) | `91.66% <0.00%> (-8.34%)` | `1.00% <0.00%> (ø%)` | | | [...uthentication/PostgreSQLAuthenticationHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/10177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcm
[GitHub] [shardingsphere] terrymanu merged pull request #10181: fix error of encrypt alter table when drop columns.
terrymanu merged pull request #10181: URL: https://github.com/apache/shardingsphere/pull/10181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu edited a comment on issue #10184: Clear business logic with PostgreSQLBinaryStatementRegistry
terrymanu edited a comment on issue #10184: URL: https://github.com/apache/shardingsphere/issues/10184#issuecomment-826253836 The new PR #10186 used running task count instead of in use status, consider about revert them together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed pull request #10172: Rewrite table name with alter table for fk
terrymanu closed pull request #10172: URL: https://github.com/apache/shardingsphere/pull/10172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #10170: Force set in transaction for PG
menghaoranss merged pull request #10170: URL: https://github.com/apache/shardingsphere/pull/10170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #10166: Implement SQLServerPrivilegeHandler and add unit test
terrymanu merged pull request #10166: URL: https://github.com/apache/shardingsphere/pull/10166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #10184: Clear business logic with PostgreSQLBinaryStatementRegistry
terrymanu commented on issue #10184: URL: https://github.com/apache/shardingsphere/issues/10184#issuecomment-826253836 The new PR #10186 used running task count instead of in use status, consider revert them together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] wangkang09 commented on issue #10105: rewrite sql error when using keyGenerator and encrypt together
wangkang09 commented on issue #10105: URL: https://github.com/apache/shardingsphere/issues/10105#issuecomment-826065858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] huanghao495430759 closed pull request #10177: fix error of encrypt alter table when drop columns.
huanghao495430759 closed pull request #10177: URL: https://github.com/apache/shardingsphere/pull/10177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] TeslaCN merged pull request #10185: Add in use flag with backend connection
TeslaCN merged pull request #10185: URL: https://github.com/apache/shardingsphere/pull/10185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #10178: Rewrite table name with alter table for fk
tristaZero merged pull request #10178: URL: https://github.com/apache/shardingsphere/pull/10178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #10186: Use running task count instead of is in use on backend connection
strongduanmu merged pull request #10186: URL: https://github.com/apache/shardingsphere/pull/10186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #10169: Support Transaction in PostgreSQL
menghaoranss merged pull request #10169: URL: https://github.com/apache/shardingsphere/pull/10169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #10175: postgresql modify column definition
menghaoranss merged pull request #10175: URL: https://github.com/apache/shardingsphere/pull/10175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #10183: Rename PostgreSQLBinaryStatementRegistry
strongduanmu merged pull request #10183: URL: https://github.com/apache/shardingsphere/pull/10183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #10190: java.lang.ClassNotFoundException: org.apache.shardingsphere.spring.boot.util.PropertyUtil
RaigorJiang commented on issue #10190: URL: https://github.com/apache/shardingsphere/issues/10190#issuecomment-826327968 Hi @chenchen1008 Thanks for you report, I will make a check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #10174: Add vacumm support
menghaoranss merged pull request #10174: URL: https://github.com/apache/shardingsphere/pull/10174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on issue #650: Welcome to leave your article link(欢迎留下关于ShardingSphere的文章链接)
tristaZero commented on issue #650: URL: https://github.com/apache/shardingsphere/issues/650#issuecomment-826313804 Hi @Samhom Yep, we are recruiting people who are interested at this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1873: Make sure supporting the case that job instances are crashed while ex…
TeslaCN merged pull request #1873: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] wgy8283335 commented on pull request #10168: 10104 oracle antlr transfer tool
wgy8283335 commented on pull request #10168:
URL: https://github.com/apache/shardingsphere/pull/10168#issuecomment-826447551
I've test the TransferTool, the result of the rule sentence like below:
```
---
Before:
UPDATE [ hint ] { dml_table_expression_clause | ONLY
(dml_table_expression_clause) } [ t_alias ] update_set_clause [ where_clause ]
[ returning_clause ] [error_logging_clause] ;
After:
UPDATE (hint)? (dmlTableExpressionClause | ONLY
LP_(dmlTableExpressionClause)RP_ ) (tAlias)? updateSetClause (whereClause)?
(returningClause)? (errorLoggingClause)? ;
---
Before:
ALTER TABLE [ schema. ] table
[ memoptimize_read_clause ]
[ memoptimize_write_clause ]
[ alter_table_properties
| column_clauses
| constraint_clauses
| alter_table_partitioning
| alter_external_table
| move_table_clause
| modify_to_partitioned
| modify_opaque_type
| immutable_table_clauses
| blockchain_table_clauses
]
[ enable_disable_clause
| { ENABLE | DISABLE }
{ TABLE LOCK | ALL TRIGGERS | CONTAINER_MAP | CONTAINERS_DEFAULT }
] ...
;
After:
ALTER TABLE (schema.)? table (memoptimizeReadClause)?
(memoptimizeWriteClause)? (alterTableProperties | columnClauses |
constraintClauses | alterTablePartitioning | alterExternalTable |
moveTableClause | modifyToPartitioned | modifyOpaqueType |
immutableTableClauses | blockchainTableClauses)? (enableDisableClause |
(ENABLE | DISABLE) (TABLE LOCK | ALL TRIGGERS | CONTAINER_MAP |
CONTAINERS_DEFAULT) )* ;
Before:
SET
{ { (column [, column ]...) = (subquery)
| column = { expr | (subquery) | DEFAULT }
}
[, { (column [, column]...) = (subquery)
| column = { expr | (subquery) | DEFAULT }
}
]...
| VALUE (t_alias) = { expr | (subquery) }
}};
After:
SET ( ( LP_(column (,column)* )RP_ EQ_ LP_(subquery)RP_ | column EQ_
(expr | LP_(subquery)RP_ | DEFAULT) ) (, ( LP_(column (,column)* )RP_ EQ_
LP_(subquery)RP_ | column EQ_ (expr | LP_(subquery)RP_ | DEFAULT) ) )* |
VALUE LP_(tAlias)RP_ EQ_ (expr | LP_(subquery)RP_ ) )
---
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] TeslaCN closed issue #10153: Error occurred in Proxy when using BenchmarkSQL 5.0
TeslaCN closed issue #10153: URL: https://github.com/apache/shardingsphere/issues/10153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #1874: Update elastic.cn.md
codecov-commenter commented on pull request #1874: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1874#issuecomment-826515887 # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1874?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1874](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1874?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff5ac7f) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/05a0a2cbe67fdf72a56acd985145783cfda1a84a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05a0a2c) will **decrease** coverage by `0.07%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1874 +/- ## - Coverage 85.68% 85.60% -0.08% Complexity 113 113 Files 276 276 Lines 5999 6023 +24 Branches916 921 +5 + Hits 5140 5156 +16 - Misses 523 527 +4 - Partials336 340 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...re/elasticjob/lite/internal/server/ServerNode.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2VydmVyL1NlcnZlck5vZGUuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (ø%)` | | | [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | | | [...ite/internal/election/ElectionListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZWxlY3Rpb24vRWxlY3Rpb25MaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `96.00% <0.00%> (-4.00%)` | `0.00% <0.00%> (ø%)` | | | [...ticjob/lite/internal/failover/FailoverService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZmFpbG92ZXIvRmFpbG92ZXJTZXJ2aWNlLmphdmE=) | `94.20% <0.00%> (-2.17%)` | `0.00% <0.00%> (ø%)` | | | [...ticjob/lite/internal/sharding/ShardingService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2hhcmRpbmcvU2hhcmRpbmdTZXJ2aWNlLmphdmE=) | `98.83% <0.00%> (+0.13%)` | `0.00% <0.00%> (ø%)` | | | [...lasticjob/lite/internal/failover/FailoverNode.java](https://codecov.io/gh/apache/shardingspher
[GitHub] [shardingsphere] glon edited a comment on issue #10063: Proxy broadcastTables select * error
glon edited a comment on issue #10063: URL: https://github.com/apache/shardingsphere/issues/10063#issuecomment-826273393 I configured `defaultDataSourceName: ds_0` to solved the problem, but during the process I've been tried, not work, oddly... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #10189: Revise #10186
strongduanmu merged pull request #10189: URL: https://github.com/apache/shardingsphere/pull/10189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] glon commented on issue #10063: Proxy broadcastTables select * error
glon commented on issue #10063: URL: https://github.com/apache/shardingsphere/issues/10063#issuecomment-826273393 I configured defaultDataSourceName: ds_0 to solved the problem, but during the process I've been tried, not work, oddly... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] wangkang09 removed a comment on issue #10105: rewrite sql error when using keyGenerator and encrypt together
wangkang09 removed a comment on issue #10105: URL: https://github.com/apache/shardingsphere/issues/10105#issuecomment-826065858 > Hi we suggest users to try 5.0.0-alpha, since it fixed many issues of 4.x releases and supported more complex SQLs. Besides, more maintenance work will be done on this series. i use 5.0.0-alpha,it has this problem too。 my config: spring: shardingsphere: datasource: names: db0,db1,db0-slave,db1-slave common: type: com.alibaba.druid.pool.DruidDataSource username: sa password: "" initialSize: 5 minIdle: 5 maxActive: 500 maxWait: 6 timeBetweenEvictionRunsMillis: 2 minEvictableIdleTimeMillis: 20 maxEvictableIdleTimeMillis: 20 db0: url: jdbc:h2:mem:db0;DB_CLOSE_ON_EXIT=FALSE;database_to_upper=false db0-slave: url: jdbc:h2:mem:db0-slave;DB_CLOSE_ON_EXIT=FALSE;database_to_upper=false db1: url: jdbc:h2:mem:db1;DB_CLOSE_ON_EXIT=FALSE;database_to_upper=false db1-slave: url: jdbc:h2:mem:db1-slave;DB_CLOSE_ON_EXIT=FALSE;database_to_upper=false rules: sharding: tables: rs_order: actual-data-nodes: db0.rs_order_0,db0.rs_order_2,db1.rs_order_1,db1.rs_order_3 rs_order_hint: actual-data-nodes: db0.rs_order_0,db0.rs_order_2,db1.rs_order_1,db1.rs_order_3 table-strategy: complex: sharding-columns: member_id,billno sharding-algorithm-name: table-hint database-strategy: complex: sharding-columns: member_id,billno sharding-algorithm-name: db-hint default-database-strategy: complex: sharding-columns: member_id,billno sharding-algorithm-name: db-complex default-table-strategy: complex: sharding-columns: member_id,billno sharding-algorithm-name: table-complex default-key-generate-strategy: column: id key-generator-name: rs-order-generator #sharding 中的 key generator 配置 key-generators: # rs-order-generator 为 generator 的名字。供上面的 key-generator-name 使用 rs-order-generator: type: DbSnowflakeKeyGenerator props: key.snow.type: rs_order # 传入 DbSnowflakeKeyGenerator 对应的 generator 实例 sharding-algorithms: table-complex: type: tableComplex props: xx: xx # https://github.com/apache/shardingsphere/pull/8331 db-complex: type: dbComplex props: xx: xx table-hint: type: tableHint props: xx: xx db-hint: type: dbHint props: xx: xx replica-query: data-sources: db0: primary-data-source-name: db0 replica-data-source-names: db0-slave load-balancer-name: round-robin db1: primary-data-source-name: db1 replica-data-source-names: db1-slave load-balancer-name: round-robin load-balancers: round-robin: type: ROUND_ROBIN props: xx: xx # https://github.com/apache/shardingsphere/pull/8331 encrypt: tables: rs_order: columns: email: plain-column: email_plain cipher-column: email assisted-query-column: email_hash encryptor-name: my-aes encryptors: my-aes: type: my-AssistQuery props: business-key: 'privateDWK' my-aes1: type: my-AssistQuery props: business-key: 'privateDWK' # shadow: #column: shadow #source-data-source-names: db0,db1 #shadow-data-source-names: db0-shadow,db1-shadow props: sql-show: true query-with-cipher-column: true # 是否使用密文查询 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob-ui] TeslaCN commented on issue #114: Does console support internationalization
TeslaCN commented on issue #114: URL: https://github.com/apache/shardingsphere-elasticjob-ui/issues/114#issuecomment-826473412 After signed in, You may switch language by a button in the top right-hand corner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #10165: Fix oracle grammar error
tristaZero merged pull request #10165: URL: https://github.com/apache/shardingsphere/pull/10165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] glon closed issue #10063: Proxy broadcastTables select * error
glon closed issue #10063: URL: https://github.com/apache/shardingsphere/issues/10063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #1877: Use a random port for Spring Boot testcases
codecov-commenter commented on pull request #1877: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1877#issuecomment-826505041 # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1877?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1877](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1877?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (056d203) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/0ca3a7bb918b93797638094ca06d56497caafc84?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0ca3a7b) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1877?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1877 +/- ## - Coverage 85.68% 85.67% -0.02% + Complexity 114 113 -1 Files 276 276 Lines 6023 6023 Branches921 921 - Hits 5161 5160 -1 - Misses 525 526 +1 Partials337 337 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1877?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...sticjob/reg/zookeeper/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1877/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9yZWcvem9va2VlcGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `72.44% <0.00%> (-0.79%)` | `32.00% <0.00%> (-1.00%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1877?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1877?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0ca3a7b...056d203](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1877?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on issue #10127: read-write-splitting doesn't work
tristaZero commented on issue #10127: URL: https://github.com/apache/shardingsphere/issues/10127#issuecomment-826314279 Thanks for your comment @hilton1977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #10148: Implement OraclePrivilegeHandler and add unit test
tristaZero commented on pull request #10148: URL: https://github.com/apache/shardingsphere/pull/10148#issuecomment-826309876 @Liangda-w Thanks, Hi @zhujunx Could you give a look one more? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on issue #10119: RangeShardingAlgorithm Generic problem, specified as Date, actually a string
tristaZero commented on issue #10119: URL: https://github.com/apache/shardingsphere/issues/10119#issuecomment-826314458 Hi please try the release one, i.e., 5.0.0-alpha -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob-ui] TeslaCN edited a comment on issue #113: Registry Center can`t connect zookeeper
TeslaCN edited a comment on issue #113: URL: https://github.com/apache/shardingsphere-elasticjob-ui/issues/113#issuecomment-826474011 Hi @Pudge-T I cannot reproduce your problem in my environment. Could you show me what have you typed in the page? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #10193: fix bad rewritten result for foreign key SQL
codecov-commenter commented on pull request #10193: URL: https://github.com/apache/shardingsphere/pull/10193#issuecomment-826483708 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#10193](https://codecov.io/gh/apache/shardingsphere/pull/10193?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (45f63bb) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e66e4de6b2d66529754e433614361324727a265f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e66e4de) will **decrease** coverage by `0.07%`. > The diff coverage is `54.05%`. [](https://codecov.io/gh/apache/shardingsphere/pull/10193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #10193 +/- ## - Coverage 68.05% 67.98% -0.08% Complexity 680 680 Files 1696 1697 +1 Lines 2906629145 +79 Branches 5205 5226 +21 + Hits 1978219815 +33 - Misses 7768 7809 +41 - Partials 1516 1521 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/validator/ShardingStatementValidatorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/10193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS92YWxpZGF0b3IvU2hhcmRpbmdTdGF0ZW1lbnRWYWxpZGF0b3JGYWN0b3J5LmphdmE=) | `13.79% <0.00%> (-1.03%)` | `0.00 <0.00> (ø)` | | | [...broadcast/ShardingTableBroadcastRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS90eXBlL2Jyb2FkY2FzdC9TaGFyZGluZ1RhYmxlQnJvYWRjYXN0Um91dGluZ0VuZ2luZS5qYXZh) | `53.84% <23.52%> (-14.73%)` | `0.00 <0.00> (ø)` | | | [...ddl/impl/ShardingAlterTableStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/10193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS92YWxpZGF0b3IvZGRsL2ltcGwvU2hhcmRpbmdBbHRlclRhYmxlU3RhdGVtZW50VmFsaWRhdG9yLmphdmE=) | `87.50% <87.50%> (ø)` | `0.00 <0.00> (?)` | | | [...che/shardingsphere/sharding/rule/ShardingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/10193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `70.14% <100.00%> (+0.45%)` | `0.00 <0.00> (ø)` | | | [.../frontend/postgresql/PostgreSQLFrontendEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhl
[GitHub] [shardingsphere] menghaoranss merged pull request #10173: fix error of mysql alter table drop column visitor.
menghaoranss merged pull request #10173: URL: https://github.com/apache/shardingsphere/pull/10173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] DreamSaddle removed a comment on issue #10191: Throw exception message error
DreamSaddle removed a comment on issue #10191: URL: https://github.com/apache/shardingsphere/issues/10191#issuecomment-826482306 Yes, it would be my pleasure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #10179: support parsing vacuum sql
menghaoranss merged pull request #10179: URL: https://github.com/apache/shardingsphere/pull/10179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN closed issue #1868: I can't find the branch which includes the code from Bug fix for Failover #714
TeslaCN closed issue #1868: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero edited a comment on issue #10119: RangeShardingAlgorithm Generic problem, specified as Date, actually a string
tristaZero edited a comment on issue #10119: URL: https://github.com/apache/shardingsphere/issues/10119#issuecomment-826314458 Hi please try the released one, i.e., 5.0.0-alpha -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #10189: Revise #10186
terrymanu commented on a change in pull request #10189: URL: https://github.com/apache/shardingsphere/pull/10189#discussion_r619768636 ## File path: shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/main/java/org/apache/shardingsphere/proxy/frontend/state/impl/OKProxyState.java ## @@ -40,5 +40,6 @@ public void execute(final ChannelHandlerContext context, final Object message, f ExecutorService executorService = CommandExecutorSelector.getExecutorService( isOccupyThreadForPerConnection, supportHint, backendConnection.getTransactionStatus().getTransactionType(), context.channel().id()); executorService.execute(new CommandExecutorTask(databaseProtocolFrontendEngine, backendConnection, context, message)); +backendConnection.getSubmittedTaskCount().incrementAndGet(); Review comment: How about change seq of line 42 and 43? It seems better to increment count before task execute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #10187: Fix test case for PostgreSQLFrontendEngineTest
strongduanmu merged pull request #10187: URL: https://github.com/apache/shardingsphere/pull/10187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] SkyMoreStars commented on a change in pull request #1069: Consider about improvement of get IP address inaccurate
SkyMoreStars commented on a change in pull request #1069:
URL:
https://github.com/apache/shardingsphere-elasticjob/pull/1069#discussion_r619995613
##
File path:
elasticjob-infra/elasticjob-infra-common/src/main/java/org/apache/shardingsphere/elasticjob/infra/env/IpUtils.java
##
@@ -45,42 +52,93 @@ public static String getIp() {
if (null != cachedIpAddress) {
return cachedIpAddress;
}
-Enumeration netInterfaces;
+NetworkInterface networkInterface = findNetworkInterface();
+if (networkInterface != null) {
+Enumeration ipAddresses =
networkInterface.getInetAddresses();
+while (ipAddresses.hasMoreElements()) {
+InetAddress ipAddress = ipAddresses.nextElement();
+if (isValidAddress(ipAddress)) {
+cachedIpAddress = ipAddress.getHostAddress();
+return cachedIpAddress;
+}
+}
+}
+return null;
+}
+
+private static NetworkInterface findNetworkInterface() {
+Enumeration interfaces;
try {
-netInterfaces = NetworkInterface.getNetworkInterfaces();
+interfaces = NetworkInterface.getNetworkInterfaces();
} catch (final SocketException ex) {
throw new HostException(ex);
}
-String localIpAddress = null;
-while (netInterfaces.hasMoreElements()) {
-NetworkInterface netInterface = netInterfaces.nextElement();
-Enumeration ipAddresses =
netInterface.getInetAddresses();
-while (ipAddresses.hasMoreElements()) {
-InetAddress ipAddress = ipAddresses.nextElement();
-if (isPublicIpAddress(ipAddress)) {
-String publicIpAddress = ipAddress.getHostAddress();
-cachedIpAddress = publicIpAddress;
-return publicIpAddress;
-}
-if (isLocalIpAddress(ipAddress)) {
-localIpAddress = ipAddress.getHostAddress();
+List validNetworkInterfaces = new LinkedList<>();
+while (interfaces.hasMoreElements()) {
+NetworkInterface networkInterface = interfaces.nextElement();
+if (ignoreNetworkInterface(networkInterface)) {
+continue;
+}
+validNetworkInterfaces.add(networkInterface);
+}
+NetworkInterface networkInterface = null;
+for (NetworkInterface item : validNetworkInterfaces) {
+if (isPreferredNetworkInterface(item)) {
+networkInterface = item;
+break;
+}
+}
+if (networkInterface == null) {
+networkInterface =
getFirstNetworkInterface(validNetworkInterfaces);
+}
+return networkInterface;
Review comment:
execuse me ! i network first position is llw0 ,but default network
device is en0.so elastic-job can't find ipaddress.
```
"validNetworkInterfaces":["llw0","awdl0","en5","en0"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] wangkang09 edited a comment on issue #10105: rewrite sql error when using keyGenerator and encrypt together
wangkang09 edited a comment on issue #10105: URL: https://github.com/apache/shardingsphere/issues/10105#issuecomment-826070317 > Hi 5.0.0-alpha has been released for a long time. Maybe you have no interests on Scaling etc. But this issue was fixed from 5.x release. Actual SQL: db1 ::: INSERT INTO rs_order_1 ( member_id,billno,email, email_hash, email_plain , id) VALUES (?, ?, ?, ?, ?, ?) ::: [1, 1, NEQ2VjNrWU5VT3N1VXM4Ul4EwtHvtZ7u3vHxb/iiEsA=, 2021042408597934083, 6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b, 1]  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] avalon5666 merged pull request #10188: Remove timeout limit with unregister PostgreSQLBinaryStatementRegistry
avalon5666 merged pull request #10188: URL: https://github.com/apache/shardingsphere/pull/10188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #10181: fix error of encrypt alter table when drop columns.
codecov-commenter commented on pull request #10181: URL: https://github.com/apache/shardingsphere/pull/10181#issuecomment-826092639 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10181?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#10181](https://codecov.io/gh/apache/shardingsphere/pull/10181?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd61f4f) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e66e4de6b2d66529754e433614361324727a265f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e66e4de) will **increase** coverage by `0.00%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/shardingsphere/pull/10181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master #10181 +/- ## = Coverage 68.05% 68.06% Complexity 680 680 = Files 1696 1696 Lines 2906629066 Branches 5205 5205 = + Hits 1978219783+1 Misses 7768 7768 + Partials 1516 1515-1 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...enerator/impl/EncryptAlterTableTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/10181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0QWx0ZXJUYWJsZVRva2VuR2VuZXJhdG9yLmphdmE=) | `98.78% <100.00%> (+1.21%)` | `0.00 <0.00> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10181?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10181?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e66e4de...bd61f4f](https://codecov.io/gh/apache/shardingsphere/pull/10181?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #10195: Fix exception message missing format in JDBCLockEngine
codecov-commenter commented on pull request #10195: URL: https://github.com/apache/shardingsphere/pull/10195#issuecomment-826538241 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#10195](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05ec63) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c5f300a8e94e6253c51c2e17b49bbcd4ec70b426?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f300a) will **not change** coverage. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master #10195 +/- ## = Coverage 68.08% 68.08% Complexity 680 680 = Files 1696 1696 Lines 2910829108 Branches 5216 5216 = Hits 1981719817 Misses 7772 7772 Partials 1519 1519 ``` | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...shardingsphere/driver/executor/JDBCLockEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10195/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9KREJDTG9ja0VuZ2luZS5qYXZh) | `37.14% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5f300a...a05ec63](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] sangewuxie commented on issue #10106: bug, emoji cant save(insert) or update, update is work shardingsphere-5.0.0-alpha
sangewuxie commented on issue #10106: URL: https://github.com/apache/shardingsphere/issues/10106#issuecomment-826439916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #10191: Throw exception message error
RaigorJiang commented on issue #10191: URL: https://github.com/apache/shardingsphere/issues/10191#issuecomment-826455935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #10182: Revise #10163 and complete testcases
tristaZero merged pull request #10182: URL: https://github.com/apache/shardingsphere/pull/10182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] 726411951 closed issue #10086: Is there a better way to cofig sharding properties
726411951 closed issue #10086: URL: https://github.com/apache/shardingsphere/issues/10086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob-ui] TeslaCN commented on issue #113: Registry Center can`t connect zookeeper
TeslaCN commented on issue #113: URL: https://github.com/apache/shardingsphere-elasticjob-ui/issues/113#issuecomment-826474011 Hi @Pudge-T I cannot reproduce your problem in my environment. Could you show me what you have typed in the page? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1846: Adding code maintainability badge
TeslaCN merged pull request #1846: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on issue #10126: sqlserver row_number() over() faild，Error preparing statement. Cause: org.antlr.v4.runtime.misc.ParseCancellationException
tristaZero commented on issue #10126: URL: https://github.com/apache/shardingsphere/issues/10126#issuecomment-826314099 @cilfm Thank for your feedback. Are you interested raising a PR to fix this bug in the master branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #10189: Revise #10186
TeslaCN commented on a change in pull request #10189: URL: https://github.com/apache/shardingsphere/pull/10189#discussion_r619769360 ## File path: shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/main/java/org/apache/shardingsphere/proxy/frontend/state/impl/OKProxyState.java ## @@ -40,5 +40,6 @@ public void execute(final ChannelHandlerContext context, final Object message, f ExecutorService executorService = CommandExecutorSelector.getExecutorService( isOccupyThreadForPerConnection, supportHint, backendConnection.getTransactionStatus().getTransactionType(), context.channel().id()); executorService.execute(new CommandExecutorTask(databaseProtocolFrontendEngine, backendConnection, context, message)); +backendConnection.getSubmittedTaskCount().incrementAndGet(); Review comment: I think it is OK that add the submitted count after the task submitted. ## File path: shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/main/java/org/apache/shardingsphere/proxy/frontend/state/impl/OKProxyState.java ## @@ -40,5 +40,6 @@ public void execute(final ChannelHandlerContext context, final Object message, f ExecutorService executorService = CommandExecutorSelector.getExecutorService( isOccupyThreadForPerConnection, supportHint, backendConnection.getTransactionStatus().getTransactionType(), context.channel().id()); executorService.execute(new CommandExecutorTask(databaseProtocolFrontendEngine, backendConnection, context, message)); +backendConnection.getSubmittedTaskCount().incrementAndGet(); Review comment: Maybe we can add count before execute and catch `RejectedExecutinoException`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #10102: Implement SQLServerPrivilegeHandler and add unit test
terrymanu closed issue #10102: URL: https://github.com/apache/shardingsphere/issues/10102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #10176: Refactor PostgreSQLAuthenticationEngine
menghaoranss merged pull request #10176: URL: https://github.com/apache/shardingsphere/pull/10176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] DreamSaddle commented on issue #10191: Throw exception message error
DreamSaddle commented on issue #10191: URL: https://github.com/apache/shardingsphere/issues/10191#issuecomment-826482306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang edited a comment on issue #10190: java.lang.ClassNotFoundException: org.apache.shardingsphere.spring.boot.util.PropertyUtil
RaigorJiang edited a comment on issue #10190: URL: https://github.com/apache/shardingsphere/issues/10190#issuecomment-826327968 Hi @chenchen1008 Thanks for your report, I will make a check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1878: Update elastic.en.md
TeslaCN merged pull request #1878: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1874: Update elastic.cn.md
TeslaCN commented on pull request #1874: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1874#issuecomment-826521770 Hi @yuanrengu Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1874: Update elastic.cn.md
TeslaCN merged pull request #1874: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] hanxu00920 opened a new issue #10197: use orchestration for springboot can't work
hanxu00920 opened a new issue #10197:
URL: https://github.com/apache/shardingsphere/issues/10197
##maven dependencies:
org.apache.shardingsphere
sharding-jdbc-orchestration-spring-boot-starter
${shardingsphere.version}
org.apache.shardingsphere
sharding-orchestration-center-zookeeper-curator
${shardingsphere.version}
##springboot version:
2.0.3.RELEASE
##shadingsphere version:
4.1.1
##spring applaction.properties:
spring.shardingsphere.datasource.names=ds0,ds1
spring.shardingsphere.datasource.ds0.type=com.zaxxer.hikari.HikariDataSource
spring.shardingsphere.datasource.ds0.driver-class-name=org.postgresql.Driver
spring.shardingsphere.datasource.ds0.jdbc-url=jdbc:postgresql://hxvm1:5432/postgres
spring.shardingsphere.datasource.ds0.username=postgres
spring.shardingsphere.datasource.ds0.password=
spring.shardingsphere.datasource.ds1.type=com.zaxxer.hikari.HikariDataSource
spring.shardingsphere.datasource.ds1.driver-class-name=org.postgresql.Driver
spring.shardingsphere.datasource.ds1.jdbc-url=jdbc:postgresql://hxvm2:5432/postgres
spring.shardingsphere.datasource.ds1.username=postgres
spring.shardingsphere.datasource.ds1.password=
spring.shardingsphere.sharding.tables.t_order.actual-data-nodes=ds$->{0..1}.cd_order_info
spring.shardingsphere.sharding.tables.cd_order_info.database-strategy.standard.sharding-column=ordernum
spring.shardingsphere.sharding.tables.cd_order_info.database-strategy.standard.precise-algorithm-class-name=com.post.trade.shading.OrderNumAlgorithm
spring.shardingsphere.sharding.tables.cd_order_info.key-generator.column=order_id
spring.shardingsphere.sharding.tables.cd_order_info.key-generator.type=SNOWFLAKE
spring.shardingsphere.sharding.tables.cd_trans_serial_info.actual-data-nodes=ds$->{0..1}.cd_trans_serial_info
spring.shardingsphere.sharding.tables.cd_trans_serial_info.database-strategy.standard.sharding-column=ordernum
spring.shardingsphere.sharding.tables.cd_trans_serial_info.database-strategy.standard.precise-algorithm-class-name=com.post.trade.shading.OrderNumAlgorithm
spring.shardingsphere.sharding.tables.cd_trans_serial_info.key-generator.column=serial_id
spring.shardingsphere.sharding.tables.cd_trans_serial_info.key-generator.type=SNOWFLAKE
spring.shardingsphere.props.sql.show=true
spring.shardingsphere.orchestration.name=spring_boot_ds_sharding
spring.shardingsphere.orchestration.overwrite=true
spring.shardingsphere.orchestration.registry.type=zookeeper
spring.shardingsphere.orchestration.registry.namespace=orchestration-spring-boot-sharding-test
spring.shardingsphere.orchestration.registry.server-lists=localhost:2181
##springboot run failed log
***
APPLICATION FAILED TO START
***
Description:
Failed to bind properties under 'spring.shardingsphere.orchestration.name'
to
org.apache.shardingsphere.orchestration.center.yaml.config.YamlCenterRepositoryConfiguration:
Property: spring.shardingsphere.orchestration.name
Value: spring_boot_ds_sharding
Origin: class path resource [application-dev.properties]:53:42
Reason: No converter found capable of converting from type
[java.lang.String] to type
[org.apache.shardingsphere.orchestration.center.yaml.config.YamlCenterRepositoryConfiguration]
Action:
Update your application's configuration
I read document, can't explain why the error.
problem with the version using?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] zhonghuali commented on issue #7196: In multi-tenant mode database sharding invalid
zhonghuali commented on issue #7196: URL: https://github.com/apache/shardingsphere/issues/7196#issuecomment-826602578 Striongly suggest to add new config for setting whether all tables are default sharded or not, then simplifying this kind of configuration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] kaihekaihe opened a new issue #1879: If the timeout parameter are set to 0L,then the thread executing some sharding may wait for Long.maxvalue.
kaihekaihe opened a new issue #1879: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1879 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: - Searched open and closed [GitHub issues](https://github.com/apache/shardingsphere-elasticjob/issues). - Read documentation: [ElasticJob Doc](https://shardingsphere.apache.org/elasticjob/current/en/overview/). Please pay attention on issues you submitted, because we maybe need more details. If no response anymore and we cannot reproduce it on current information, we will **close it**. Please answer these questions before submitting your issue. Thanks! ### Which version of ElasticJob did you use? ### Which project did you use? ElasticJob-Lite or ElasticJob-Cloud? ### Expected behavior If the timeout parameter are set to 0L, the thread executing some sharding wait for 0L. That is to say, I dont want these threads wait ### Actual behavior If the timeout parameter are set to 0L,then the thread executing some sharding may wait for Long.maxvalue. ### Reason analyze (If you can) ### Steps to reproduce the behavior. ### Example codes for reproduce this issue (such as a github link). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] Victoryli opened a new issue #10198: 读写分离配合分表，分表失效
Victoryli opened a new issue #10198:
URL: https://github.com/apache/shardingsphere/issues/10198
## Bug Report
**For English only**, other languages will not accept.
Before report a bug, make sure you have:
- Searched open and closed [GitHub
issues](https://github.com/apache/shardingsphere/issues).
- Read documentation: [ShardingSphere
Doc](https://shardingsphere.apache.org/document/current/en/overview).
Please pay attention on issues you submitted, because we maybe need more
details.
If no response anymore and we cannot reproduce it on current information, we
will **close it**.
Please answer these questions before submitting your issue. Thanks!
### Which version of ShardingSphere did you use?
4.0.0-RC1
### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy?
ShardingSphere-JDBC
### Expected behavior
读写分离配合分表
### Actual behavior
在分表生效的基础上，加入读写分离的配置，分表失效，只是读写分离生效
## Question
为什么分表失效
### Reason analyze (If you can)
### Steps to reproduce the behavior, such as: SQL to execute, sharding rule
configuration, when exception occur etc.
### Example codes for reproduce this issue (such as a github link).
application.yml 文件配置如下：
`spring:
shardingsphere:
datasource:
names: shardingmaster,shardingslave # 最好不要有特殊字符
shardingmaster:
type: com.zaxxer.hikari.HikariDataSource
driver-class-name: com.mysql.jdbc.Driver
jdbc-url:
jdbc:mysql://xxx:3306/shardingsphere1?useUnicode=true&characterEncoding=UTF8&serverTimezone=Asia/Shanghai&connectTimeout=1&socketTimeout=10&allowMultiQueries=true&useSSL=false
username: root
password: 123456
shardingslave:
type: com.zaxxer.hikari.HikariDataSource
driver-class-name: com.mysql.jdbc.Driver
jdbc-url:
jdbc:mysql://xx:3306/x?useUnicode=true&characterEncoding=UTF8&serverTimezone=Asia/Shanghai&connectTimeout=1&socketTimeout=10&allowMultiQueries=true&useSSL=false
username: root
password: 123456
masterslave:
load-balance-algorithm-type: 'ROUND_ROBIN'
master-data-source-name: 'shardingmaster'
name: datasource
slave-data-source-names: 'shardingslave'
sharding:
tables:
account_generate_mq_log: # 表名
table-strategy:
standard:
sharding-column: account_time # 分片字段
precise-algorithm-class-name:
com.xxx.sharding.config.PreciseSharingTableAlgorithmOfAccountGenerateMqLog
range-algorithm-class-name:
com.xxxsharding.config.RangeShardingAlgorithmOfAccountGenerateMqLog
actual-data-nodes: account_generate_mq_log_$->{[202104]}
props:
sql:
show: true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #10195: Fix exception message missing format in JDBCLockEngine
RaigorJiang commented on pull request #10195: URL: https://github.com/apache/shardingsphere/pull/10195#issuecomment-826635878 @DreamSaddle Hi, DreamSaddle, please check code style, do not format the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #10195: Fix exception message missing format in JDBCLockEngine
RaigorJiang commented on a change in pull request #10195:
URL: https://github.com/apache/shardingsphere/pull/10195#discussion_r620091075
##
File path:
shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/executor/JDBCLockEngine.java
##
@@ -43,34 +43,34 @@
* JDBC lock engine.
*/
public final class JDBCLockEngine {
-
Review comment:
Do not change the indentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] zhonghuali opened a new issue #10199: Striongly suggest to add new config for setting whether all tables are default sharded or not, then simplifying this kind of configurati
zhonghuali opened a new issue #10199: URL: https://github.com/apache/shardingsphere/issues/10199 Striongly suggest to add new config for setting whether all tables are default sharded or not, then simplifying this kind of configuration _Originally posted by @zhonghuali in https://github.com/apache/shardingsphere/issues/7196#issuecomment-826602578_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] zhonghuali edited a comment on issue #7196: In multi-tenant mode database sharding invalid
zhonghuali edited a comment on issue #7196: URL: https://github.com/apache/shardingsphere/issues/7196#issuecomment-826602578 Strongly suggest to add new config for setting whether all tables are default sharded or not, then simplifying this kind of configuration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] DreamSaddle commented on a change in pull request #10195: Fix exception message missing format in JDBCLockEngine
DreamSaddle commented on a change in pull request #10195:
URL: https://github.com/apache/shardingsphere/pull/10195#discussion_r620121238
##
File path:
shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/executor/JDBCLockEngine.java
##
@@ -43,34 +43,34 @@
* JDBC lock engine.
*/
public final class JDBCLockEngine {
-
Review comment:
Ok, I will resubmit it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] yudonghua opened a new issue #10200: 第一次执行慢
yudonghua opened a new issue #10200: URL: https://github.com/apache/shardingsphere/issues/10200 在项目刚启动时，第一次查询由于加载大量类，导致正常执行只需要20ms~30ms左右的查询执行了2000ms~3000ms -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new issue #1880: Support configuring Mail SMTP SSL trusted
TeslaCN opened a new issue #1880: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1880 ## Feature Request ### Is your feature request related to a problem? Our SMTP server using self-signed certificate. There is no way to configure trusted host for now. ### Describe the feature you would like. Support configuring trusted host by property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] yudonghua closed issue #10200: 第一次执行慢
yudonghua closed issue #10200: URL: https://github.com/apache/shardingsphere/issues/10200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on issue #1876: 任务执行后重启服务增加tracing功能不生效
TeslaCN commented on issue #1876: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1876#issuecomment-826743795 **For English only** You may set `overwrite` to `true` to overwrite the configurations in Zookeeper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN closed issue #1876: 任务执行后重启服务增加tracing功能不生效
TeslaCN closed issue #1876: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on issue #1872: job触发有延迟
TeslaCN commented on issue #1872: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1872#issuecomment-826744254 **For English only** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN closed issue #1872: job触发有延迟
TeslaCN closed issue #1872: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on issue #1879: If the timeout parameter are set to 0L,then the thread executing some sharding may wait for Long.maxvalue.
TeslaCN commented on issue #1879: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1879#issuecomment-826746450 Hi @kaihekaihe Do you mean the timeout of `DistributeOnceElasticJobListener`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #10190: java.lang.ClassNotFoundException: org.apache.shardingsphere.spring.boot.util.PropertyUtil
RaigorJiang commented on issue #10190:
URL:
https://github.com/apache/shardingsphere/issues/10190#issuecomment-826829298
@chenchen1008
Hi, I have tested with version `5.0.0-alpha`, and there was no problem.
But, the starter should be `shardingsphere-jdbc-core-spring-boot-starter`,
your dependency is wrong.
The correct dependency is
`
org.apache.shardingsphere
shardingsphere-jdbc-core-spring-boot-starter
${shardingsphere.version}
`
Please see
https://shardingsphere.apache.org/document/current/cn/user-manual/shardingsphere-jdbc/usage/sharding/spring-boot-starter/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10193: fix bad rewritten result for foreign key SQL
tristaZero commented on a change in pull request #10193:
URL: https://github.com/apache/shardingsphere/pull/10193#discussion_r620295127
##
File path:
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/ddl/impl/ShardingAlterTableStatementValidator.java
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.route.engine.validator.ddl.impl;
+
+import org.apache.shardingsphere.infra.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.infra.binder.type.TableAvailable;
+import org.apache.shardingsphere.infra.exception.ShardingSphereException;
+import org.apache.shardingsphere.infra.metadata.schema.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.route.context.RouteContext;
+import
org.apache.shardingsphere.sharding.route.engine.validator.ddl.ShardingDDLStatementValidator;
+import org.apache.shardingsphere.sharding.rule.ShardingRule;
+import org.apache.shardingsphere.sharding.rule.TableRule;
+import
org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.AlterTableStatement;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.stream.Collectors;
+
+/**
+ * Sharding alter table statement validator.
+ */
+public final class ShardingAlterTableStatementValidator extends
ShardingDDLStatementValidator {
+
+@Override
+public void preValidate(final ShardingRule shardingRule, final
SQLStatementContext sqlStatementContext, final
List parameters, final ShardingSphereSchema schema) {
+Collection shardingLogicTableNames =
getShardingLogicTableNames(shardingRule, sqlStatementContext);
+if (shardingLogicTableNames.size() <= 1) {
+return;
+}
Review comment:
How about `broadcast Table`or `single table`?
Is #10172 a interim solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #10194: 期望有rust语言的shardingsphere
RaigorJiang commented on issue #10194: URL: https://github.com/apache/shardingsphere/issues/10194#issuecomment-826835931 Hello, for English only, please translate, thank you. By the way, Sharding-Proxy supports standard SQL protocols and can be language free. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #10195: Fix exception message missing format in JDBCLockEngine
RaigorJiang commented on pull request #10195: URL: https://github.com/apache/shardingsphere/pull/10195#issuecomment-826846247 @DreamSaddle Hi, please see `Files changed`, there are still lots of format changes.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on issue #10111: [SQL Definition Collation][Oracle]Collate the SQL definition of alter session
ThanoshanMV commented on issue #10111: URL: https://github.com/apache/shardingsphere/issues/10111#issuecomment-826850523 Hi @tristaZero, next, I'll try [ALTER SYSTEM](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/ALTER-SYSTEM.html#GUID-2C638517-D73A-41CA-9D8E-A62D1A0B7ADB). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #10133: shardingjdbc 4.1.1 insert...select NullPointerException
RaigorJiang commented on issue #10133: URL: https://github.com/apache/shardingsphere/issues/10133#issuecomment-826854771 Hi @xsong123 Is the exception still exists? Because you did not provide your SQL and configuration， we can not say anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] LutzWeischerFujitsu commented on issue #9710: build fails on AArch64, Fedora 33
LutzWeischerFujitsu commented on issue #9710: URL: https://github.com/apache/shardingsphere/issues/9710#issuecomment-826863152 [jw@cn05 shardingsphere]$ ./mvnw clean install -Prelease -DskipTests ... [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 27.325 s [INFO] Finished at: 2021-04-26T16:01:02+02:00 [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.3:jar (attach-javadocs) on project shardingsphere-agent-api: MavenReportException: Error while generating Javadoc: Unable to find javadoc command: The javadoc executable '/usr/lib/jvm/java-11-openjdk-11.0.10.0.9-0.fc33.aarch64/../bin/javadoc' doesn't exist or is not a file. Verify the parameter. -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :shardingsphere-agent-api [jw@cn05 shardingsphere]$ javadoc javadoc: error - No modules, packages or classes specified. 1 error [jw@cn05 shardingsphere]$ echo $JAVA_HOME /usr/lib/jvm/java-11-openjdk [jw@cn05 shardingsphere]$ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere] Liangda-w opened a new pull request #10201: Fix Oracle addColumnSpecification grammar
Liangda-w opened a new pull request #10201: URL: https://github.com/apache/shardingsphere/pull/10201 Relates #9694. Changes proposed in this pull request: - Fix Oracle `addColumnSpecification` grammar of [ALTER TABLE](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/ALTER-TABLE.html#GUID-552E7373-BF93-477D-9DA3-B2C9386F2877) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [shardingsphere-elasticjob] gonedays opened a new issue #1881: Specify an ip when job instance application deployed on a multi-ip server.
gonedays opened a new issue #1881: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1881 ## Feature Request **For English only**, other languages will not accept. Please pay attention on issues you submitted, because we maybe need more details. If no response anymore and we cannot make decision by current information, we will **close it**. Please answer these questions before submitting your issue. Thanks! ### Is your feature request related to a problem? No ### Describe the feature you would like. When application doployed on a server with multi-ip, then the job instance will register to ZK with the first ip of org.apache.shardingsphere.elasticjob.infra.env.IpUtils#getIP(), this may cause some network problem. E.g, sheduling task failed to communicate with instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
