[netsurf-dev] Re: [PATCH 1/1] bindings/xml/libxml_xmlparser.c: add stdlib.h include
On 03/02/2024 16:49, Michael Orlitzky wrote: This file uses malloc() but does not include stdlib.h directly. With glibc, that apparently works out just fine... but with musl, it leads to implicit declaration warnings/errors, most likely because musl does not include stdlib.h transitively via any of the other headers used by this file. [...] Applied, thanks! John-Mark.
[netsurf-dev] Re: [PATCH 1/1] bindings/xml/libxml_xmlparser.c: update for libxml2 >= 2.12.0
On 08/02/2024 03:08, Michael Orlitzky wrote: Version 2.12.0 of libxml2 changes a few functions to return (const xmlError *) where previously they returned only (xmlError *). Compilers generally are not happy with this. For example, bindings/xml/libxml_xmlparser.c: In function 'xml_parser_start_document': bindings/xml/libxml_xmlparser.c:327:16: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] 327 | xmlerr = xmlCtxtGetLastError(parser->xml_ctx); This commit adds a few #ifdefs to handle both versions of the API cleanly. It's probably not the sexiest fix, but it's simple and gets the job done. [...] Applied, thanks! John-Mark.
[netsurf-dev] Re: netsurf: branch jmb/ssl-purge created. release/3.11-16-g6bb70e881
On 08/02/2024 20:32, NetSurf Browser Project (Commit Mailer) wrote: Gitweb links: ...log http://git.netsurf-browser.org/netsurf.git/shortlog/6bb70e88108c904d67e9af7c8e5b273f6cd6854f ...commit http://git.netsurf-browser.org/netsurf.git/commit/6bb70e88108c904d67e9af7c8e5b273f6cd6854f ...tree http://git.netsurf-browser.org/netsurf.git/tree/6bb70e88108c904d67e9af7c8e5b273f6cd6854f The branch, jmb/ssl-purge has been created at 6bb70e88108c904d67e9af7c8e5b273f6cd6854f (commit) - Log - commitdiff http://git.netsurf-browser.org/netsurf.git/commit/?id=6bb70e88108c904d67e9af7c8e5b273f6cd6854f commit 6bb70e88108c904d67e9af7c8e5b273f6cd6854f Author: John-Mark Bell Commit: John-Mark Bell fetchers: drop support for ancient OpenSSL We now require 1.1.1 or later (and, preferably, 3.x). Also take the opportunity to add support for LibreSSL 3.5.0 or later (we still support ancient versions of this because 3.5.0 is still relatively modern -- give it a few more years and support for old LibreSSL can go, too) [...] This builds fine for me against both OpenSSL 1.1.1 and 3.x. All our SDKs contain 3.x so CI builds that use it should also be fine. However, I've not actually tested LibreSSL and I believe at least one of the Amiga builds uses AmiSSL. Can people who care about these things take a look at this change and ensure it works for you? Ta, John-Mark.
[netsurf-dev] Re: netsurf: branch jmb/ssl-purge created. release/3.11-16-g6bb70e881
Hi, The AmigaOS 3 build uses AmiSSL (OpenSSL doesn't connect to any sites for some years on that platform for some reason). As long as it is building against AmiSSL 5.x it will be using the OpenSSL 3 API. I did update the SDK to v5 but I think it needs somebody to forcibly rebuild it. Chris 8 Feb 2024 20:48:24 John-Mark Bell : > On 08/02/2024 20:32, NetSurf Browser Project (Commit Mailer) wrote: >> Gitweb links: >> ...log >> http://git.netsurf-browser.org/netsurf.git/shortlog/6bb70e88108c904d67e9af7c8e5b273f6cd6854f >> ...commit >> http://git.netsurf-browser.org/netsurf.git/commit/6bb70e88108c904d67e9af7c8e5b273f6cd6854f >> ...tree >> http://git.netsurf-browser.org/netsurf.git/tree/6bb70e88108c904d67e9af7c8e5b273f6cd6854f >> The branch, jmb/ssl-purge has been created >> at 6bb70e88108c904d67e9af7c8e5b273f6cd6854f (commit) >> - Log - >> commitdiff >> http://git.netsurf-browser.org/netsurf.git/commit/?id=6bb70e88108c904d67e9af7c8e5b273f6cd6854f >> commit 6bb70e88108c904d67e9af7c8e5b273f6cd6854f >> Author: John-Mark Bell >> Commit: John-Mark Bell >> fetchers: drop support for ancient OpenSSL >> We now require 1.1.1 or later (and, preferably, 3.x). >> Also take the opportunity to add support for LibreSSL 3.5.0 or >> later (we still support ancient versions of this because 3.5.0 is >> still relatively modern -- give it a few more years and support >> for old LibreSSL can go, too) > > [...] > > This builds fine for me against both OpenSSL 1.1.1 and 3.x. All our SDKs > contain 3.x so CI builds that use it should also be fine. However, I've not > actually tested LibreSSL and I believe at least one of the Amiga builds uses > AmiSSL. > > Can people who care about these things take a look at this change and ensure > it works for you? > > Ta, > > > John-Mark.
