Re: [PATCH net-next 0/7] virtnet_net: prepare for af-xdp

2024-05-26 Thread Jason Wang
On Thu, May 23, 2024 at 10:27 AM Xuan Zhuo  wrote:
>
> Any comments for this.
>
> Thanks.

Will have a look.

Btw, does Michael happy with moving files into a dedicated directory?

Thanks

>
> On Wed,  8 May 2024 16:05:07 +0800, Xuan Zhuo  
> wrote:
> > This patch set prepares for supporting af-xdp zerocopy.
> > There is no feature change in this patch set.
> > I just want to reduce the patch num of the final patch set,
> > so I split the patch set.
> >
> > #1-#3 add independent directory for virtio-net
> > #4-#7 do some refactor, the sub-functions will be used by the subsequent 
> > commits
> >
> > Thanks.
> >
> > Xuan Zhuo (7):
> >   virtio_net: independent directory
> >   virtio_net: move core structures to virtio_net.h
> >   virtio_net: add prefix virtnet to all struct inside virtio_net.h
> >   virtio_net: separate virtnet_rx_resize()
> >   virtio_net: separate virtnet_tx_resize()
> >   virtio_net: separate receive_mergeable
> >   virtio_net: separate receive_buf
> >
> >  MAINTAINERS   |   2 +-
> >  drivers/net/Kconfig   |   9 +-
> >  drivers/net/Makefile  |   2 +-
> >  drivers/net/virtio/Kconfig|  12 +
> >  drivers/net/virtio/Makefile   |   8 +
> >  drivers/net/virtio/virtnet.h  | 246 
> >  .../{virtio_net.c => virtio/virtnet_main.c}   | 534 ++
> >  7 files changed, 452 insertions(+), 361 deletions(-)
> >  create mode 100644 drivers/net/virtio/Kconfig
> >  create mode 100644 drivers/net/virtio/Makefile
> >  create mode 100644 drivers/net/virtio/virtnet.h
> >  rename drivers/net/{virtio_net.c => virtio/virtnet_main.c} (94%)
> >
> > --
> > 2.32.0.3.g01195cf9f
> >
>




Re: [PATCH net-next] virtio-net: synchronize operstate with admin state on up/down

2024-05-26 Thread Jason Wang
On Tue, May 21, 2024 at 4:14 PM Paolo Abeni  wrote:
>
> On Mon, 2024-05-20 at 09:03 +0800, Jason Wang wrote:
> > This patch synchronize operstate with admin state per RFC2863.
> >
> > This is done by trying to toggle the carrier upon open/close and
> > synchronize with the config change work. This allows propagate status
> > correctly to stacked devices like:
> >
> > ip link add link enp0s3 macvlan0 type macvlan
> > ip link set link enp0s3 down
> > ip link show
> >
> > Before this patch:
> >
> > 3: enp0s3:  mtu 1500 qdisc pfifo_fast state DOWN mode 
> > DEFAULT group default qlen 1000
> > link/ether 00:00:05:00:00:09 brd ff:ff:ff:ff:ff:ff
> > ..
> > 5: macvlan0@enp0s3:  mtu 1500 qdisc 
> > noqueue state UP mode DEFAULT group default qlen 1000
> > link/ether b2:a9:c5:04:da:53 brd ff:ff:ff:ff:ff:ff
> >
> > After this patch:
> >
> > 3: enp0s3:  mtu 1500 qdisc pfifo_fast state DOWN mode 
> > DEFAULT group default qlen 1000
> > link/ether 00:00:05:00:00:09 brd ff:ff:ff:ff:ff:ff
> > ...
> > 5: macvlan0@enp0s3:  mtu 1500 
> > qdisc noqueue state LOWERLAYERDOWN mode DEFAULT group default qlen 1000
> > link/ether b2:a9:c5:04:da:53 brd ff:ff:ff:ff:ff:ff
> >
> > Cc: Venkat Venkatsubra 
> > Cc: Gia-Khanh Nguyen 
> > Signed-off-by: Jason Wang 
>
> ## Form letter - net-next-closed
>
> The merge window for v6.10 has begun and we have already posted our
> pull
> request. Therefore net-next is closed for new drivers, features, code
> refactoring and optimizations. We are currently accepting bug fixes
> only.
>
> Please repost when net-next reopens after May 26th.

Will repost thanks.

>
> RFC patches sent for review only are obviously welcome at any time.
>
> See:
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle

Thanks for the pointer, I've done a short path by just looking at if
there's a patch with net-next posted in netdev :(

> --
> pw-bot: defer
>
>