Re: RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated [v6]
On Tue, 4 Feb 2025 14:26:23 GMT, Volkan Yazici wrote: >> Adds `test.lib.Utils::createTempFileOfSize` to generate >> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory >> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file >> tracked by git: >> >> >> $ git ls-files | while read f; do echo -e $(stat -c %s "$f")"\t$f"; done >> >/tmp/trackedFileSizes.txt >> $ sort -n /tmp/trackedFileSizes.txt | tail -n 4 >> 2730088 test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt >> 2798680 src/java.base/share/data/unicodedata/NormalizationTest.txt >> 3574947 test/jdk/java/foreign/libTestDowncallStack.c >> 7128495 test/jdk/java/foreign/libTestUpcallStack.c >> >> >> **Other highlights:** >> >> - `jdk.httpclient.test.lib.common.TestUtil` is removed in favor of similar >> alternatives in `test.lib.Utils` and `test.lib.Asserts` >> - `test.lib.Asserts::assertFileContentsEqual` is added > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing `assertFileContentsEqual` replacement to `FixedThreadPoolTest` @vy Your change (at version 5e9b30f431676c714cf81b85846f16c58c0dcdf6) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.org/jdk/pull/23401#issuecomment-2643664263
Integrated: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified
On Fri, 31 Jan 2025 01:45:47 GMT, Bradford Wetmore wrote: > Update and clarify the sample code. > > Docs only, no additional testing other than verifying javadoc is correctly > output. This pull request has now been integrated. Changeset: 88a84835 Author:Bradford Wetmore URL: https://git.openjdk.org/jdk/commit/88a84835a3a13f9adfcfa2ad034acff8fbc4fadc Stats: 17 lines in 1 file changed: 10 ins; 1 del; 6 mod 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified Reviewed-by: abarashev, jnimeh, dfuchs - PR: https://git.openjdk.org/jdk/pull/23379
RFR: 8349662: SSLTube SSLSubscriptionWrapper has potential races when switching subscriptions
Hi, Please find here a change that fixes a potential race condition in SSLTube.SSLSubscriptionWrapper. Typically the race may get triggered if the demand increased by request() is not exhausted by the time the subscription is switched by setSubscription. Some synchronization is required to present a consistent view of the subscripton state, so that pending demand can be consistently transferred to the new the subscription. This mostly affects HTTP/1.1 over TLS since each new exchange will cause the subscription to be switched to the new exchange. The race condition is elusive and hard to reproduce. when it occurs, it mostly causes tests to fail in jtreg timeout as the demand from upstream may not be transferred properly. Some additional logging has been added to the DigestEchoClient.java test class (which is used by DigestEchoClientSSL) to help diagnosability of intermittent failures in these tests. - Commit messages: - 8349662: SSLTube SSLSubscriptionWrapper has potential races when switching subscriptions Changes: https://git.openjdk.org/jdk/pull/23515/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23515&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349662 Stats: 147 lines in 3 files changed: 94 ins; 14 del; 39 mod Patch: https://git.openjdk.org/jdk/pull/23515.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23515/head:pull/23515 PR: https://git.openjdk.org/jdk/pull/23515
Re: RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated [v6]
On Tue, 4 Feb 2025 14:26:23 GMT, Volkan Yazici wrote: >> Adds `test.lib.Utils::createTempFileOfSize` to generate >> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory >> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file >> tracked by git: >> >> >> $ git ls-files | while read f; do echo -e $(stat -c %s "$f")"\t$f"; done >> >/tmp/trackedFileSizes.txt >> $ sort -n /tmp/trackedFileSizes.txt | tail -n 4 >> 2730088 test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt >> 2798680 src/java.base/share/data/unicodedata/NormalizationTest.txt >> 3574947 test/jdk/java/foreign/libTestDowncallStack.c >> 7128495 test/jdk/java/foreign/libTestUpcallStack.c >> >> >> **Other highlights:** >> >> - `jdk.httpclient.test.lib.common.TestUtil` is removed in favor of similar >> alternatives in `test.lib.Utils` and `test.lib.Asserts` >> - `test.lib.Asserts::assertFileContentsEqual` is added > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing `assertFileContentsEqual` replacement to `FixedThreadPoolTest` The updated changes look good to me. - Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23401#pullrequestreview-2601992489
Re: RFR: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified [v4]
On Thu, 6 Feb 2025 19:31:24 GMT, Bradford Wetmore wrote: >> Update and clarify the sample code. >> >> Docs only, no additional testing other than verifying javadoc is correctly >> output. > > Bradford Wetmore has updated the pull request incrementally with one > additional commit since the last revision: > > minor wording tweak Marked as reviewed by jnimeh (Reviewer). The comment changes look good to me also. - PR Review: https://git.openjdk.org/jdk/pull/23379#pullrequestreview-2602167697 PR Comment: https://git.openjdk.org/jdk/pull/23379#issuecomment-2643355946