Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket
On Wed, 2 Mar 2022 07:13:36 GMT, TheShermanTanker wrote: >> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was >> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / >> Socket.shutdownOutput() and InputStream.close() / OutputStream.close() >> performed half-close of TLS-1.3 connection. However this behaviour has >> changed as result of JDK-8216326 [2]. InputStream.close() / >> OutputStream.close() no longer perform half-close but full socket close, but >> API Note was never updated. >> >> [1] https://bugs.openjdk.java.net/browse/JDK-8208526 >> [2] https://bugs.openjdk.java.net/browse/JDK-8216326 > > @zzambers I've created a corresponding issue for you in the tracker, please > rename your PR title to 8282529 and the system should automatically mark your > PR as ready for review @TheShermanTanker thank you - PR: https://git.openjdk.java.net/jdk/pull/7648
RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket
Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / Socket.shutdownOutput() and InputStream.close() / OutputStream.close() performed half-close of TLS-1.3 connection. However this behaviour has changed as result of JDK-8216326 [2]. InputStream.close() / OutputStream.close() no longer perform half-close but full socket close, but API Note was never updated. [1] https://bugs.openjdk.java.net/browse/JDK-8208526 [2] https://bugs.openjdk.java.net/browse/JDK-8216326 - Commit messages: - javax/net/ssl/SSLSocket: Fixed API Note in javadoc Changes: https://git.openjdk.java.net/jdk/pull/7648/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7648&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282529 Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/7648.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7648/head:pull/7648 PR: https://git.openjdk.java.net/jdk/pull/7648
Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]
> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed half-close of TLS-1.3 connection. However this behaviour has > changed as result of JDK-8216326 [2]. InputStream.close() / > OutputStream.close() no longer perform half-close but full socket close, but > API Note was never updated. > > [1] https://bugs.openjdk.java.net/browse/JDK-8208526 > [2] https://bugs.openjdk.java.net/browse/JDK-8216326 zzambers has updated the pull request incrementally with one additional commit since the last revision: Updated copyright for SSLSocket.java - Changes: - all: https://git.openjdk.java.net/jdk/pull/7648/files - new: https://git.openjdk.java.net/jdk/pull/7648/files/ff33d3f6..7fe494ab Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7648&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7648&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/7648.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7648/head:pull/7648 PR: https://git.openjdk.java.net/jdk/pull/7648
Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]
On Fri, 4 Mar 2022 23:43:30 GMT, Bradford Wetmore wrote: >> zzambers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated copyright for SSLSocket.java > > There are more changes needed, and should probably be done as part of this > issue since we're already in this code anyway. The current code only talks > about shutdownInput/shutdownOutput, but makes no mention of the duplex > close(), which is the other way to shutdown the SSLSocket. It only needs a > few words. > > https://mail.openjdk.java.net/pipermail/security-dev/2022-March/029167.html > https://mail.openjdk.java.net/pipermail/security-dev/2022-March/029209.html > > These two changes will require a CSR to update the @ apiNote. @bradfordwetmore Sure if more changes are desired I can pull your changes. When It comes to CSR I am not fully familiar with the process. Is action expected from my side? - PR: https://git.openjdk.java.net/jdk/pull/7648
Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v3]
> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed half-close of TLS-1.3 connection. However this behaviour has > changed as result of JDK-8216326 [2]. InputStream.close() / > OutputStream.close() no longer perform half-close but full socket close, but > API Note was never updated. > > [1] https://bugs.openjdk.java.net/browse/JDK-8208526 > [2] https://bugs.openjdk.java.net/browse/JDK-8216326 zzambers has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: javax/net/ssl/SSLSocket: Fixed API Note in javadoc - Changes: https://git.openjdk.java.net/jdk/pull/7648/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7648&range=02 Stats: 13 lines in 1 file changed: 2 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/7648.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7648/head:pull/7648 PR: https://git.openjdk.java.net/jdk/pull/7648
Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]
On Mon, 7 Mar 2022 21:01:12 GMT, Bradford Wetmore wrote: >> @bradfordwetmore Sure if more changes are desired I can pull your changes. >> When It comes to CSR I am not fully familiar with the process. Is action >> expected from my side? > >> Sure if more changes are desired I can pull your changes. When It comes to >> CSR I am not fully familiar with the > process. Is action expected from my side? > > One of us needs to get the CSR approved. Why don't you pull the changes > described in: > > https://mail.openjdk.java.net/pipermail/security-dev/2022-March/029209.html > > Assuming you are ok with the updated wording, I can create the CSR and > submit. Once that it approved, then we can get this PR approved and you can > integrate. > > Are you at contributor status? @bradfordwetmore I have updated this PR with your patch. I am covered by OCA. - PR: https://git.openjdk.java.net/jdk/pull/7648
Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v3]
On Tue, 8 Mar 2022 14:21:19 GMT, zzambers wrote: >> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was >> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / >> Socket.shutdownOutput() and InputStream.close() / OutputStream.close() >> performed half-close of TLS-1.3 connection. However this behaviour has >> changed as result of JDK-8216326 [2]. InputStream.close() / >> OutputStream.close() no longer perform half-close but full socket close, but >> API Note was never updated. >> >> [1] https://bugs.openjdk.java.net/browse/JDK-8208526 >> [2] https://bugs.openjdk.java.net/browse/JDK-8216326 > > zzambers has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains one commit: > > javax/net/ssl/SSLSocket: Fixed API Note in javadoc But I am not a Commiter (I need sponsor). - PR: https://git.openjdk.java.net/jdk/pull/7648
Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v4]
> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed half-close of TLS-1.3 connection. However this behaviour has > changed as result of JDK-8216326 [2]. InputStream.close() / > OutputStream.close() no longer perform half-close but full socket close, but > API Note was never updated. > > [1] https://bugs.openjdk.java.net/browse/JDK-8208526 > [2] https://bugs.openjdk.java.net/browse/JDK-8216326 zzambers has updated the pull request incrementally with one additional commit since the last revision: small fixes - Changes: - all: https://git.openjdk.java.net/jdk/pull/7648/files - new: https://git.openjdk.java.net/jdk/pull/7648/files/ddd59a9e..38d649e9 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7648&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7648&range=02-03 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/7648.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7648/head:pull/7648 PR: https://git.openjdk.java.net/jdk/pull/7648
Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]
On Mon, 7 Mar 2022 21:01:12 GMT, Bradford Wetmore wrote: >> @bradfordwetmore Sure if more changes are desired I can pull your changes. >> When It comes to CSR I am not fully familiar with the process. Is action >> expected from my side? > >> Sure if more changes are desired I can pull your changes. When It comes to >> CSR I am not fully familiar with the > process. Is action expected from my side? > > One of us needs to get the CSR approved. Why don't you pull the changes > described in: > > https://mail.openjdk.java.net/pipermail/security-dev/2022-March/029209.html > > Assuming you are ok with the updated wording, I can create the CSR and > submit. Once that it approved, then we can get this PR approved and you can > integrate. > > Are you at contributor status? @bradfordwetmore Your changes look good to me. When it comes to wording, I'll let that to native english speaker(s) to judge :) (As I am not native english speaker myself). I built docs locally and result looks good (also links work), there was just one problem with brace, but I have fixed that. - PR: https://git.openjdk.java.net/jdk/pull/7648
Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]
On Sat, 12 Mar 2022 01:43:16 GMT, Bradford Wetmore wrote: >> @bradfordwetmore Your changes look good to me. When it comes to wording, >> I'll let that to native english speaker(s) to judge :) (As I am not native >> english speaker myself). I built docs locally and result looks good (also >> links work), there was just one problem with brace, but I have fixed that. > > @zzambers, the CSR was approved yesterday, and is just waiting your > integration. I will sponsor it. @bradfordwetmore, thanks - PR: https://git.openjdk.java.net/jdk/pull/7648
Integrated: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket
On Tue, 1 Mar 2022 17:09:57 GMT, zzambers wrote: > Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed half-close of TLS-1.3 connection. However this behaviour has > changed as result of JDK-8216326 [2]. InputStream.close() / > OutputStream.close() no longer perform half-close but full socket close, but > API Note was never updated. > > [1] https://bugs.openjdk.java.net/browse/JDK-8208526 > [2] https://bugs.openjdk.java.net/browse/JDK-8216326 This pull request has now been integrated. Changeset: 08573cc3 Author:Zdenek Zambersky Committer: Bradford Wetmore URL: https://git.openjdk.java.net/jdk/commit/08573cc3b2370a697a7bd4ad0665ee20ae148d39 Stats: 13 lines in 1 file changed: 2 ins; 0 del; 11 mod 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket Reviewed-by: wetmore, xuelei - PR: https://git.openjdk.java.net/jdk/pull/7648
