hg: jdk8/tl/jdk: 7200277: [parfait] potential buffer overflow in npt/utf.c
Changeset: 94cc251d0c45 Author:sla Date: 2013-09-20 16:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94cc251d0c45 7200277: [parfait] potential buffer overflow in npt/utf.c Reviewed-by: dsamersoff, dcubed ! src/share/npt/utf.c
hg: jdk8/tl/jdk: 8023492: jfr.jar gets loaded even though it's not used
Changeset: cceaad499685 Author:sla Date: 2013-09-30 12:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cceaad499685 8023492: jfr.jar gets loaded even though it's not used Reviewed-by: erikj, mgronlun ! make/tools/src/build/tools/buildmetaindex/BuildMetaIndex.java
hg: jdk8/tl/jdk: 6696975: JTop plugin fails if connected readonly to target JVM
Changeset: 3bb89c509d59 Author:egahlin Date: 2013-10-01 17:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3bb89c509d59 6696975: JTop plugin fails if connected readonly to target JVM Reviewed-by: mchung, jbachorik, sla, sjiang ! src/share/demo/management/JTop/JTop.java
hg: jdk8/tl/jdk: 8025829: Add java/lang/instrument/RetransformBigClass.sh to problemlist
Changeset: 77ba1e67707c Author:allwin Date: 2013-10-04 15:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77ba1e67707c 8025829: Add java/lang/instrument/RetransformBigClass.sh to problemlist Reviewed-by: sla, jbachorik ! test/ProblemList.txt
hg: jdk8/tl/jdk: 8025427: jstat tests fails on 32-bit platforms
Changeset: 6aa637dde16e Author:sla Date: 2013-10-10 09:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6aa637dde16e 8025427: jstat tests fails on 32-bit platforms Reviewed-by: ehelin, dsamersoff, dholmes, sspitsyn ! src/share/classes/sun/tools/jstat/RowClosure.java ! test/ProblemList.txt ! test/sun/tools/jstat/gcCauseOutput1.awk ! test/sun/tools/jstat/lineCounts1.awk ! test/sun/tools/jstat/lineCounts2.awk ! test/sun/tools/jstat/lineCounts3.awk ! test/sun/tools/jstat/lineCounts4.awk ! test/sun/tools/jstat/timeStamp1.awk ! test/sun/tools/jstatd/jstatGcutilOutput1.awk
hg: jdk8/tl/jdk: 8014446: JT_JDK: Wrong detection of test result for test com/sun/jdi/NoLaunchOptionTest.java
Changeset: 998560cccefc Author:allwin Date: 2013-10-10 10:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/998560cccefc 8014446: JT_JDK: Wrong detection of test result for test com/sun/jdi/NoLaunchOptionTest.java Reviewed-by: sla, mgronlun, dholmes, jbachorik, chegar ! test/com/sun/jdi/NoLaunchOptionTest.java
hg: jdk8/tl/jdk: 8021897: EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals()
Changeset: 8479a48d9fd4 Author:sla Date: 2013-10-18 11:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8479a48d9fd4 8021897: EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals() Reviewed-by: alanb, sspitsyn ! src/share/back/outStream.c + test/com/sun/jdi/GetUninitializedStringValue.java
hg: jdk8/tl/jdk: 8026962: Put java/lang/management/ClassLoadingMXBean/LoadCounts.java into ProblemList.txt
Changeset: bb2fb6be8b2a Author:ykantser Date: 2013-10-22 10:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb2fb6be8b2a 8026962: Put java/lang/management/ClassLoadingMXBean/LoadCounts.java into ProblemList.txt Reviewed-by: sla, jbachorik ! test/ProblemList.txt
hg: jdk8/tl/jdk: 8026789: Update test/java/lang/instrument/Re(transform|define)BigClass.sh test to use NMT for memory leak detection
Changeset: 8c20e9ef8709 Author:sla Date: 2013-10-23 15:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c20e9ef8709 8026789: Update test/java/lang/instrument/Re(transform|define)BigClass.sh test to use NMT for memory leak detection Reviewed-by: dcubed ! test/ProblemList.txt + test/java/lang/instrument/NMTHelper.java ! test/java/lang/instrument/RedefineBigClass.sh ! test/java/lang/instrument/RedefineBigClassApp.java ! test/java/lang/instrument/RetransformBigClass.sh ! test/java/lang/instrument/RetransformBigClassApp.java
hg: jdk8/tl/jdk: 8009681: TEST_BUG: MethodExitReturnValuesTest.java may fail when there are unexpected background threads
Changeset: e6bc0dca294b Author:sla Date: 2013-10-15 12:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6bc0dca294b 8009681: TEST_BUG: MethodExitReturnValuesTest.java may fail when there are unexpected background threads Reviewed-by: sla, allwin Contributed-by: mikael.a...@oracle.com ! test/com/sun/jdi/MethodEntryExitEvents.java ! test/com/sun/jdi/MethodExitReturnValuesTest.java
hg: jdk8/tl/jdk: 8027371: Add JDI tests for breakpointing and stepping in lambda code
Changeset: ecba02f6be31 Author:sla Date: 2013-10-29 08:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecba02f6be31 8027371: Add JDI tests for breakpointing and stepping in lambda code Reviewed-by: mchung, sspitsyn + test/com/sun/jdi/LambdaBreakpointTest.java + test/com/sun/jdi/LambdaStepTest.java
hg: jdk8/tl/jdk: 8022229: Intermittent test failures in sun/tools/jstatd
Changeset: b04b124418d8 Author:ykantser Date: 2013-10-30 13:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b04b124418d8 809: Intermittent test failures in sun/tools/jstatd Reviewed-by: sla, egahlin, jbachorik, allwin + test/lib/testlibrary/jdk/testlibrary/Asserts.java + test/lib/testlibrary/jdk/testlibrary/JDKToolFinder.java + test/lib/testlibrary/jdk/testlibrary/JDKToolLauncher.java + test/lib/testlibrary/jdk/testlibrary/Platform.java + test/lib/testlibrary/jdk/testlibrary/ProcessThread.java + test/lib/testlibrary/jdk/testlibrary/TestThread.java + test/lib/testlibrary/jdk/testlibrary/Utils.java + test/lib/testlibrary/jdk/testlibrary/XRun.java + test/sun/tools/jstatd/JstatGCUtilParser.java + test/sun/tools/jstatd/JstatdTest.java + test/sun/tools/jstatd/TestJstatdDefaults.java + test/sun/tools/jstatd/TestJstatdExternalRegistry.java + test/sun/tools/jstatd/TestJstatdPort.java + test/sun/tools/jstatd/TestJstatdPortAndServer.java + test/sun/tools/jstatd/TestJstatdServer.java + test/sun/tools/jstatd/TestJstatdUsage.java - test/sun/tools/jstatd/jpsOutput1.awk - test/sun/tools/jstatd/jstatGcutilOutput1.awk - test/sun/tools/jstatd/jstatdDefaults.sh - test/sun/tools/jstatd/jstatdExternalRegistry.sh - test/sun/tools/jstatd/jstatdPort.sh - test/sun/tools/jstatd/jstatdServerName.sh - test/sun/tools/jstatd/jstatdUsage1.sh - test/sun/tools/jstatd/usage.out
hg: jdk8/tl/jdk: 8027692: Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from ProblemList.txt
Changeset: c35f6df5bce9 Author:sla Date: 2013-11-01 10:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c35f6df5bce9 8027692: Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from ProblemList.txt Reviewed-by: stefank, alanb ! test/ProblemList.txt
hg: jdk8/tl/jdk: 8027705: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events.
Changeset: c59ccad6eb72 Author:sla Date: 2013-11-01 15:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c59ccad6eb72 8027705: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events. Reviewed-by: dcubed ! test/com/sun/jdi/JdbMethodExitTest.sh ! test/com/sun/jdi/ShellScaffold.sh
hg: jdk8/tl/jdk: 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object
Changeset: 8a4405fb40ba Author:ykantser Date: 2013-11-07 16:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a4405fb40ba 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object Reviewed-by: sla, jbachorik ! test/sun/tools/jstatd/JstatdTest.java
hg: jdk8/tl/jdk: 8014506: Test of Jdp feature
Changeset: 0cacac7f5c37 Author:sla Date: 2013-11-08 18:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cacac7f5c37 8014506: Test of Jdp feature Reviewed-by: sla Contributed-by: Alex Schenkman + test/sun/management/jdp/ClientConnection.java + test/sun/management/jdp/DynamicLauncher.java ! test/sun/management/jdp/JdpClient.java + test/sun/management/jdp/JdpDefaultsTest.java ! test/sun/management/jdp/JdpDoSomething.java + test/sun/management/jdp/JdpOffTest.java + test/sun/management/jdp/JdpOffTestCase.java + test/sun/management/jdp/JdpOnTestCase.java + test/sun/management/jdp/JdpSpecificAddressTest.java ! test/sun/management/jdp/JdpTest.sh + test/sun/management/jdp/JdpTestCase.java + test/sun/management/jdp/JdpTestUtil.java + test/sun/management/jdp/JdpTestUtilTest.java ! test/sun/management/jdp/JdpUnitTest.java + test/sun/management/jdp/PacketTest.java + test/sun/management/jdp/PortAlreadyInUseTest.java + test/sun/management/jdp/README
hg: jdk8/tl/jdk: 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary
Changeset: a42a416351b8 Author:ykantser Date: 2013-11-13 11:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a42a416351b8 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary Reviewed-by: sla + test/lib/testlibrary/AssertsTest.java + test/lib/testlibrary/OutputAnalyzerReportingTest.java + test/lib/testlibrary/jdk/testlibrary/InputArguments.java ! test/lib/testlibrary/jdk/testlibrary/JcmdBase.java - test/lib/testlibrary/jdk/testlibrary/JdkFinder.java ! test/lib/testlibrary/jdk/testlibrary/OutputAnalyzer.java ! test/lib/testlibrary/jdk/testlibrary/ProcessTools.java ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java
hg: jdk8/tl/jdk: 8027765: Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent
Changeset: 65f7b83ab477 Author:sla Date: 2013-11-14 19:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/65f7b83ab477 8027765: Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent Reviewed-by: alanb, allwin, sspitsyn, mgronlun ! src/share/classes/sun/tools/jinfo/JInfo.java ! src/share/classes/sun/tools/jmap/JMap.java ! src/share/classes/sun/tools/jps/Jps.java ! src/share/classes/sun/tools/jstack/JStack.java
hg: jdk8/tl/jdk: 8023138: [TEST_BUG] java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently
Changeset: 64a492bc0ba7 Author:sla Date: 2013-11-14 12:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64a492bc0ba7 8023138: [TEST_BUG] java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently Summary: Port tests for java/lang/instrument/PremainClass from script to java Reviewed-by: sla Contributed-by: mattias.tobias...@oracle.com - test/java/lang/instrument/PremainClass/NoPremainAgent.sh + test/java/lang/instrument/PremainClass/NoPremainAgentTest.java + test/java/lang/instrument/PremainClass/PremainClassTest.java - test/java/lang/instrument/PremainClass/PremainClassTest.sh - test/java/lang/instrument/PremainClass/ZeroArgPremainAgent.sh + test/java/lang/instrument/PremainClass/ZeroArgPremainAgentTest.java ! test/lib/testlibrary/jdk/testlibrary/Utils.java
hg: jdk8/tl/jdk: 8028632: Update jdk/test/ProblemList.txt to reflect fix JDK-8024423
Changeset: fc9f24b9408e Author:sla Date: 2013-11-21 12:57 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc9f24b9408e 8028632: Update jdk/test/ProblemList.txt to reflect fix JDK-8024423 Summary: Removed 5 testcases from the ProblemList Reviewed-by: sla Contributed-by: balchandra.vai...@oracle.com ! test/ProblemList.txt
hg: jdk8/tl/jdk: 6461635: [TESTBUG] BasicTests.sh test fails intermittently
Changeset: d30f49aa2d01 Author:sla Date: 2013-12-03 17:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d30f49aa2d01 6461635: [TESTBUG] BasicTests.sh test fails intermittently Summary: Transform dummy class instead of BigInteger to avoid complication by -Xshare. Ported from script to java. Reviewed-by: alanb Contributed-by: mattias.tobias...@oracle.com ! test/ProblemList.txt - test/com/sun/tools/attach/AgentSetup.sh ! test/com/sun/tools/attach/Application.java - test/com/sun/tools/attach/ApplicationSetup.sh ! test/com/sun/tools/attach/BasicTests.java - test/com/sun/tools/attach/BasicTests.sh - test/com/sun/tools/attach/CommonSetup.sh ! test/com/sun/tools/attach/PermissionTest.java - test/com/sun/tools/attach/PermissionTests.sh ! test/com/sun/tools/attach/ProviderTest.java - test/com/sun/tools/attach/ProviderTests.sh ! test/com/sun/tools/attach/RedefineAgent.java + test/com/sun/tools/attach/RedefineDummy.java + test/com/sun/tools/attach/RunnerUtil.java ! test/lib/testlibrary/jdk/testlibrary/ProcessThread.java ! test/lib/testlibrary/jdk/testlibrary/ProcessTools.java ! test/lib/testlibrary/jdk/testlibrary/Utils.java ! test/sun/tools/jstatd/JstatdTest.java
Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests
Volker, I’ve look at the following files: src/share/native/sun/management/DiagnosticCommandImpl.c: nit: “legel” -> “legal” (two times) In Java_sun_management_DiagnosticCommandImpl_getDiagnosticCommandInfo() if you allow dcmd_info_array to become NULL, then jmm_interface->GetDiagnosticCommandInfo() will throw an NPE and you need to check that. src/solaris/native/sun/management/OperatingSystemImpl.c No comments. src/share/transport/socket/socketTransport.c No comments. src/share/classes/sun/tools/attach/META-INF/services/com.sun.tools.attach.spi.AttachProvider No comments. Thanks, /Staffan On 14 jan 2014, at 09:40, Volker Simonis wrote: > Hi, > > could you please review the following changes for the ppc-aix-port > stage/stage-9 repositories (the changes are planned for integration into > ppc-aix-port/stage-9 and subsequent backporting to ppc-aix-port/stage): > > http://cr.openjdk.java.net/~simonis/webrevs/8031581/ > > I've build and smoke tested without any problems on Linux/x86_64 and PPC64, > Windows/x86_64, MacOSX, Solaris/SPARC64 and AIX7PPC64. > > With these changes (and together with the changes from "8028537: PPC64: > Updated jdk/test scripts to understand the AIX os and environment" and > "8031134 : PPC64: implement printing on AIX") our port passes all but the > following 7 jtreg regression tests on AIX (compared to the Linux/x86_64 > baseline from www.java.net/download/jdk8/testresults/testresults.html): > > java/net/Inet6Address/B6558853.java > java/nio/channels/AsynchronousChannelGroup/Basic.java (sporadically) > java/nio/channels/AsynchronousChannelGroup/GroupOfOne.java > java/nio/channels/AsynchronousChannelGroup/Unbounded.java (sporadically) > java/nio/channels/Selector/RacyDeregister.java > sun/security/krb5/auto/Unreachable.java (only on IPv6) > > Thank you and best regards, > Volker > > > Following a detailed description of the various changes: > src/share/native/java/util/zip/zip_util.c > src/share/native/sun/management/DiagnosticCommandImpl.c > > According to ISO C it is perfectly legal for malloc to return zero if called > with a zero argument. Fix various places where malloc can potentially > correctly return zero because it was called with a zero argument. > Also fixed DiagnosticCommandImpl.c to include stdlib.h. This only fixes a > compiler warning on Linux, but on AIX it prevents a VM crash later on because > the return value of malloc() will be casted to int which is especially bad if > that pointer was bigger than 32-bit. > make/CompileJavaClasses.gmk > > Also use PollingWatchService on AIX. > make/lib/NioLibraries.gmk > src/aix/native/sun/nio/ch/AixNativeThread.c > > Put the implementation for the native methods of NativeThread into > AixNativeThread.c on AIX. > src/solaris/native/sun/nio/ch/PollArrayWrapper.c > src/solaris/native/sun/nio/ch/Net.c > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/native/sun/nio/ch/AixPollPort.c > src/aix/native/java/net/aix_close.c > > On AIX, the constants used for the polling events (i.e. POLLIN, POLLOUT, ...) > are defined to different values than on other operating systems. The problem > is however, that these constants are hardcoded as public final static members > of various, shared Java classes. We therefore have to map them from Java to > native every time before calling one of the native poll functions and back to > Java after the call on AIX in order to get the right semantics. > src/share/classes/java/nio/file/CopyMoveHelper.java > > As discussed on the core-libs mailing list (see > http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-December/024119.html) > it is not necessary to call Files.getFileAttributeView() with any > linkOptions because at that place we've already checked that the target file > can not be a symbolic link. This change makes the implementation more robust > on platforms which support symbolic links but do not support the O_NOFOLLOW > flag to the open system call. It also makes the JDK pass the > demo/zipfs/basic.sh test on AIX. > src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java > > Support "compound text" on AIX in the same way like on other Unix platforms. > src/share/classes/sun/tools/attach/META-INF/services/com.sun.tools.attach.spi.AttachProvider > > Define the correct attach provider for AIX. > src/solaris/native/java/net/net_util_md.h > src/solaris/native/sun/nio/ch/FileDispatcherImpl.c > src/solaris/native/sun/nio/ch/ServerSocketChannelImpl.c > > AIX needs a workaround for I/O cancellation (see: > http://publib.boulder.ibm.com/infocenter/pseries/v5r3/index.jsp?topic=/com.ibm.aix.basetechref/doc/basetrf1/close.htm). > "..The close() subroutine is blocked until all subroutines which use the > file descriptor return to usr space. For example, when a thread is calling > close and another thread is calling select with the same file descriptor, the > close subroutine does not return until the select call returns...". To fix > this pro
Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests
Yes, that looks like a good solution.
/Staffan
On 15 jan 2014, at 17:34, Volker Simonis wrote:
> Hi Staffan,
>
> thanks for the review. Please find my comments inline:
>
> On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen
> wrote:
> Volker,
>
> I’ve look at the following files:
>
> src/share/native/sun/management/DiagnosticCommandImpl.c:
> nit: “legel” -> “legal” (two times)
> In Java_sun_management_DiagnosticCommandImpl_getDiagnosticCommandInfo() if
> you allow dcmd_info_array to become NULL, then
> jmm_interface->GetDiagnosticCommandInfo() will throw an NPE and you need to
> check that.
>
> Good catch. I actually had problems with malloc returning NULL in
> 'getDiagnosticCommandArgumentInfoArray()' and then changed all other
> potentially dangerous locations which used the same pattern.
>
> However I think if the 'dcmd_info_array' has zero length it would be
> perfectly fine to return a zero length array. So what about the following
> solution:
>
> dcmdInfoCls = (*env)->FindClass(env,
> "sun/management/DiagnosticCommandInfo");
> num_commands = (*env)->GetArrayLength(env, commands);
> if (num_commands = 0) {
> result = (*env)->NewObjectArray(env, 0, dcmdInfoCls, NULL);
> if (result == NULL) {
> JNU_ThrowOutOfMemoryError(env, 0);
> }
> else {
> return result;
> }
> }
> dcmd_info_array = (dcmdInfo*) malloc(num_commands * sizeof(dcmdInfo));
> if (dcmd_info_array == NULL) {
> JNU_ThrowOutOfMemoryError(env, NULL);
> }
> jmm_interface->GetDiagnosticCommandInfo(env, commands, dcmd_info_array);
> result = (*env)->NewObjectArray(env, num_commands, dcmdInfoCls, NULL);
>
> That seems easier and saves me from handling the exception.
>
> What do you think?
>
> src/solaris/native/sun/management/OperatingSystemImpl.c
> No comments.
>
> src/share/transport/socket/socketTransport.c
> No comments.
>
> src/share/classes/sun/tools/attach/META-INF/services/com.sun.tools.attach.spi.AttachProvider
> No comments.
>
>
> Thanks,
> /Staffan
>
>
>
> On 14 jan 2014, at 09:40, Volker Simonis wrote:
>
>> Hi,
>>
>> could you please review the following changes for the ppc-aix-port
>> stage/stage-9 repositories (the changes are planned for integration into
>> ppc-aix-port/stage-9 and subsequent backporting to ppc-aix-port/stage):
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/8031581/
>>
>> I've build and smoke tested without any problems on Linux/x86_64 and PPC64,
>> Windows/x86_64, MacOSX, Solaris/SPARC64 and AIX7PPC64.
>>
>> With these changes (and together with the changes from "8028537: PPC64:
>> Updated jdk/test scripts to understand the AIX os and environment" and
>> "8031134 : PPC64: implement printing on AIX") our port passes all but the
>> following 7 jtreg regression tests on AIX (compared to the Linux/x86_64
>> baseline from www.java.net/download/jdk8/testresults/testresults.html):
>>
>> java/net/Inet6Address/B6558853.java
>> java/nio/channels/AsynchronousChannelGroup/Basic.java (sporadically)
>> java/nio/channels/AsynchronousChannelGroup/GroupOfOne.java
>> java/nio/channels/AsynchronousChannelGroup/Unbounded.java (sporadically)
>> java/nio/channels/Selector/RacyDeregister.java
>> sun/security/krb5/auto/Unreachable.java (only on IPv6)
>>
>> Thank you and best regards,
>> Volker
>>
>>
>> Following a detailed description of the various changes:
>> src/share/native/java/util/zip/zip_util.c
>> src/share/native/sun/management/DiagnosticCommandImpl.c
>>
>> According to ISO C it is perfectly legal for malloc to return zero if called
>> with a zero argument. Fix various places where malloc can potentially
>> correctly return zero because it was called with a zero argument.
>> Also fixed DiagnosticCommandImpl.c to include stdlib.h. This only fixes a
>> compiler warning on Linux, but on AIX it prevents a VM crash later on
>> because the return value of malloc() will be casted to int which is
>> especially bad if that pointer was bigger than 32-bit.
>> make/CompileJavaClasses.gmk
>>
>> Also use PollingWatchService on AIX.
>> make/lib/NioLibraries.gmk
>> src/aix/native/sun/nio/ch/AixNativeThread.c
>>
>> Put the implementation for the native methods of NativeThread into
>> AixNativeThread.c on AIX.
>> src/solaris/native/sun/nio/ch/PollArrayWrapper.c
>> src/solaris/native/sun/nio/ch/Net.c
>> src/aix/classes/sun/n
Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests
On 15 jan 2014, at 18:27, Volker Simonis wrote:
> On Wed, Jan 15, 2014 at 5:34 PM, Volker Simonis
> wrote:
>> Hi Staffan,
>>
>> thanks for the review. Please find my comments inline:
>>
>> On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen
>> wrote:
>>>
>>> Volker,
>>>
>>> I’ve look at the following files:
>>>
>>> src/share/native/sun/management/DiagnosticCommandImpl.c:
>>> nit: “legel” -> “legal” (two times)
>>> In Java_sun_management_DiagnosticCommandImpl_getDiagnosticCommandInfo() if
>>> you allow dcmd_info_array to become NULL, then
>>> jmm_interface->GetDiagnosticCommandInfo() will throw an NPE and you need to
>>> check that.
>>
>>
>> Good catch. I actually had problems with malloc returning NULL in
>> 'getDiagnosticCommandArgumentInfoArray()' and then changed all other
>> potentially dangerous locations which used the same pattern.
>>
>> However I think if the 'dcmd_info_array' has zero length it would be
>> perfectly fine to return a zero length array. So what about the following
>> solution:
>>
>> dcmdInfoCls = (*env)->FindClass(env,
>> "sun/management/DiagnosticCommandInfo");
>> num_commands = (*env)->GetArrayLength(env, commands);
>
> Sorry, of course I wanted to say "if (num_commands == 0)" here!
I understood as much :-)
>
>> if (num_commands = 0) {
>> result = (*env)->NewObjectArray(env, 0, dcmdInfoCls, NULL);
>> if (result == NULL) {
>> JNU_ThrowOutOfMemoryError(env, 0);
>> }
>> else {
>> return result;
>> }
>> }
>> dcmd_info_array = (dcmdInfo*) malloc(num_commands * sizeof(dcmdInfo));
>> if (dcmd_info_array == NULL) {
>> JNU_ThrowOutOfMemoryError(env, NULL);
>> }
>> jmm_interface->GetDiagnosticCommandInfo(env, commands, dcmd_info_array);
>> result = (*env)->NewObjectArray(env, num_commands, dcmdInfoCls, NULL);
>>
>> That seems easier and saves me from handling the exception.
>>
>> What do you think?
>>
>>> src/solaris/native/sun/management/OperatingSystemImpl.c
>>> No comments.
>>>
>>> src/share/transport/socket/socketTransport.c
>>> No comments.
>>>
>>>
>>> src/share/classes/sun/tools/attach/META-INF/services/com.sun.tools.attach.spi.AttachProvider
>>> No comments.
>>>
>>>
>>> Thanks,
>>> /Staffan
>>>
>>>
>>>
>>> On 14 jan 2014, at 09:40, Volker Simonis wrote:
>>>
>>> Hi,
>>>
>>> could you please review the following changes for the ppc-aix-port
>>> stage/stage-9 repositories (the changes are planned for integration into
>>> ppc-aix-port/stage-9 and subsequent backporting to ppc-aix-port/stage):
>>>
>>> http://cr.openjdk.java.net/~simonis/webrevs/8031581/
>>>
>>> I've build and smoke tested without any problems on Linux/x86_64 and
>>> PPC64, Windows/x86_64, MacOSX, Solaris/SPARC64 and AIX7PPC64.
>>>
>>> With these changes (and together with the changes from "8028537: PPC64:
>>> Updated jdk/test scripts to understand the AIX os and environment" and
>>> "8031134 : PPC64: implement printing on AIX") our port passes all but the
>>> following 7 jtreg regression tests on AIX (compared to the Linux/x86_64
>>> baseline from www.java.net/download/jdk8/testresults/testresults.html):
>>>
>>> java/net/Inet6Address/B6558853.java
>>> java/nio/channels/AsynchronousChannelGroup/Basic.java (sporadically)
>>> java/nio/channels/AsynchronousChannelGroup/GroupOfOne.java
>>> java/nio/channels/AsynchronousChannelGroup/Unbounded.java (sporadically)
>>> java/nio/channels/Selector/RacyDeregister.java
>>> sun/security/krb5/auto/Unreachable.java (only on IPv6)
>>>
>>> Thank you and best regards,
>>> Volker
>>>
>>>
>>> Following a detailed description of the various changes:
>>>
>>> src/share/native/java/util/zip/zip_util.c
>>> src/share/native/sun/management/DiagnosticCommandImpl.c
>>>
>>> According to ISO C it is perfectly legal for malloc to return zero if
>>> called with a zero argument. Fix various places where malloc can potentially
>>> correctly return zero because it was called with a zero argument.
>>> Also fixed DiagnosticCommandImpl.c to include stdlib.h. This only fixe
Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests
On 15 jan 2014, at 18:52, Volker Simonis wrote:
>
>
> On Wed, Jan 15, 2014 at 6:27 PM, Volker Simonis
> wrote:
> > On Wed, Jan 15, 2014 at 5:34 PM, Volker Simonis
> > wrote:
> >> Hi Staffan,
> >>
> >> thanks for the review. Please find my comments inline:
> >>
> >> On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen
> >> wrote:
> >>>
> >>> Volker,
> >>>
> >>> I’ve look at the following files:
> >>>
> >>> src/share/native/sun/management/DiagnosticCommandImpl.c:
> >>> nit: “legel” -> “legal” (two times)
> >>> In Java_sun_management_DiagnosticCommandImpl_getDiagnosticCommandInfo() if
> >>> you allow dcmd_info_array to become NULL, then
> >>> jmm_interface->GetDiagnosticCommandInfo() will throw an NPE and you need
> >>> to
> >>> check that.
> >>
> >>
> >> Good catch. I actually had problems with malloc returning NULL in
> >> 'getDiagnosticCommandArgumentInfoArray()' and then changed all other
> >> potentially dangerous locations which used the same pattern.
> >>
> >> However I think if the 'dcmd_info_array' has zero length it would be
> >> perfectly fine to return a zero length array. So what about the following
> >> solution:
> >>
>
> Sorry for the noise - it seems I was a little indisposed during the last
> mails:)
> So this is the simple change I'd like to propose for
> Java_sun_management_DiagnosticCommandImpl_getDiagnosticCommandInfo():
>
>
> @@ -117,19 +119,23 @@
>return NULL;
>}
>num_commands = (*env)->GetArrayLength(env, commands);
> - dcmd_info_array = (dcmdInfo*) malloc(num_commands *
> - sizeof(dcmdInfo));
> + dcmdInfoCls = (*env)->FindClass(env,
> + "sun/management/DiagnosticCommandInfo");
> + result = (*env)->NewObjectArray(env, num_commands, dcmdInfoCls, NULL);
> + if (result == NULL) {
> + JNU_ThrowOutOfMemoryError(env, 0);
> + }
> + if (num_commands == 0) {
> + /* Handle the 'zero commands' case specially to avoid calling
> 'malloc()' */
> + /* with a zero argument because that may legally return a NULL
> pointer. */
> + return result;
> + }
> + dcmd_info_array = (dcmdInfo*) malloc(num_commands * sizeof(dcmdInfo));
>if (dcmd_info_array == NULL) {
>JNU_ThrowOutOfMemoryError(env, NULL);
>}
>jmm_interface->GetDiagnosticCommandInfo(env, commands, dcmd_info_array);
> - dcmdInfoCls = (*env)->FindClass(env,
> - "sun/management/DiagnosticCommandInfo");
> - result = (*env)->NewObjectArray(env, num_commands, dcmdInfoCls, NULL);
> - if (result == NULL) {
> - free(dcmd_info_array);
> - JNU_ThrowOutOfMemoryError(env, 0);
> - }
>for (i=0; iargs = getDiagnosticCommandArgumentInfoArray(env,
>
> (*env)->GetObjectArrayElement(env,commands,i),
>
> If the 'commands' input array is of zero length just return a zero length
> array.
> OK?
Yes, this looks good (still :-) )
/Staffan
>
> >> dcmdInfoCls = (*env)->FindClass(env,
> >> "sun/management/DiagnosticCommandInfo");
> >> num_commands = (*env)->GetArrayLength(env, commands);
> >
> > Sorry, of course I wanted to say "if (num_commands == 0)" here!
> >
> >> if (num_commands = 0) {
> >> result = (*env)->NewObjectArray(env, 0, dcmdInfoCls, NULL);
> >> if (result == NULL) {
> >> JNU_ThrowOutOfMemoryError(env, 0);
> >> }
> >> else {
> >> return result;
> >> }
> >> }
> >> dcmd_info_array = (dcmdInfo*) malloc(num_commands * sizeof(dcmdInfo));
> >> if (dcmd_info_array == NULL) {
> >> JNU_ThrowOutOfMemoryError(env, NULL);
> >> }
> >> jmm_interface->GetDiagnosticCommandInfo(env, commands, dcmd_info_array);
> >> result = (*env)->NewObjectArray(env, num_commands, dcmdInfoCls, NULL);
> >>
> >> That seems easier and saves me from handling the exception.
> >>
> >> What do you think?
> >>
> >>> src/solaris/native/sun/management/OperatingSystemImpl.c
> >>> No comments.
> >>>
> >>> src/share/transport/socket/socketTransport.c
> >>> No comments.
> >>
hg: jdk8/tl/jdk: 2 new changesets
Changeset: 431bc327f34a Author:sla Date: 2012-01-31 10:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/431bc327f34a 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms Summary: Make sure HotSpot and JDK looks for well-known files in the same location Reviewed-by: dholmes, dsamersoff ! src/solaris/classes/sun/tools/attach/LinuxVirtualMachine.java ! src/solaris/classes/sun/tools/attach/SolarisVirtualMachine.java ! test/ProblemList.txt Changeset: 663a6333105d Author:sla Date: 2012-01-31 04:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/663a6333105d Merge
hg: jdk8/tl/jdk: 7073626: RmiBootstrapTest.sh and RmiSslBootstrapTest.sh fail under Cygwin
Changeset: 585f2c72d042 Author:sla Date: 2012-02-24 20:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/585f2c72d042 7073626: RmiBootstrapTest.sh and RmiSslBootstrapTest.sh fail under Cygwin Summary: Detect and handle cygwin correctly Reviewed-by: alanb, sspitsyn ! test/ProblemList.txt ! test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh
hg: jdk8/tl/jdk: 7079093: TEST_BUG: java/lang/instrument/ManifestTest.sh fails with cygwin
Changeset: 4893a89b4916 Author:sla Date: 2012-02-24 20:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4893a89b4916 7079093: TEST_BUG: java/lang/instrument/ManifestTest.sh fails with cygwin Summary: Work around problems in some cygwin installations Reviewed-by: alanb, sspitsyn ! test/ProblemList.txt ! test/java/lang/instrument/ManifestTest.sh
hg: jdk8/tl/jdk: 7152798: TEST_BUG: sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java does not compile
Changeset: 3b50a4971a1a Author:sla Date: 2012-03-19 14:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b50a4971a1a 7152798: TEST_BUG: sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java does not compile Summary: Make sure the test is compiled, run and finds it supporting classes Reviewed-by: alanb, sspitsyn, rbackman ! test/sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java
hg: jdk8/tl/jdk: 7154114: jstat tests failing on non-english locales; ...
Changeset: 2dc35f14bf17 Author:sla Date: 2012-03-20 12:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2dc35f14bf17 7154114: jstat tests failing on non-english locales 7154113: jcmd, jps and jstat tests failing when there are unknown Java processes on the system Reviewed-by: rbackman, kamg, dsamersoff ! test/sun/tools/jcmd/jcmd_Output1.awk ! test/sun/tools/jps/jps-l_Output1.awk ! test/sun/tools/jps/jps_Output1.awk ! test/sun/tools/jstat/jstatClassOutput1.sh ! test/sun/tools/jstat/jstatClassloadOutput1.sh ! test/sun/tools/jstat/jstatCompilerOutput1.sh ! test/sun/tools/jstat/jstatFileURITest1.sh ! test/sun/tools/jstat/jstatGcCapacityOutput1.sh ! test/sun/tools/jstat/jstatGcCauseOutput1.sh ! test/sun/tools/jstat/jstatGcNewCapacityOutput1.sh ! test/sun/tools/jstat/jstatGcNewOutput1.sh ! test/sun/tools/jstat/jstatGcOldCapacityOutput1.sh ! test/sun/tools/jstat/jstatGcOldOutput1.sh ! test/sun/tools/jstat/jstatGcOutput1.sh ! test/sun/tools/jstat/jstatGcPermCapacityOutput1.sh ! test/sun/tools/jstat/jstatLineCounts1.sh ! test/sun/tools/jstat/jstatLineCounts2.sh ! test/sun/tools/jstat/jstatLineCounts3.sh ! test/sun/tools/jstat/jstatLineCounts4.sh ! test/sun/tools/jstat/jstatOptions1.sh ! test/sun/tools/jstat/jstatPrintCompilationOutput1.sh ! test/sun/tools/jstat/jstatSnap1.sh ! test/sun/tools/jstat/jstatSnap2.sh ! test/sun/tools/jstat/jstatTimeStamp1.sh ! test/sun/tools/jstatd/jpsOutput1.awk ! test/sun/tools/jstatd/jstatdDefaults.sh ! test/sun/tools/jstatd/jstatdExternalRegistry.sh ! test/sun/tools/jstatd/jstatdPort.sh ! test/sun/tools/jstatd/jstatdServerName.sh
hg: jdk8/tl/jdk: 7154809: JDI: update JDI/JDB debugee commandline option parsing
Changeset: fb52e8bd3718 Author:mgronlun Date: 2012-04-10 10:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fb52e8bd3718 7154809: JDI: update JDI/JDB debugee commandline option parsing Summary: update debugee commandline parsing Reviewed-by: dcubed, dsamersoff, sla ! src/share/classes/com/sun/tools/example/debug/tty/VMConnection.java
hg: jdk8/tl/jdk: 3 new changesets
Changeset: 869f53f58692 Author:sla Date: 2012-04-17 06:45 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/869f53f58692 7147848: com.sun.management.UnixOperatingSystem uses hardcoded dummy values [macosx] Summary: Provide the missing implementation UnixOperatingSystem on Mac OS X Reviewed-by: dsamersoff, dcubed ! src/solaris/native/com/sun/management/MacosxOperatingSystem.c ! src/solaris/native/com/sun/management/UnixOperatingSystem_md.c ! test/com/sun/management/OperatingSystemMXBean/TestTotalSwap.sh Changeset: 4ce1333232c5 Author:sla Date: 2012-04-17 07:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ce1333232c5 Merge Changeset: 1d14903b32e8 Author:sla Date: 2012-04-17 08:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d14903b32e8 Merge
hg: jdk8/tl/jdk: 7163524: Add SecTaskAccess attribute to jstack [macosx]
Changeset: fd22345bf1bf Author:sla Date: 2012-04-23 16:34 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd22345bf1bf 7163524: Add SecTaskAccess attribute to jstack [macosx] Reviewed-by: dholmes ! make/launchers/Makefile.launcher
hg: jdk8/tl/jdk: 7167157: jcmd command file parsing does not respect the "stop" command
Changeset: 0a1ef7e07e01 Author:sla Date: 2012-05-21 19:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a1ef7e07e01 7167157: jcmd command file parsing does not respect the "stop" command Reviewed-by: alanb, dsamersoff, nloodin ! src/share/classes/sun/tools/jcmd/JCmd.java
hg: jdk8/tl/jdk: 2 new changesets
Changeset: 82c41d3065e2 Author:sla Date: 2012-06-07 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82c41d3065e2 7165257: Add JFR tests to the JDK code base Reviewed-by: ohair, dholmes, nloodin, mgronlun ! make/jprt.properties ! test/Makefile Changeset: 961807959c5f Author:sla Date: 2012-06-08 05:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/961807959c5f Merge
hg: jdk8/tl: 7165257: Add JFR tests to the JDK code base
Changeset: df998cd4d51d Author:sla Date: 2012-06-07 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/df998cd4d51d 7165257: Add JFR tests to the JDK code base Reviewed-by: ohair, dholmes, nloodin, mgronlun ! make/jprt.properties
hg: jdk8/tl: 7175802: Missing jdk_jfr in top-level make file
Changeset: 1af3996aa431 Author:sla Date: 2012-06-11 20:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1af3996aa431 7175802: Missing jdk_jfr in top-level make file Reviewed-by: alanb ! test/Makefile
hg: jdk8/tl/jdk: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value
Changeset: 3338019fda8a Author:sla Date: 2009-06-19 16:50 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3338019fda8a 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value Reviewed-by: alanb, dholmes, sla Contributed-by: Dmytro Sheyko ! src/windows/native/com/sun/management/OperatingSystem_md.c + test/com/sun/management/OperatingSystemMXBean/MemoryStatusOverflow.java
hg: jdk8/tl/jdk: 6963102: Testcase failures sun/tools/jstatd/jstatdExternalRegistry.sh and sun/tools/jstatd/jstatdDefaults.sh
Changeset: 5ca450af2a9e Author:sla Date: 2012-09-05 14:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ca450af2a9e 6963102: Testcase failures sun/tools/jstatd/jstatdExternalRegistry.sh and sun/tools/jstatd/jstatdDefaults.sh Summary: Make tests more resilient by allowing for more error messages from jps Reviewed-by: alanb, rbackman, dsamersoff ! test/sun/tools/jstatd/jpsOutput1.awk
hg: jdk8/tl/jdk: 7198846: Add javax/management/remote/mandatory/notif/DiffHBTest.java to ProblemList.txt
Changeset: 39e97f68fa8c Author:sla Date: 2012-09-17 11:27 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39e97f68fa8c 7198846: Add javax/management/remote/mandatory/notif/DiffHBTest.java to ProblemList.txt Reviewed-by: alanb ! test/ProblemList.txt
hg: jdk8/tl/jdk: 7198849: Make javax/management/remote/mandatory/notif/ListenerScaleTest.java less timing sensitive
Changeset: 8a454e92aaf1 Author:sla Date: 2012-09-17 12:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a454e92aaf1 7198849: Make javax/management/remote/mandatory/notif/ListenerScaleTest.java less timing sensitive Reviewed-by: alanb ! test/javax/management/remote/mandatory/notif/ListenerScaleTest.java
hg: jdk8/tl/jdk: 8001621: Update awk scripts that check output from jps/jcmd
Changeset: d1ffbdf7e3c6 Author:sla Date: 2012-10-29 09:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1ffbdf7e3c6 8001621: Update awk scripts that check output from jps/jcmd Reviewed-by: alanb ! test/sun/tools/jcmd/jcmd_Output1.awk ! test/sun/tools/jps/jps-l_Output1.awk ! test/sun/tools/jps/jps_Output1.awk
hg: jdk8/tl/jdk: 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo
Changeset: 55f8ddc2f9c6 Author:sla Date: 2012-11-30 08:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55f8ddc2f9c6 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo Reviewed-by: okutsu ! test/java/util/TimeZone/Bug6912560.java
hg: jdk8/tl/jdk: 8007142: Add utility classes for writing better multiprocess tests in jtreg
Changeset: 2de8c6c2d652 Author:ykantser Date: 2013-02-07 11:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2de8c6c2d652 8007142: Add utility classes for writing better multiprocess tests in jtreg Reviewed-by: alanb, rbackman + test/lib/testlibrary/OutputAnalyzerTest.java + test/lib/testlibrary/jdk/testlibrary/JcmdBase.java + test/lib/testlibrary/jdk/testlibrary/JdkFinder.java + test/lib/testlibrary/jdk/testlibrary/OutputAnalyzer.java + test/lib/testlibrary/jdk/testlibrary/OutputBuffer.java + test/lib/testlibrary/jdk/testlibrary/ProcessTools.java + test/lib/testlibrary/jdk/testlibrary/StreamPumper.java
hg: jdk8/tl/jdk: 8008089: Delete OS dependent check in JdkFinder.getExecutable()
Changeset: ca43e2761a1d Author:ykantser Date: 2013-02-13 10:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca43e2761a1d 8008089: Delete OS dependent check in JdkFinder.getExecutable() Reviewed-by: egahlin, alanb ! test/lib/testlibrary/jdk/testlibrary/JdkFinder.java
hg: jdk8/tl/jdk: 8009397: test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket
Changeset: 34372bb9115d Author:sla Date: 2013-03-05 19:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/34372bb9115d 8009397: test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket Reviewed-by: alanb ! src/share/back/transport.c ! src/share/demo/jvmti/hprof/hprof_init.c ! src/solaris/back/linker_md.c ! src/solaris/demo/jvmti/hprof/hprof_md.c ! src/windows/back/linker_md.c ! src/windows/demo/jvmti/hprof/hprof_md.c
hg: jdk8/tl/jdk: 8006637: Failure to filter out native frame events on Solaris
Changeset: a0275a47fa78 Author:sla Date: 2013-03-19 09:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a0275a47fa78 8006637: Failure to filter out native frame events on Solaris Summary: Test is confused by other threads calling String.intern(). Add a thread filter to avoid this. Reviewed-by: sspitsyn, alanb ! test/com/sun/jdi/NativeInstanceFilter.java
hg: jdk8/tl/jdk: 8009558: linked_md.c::dll_build_name can get stuck in an infinite loop
Changeset: f1b89d4cce82 Author:sla Date: 2013-04-02 10:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1b89d4cce82 8009558: linked_md.c::dll_build_name can get stuck in an infinite loop Reviewed-by: alanb, sspitsyn ! src/share/back/export/sys.h ! src/share/back/transport.c ! src/share/demo/jvmti/hprof/hprof_md.h ! src/solaris/back/linker_md.c ! src/solaris/demo/jvmti/hprof/hprof_md.c ! src/windows/back/linker_md.c ! src/windows/demo/jvmti/hprof/hprof_md.c
hg: jdk8/tl/jdk: 8009985: [parfait] Uninitialised variable at jdk/src/solaris/native/com/sun/management/UnixOperatingSystem_md.c
Changeset: 754c9bb4f085 Author:sla Date: 2013-04-24 14:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/754c9bb4f085 8009985: [parfait] Uninitialised variable at jdk/src/solaris/native/com/sun/management/UnixOperatingSystem_md.c Reviewed-by: sla, rbackman, alanb, dholmes, rdurbin Contributed-by: peter.all...@oracle.com ! src/solaris/native/com/sun/management/UnixOperatingSystem_md.c
hg: jdk8/tl/jdk: 8003671: [findbugs] sun.management.AgentConfigurationError.getParams() may expose internal representation by returning AgentConfigurationError.params
Changeset: fff665e54df0 Author:sla Date: 2013-04-30 10:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fff665e54df0 8003671: [findbugs] sun.management.AgentConfigurationError.getParams() may expose internal representation by returning AgentConfigurationError.params Reviewed-by: mchung, rbackman, jbachorik ! src/share/classes/sun/management/AgentConfigurationError.java
hg: jdk8/tl/jdk: 8004007: test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true
Changeset: 100027950b05 Author:sla Date: 2013-05-07 20:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/100027950b05 8004007: test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true Reviewed-by: alanb, dsamersoff ! test/sun/tools/jinfo/Basic.sh
hg: jdk8/tl/jdk: 6980985: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage is not robust when getMax() returns -1; ...
Changeset: 7b40394ad944 Author:sla Date: 2013-05-07 19:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b40394ad944 6980985: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage is not robust when getMax() returns -1 7181907: TEST_BUG: j/l/management/MemoryMXBean/ResetPeakMemoryUsage fails with NegativeArraySizeException 7148492: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java failing since update to hs23-b15 or b16 Reviewed-by: mchung, brutisso ! test/ProblemList.txt ! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java
hg: jdk8/tl/jdk: 8015440: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException
Changeset: bd6d3801347b Author:sla Date: 2013-05-29 09:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd6d3801347b 8015440: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException Summary: Make sure serial gc compacts heap every time Reviewed-by: mchung, brutisso, nloodin ! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java
hg: jdk8/tl/jdk: 8015856: Remove java/lang/instrument/IsModifiableClassAgent.java from ProblemList.txt
Changeset: 25cf25fb8c68 Author:sla Date: 2013-06-04 09:45 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/25cf25fb8c68 8015856: Remove java/lang/instrument/IsModifiableClassAgent.java from ProblemList.txt Reviewed-by: dholmes ! test/ProblemList.txt
hg: jdk8/tl/jdk: 8019155: Update makefiles with correct jfr packages
Changeset: 19a6d2d701d9 Author:sla Date: 2013-06-26 19:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19a6d2d701d9 8019155: Update makefiles with correct jfr packages Reviewed-by: mgronlun, erikj ! make/common/Release.gmk ! makefiles/CreateJars.gmk
hg: jdk8/tl/jdk: 8022071: Some vm/jvmti tests fail because cannot attach to the Java virtual machine
Changeset: 53ea4b5cef9b Author:sla Date: 2013-08-20 08:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53ea4b5cef9b 8022071: Some vm/jvmti tests fail because cannot attach to the Java virtual machine Reviewed-by: erikj, sspitsyn ! makefiles/CompileNativeLibraries.gmk + makefiles/mapfiles/libattach/reorder-windows-x86 + makefiles/mapfiles/libattach/reorder-windows-x86_64 ! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c
hg: jdk8/tl/jdk: 8016727: test/com/sun/jdi/sde/TemperatureTableTest.java failing intermittently
Changeset: 961cdea684b5 Author:sla Date: 2013-08-20 16:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/961cdea684b5 8016727: test/com/sun/jdi/sde/TemperatureTableTest.java failing intermittently Reviewed-by: alanb ! test/com/sun/jdi/sde/TemperatureTableTest.java
hg: jdk8/tl/jdk: 8023250: Update JavaScript code in JDK for changes in iteration over Java arrays
Changeset: 1ccc7bbee0bb Author:attila Date: 2013-08-20 11:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ccc7bbee0bb 8023250: Update JavaScript code in JDK for changes in iteration over Java arrays Reviewed-by: sundar, sla ! src/share/classes/com/sun/tools/hat/resources/hat.js
hg: jdk8/tl/jdk: 4 new changesets
Changeset: 68be998c2596 Author:egahlin Date: 2013-08-19 12:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68be998c2596 6358357: Division by zero in Threads tab when shrinking jconsole window Reviewed-by: mchung, leifs, jbachorik ! src/share/classes/sun/tools/jconsole/Plotter.java Changeset: bddf55211ed8 Author:egahlin Date: 2013-08-19 16:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bddf55211ed8 6417721: Thread list should not allow multiple selection Reviewed-by: alanb, jbachorik, sjiang ! src/share/classes/sun/tools/jconsole/ThreadTab.java Changeset: 2636d337a1ed Author:egahlin Date: 2013-08-19 16:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2636d337a1ed 6800801: NPE in JConsole when using Nimbus L&F Reviewed-by: alanb, sjiang ! src/share/classes/sun/tools/jconsole/ConnectDialog.java ! src/share/classes/sun/tools/jconsole/VMPanel.java Changeset: ba943fc47fc8 Author:egahlin Date: 2013-08-19 13:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ba943fc47fc8 7042707: Un-needed mnemonic in JConsole resource file Reviewed-by: mfang, jbachorik ! src/share/classes/sun/tools/jconsole/Messages.java ! src/share/classes/sun/tools/jconsole/resources/messages.properties ! src/share/classes/sun/tools/jconsole/resources/messages_ja.properties ! src/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties
hg: jdk8/tl/jdk: 8023485: Remove com/sun/jdi/DoubleAgentTest.java and com/sun/jdi/FieldWatchpoints.java from ProblemList.txt
Changeset: 8996f47f738d Author:sla Date: 2013-08-21 17:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8996f47f738d 8023485: Remove com/sun/jdi/DoubleAgentTest.java and com/sun/jdi/FieldWatchpoints.java from ProblemList.txt Reviewed-by: chegar, mgronlun ! test/ProblemList.txt
hg: jdk8/tl/jdk: 8023101: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails
Changeset: a0896634ab46 Author:sla Date: 2013-08-22 08:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a0896634ab46 8023101: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails Reviewed-by: ysr ! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java
hg: jdk8/tl/jdk: 2 new changesets
Changeset: 7b6211cd8d76 Author:egahlin Date: 2013-08-21 17:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b6211cd8d76 6417649: -interval=0 is accepted and jconsole doesn't update window content at all Reviewed-by: alanb, jbachorik ! src/share/classes/sun/tools/jconsole/JConsole.java Changeset: 77a32e5df365 Author:egahlin Date: 2013-08-21 17:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77a32e5df365 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace Reviewed-by: alanb, jbachorik ! src/share/classes/sun/tools/jconsole/Messages.java ! src/share/classes/sun/tools/jconsole/ThreadTab.java ! src/share/classes/sun/tools/jconsole/resources/messages.properties
hg: jdk8/tl/jdk: 8023786: (jdk) setjmp/longjmp changes the process signal mask on OS X
Changeset: 779ff9f3b2e3 Author:sla Date: 2013-08-29 11:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/779ff9f3b2e3 8023786: (jdk) setjmp/longjmp changes the process signal mask on OS X Reviewed-by: dholmes ! src/share/back/SDE.c ! src/share/native/common/check_code.c
hg: jdk8/tl/jdk: 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing
Changeset: a7d463f5a5b9 Author:egahlin Date: 2013-09-02 16:03 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7d463f5a5b9 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing Reviewed-by: mchung, mfang ! src/share/classes/sun/tools/jconsole/Resources.java ! test/ProblemList.txt - test/sun/tools/jconsole/ImmutableResourceTest.java - test/sun/tools/jconsole/ImmutableResourceTest.sh ! test/sun/tools/jconsole/ResourceCheckTest.java ! test/sun/tools/jconsole/ResourceCheckTest.sh
hg: jdk8/tl/jdk: 2 new changesets
Changeset: 58fd427b454d Author:sla Date: 2013-09-20 10:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/58fd427b454d 8024985: com/sun/jdi/StepTest.java failed since jdk8b107 Reviewed-by: dcubed ! test/com/sun/jdi/ExceptionEvents.java ! test/com/sun/jdi/FilterNoMatch.java ! test/com/sun/jdi/JDIScaffold.java ! test/com/sun/jdi/PopAndStepTest.java ! test/com/sun/jdi/RepStep.java ! test/com/sun/jdi/TestScaffold.java Changeset: 6a1c70e191d4 Author:sla Date: 2013-09-20 10:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a1c70e191d4 8024416: TESTBUG: com/sun/jdi/MethodEntryExitEvents.java: method entry count mismatch Reviewed-by: dcubed ! test/com/sun/jdi/MethodEntryExitEvents.java
