hg: jdk8/tl/jdk: 8026812: doclint clean up for java.sql and javax.sql
Changeset: 64c0ac7cd936 Author:lancea Date: 2013-10-17 15:14 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64c0ac7cd936 8026812: doclint clean up for java.sql and javax.sql Reviewed-by: mduigou ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Connection.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLException.java ! src/share/classes/java/sql/SQLFeatureNotSupportedException.java ! src/share/classes/java/sql/SQLPermission.java ! src/share/classes/java/sql/SQLWarning.java ! src/share/classes/java/sql/SQLXML.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/javax/sql/CommonDataSource.java ! src/share/classes/javax/sql/RowSet.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java ! src/share/classes/javax/sql/rowset/FilteredRowSet.java ! src/share/classes/javax/sql/rowset/JdbcRowSet.java ! src/share/classes/javax/sql/rowset/JoinRowSet.java ! src/share/classes/javax/sql/rowset/Joinable.java ! src/share/classes/javax/sql/rowset/Predicate.java ! src/share/classes/javax/sql/rowset/WebRowSet.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncProvider.java ! src/share/classes/javax/sql/rowset/spi/SyncResolver.java
hg: jdk8/tl/jdk: 8028149: Clean-up javac -Xlint warnings in com.sun.rowset and com.sun.rowset.internal
Changeset: 59ff7957c26f Author:lancea Date: 2013-11-11 14:22 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59ff7957c26f 8028149: Clean-up javac -Xlint warnings in com.sun.rowset and com.sun.rowset.internal Reviewed-by: darcy ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/BaseRow.java
hg: jdk8/tl/jdk: 8029417: JDBC 4.2 javadoc updates
Changeset: bcf5fa5e9509 Author:lancea Date: 2013-12-02 16:06 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcf5fa5e9509 8029417: JDBC 4.2 javadoc updates Reviewed-by: darcy ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/JDBCType.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLPermission.java
Re: JDK 9 RFR of JDK-8041395: Doclint regression in java.net.SocketOption
r its affiliates. All rights
> reserved.
> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> *
> * This code is free software; you can redistribute it and/or modify it
> @@ -1727,6 +1727,7 @@
> /**
> * Sets the value of a socket option.
> *
> + * @param The type of the socket option value
> * @param name The socket option
> * @param value The value of the socket option. A value of {@code null}
> * may be valid for some options.
> @@ -1758,6 +1759,7 @@
> /**
> * Returns the value of a socket option.
> *
> + * @param The type of the socket option value
> * @param name The socket option
> *
> * @return The value of the socket option.
> --- old/src/java.base/share/classes/java/net/SocketImpl.java 2015-02-09
> 15:19:27.191374279 -0800
> +++ new/src/java.base/share/classes/java/net/SocketImpl.java 2015-02-09
> 15:19:27.031376290 -0800
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 1995, 2013, Oracle and/or its affiliates. All rights
> reserved.
> + * Copyright (c) 1995, 2015, Oracle and/or its affiliates. All rights
> reserved.
> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> *
> * This code is free software; you can redistribute it and/or modify it
> @@ -362,6 +362,7 @@
> /**
> * Called to set a socket option.
> *
> + * @param The type of the socket option value
> * @param name The socket option
> *
> * @param value The value of the socket option. A value of {@code null}
> @@ -397,6 +398,7 @@
> /**
> * Called to get a socket option.
> *
> + * @param The type of the socket option value
> * @param name The socket option
> *
> * @return the value of the named option
>
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Re: RFR 8220598: Malformed copyright year range in a few files in java.base
+1 > On Mar 13, 2019, at 1:04 PM, Chris Hegarty wrote: > > Trivially, there should be a comma after the year. Just add it. > > > $ hg diff src/java.base/share/classes/jdk/ src/java.base/share/classes/sun > diff --git a/src/java.base/share/classes/jdk/internal/util/ArraysSupport.java > b/src/java.base/share/classes/jdk/internal/util/ArraysSupport.java > --- a/src/java.base/share/classes/jdk/internal/util/ArraysSupport.java > +++ b/src/java.base/share/classes/jdk/internal/util/ArraysSupport.java > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2015, 2017 Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > diff --git > a/src/java.base/share/classes/sun/net/spi/DefaultProxySelector.java > b/src/java.base/share/classes/sun/net/spi/DefaultProxySelector.java > --- a/src/java.base/share/classes/sun/net/spi/DefaultProxySelector.java > +++ b/src/java.base/share/classes/sun/net/spi/DefaultProxySelector.java > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2003, 2018 Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2003, 2018, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > diff --git a/src/java.base/share/classes/sun/security/util/IOUtils.java > b/src/java.base/share/classes/sun/security/util/IOUtils.java > --- a/src/java.base/share/classes/sun/security/util/IOUtils.java > +++ b/src/java.base/share/classes/sun/security/util/IOUtils.java > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2009, 2017 Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2009, 2017, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > > -Chris. <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
Re: RFR[8240533]: 'Inconsistent Exceptions are thrown by DatagramSocket and DatagramChannel when sending a DatagramPacket to port 0.'
Hi Patrick, I think this looks OK. I might suggest using assertThrows vs expectThrows. While they are the same, assertThrows seems more natural and consistent with the other testNG assert methods. HTH Best Lance > On Mar 31, 2020, at 6:15 AM, Patrick Concannon > wrote: > > Hi, > > Could someone please review my fix for JDK-8240533 'Inconsistent Exceptions > are thrown by DatagramSocket and DatagramChannel when sending a > DatagramPacket to port 0.' ? > > Currently, DatagramSocket throws an IOException when sending to port 0, and > doesn't throw when connecting. DatagramChannel currently throws a > BindException in both cases. > The fix adds checks for port == 0 to the send and connect methods in > DatagramSocket and DatagramChannelImpl. This is to ensure that consistent > Exceptions i.e. SocketExceptions are thrown when trying to connect or send to > port 0. > > > bug: https://bugs.openjdk.java.net/browse/JDK-8240533 > webrev: http://cr.openjdk.java.net/~pconcannon/8240533/webrevs/webrev.00/ > > > Kind regards, > > Patrick <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
Re: RFR[8240533]: 'Inconsistent Exceptions are thrown by DatagramSocket and DatagramChannel when sending a DatagramPacket to port 0.'
Hi Patrick,
This looks good to me..
Best
Lance
> On Apr 4, 2020, at 11:26 AM, Patrick Concannon
> wrote:
>
> Hi Chris and Daniel,
>
>
> Well spotted, Chris. Thanks for that!
>
> Thanks too Daniel, that's a good idea. I've made those changes and included
> them in a new webrev, which you can find below.
>
> http://cr.openjdk.java.net/~pconcannon/8240533/webrevs/webrev.02/
>
>
> Kind regards,
>
> Patrick
>
> On 03/04/2020 17:16, Daniel Fuchs wrote:
>> Hi Patrick,
>>
>> 120 { perms.add(new SocketPermission("127.0.0.1:0",
>> 121 "connect,accept")); }
>> 122 { perms.add(new SocketPermission("0.0.0.0:0",
>> 123 "connect,accept")); }
>>
>> there in other tests - I think a single permission:
>>
>> { perms.add(new SocketPermission("*:0")); }
>>
>> would be more robust as it would take care of both IPv6 and IPv4 in one
>> go. We should strive to avoid to hard-code 127.0.0.1 and 0.0.0.0
>> in tests.
>>
>> best regards,
>>
>> -- daniel
>>
>> On 03/04/2020 14:47, Patrick Concannon wrote:
>>> Hi,
>>>
>>> Thanks for the feedback.
>
>
>>>
>>> Lance - I swapped out expectThrows for assertThrows, as requested.
>>>
>>> Chris - I put in an extra check in the tests to ensure that the new code
>>> doesn’t interfere with the Security Manager checks already present in the
>>> source.
>>>
>>> The new webrev can be found here:
>>> http://cr.openjdk.java.net/~pconcannon/8240533/webrevs/webrev.01/
>
>>> <http://cr.openjdk.java.net/~pconcannon/8240533/webrevs/webrev.01/>
>>>
>>>
>>> Kind regards,
>>>
>>> Patrick
>>>
>>> On 31/03/2020 15:33, Chris Hegarty wrote:
>>>> Patrick,
>>>>
>>>>> On 31 Mar 2020, at 15:08, Daniel Fuchs wrote:
>>>>>
>>>>>> ..
>>>>>> bug:https://bugs.openjdk.java.net/browse/JDK-8240533
>>>>>> webrev:http://cr.openjdk.java.net/~pconcannon/8240533/webrevs/webrev.00/
>>>> Look good Patrick.
>>>>
>>>> The check is deliberately performed after the security manager checks,
>>>> right? If so, it is worth asserting this in a test.
>>>>
>>>> -Chris.
>>>>
>>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
Re: RFR: JDK-8255262: Remove use of legacy custom @spec tag
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote: > The change is (just) to remove legacy usages of a JDK-private custom tag. looks fine - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/814
Re: RFR: 8259493: [test] Use HexFormat instead of adhoc hex utilities in network code and locale SoftKeys
On Fri, 8 Jan 2021 20:34:10 GMT, Roger Riggs wrote: > Cleanup of tests test/jdk/java/net and test/jdk/sun/net that format > hexadecimal strings to use java.util.HexFormat methods. > Also in tests test/jdk/java/util/Locale/SoftKeys. Looks good Roger. Nice cleanup. - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2009
Re: RFR: JDK-8262430: doclint warnings in java.base module
On Thu, 25 Feb 2021 22:59:23 GMT, Jonathan Gibbons wrote: > Please review some simple doc fixes in the `java.base` module. Two were > reported by doclint; the spelling error was detected by the IDE. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2734
Re: RFR: JDK-8262875: doccheck: empty paragraphs, etc in java.base module
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote: > Please review some minor doc fixes, for issues found by _doccheck_.There > are two kinds of errors that are addressed. > > 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a > paragraph. It is not a terminator, to mark the end of a paragraph, or a > separator to mark the boundary between paragraphs. In particular, it should > not be used at the end of a description before a javadoc block tag, such as > `@param` or before other HTML block tags, like `` or ``. > > 2. References to the id `package-description`, following the recent > standardization of all ids generated by javadoc, Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2795
Re: RFR: 8262883: doccheck: Broken links in java.base
On Wed, 14 Apr 2021 14:03:01 GMT, Michael McMahon wrote: > Hi, > > Could I get the following trivial doc changes reviewed please, caused by: > > - broken tags in MethodHandles referring to package.html instead of > package-summary.html > > - references to a package level #unixdomain anchor that no longer exists. > > - a tag missing a "../" in SocketChannel > > Thanks, > > Michael Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3491
Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v6]
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote: >> Please review this implementation of [JEP >> 411](https://openjdk.java.net/jeps/411). >> >> The code change is divided into 3 commits. Please review them one by one. >> >> 1. >> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1 >> The essential change for this JEP, including the `@Deprecate` annotations >> and spec change. It also update the default value of the >> `java.security.manager` system property to "disallow", and necessary test >> change following this update. >> 2. >> https://github.com/openjdk/jdk/commit/26a54a835e9f84aa528740a7c5c35d07355a8a66 >> Manual changes to several files so that the next commit can be generated >> programatically. >> 3. >> https://github.com/openjdk/jdk/commit/eb6c566ff9207974a03a53335e0e697cffcf0950 >> Automatic changes to other source files to avoid javac warnings on >> deprecation for removal >> >> The 1st and 2nd commits should be reviewed carefully. The 3rd one is >> generated programmatically, see the comment below for more details. If you >> are only interested in a portion of the 3rd commit and would like to review >> it as a separate file, please comment here and I'll generate an individual >> webrev. >> >> Due to the size of this PR, no attempt is made to update copyright years for >> any file to minimize unnecessary merge conflict. >> >> Furthermore, since the default value of `java.security.manager` system >> property is now "disallow", most of the tests calling >> `System.setSecurityManager()` need to launched with >> `-Djava.security.manager=allow`. This is covered in a different PR at >> https://github.com/openjdk/jdk/pull/4071. >> >> Update: the deprecation annotations and javadoc tags, build, compiler, >> core-libs, hotspot, i18n, jmx, net, nio, security, and serviceability are >> reviewed. Rest are 2d, awt, beans, sound, and swing. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > default behavior reverted to allow Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4073
Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v7]
On Wed, 9 Jun 2021 08:44:44 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains ten additional > commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into JDK-8268056 > - 8268056: renamed variable in Files > - Merge remote-tracking branch 'origin/master' into JDK-8268056 > - Merge remote-tracking branch 'origin/master' into JDK-8268056 > - 8268056: Added yield to switch expression in Files > - 8268056: reverted changes to FileTime > - Merge remote-tracking branch 'origin/master' into JDK-8268056 > - 8268056: Reverted changes to URLDecoder; reformatted change to FileTime > - 8268056: Update java.net and java.nio to use switch expressions Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4285
Re: [jdk17] RFR: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote: > More refactoring to limit the scope of `@SuppressWarnings` annotations. > > Sometimes I introduce new methods. Please feel free to suggest method names > you like to use. Changes look good Max - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/152
Re: [jdk17] RFR: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K [v2]
On Fri, 25 Jun 2021 23:40:27 GMT, Weijun Wang wrote: >> More refactoring to limit the scope of `@SuppressWarnings` annotations. >> >> Sometimes I introduce new methods. Please feel free to suggest method names >> you like to use. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > one more Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/152
Re: RFR: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K
On Mon, 28 Jun 2021 18:03:56 GMT, Weijun Wang wrote: > More refactoring to limit the scope of `@SuppressWarnings` annotations. > > Sometimes I introduce new methods. Please feel free to suggest method names > you like to use. > > Note: this is copied from https://github.com/openjdk/jdk17/pull/152. The revisions you made as part of the push to JDK 18 look fine Max. - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4615
Re: RFR: 8273616: Fix trivial doc typos in the java.base module [v2]
On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo wrote: >> 8273616: Fix trivial doc typos in the java.base module > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Revert two fixes Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5475
Re: RFR: 8273616: Fix trivial doc typos in the java.base module [v3]
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote: >> 8273616: Fix trivial doc typos in the java.base module > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Use "ensure" instead of "insure" Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5475
Re: RFR: 8274835: Remove unnecessary castings in java.base
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov wrote: > Redundant castings make code harder to read. > Found them by IntelliJ IDEA. > I tried to select only casts which are definitely safe to remove. Also didn't > touch primitive types casts. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5454
Re: RFR: 8274949: Use String.contains() instead of String.indexOf() in java.base
On Fri, 17 Sep 2021 08:56:47 GMT, Andrey Turbanov wrote: > String.contains was introduced in Java 5. > Some code in java.base still uses old approach with `String.indexOf` to check > if String contains specified substring. > I propose to migrate such usages. Makes code shorter and easier to read. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5559
Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec for
> JEP 421. It also updates the relevant @SuppressWarning annotations.
>
> The CSR has been approved.
> An automated test build+test run passes cleanly (FWIW :D ).
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6465
Re: RFR: JDK-8276681: Malformed Javadoc inline tags in JDK source jdk/internal/net/http/ResponseSubscribers.java
On Sat, 20 Nov 2021 04:09:51 GMT, Tim Prinzing wrote: > JDK-8276681: Malformed Javadoc inline tags in JDK source > jdk/internal/net/http/ResponseSubscribers.java Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6486
Re: RFR: 8278028: [test-library] Warnings cleanup of the test library
On Wed, 1 Dec 2021 14:47:54 GMT, Roger Riggs wrote:
> Compilation warnings of the test library introduce noise in test output and
> should be addressed or suppressed.
> Changes include:
> - SuppressWarnings("deprecation") and SuppressWarnings("removal")
> - Adding type parameters to Raw types
> - Adding a hashCode method where equals was already present
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6638
Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189
Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo The changes look OK. The copyright year probably should be updated as part of this PR - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7268
Re: RFR: JDK-8282686: Add constructors taking a cause to SocketException
On Fri, 4 Mar 2022 21:17:01 GMT, Joe Darcy wrote: > Please review this small API enhancement to add the usual constructors taking > a cause to SocketException and then update uses of initiCause on creating > SocketException to instead pass the cause via the constructor. > > Please also review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282688 Looks fine, would be worth including a couple of tests for coverage - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7705
Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo What problem are you having editing the PR header? You should be able to do so as the author of the PR - PR: https://git.openjdk.java.net/jdk/pull/7268
Re: RFR: 8186958: Need method to create pre-sized HashMap [v16]
On Wed, 13 Apr 2022 16:29:11 GMT, XenoAmess wrote: >> 8186958: Need method to create pre-sized HashMap > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > revert changes in: > src/java.desktop > src/java.management > src/jdk.internal.vm.ci > src/jdk.jfr > src/jdk.management.jfr > src/jdk.management > src/utils/IdealGraphVisualizer The ZipFS and Jar changes seem OK - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7928
Re: RFR: 8284893: Fix typos in java.base [v4]
On Tue, 19 Apr 2022 16:50:12 GMT, Magnus Ihse Bursie wrote: >> I ran `codespell` on the `src/java.base` directory, and accepted those >> changes where it indeed discovered real typos. >> >> (Due to false positives this can unfortunately not be run automatically) >> >> The majority of fixes are in comments. A handful is in strings, one in a >> local variable name, and a couple in parameter declarations. >> >> Annoyingly, there are several instances of "childs" (instead of "children") >> in the source code, but they were not local and I dared not change them. >> Someone braver than me might take a stab at it, perhaps.. > > Magnus Ihse Bursie has updated the pull request incrementally with two > additional commits since the last revision: > > - Update Oracle copyrights > - Also revert changes in ASM (3rd party code) Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8250
Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8768
hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be. (also reviewed by ksaks, ryano)
Changeset: 4ec7d1890538 Author:lancea Date: 2009-08-20 19:21 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4ec7d1890538 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be. (also reviewed by ksaks, ryano) Reviewed-by: valeriep + src/share/classes/com/sun/rowset/RowSetFactoryImpl.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java + src/share/classes/javax/sql/rowset/RowSetFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncProvider.java
hg: jdk7/tl/jdk: 6737212: Fixed javadoc warning messages in RowSet classes
Changeset: f1eb4c28b313 Author:lancea Date: 2009-09-09 20:15 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f1eb4c28b313 6737212: Fixed javadoc warning messages in RowSet classes Reviewed-by: darcy ! src/share/classes/com/sun/rowset/JdbcRowSetResourceBundle.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlReader.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java
hg: jdk7/tl/jdk: 6898593: java.sql.Date.valueOf no exception if date given is not in the JDBC date escape syntax
Changeset: 3e239fe92832 Author:lancea Date: 2010-08-10 10:07 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3e239fe92832 6898593: java.sql.Date.valueOf no exception if date given is not in the JDBC date escape syntax Reviewed-by: minqi ! src/share/classes/java/sql/Date.java
hg: jdk7/tl/jdk: 6861385: Updated SQLException subclasses to clarify that they may be thrown for vendor specific conditions
Changeset: 1f99ad63eb9e Author:lancea Date: 2010-09-04 12:21 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f99ad63eb9e 6861385: Updated SQLException subclasses to clarify that they may be thrown for vendor specific conditions Reviewed-by: alanb ! src/share/classes/java/sql/SQLDataException.java ! src/share/classes/java/sql/SQLIntegrityConstraintViolationException.java ! src/share/classes/java/sql/SQLInvalidAuthorizationSpecException.java ! src/share/classes/java/sql/SQLNonTransientConnectionException.java ! src/share/classes/java/sql/SQLSyntaxErrorException.java ! src/share/classes/java/sql/SQLTransactionRollbackException.java ! src/share/classes/java/sql/SQLTransientConnectionException.java
hg: jdk7/tl/jdk: 6843995: RowSet 1.1 updates
Changeset: d44696691445 Author:lancea Date: 2010-09-04 13:56 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d44696691445 6843995: RowSet 1.1 updates Reviewed-by: darcy, valeriep + src/share/classes/com/sun/rowset/RowSetFactoryImpl.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java + src/share/classes/javax/sql/rowset/RowSetFactory.java + src/share/classes/javax/sql/rowset/RowSetProvider.java ! src/share/classes/javax/sql/rowset/package.html ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncProvider.java
hg: jdk7/tl/jdk: 6680198: UnmarshalException caused by incompatible serialVersionUID
Changeset: c4defe31c94a Author:lancea Date: 2010-09-04 15:30 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c4defe31c94a 6680198: UnmarshalException caused by incompatible serialVersionUID Reviewed-by: sherman ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetResourceBundle.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/WebRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetReader.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/share/classes/com/sun/rowset/internal/InsertRow.java ! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlReader.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java ! src/share/classes/com/sun/rowset/providers/RIOptimisticProvider.java
hg: jdk7/tl/jdk: 6982510: Updated SQLException subclasses from the outback for 6861385 so that the copyrights only have 2 years
Changeset: 5cf79568f0b9 Author:lancea Date: 2010-09-04 15:37 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5cf79568f0b9 6982510: Updated SQLException subclasses from the outback for 6861385 so that the copyrights only have 2 years Reviewed-by: alanb ! src/share/classes/java/sql/SQLDataException.java ! src/share/classes/java/sql/SQLIntegrityConstraintViolationException.java ! src/share/classes/java/sql/SQLInvalidAuthorizationSpecException.java ! src/share/classes/java/sql/SQLNonTransientConnectionException.java ! src/share/classes/java/sql/SQLSyntaxErrorException.java ! src/share/classes/java/sql/SQLTransactionRollbackException.java ! src/share/classes/java/sql/SQLTransientConnectionException.java
hg: jdk7/tl/jdk: 6589685: JDBC 4.1 updates
Changeset: c786a9c927fd Author:lancea Date: 2010-09-10 15:26 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c786a9c927fd 6589685: JDBC 4.1 updates Reviewed-by: darcy ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Connection.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/Date.java ! src/share/classes/java/sql/Driver.java ! src/share/classes/java/sql/PreparedStatement.java + src/share/classes/java/sql/PseudoColumnUsage.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLPermission.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/sql/Timestamp.java ! src/share/classes/javax/sql/CommonDataSource.java
hg: jdk7/tl/jdk: 6983984: Fixed typo in DatabaseMetaData.getPseudoColumns() javadocs
Changeset: 73872b992aab Author:lancea Date: 2010-09-10 18:51 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/73872b992aab 6983984: Fixed typo in DatabaseMetaData.getPseudoColumns() javadocs Reviewed-by: darcy ! src/share/classes/java/sql/DatabaseMetaData.java
hg: jdk7/tl/jdk: 4 new changesets
Changeset: 7794d718ffe2 Author:lancea Date: 2010-09-17 13:23 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7794d718ffe2 6983452: SyncProvider issue for JoinRowSet implementation Reviewed-by: darcy, ohair ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java Changeset: 1cb444a3d5cd Author:lancea Date: 2010-09-17 13:26 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1cb444a3d5cd 6984864: Exception when running acceptChanges with custom SyncProvider Reviewed-by: darcy, ohair ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java Changeset: 095a5e5a025a Author:lancea Date: 2010-09-17 13:30 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/095a5e5a025a 6985400: DatabaseMetaData.generatedKeyAlwaysReturned, "indexe(s)" should be "index(es)" Reviewed-by: darcy, ohair ! src/share/classes/java/sql/DatabaseMetaData.java Changeset: 291a5c52f9d0 Author:lancea Date: 2010-09-17 13:33 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/291a5c52f9d0 6985725: RowSetProvider has typo for the property javax.sql.rowset.RowSetFactory in the javadoc Reviewed-by: darcy, ohair ! src/share/classes/javax/sql/rowset/RowSetProvider.java
hg: jdk7/tl/jdk: 6984044: RowSet source needs to rebrand vendor references
Changeset: 0d78b3eedecc Author:lancea Date: 2010-09-18 06:09 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0d78b3eedecc 6984044: RowSet source needs to rebrand vendor references Reviewed-by: darcy, ohair ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java ! src/share/classes/com/sun/rowset/providers/RIOptimisticProvider.java ! src/share/classes/com/sun/rowset/providers/RIXMLProvider.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java ! src/share/classes/javax/sql/rowset/WebRowSet.java ! src/share/classes/javax/sql/rowset/rowset.properties ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncProvider.java ! src/share/classes/javax/sql/rowset/spi/package.html
hg: jdk7/tl/jdk: 6987638: javadoc update to RowSetProvider and Statement
Changeset: 7b2b0131fa61 Author:lancea Date: 2010-09-27 18:05 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b2b0131fa61 6987638: javadoc update to RowSetProvider and Statement Reviewed-by: darcy, alanb ! src/share/classes/java/sql/Statement.java ! src/share/classes/javax/sql/rowset/RowSetProvider.java
hg: jdk7/tl/jdk: 6988993: Address Findbugs warnings for the use of String Constructor
Changeset: 9a8022905f6a Author:lancea Date: 2010-10-01 14:36 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a8022905f6a 6988993: Address Findbugs warnings for the use of String Constructor Reviewed-by: ohair ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/RowSetMetaDataImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java
hg: jdk7/tl/jdk: 6989139: Address JDBC Findbugs where Number type Constructor are used
Changeset: ffaf6a35b895 Author:lancea Date: 2010-10-04 13:04 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ffaf6a35b895 6989139: Address JDBC Findbugs where Number type Constructor are used Reviewed-by: ohair ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java
hg: jdk7/tl/jdk: 2 new changesets
Changeset: 0f23a139e819 Author:lancea Date: 2010-10-06 10:09 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f23a139e819 6988310: SyncFactory.setLogger(Logger,Level) requires unspecified security permission Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java Changeset: 6fd4928b82a2 Author:lancea Date: 2010-10-06 10:11 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6fd4928b82a2 6988317: RowSetProvider.newFactory() may throw unspecified exception Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/RowSetProvider.java
hg: jdk7/tl/jdk: 6982530: javadoc update to SyncFactory & JdbcResource bundle for synchronization issues
Changeset: af2de4de1076 Author:lancea Date: 2010-11-12 07:15 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/af2de4de1076 6982530: javadoc update to SyncFactory & JdbcResource bundle for synchronization issues Reviewed-by: alanb ! src/share/classes/com/sun/rowset/JdbcRowSetResourceBundle.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java
hg: jdk7/tl/jdk: 6999086: Clarify that SyncFactory.setLogger can throw an NullPointerException
Changeset: c4a38022fdc1 Author:lancea Date: 2010-11-12 08:41 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c4a38022fdc1 6999086: Clarify that SyncFactory.setLogger can throw an NullPointerException Reviewed-by: alanb ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java
hg: jdk7/tl/jdk: 2 new changesets
Changeset: ff619988afac Author:lancea Date: 2010-11-19 17:15 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ff619988afac 7000752: Duplicate entry in RowSetResourceBundles.properties Reviewed-by: alanb ! src/share/classes/com/sun/rowset/RowSetResourceBundle.properties ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java Changeset: bf407ff3e97b Author:lancea Date: 2010-11-19 17:18 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bf407ff3e97b 7001669: Typo in javadocs for SQLPermission Reviewed-by: alanb ! src/share/classes/java/sql/SQLPermission.java
hg: jdk7/tl/jdk: 6659234: Incorrect check in SerialBlob.getBytes
Changeset: 1bf378034d39 Author:lancea Date: 2010-12-09 13:01 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bf378034d39 6659234: Incorrect check in SerialBlob.getBytes Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java
hg: jdk7/tl/jdk: 7006454: Typo in javadocs typo for Statement.executeBatch @since
Changeset: a72e7147816f Author:lancea Date: 2010-12-14 16:08 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a72e7147816f 7006454: Typo in javadocs typo for Statement.executeBatch @since Reviewed-by: alanb ! src/share/classes/java/sql/Statement.java
hg: jdk7/tl/jdk: 6544224: Remove the need of sun.reflect.misc
Changeset: f4d755bbdabe Author:lancea Date: 2011-01-10 14:43 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f4d755bbdabe 6544224: Remove the need of sun.reflect.misc Reviewed-by: alanb ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java
hg: jdk7/tl/jdk: 7000693: java.sql.Timestamp compareTo() issues using low values
Changeset: befe813e24d2 Author:lancea Date: 2011-01-11 12:36 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/befe813e24d2 7000693: java.sql.Timestamp compareTo() issues using low values Reviewed-by: okutsu ! src/share/classes/java/sql/Timestamp.java
hg: jdk7/tl/jdk: 7014095: Broken link in java.sql package specification
Changeset: 9599534b1727 Author:lancea Date: 2011-02-04 09:07 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9599534b1727 7014095: Broken link in java.sql package specification Reviewed-by: alanb ! src/share/classes/java/sql/package.html
hg: jdk7/tl/jdk: 7026898: DriverManager to now use CopyOnWriteArrayList
Changeset: df9991dc1f0d Author:lancea Date: 2011-03-17 11:37 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/df9991dc1f0d 7026898: DriverManager to now use CopyOnWriteArrayList Reviewed-by: alanb, briangoetz ! src/share/classes/java/sql/DriverManager.java
hg: jdk7/tl/jdk: 7034471: Wrap registeredDrivers in DriverManager
Changeset: d5bc10b1aa2c Author:lancea Date: 2011-04-06 17:37 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d5bc10b1aa2c 7034471: Wrap registeredDrivers in DriverManager Reviewed-by: alanb, briangoetz ! src/share/classes/java/sql/DriverManager.java
hg: jdk7/tl/jdk: 7034656: Address lint warnings for DriverManager
Changeset: 5137806a3e34 Author:lancea Date: 2011-04-07 11:25 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5137806a3e34 7034656: Address lint warnings for DriverManager Reviewed-by: alanb, forax, ohair ! src/share/classes/java/sql/DriverManager.java
hg: jdk7/tl/jdk: 7035615: Address lint warnings for javax.sql.rowset & com.sun.rowset
Changeset: 1bb95f6ac753 Author:lancea Date: 2011-04-12 12:25 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bb95f6ac753 7035615: Address lint warnings for javax.sql.rowset & com.sun.rowset Reviewed-by: alanb, darcy ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/RowSetMetaDataImpl.java ! src/share/classes/javax/sql/rowset/RowSetProvider.java
hg: jdk7/tl/jdk: 7007772: Address typos in javadoc for ResultSet
Changeset: 0bae251b548b Author:lancea Date: 2011-04-12 14:32 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bae251b548b 7007772: Address typos in javadoc for ResultSet Reviewed-by: ohair, smarks ! src/share/classes/java/sql/ResultSet.java
hg: jdk7/tl/jdk: 7036251: Correct SQLPermission constructor javadocs for permission target names
Changeset: d9248245a88c Author:lancea Date: 2011-04-13 11:21 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d9248245a88c 7036251: Correct SQLPermission constructor javadocs for permission target names Reviewed-by: alanb ! src/share/classes/java/sql/SQLPermission.java
hg: jdk7/tl/jdk: 7037085: Add hashCode() to Timestamp to address Findbugs warning
Changeset: 9b3e6baad033 Author:lancea Date: 2011-04-18 12:07 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9b3e6baad033 7037085: Add hashCode() to Timestamp to address Findbugs warning Reviewed-by: darcy, alanb, emcmanus ! src/share/classes/java/sql/Timestamp.java
hg: jdk7/tl/jdk: 7038565: address Findbugs issue in BatchUpdateException
Changeset: 28caa191884a Author:lancea Date: 2011-04-28 09:46 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/28caa191884a 7038565: address Findbugs issue in BatchUpdateException Reviewed-by: alanb, forax ! src/share/classes/java/sql/BatchUpdateException.java
hg: jdk7/tl/jdk: 7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow
Changeset: 0b1354ecf5a3 Author:lancea Date: 2011-04-29 09:04 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b1354ecf5a3 7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow Reviewed-by: smarks ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
hg: jdk7/tl/jdk: 7043443: address missed reason initialization in BatchUpdateException
Changeset: 6a3a41e0af88 Author:lancea Date: 2011-05-10 14:41 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a3a41e0af88 7043443: address missed reason initialization in BatchUpdateException Reviewed-by: alanb ! src/share/classes/java/sql/BatchUpdateException.java
hg: jdk7/tl/jdk: 7049107: Cannot call initCause() on BatchUpdateException
Changeset: a00f48c96345 Author:lancea Date: 2011-06-02 12:02 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a00f48c96345 7049107: Cannot call initCause() on BatchUpdateException Reviewed-by: darcy ! src/share/classes/java/sql/BatchUpdateException.java
hg: jdk8/tl/jdk: 7077451: SerialLob, SerialClob have the wrong checks for setStream methods
Changeset: 7676670d1e97 Author:lancea Date: 2011-08-10 16:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7676670d1e97 7077451: SerialLob, SerialClob have the wrong checks for setStream methods Reviewed-by: alanb Contributed-by: Patrick Reinhart ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java + test/javax/sql/rowset/serial/SerialBlob/SetBinaryStream.java + test/javax/sql/rowset/serial/SerialClob/SetAsciiStream.java + test/javax/sql/rowset/serial/SerialClob/SetCharacterStream.java
hg: jdk8/tl/jdk: 7110111: Minor Java SE javadoc & Constructor clean up
Changeset: 830d2e46023a Author:lancea Date: 2011-11-10 11:41 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/830d2e46023a 7110111: Minor Java SE javadoc & Constructor clean up Reviewed-by: alanb, darcy Contributed-by: Martin Desruisseaux ! src/share/classes/java/io/Writer.java ! src/share/classes/java/lang/AssertionError.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/util/jar/Attributes.java
hg: jdk8/tl/jdk: 7116445: Miscellaneous warnings in the JDBC/RowSet classes
Changeset: 3c524deb8431 Author:lancea Date: 2011-12-02 19:33 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c524deb8431 7116445: Miscellaneous warnings in the JDBC/RowSet classes Reviewed-by: smarks, chegar ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetResourceBundle.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/WebRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetReader.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/share/classes/com/sun/rowset/internal/Row.java ! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java ! src/share/classes/java/sql/Date.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/Time.java ! src/share/classes/java/sql/Timestamp.java ! src/share/classes/javax/sql/StatementEvent.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/RowSetMetaDataImpl.java ! src/share/classes/javax/sql/rowset/RowSetProvider.java ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java
hg: jdk8/tl/jdk: 7132879: address Findbugs issue in WebRowSetXmlWriter
Changeset: 303b67074666 Author:lancea Date: 2012-01-24 15:13 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/303b67074666 7132879: address Findbugs issue in WebRowSetXmlWriter Reviewed-by: forax ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java
hg: jdk8/tl/jdk: 7133815: address the findbug errors in CachedRowSetImpl, SerialStruct, BaseRow, SerialInputImpl, SerialOutputImpl
Changeset: b518b160607f Author:lancea Date: 2012-01-26 19:41 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b518b160607f 7133815: address the findbug errors in CachedRowSetImpl, SerialStruct, BaseRow, SerialInputImpl, SerialOutputImpl Reviewed-by: forax ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/BaseRow.java ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java
hg: jdk8/tl/jdk: 7166598: FilteredRowSetImpl can result in Invalid Cursor Position
Changeset: 4580652d9828 Author:lancea Date: 2012-05-04 16:00 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4580652d9828 7166598: FilteredRowSetImpl can result in Invalid Cursor Position Reviewed-by: lancea Contributed-by: Knut Anders Hatlen ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java
hg: jdk8/tl/jdk: 2 new changesets
Changeset: 8305ddc88a5a Author:lancea Date: 2012-06-07 20:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8305ddc88a5a 7172551: Remove Native calls from DriverManager for jigsaw Reviewed-by: alanb, chegar, darcy, mchung ! make/java/java/FILES_c.gmk ! make/java/java/mapfile-vers ! makefiles/java/java/FILES_c.gmk ! makefiles/java/java/mapfile-vers ! src/share/classes/java/sql/DriverManager.java - src/share/native/java/sql/DriverManager.c Changeset: 7cb7bfae9d3a Author:lancea Date: 2012-06-08 09:22 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7cb7bfae9d3a Merge
hg: jdk8/tl/jdk: 7171917: CachedRowSetImpl.populate does not handle map properly
Changeset: 46ff1b63b0c3 Author:lancea Date: 2012-06-11 07:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46ff1b63b0c3 7171917: CachedRowSetImpl.populate does not handle map properly Reviewed-by: joehw ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
hg: jdk8/tl/jdk: 7171918: XmlReaderContentHandler.endElement does not handle a Delete Tag properly
Changeset: 6b6a73e8c036 Author:lancea Date: 2012-06-12 17:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b6a73e8c036 7171918: XmlReaderContentHandler.endElement does not handle a Delete Tag properly Reviewed-by: joehw ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java
hg: jdk8/tl/jdk: 7145913: CachedRowSetSwriter.insertNewRow() throws SQLException
Changeset: 28588ace1fb9 Author:lancea Date: 2012-06-14 15:05 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28588ace1fb9 7145913: CachedRowSetSwriter.insertNewRow() throws SQLException Reviewed-by: joehw, naoto, psandoz, forax ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java
hg: jdk8/tl/jdk: 7193683: DriverManager Iterator Warning cleanup
Changeset: 11bfec75d333 Author:lancea Date: 2012-08-30 13:38 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11bfec75d333 7193683: DriverManager Iterator Warning cleanup Reviewed-by: lancea Contributed-by: Dan Xu ! src/share/classes/java/sql/DriverManager.java
hg: jdk8/tl/jdk: 7192302: Remove JDBCRowSetImpl dependency on java.beans
Changeset: 8c6895afe204 Author:lancea Date: 2012-09-06 13:16 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c6895afe204 7192302: Remove JDBCRowSetImpl dependency on java.beans Reviewed-by: alanb, mchung ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java
hg: jdk8/tl/jdk: 7197395: Add @Deprecated to all deprecated methods to eliminate compiler warnings in JDBC
Changeset: 036c55976cef Author:lancea Date: 2012-10-09 08:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/036c55976cef 7197395: Add @Deprecated to all deprecated methods to eliminate compiler warnings in JDBC Reviewed-by: alanb, smarks ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Date.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java
hg: jdk8/tl/jdk: 8000687: Correct javadoc typo for getLogWriter and setLogWriter
Changeset: 3c4be36de073 Author:lancea Date: 2012-10-10 11:15 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c4be36de073 8000687: Correct javadoc typo for getLogWriter and setLogWriter Reviewed-by: alanb ! src/share/classes/java/sql/DriverManager.java
hg: jdk8/tl/jdk: 8000712: Remove unused fields in SyncFactory
Changeset: 734ca9f4719c Author:lancea Date: 2012-10-10 17:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/734ca9f4719c 8000712: Remove unused fields in SyncFactory Reviewed-by: mchung ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java
hg: jdk8/tl/jdk: 8001536: Added readObject, writeObject, clone, equals, hashcode to SerialXLob
Changeset: 8748331f63cf Author:lancea Date: 2012-11-01 17:35 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8748331f63cf 8001536: Added readObject,writeObject,clone, equals, hashcode to SerialXLob Reviewed-by: alanb, forax ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java
hg: jdk8/tl/jdk: 8004374: CachedRowSetSwriter.writeData reports wrong number of conflicts in SyncProviderException
Changeset: 41a1b110f34d Author:lancea Date: 2012-12-06 15:51 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41a1b110f34d 8004374: CachedRowSetSwriter.writeData reports wrong number of conflicts in SyncProviderException Reviewed-by: naoto ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java
hg: jdk8/tl/jdk: 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety
Changeset: 7a8978a5bb6e Author:lancea Date: 2012-12-12 20:57 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a8978a5bb6e 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety Reviewed-by: naoto ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/share/classes/javax/sql/rowset/serial/SerialDatalink.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java
hg: jdk8/tl/jdk: 8006139: add missing methods to javax.sql.rowset.serial.SQLInputImpl, SQLOutputImpl
Changeset: 78514544980d Author:lancea Date: 2013-01-19 10:11 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/78514544980d 8006139: add missing methods to javax.sql.rowset.serial.SQLInputImpl, SQLOutputImpl Reviewed-by: naoto, ulfzibis, alanb ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java
hg: jdk8/tl/jdk: 8005080: JDBC 4.2 Core changes
Changeset: d3da0d29d7cd Author:lancea Date: 2013-01-19 10:53 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d3da0d29d7cd 8005080: JDBC 4.2 Core changes Reviewed-by: naoto ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/Driver.java ! src/share/classes/java/sql/DriverManager.java + src/share/classes/java/sql/JDBCType.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLTimeoutException.java + src/share/classes/java/sql/SQLType.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/sql/Types.java ! src/share/classes/java/sql/package.html ! src/share/classes/javax/sql/DataSource.java ! src/share/classes/javax/sql/XADataSource.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java
hg: jdk8/tl/jdk: 8006642: Fix javadoc warnings due to Integer.MAX_VALUE
Changeset: de30e46250c5 Author:lancea Date: 2013-01-21 14:08 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de30e46250c5 8006642: Fix javadoc warnings due to Integer.MAX_VALUE Reviewed-by: alanb ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/Statement.java
hg: jdk8/tl/jdk: 8006505: additional changes for JSR 310 support
Changeset: 1574fa3df1c0 Author:lancea Date: 2013-02-06 14:15 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1574fa3df1c0 8006505: additional changes for JSR 310 support Reviewed-by: naoto, ulfzibis ! src/share/classes/java/sql/JDBCType.java ! src/share/classes/java/sql/SQLInput.java ! src/share/classes/java/sql/SQLOutput.java ! src/share/classes/java/sql/Types.java
hg: jdk8/tl/jdk: 2 new changesets
Changeset: 9f9dac5a9e74 Author:lancea Date: 2013-02-22 09:29 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f9dac5a9e74 8008716: address typo in CallableStatement javadocs Reviewed-by: chegar ! src/share/classes/java/sql/CallableStatement.java Changeset: 8d8a35ac7d40 Author:lancea Date: 2013-02-22 09:58 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d8a35ac7d40 Merge
hg: jdk8/tl/jdk: 8006036: (process) cleanup code in java/lang/Runtime/exec/WinCommand.java
Changeset: 04617e462512 Author:lancea Date: 2013-04-08 15:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04617e462512 8006036: (process) cleanup code in java/lang/Runtime/exec/WinCommand.java Reviewed-by: lancea Contributed-by: Jim Gish ! test/java/lang/Runtime/exec/WinCommand.java
hg: jdk8/tl/jdk: 8011620: adding free form netbeans project for jdbc to jdk/make/netbeans
Changeset: b456f25c2075 Author:lancea Date: 2013-04-23 11:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b456f25c2075 8011620: adding free form netbeans project for jdbc to jdk/make/netbeans Reviewed-by: chegar ! make/netbeans/common/shared.xml + make/netbeans/jdbc/README + make/netbeans/jdbc/build.properties + make/netbeans/jdbc/build.xml + make/netbeans/jdbc/nbproject/project.xml
hg: jdk8/tl/jdk: 8010416: Add a way for java.sql.Driver to be notified when it is deregistered
Changeset: ac3e189c9099 Author:lancea Date: 2013-04-30 14:44 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac3e189c9099 8010416: Add a way for java.sql.Driver to be notified when it is deregistered Reviewed-by: alanb, ulfzibis ! src/share/classes/java/sql/Driver.java + src/share/classes/java/sql/DriverAction.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/SQLPermission.java
hg: jdk8/tl/jdk: 8016101: Fix typo in SerialRef and missing @param in SerialStruct
Changeset: e2333bd8514a Author:lancea Date: 2013-06-07 14:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2333bd8514a 8016101: Fix typo in SerialRef and missing @param in SerialStruct Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java
hg: jdk8/tl/jdk: 8017471: Fix JDBC -Xdoclint public errors
Changeset: b9ba04dc210f Author:lancea Date: 2013-06-27 15:07 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b9ba04dc210f 8017471: Fix JDBC -Xdoclint public errors Reviewed-by: darcy ! src/share/classes/java/sql/Blob.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Clob.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/Driver.java ! src/share/classes/java/sql/DriverAction.java ! src/share/classes/java/sql/NClob.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLInput.java ! src/share/classes/java/sql/SQLPermission.java ! src/share/classes/java/sql/SQLXML.java ! src/share/classes/java/sql/Wrapper.java ! src/share/classes/javax/sql/CommonDataSource.java ! src/share/classes/javax/sql/ConnectionPoolDataSource.java ! src/share/classes/javax/sql/DataSource.java ! src/share/classes/javax/sql/RowSet.java ! src/share/classes/javax/sql/XADataSource.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java ! src/share/classes/javax/sql/rowset/FilteredRowSet.java ! src/share/classes/javax/sql/rowset/JdbcRowSet.java ! src/share/classes/javax/sql/rowset/Joinable.java ! src/share/classes/javax/sql/rowset/Predicate.java ! src/share/classes/javax/sql/rowset/RowSetProvider.java ! src/share/classes/javax/sql/rowset/RowSetWarning.java ! src/share/classes/javax/sql/rowset/WebRowSet.java ! src/share/classes/javax/sql/rowset/package.html ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/share/classes/javax/sql/rowset/serial/SerialDatalink.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncResolver.java
hg: jdk8/tl/jdk: 8019286: Fix javadoc typo in ResultSet.next
Changeset: a4eb59bffb60 Author:lancea Date: 2013-06-29 06:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4eb59bffb60 8019286: Fix javadoc typo in ResultSet.next Reviewed-by: darcy, mchung ! src/share/classes/java/sql/ResultSet.java
hg: jdk8/tl/jdk: 8022753: SQLXML javadoc example typo
Changeset: cc64a05836a7 Author:lancea Date: 2013-08-12 16:09 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc64a05836a7 8022753: SQLXML javadoc example typo Reviewed-by: alanb, mchung ! src/share/classes/java/sql/SQLXML.java
hg: jdk8/tl/jdk: 8015340: remove erroneous @since tag
Changeset: 60d6f60416ca Author:lancea Date: 2013-09-12 13:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60d6f60416ca 8015340: remove erroneous @since tag Reviewed-by: darcy ! src/share/classes/java/sql/PreparedStatement.java
hg: jdk8/tl/jdk: 8014967: EBehavior of DriverManager.registerDriver(dr) is unspecified if driver is null
Changeset: 5c7690923663 Author:lancea Date: 2013-09-13 19:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c7690923663 8014967: EBehavior of DriverManager.registerDriver(dr) is unspecified if driver is null Reviewed-by: alanb ! src/share/classes/java/sql/DriverManager.java
hg: jdk8/tl/jdk: 7097386: Correct error in Predicate javadoc example
Changeset: 657482758408 Author:lancea Date: 2013-09-17 07:56 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/657482758408 7097386: Correct error in Predicate javadoc example Reviewed-by: alanb, shade ! src/share/classes/javax/sql/rowset/Predicate.java
Re: 8008662: Add @jdk.Supported to JDK-specific/supported API
Well, that was quite a few files to have to go through :-) Looks fine On Feb 21, 2013, at 1:46 PM, Alan Bateman wrote: > > Joe Darcy recently added @jdk.Supported [1] to make it possible to identify > JDK-specific APIs. > > I'd like to add this to a number of APIs in the com.sun namespace to make it > obvious these are "supported". Specifically I'm proposing to add it to: > > - Java Debug Interface (com.sun.jdi) > - Attach API (com.sun.tools.attach) > - SCTP API (com.sun.nio.sctp) > - HTTP server API (com.sun.net.httpserver) > - Management extensions (com.sun.management) > - JDK-specific API to JAAS (com.sun.security.auth) > - JDK-specific JGSS API (com.sun.security.jgss) > > The javadoc for all of these is generated as part of the regular JDK "docs" > build and so shouldn't be controversial. There are a number of other > candidates in com.sun with murkier status that I've stayed clear of for now. > > The webrev with the changes is here: > > http://cr.openjdk.java.net/~alanb/8008662/webrev/ > > In a couple of cases the package description is legacy package.html so I've > had to move/convert them to package-info.java. > > In all but one case I've added the annotation to the package-info, the one > exception is com.sun.management where there is at least one type that is > documented as "not supported". Joe Darcy might have suggestions on that. > > Otherwise this is mostly mechanical and the patch file is easier to review > that the webrev. > > -Alan > > [1] http://hg.openjdk.java.net/jdk8/tl/langtools/rev/55cca2f38ee6 <> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
Re: RFR doclint issues in java.net
Good to go
On Jul 25, 2013, at 6:00 AM, Chris Hegarty wrote:
> This is a request for review for some doclint warnings in the java.net
> package. Trivially, the list type should be left to the CSS.
>
> Note: with these changes there are still warnings for two DatagramPacket
> constructors that are missing @throws for SocketException. I do not see any
> reason that these constructors need to throw SE, and I will file a separate
> bug to follow up.
>
> diff -r fd1b5adcfdf0 src/share/classes/java/net/URI.java
> --- a/src/share/classes/java/net/URI.java Wed Jul 24 22:52:01 2013 +0100
> +++ b/src/share/classes/java/net/URI.java Thu Jul 25 10:56:25 2013 +0100
> @@ -530,7 +530,7 @@ public final class URI
> * href="http://www.ietf.org/rfc/rfc2396.txt";>RFC 2396,
> * Appendix A, except for the following deviations:
>
> *
> - *
> + *
> *
> *An empty authority component is permitted as long as it is
> * followed by a non-empty path, a query component, or a fragment
> @@ -993,7 +993,7 @@ public final class URI
> *Otherwise the new URI's authority component is copied from
> * this URI, and its path is computed as follows:
> *
> - *
> + *
> *
> * If the given URI's path is absolute then the new URI's path
> * is taken from the given URI.
> @@ -1241,7 +1241,7 @@ public final class URI
> * The host component of a URI, if defined, will have one of the
> * following forms:
> *
> - *
> + *
> *
> *A domain name consisting of one or more labels
> * separated by period characters ('.'), optionally followed by
> @@ -1495,7 +1495,7 @@ public final class URI
> *
> * The ordering of URIs is defined as follows:
> *
> - *
> + *
> *
> *Two URIs with different schemes are ordered according the
> * ordering of their schemes, without regard to case.
> @@ -1513,7 +1513,7 @@ public final class URI
> *Two hierarchical URIs with identical schemes are ordered
> * according to the ordering of their authority components:
> *
> - *
> + *
> *
> * If both authority components are server-based then the URIs
> * are ordered according to their user-information components; if
> these
>
>
> -Chris.
<>
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
