hg: jdk8/tl/langtools: 8025913: Rename jdk.Supported to jdk.Exported
Changeset: 379c04c090cf Author:darcy Date: 2013-10-04 10:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/379c04c090cf 8025913: Rename jdk.Supported to jdk.Exported Reviewed-by: psandoz, forax, lancea, alanb, mchung, jjg ! src/share/classes/com/sun/source/doctree/AttributeTree.java ! src/share/classes/com/sun/source/doctree/AuthorTree.java ! src/share/classes/com/sun/source/doctree/BlockTagTree.java ! src/share/classes/com/sun/source/doctree/CommentTree.java ! src/share/classes/com/sun/source/doctree/DeprecatedTree.java ! src/share/classes/com/sun/source/doctree/DocCommentTree.java ! src/share/classes/com/sun/source/doctree/DocRootTree.java ! src/share/classes/com/sun/source/doctree/DocTree.java ! src/share/classes/com/sun/source/doctree/DocTreeVisitor.java ! src/share/classes/com/sun/source/doctree/EndElementTree.java ! src/share/classes/com/sun/source/doctree/EntityTree.java ! src/share/classes/com/sun/source/doctree/ErroneousTree.java ! src/share/classes/com/sun/source/doctree/IdentifierTree.java ! src/share/classes/com/sun/source/doctree/InheritDocTree.java ! src/share/classes/com/sun/source/doctree/InlineTagTree.java ! src/share/classes/com/sun/source/doctree/LinkTree.java ! src/share/classes/com/sun/source/doctree/LiteralTree.java ! src/share/classes/com/sun/source/doctree/ParamTree.java ! src/share/classes/com/sun/source/doctree/ReferenceTree.java ! src/share/classes/com/sun/source/doctree/ReturnTree.java ! src/share/classes/com/sun/source/doctree/SeeTree.java ! src/share/classes/com/sun/source/doctree/SerialDataTree.java ! src/share/classes/com/sun/source/doctree/SerialFieldTree.java ! src/share/classes/com/sun/source/doctree/SerialTree.java ! src/share/classes/com/sun/source/doctree/SinceTree.java ! src/share/classes/com/sun/source/doctree/StartElementTree.java ! src/share/classes/com/sun/source/doctree/TextTree.java ! src/share/classes/com/sun/source/doctree/ThrowsTree.java ! src/share/classes/com/sun/source/doctree/UnknownBlockTagTree.java ! src/share/classes/com/sun/source/doctree/UnknownInlineTagTree.java ! src/share/classes/com/sun/source/doctree/ValueTree.java ! src/share/classes/com/sun/source/doctree/VersionTree.java ! src/share/classes/com/sun/source/doctree/package-info.java ! src/share/classes/com/sun/source/tree/AnnotatedTypeTree.java ! src/share/classes/com/sun/source/tree/AnnotationTree.java ! src/share/classes/com/sun/source/tree/ArrayAccessTree.java ! src/share/classes/com/sun/source/tree/ArrayTypeTree.java ! src/share/classes/com/sun/source/tree/AssertTree.java ! src/share/classes/com/sun/source/tree/AssignmentTree.java ! src/share/classes/com/sun/source/tree/BinaryTree.java ! src/share/classes/com/sun/source/tree/BlockTree.java ! src/share/classes/com/sun/source/tree/BreakTree.java ! src/share/classes/com/sun/source/tree/CaseTree.java ! src/share/classes/com/sun/source/tree/CatchTree.java ! src/share/classes/com/sun/source/tree/ClassTree.java ! src/share/classes/com/sun/source/tree/CompilationUnitTree.java ! src/share/classes/com/sun/source/tree/CompoundAssignmentTree.java ! src/share/classes/com/sun/source/tree/ConditionalExpressionTree.java ! src/share/classes/com/sun/source/tree/ContinueTree.java ! src/share/classes/com/sun/source/tree/DoWhileLoopTree.java ! src/share/classes/com/sun/source/tree/EmptyStatementTree.java ! src/share/classes/com/sun/source/tree/EnhancedForLoopTree.java ! src/share/classes/com/sun/source/tree/ErroneousTree.java ! src/share/classes/com/sun/source/tree/ExpressionStatementTree.java ! src/share/classes/com/sun/source/tree/ExpressionTree.java ! src/share/classes/com/sun/source/tree/ForLoopTree.java ! src/share/classes/com/sun/source/tree/IdentifierTree.java ! src/share/classes/com/sun/source/tree/IfTree.java ! src/share/classes/com/sun/source/tree/ImportTree.java ! src/share/classes/com/sun/source/tree/InstanceOfTree.java ! src/share/classes/com/sun/source/tree/IntersectionTypeTree.java ! src/share/classes/com/sun/source/tree/LabeledStatementTree.java ! src/share/classes/com/sun/source/tree/LambdaExpressionTree.java ! src/share/classes/com/sun/source/tree/LineMap.java ! src/share/classes/com/sun/source/tree/LiteralTree.java ! src/share/classes/com/sun/source/tree/MemberReferenceTree.java ! src/share/classes/com/sun/source/tree/MemberSelectTree.java ! src/share/classes/com/sun/source/tree/MethodInvocationTree.java ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/ModifiersTree.java ! src/share/classes/com/sun/source/tree/NewArrayTree.java ! src/share/classes/com/sun/source/tree/NewClassTree.java ! src/share/classes/com/sun/source/tree/ParameterizedTypeTree.java ! src/share/classes/com/sun/source/tree/ParenthesizedTree.java ! src/share/classes/com/sun/source/tree/PrimitiveTypeTree.java ! src/share/classes/com/sun/source/tree/ReturnTree.java ! src/share/classes/com/sun/source/tree/Scope.java ! src/share/classes/com/sun/source/tree/StatementTree.java ! src/share/classes/com/sun/so
hg: jdk8/tl/langtools: 8026017: Make history of AnnotatedConstruct methods in jx.l.m.e.Element clearer
Changeset: 4dd7ffbf01fb Author:darcy Date: 2013-10-07 16:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4dd7ffbf01fb 8026017: Make history of AnnotatedConstruct methods in jx.l.m.e.Element clearer Reviewed-by: jjg ! src/share/classes/javax/lang/model/element/Element.java
hg: jdk8/tl/jdk: 8024354: Explicitly permit DoubleStream.sum()/average() implementations to use higher precision summation
Changeset: c13309f658e1 Author:darcy Date: 2013-10-09 18:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c13309f658e1 8024354: Explicitly permit DoubleStream.sum()/average() implementations to use higher precision summation Reviewed-by: mduigou, briangoetz ! src/share/classes/java/util/DoubleSummaryStatistics.java ! src/share/classes/java/util/stream/DoubleStream.java
hg: jdk8/tl/langtools: 8026838: Fix new doclint issues in javax.annotation.processing
Changeset: 7af634b1fc5b Author:darcy Date: 2013-10-17 19:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7af634b1fc5b 8026838: Fix new doclint issues in javax.annotation.processing Reviewed-by: jjg ! src/share/classes/javax/annotation/processing/Processor.java
hg: jdk8/tl/jdk: 8026840: Fix new doclint issues in javax.naming
Changeset: 8a7b1b615100 Author:darcy Date: 2013-10-17 22:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a7b1b615100 8026840: Fix new doclint issues in javax.naming Reviewed-by: mchung ! src/share/classes/javax/naming/CompositeName.java ! src/share/classes/javax/naming/CompoundName.java ! src/share/classes/javax/naming/Context.java ! src/share/classes/javax/naming/InitialContext.java ! src/share/classes/javax/naming/ReferralException.java ! src/share/classes/javax/naming/directory/DirContext.java ! src/share/classes/javax/naming/event/EventContext.java ! src/share/classes/javax/naming/ldap/LdapContext.java ! src/share/classes/javax/naming/ldap/Rdn.java
hg: jdk8/tl/jdk: 8022658: Revisit FunctionalInterface on some core libs types
Changeset: c1700125d041 Author:darcy Date: 2013-10-21 12:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1700125d041 8022658: Revisit FunctionalInterface on some core libs types Reviewed-by: briangoetz, mduigou, mr ! src/share/classes/java/io/Closeable.java ! src/share/classes/java/io/Flushable.java ! src/share/classes/java/lang/AutoCloseable.java ! src/share/classes/java/lang/Comparable.java ! src/share/classes/java/lang/Iterable.java ! src/share/classes/java/lang/Readable.java
hg: jdk8/tl/langtools: 8026984: Clarity intended use of jdk.Exported
Changeset: b82982ac3ca2 Author:darcy Date: 2013-10-21 15:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b82982ac3ca2 8026984: Clarity intended use of jdk.Exported Reviewed-by: psandoz, mr, alanb ! src/share/classes/jdk/Exported.java
hg: jdk8/tl/jdk: 8027062: Fix lint and doclint issues in java.lang.{ClassLoader, ClassValue, SecurityManager}
Changeset: 9a32af82bd1e
Author:darcy
Date: 2013-10-22 12:04 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a32af82bd1e
8027062: Fix lint and doclint issues in java.lang.{ClassLoader, ClassValue,
SecurityManager}
Reviewed-by: chegar, forax, alanb, mduigou
! src/share/classes/java/lang/ClassLoader.java
! src/share/classes/java/lang/ClassValue.java
! src/share/classes/java/lang/SecurityManager.java
hg: jdk8/tl/jdk: 8005294: Consider default methods for additions to AnnotatedElement
Changeset: e8894e3224d9 Author:darcy Date: 2013-10-30 17:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8894e3224d9 8005294: Consider default methods for additions to AnnotatedElement Reviewed-by: jfranck, plevart, mchung, abuckley, sogoel ! src/share/classes/java/lang/reflect/AnnotatedElement.java + test/java/lang/reflect/AnnotatedElement/TestAnnotatedElementDefaults.java
hg: jdk8/tl/langtools: 8027730: Fix release-8 type visitors to support intersection types
Changeset: e39bd9401ea5 Author:darcy Date: 2013-11-07 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e39bd9401ea5 8027730: Fix release-8 type visitors to support intersection types Reviewed-by: jjg, jlahoda, sogoel ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor8.java + test/tools/javac/processing/model/util/TestIntersectionTypeVisitors.java
hg: jdk8/tl/jdk: 8028076: Correct raw type lint warnings in core reflection implementation classes
Changeset: 11376ad23e21 Author:darcy Date: 2013-11-08 12:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11376ad23e21 8028076: Correct raw type lint warnings in core reflection implementation classes Reviewed-by: lancea, alanb ! src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java ! src/share/classes/sun/reflect/generics/repository/GenericDeclRepository.java
hg: jdk8/tl/jdk: 8028229: Fix more raw types lint warning in core libraries
Changeset: 69432cb5bca2 Author:darcy Date: 2013-11-12 09:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69432cb5bca2 8028229: Fix more raw types lint warning in core libraries Reviewed-by: chegar, forax, lancea, alanb, jfranck ! src/share/classes/java/io/ObjectOutputStream.java ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/java/nio/file/TempFileHelper.java ! src/share/classes/java/util/IdentityHashMap.java ! src/share/classes/java/util/logging/Logger.java ! src/share/classes/java/util/logging/Logging.java ! src/share/classes/sun/misc/Cleaner.java ! src/share/classes/sun/misc/ProxyGenerator.java ! src/share/classes/sun/rmi/rmic/Main.java ! src/share/classes/sun/rmi/server/LoaderHandler.java ! src/share/classes/sun/rmi/server/UnicastServerRef.java ! src/share/classes/sun/rmi/server/Util.java
hg: jdk8/tl/jdk: 8028300: Fix raw type lint warnings in java.util.concurrent
Changeset: e6333788b117 Author:darcy Date: 2013-11-13 11:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6333788b117 8028300: Fix raw type lint warnings in java.util.concurrent Reviewed-by: chegar, martin ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java
hg: jdk8/tl/jdk: 8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
Changeset: ca911e383e26 Author:darcy Date: 2013-12-01 23:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca911e383e26 8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors Reviewed-by: psandoz, mduigou ! src/share/classes/java/util/DoubleSummaryStatistics.java ! src/share/classes/java/util/stream/Collectors.java ! src/share/classes/java/util/stream/DoublePipeline.java + test/java/util/stream/TestDoubleSumAverage.java
hg: jdk8/tl/jdk: 8029478: Fix more doclint issues in javax.script
Changeset: 1c3d58caa7da Author:darcy Date: 2013-12-03 10:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c3d58caa7da 8029478: Fix more doclint issues in javax.script Reviewed-by: chegar, mduigou ! src/share/classes/javax/script/ScriptEngineFactory.java
hg: jdk8/tl/jdk: 8029475: Fix more doclint issues in javax.security
Changeset: cd4aabc40f72 Author:darcy Date: 2013-12-03 11:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd4aabc40f72 8029475: Fix more doclint issues in javax.security Reviewed-by: juh ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/CipherSpi.java ! src/share/classes/javax/crypto/KeyGenerator.java ! src/share/classes/javax/crypto/SealedObject.java ! src/share/classes/javax/net/ssl/SSLEngine.java ! src/share/classes/javax/net/ssl/SSLPermission.java ! src/share/classes/javax/security/auth/PrivateCredentialPermission.java ! src/share/classes/javax/security/auth/kerberos/DelegationPermission.java ! src/share/classes/javax/security/auth/kerberos/ServicePermission.java ! src/share/classes/javax/security/auth/login/LoginContext.java ! src/share/classes/javax/security/auth/x500/X500Principal.java
hg: jdk8/tl/jdk: 8023471: Add compatibility note to AnnotatedElement
Changeset: f8da1f34c65c Author:darcy Date: 2013-12-06 11:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8da1f34c65c 8023471: Add compatibility note to AnnotatedElement Reviewed-by: smarks, jfranck, abuckley ! src/share/classes/java/lang/annotation/Annotation.java ! src/share/classes/java/lang/reflect/AnnotatedElement.java
hg: jdk8/tl/langtools: 8030080: Correct misstatement in JSR 269 MR (in javax.lang.model)
Changeset: 6d1f9d1fd585 Author:darcy Date: 2013-12-17 10:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6d1f9d1fd585 8030080: Correct misstatement in JSR 269 MR (in javax.lang.model) Reviewed-by: jfranck ! src/share/classes/javax/lang/model/type/IntersectionType.java ! src/share/classes/javax/lang/model/util/Types.java
hg: jdk8/tl/jdk: 8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
Changeset: 68de5492a06d Author:darcy Date: 2014-01-03 11:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68de5492a06d 8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity" Reviewed-by: mduigou, psandoz ! src/share/classes/java/util/DoubleSummaryStatistics.java ! src/share/classes/java/util/stream/Collectors.java ! src/share/classes/java/util/stream/DoublePipeline.java ! test/java/util/stream/TestDoubleSumAverage.java
JDK 9 RFR of JDK-8031201: Fix casting lint issues in java.net
Hello,
Please review the simple patch below to address
JDK-8031201: Fix casting lint issues in java.net
(The various ObjectInputStream.GetField.get methods which have a default
parameter, have an property-typed return value already.)
Thanks,
-Joe
diff -r 9af7c1225730 src/share/classes/java/net/Inet6Address.java
--- a/src/share/classes/java/net/Inet6Address.javaMon Jan 06
11:00:12 2014 +
+++ b/src/share/classes/java/net/Inet6Address.javaMon Jan 06
11:34:25 2014 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2000, 2013, Oracle and/or its affiliates. All rights
reserved.
+ * Copyright (c) 2000, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -604,9 +604,9 @@
ObjectInputStream.GetField gf = s.readFields();
byte[] ipaddress = (byte[])gf.get("ipaddress", null);
-int scope_id = (int)gf.get("scope_id", -1);
-boolean scope_id_set = (boolean)gf.get("scope_id_set", false);
-boolean scope_ifname_set = (boolean)gf.get("scope_ifname_set",
false);
+int scope_id = gf.get("scope_id", -1);
+boolean scope_id_set = gf.get("scope_id_set", false);
+boolean scope_ifname_set = gf.get("scope_ifname_set", false);
String ifname = (String)gf.get("ifname", null);
if (ifname != null && !"".equals (ifname)) {
JDK 9 RFR of 8031326: Use Class rather than Class in java.net method signatures
Hello,
Please review these changes to remove use of raw Class in some method
signatures in java.net:
JDK-8031326: Use Class rather than Class in java.net method
signatures
Patch below.
Thanks,
-Joe
--- a/src/share/classes/java/net/URL.javaTue Jan 07 09:17:56 2014 -0800
+++ b/src/share/classes/java/net/URL.javaTue Jan 07 09:20:09 2014 -0800
@@ -1055,7 +1055,7 @@
/**
* Gets the contents of this URL. This method is a shorthand for:
*
- * openConnection().getContent(Class[])
+ * openConnection().getContent(classes)
*
*
* @param classes an array of Java types
@@ -1066,7 +1066,7 @@
* @seejava.net.URLConnection#getContent(Class[])
* @since 1.3
*/
-public final Object getContent(Class[] classes)
+public final Object getContent(Class[] classes)
throws java.io.IOException {
return openConnection().getContent(classes);
}
diff -r b54fa34779b6 src/share/classes/java/net/URLConnection.java
--- a/src/share/classes/java/net/URLConnection.javaTue Jan 07
09:17:56 2014 -0800
+++ b/src/share/classes/java/net/URLConnection.javaTue Jan 07
09:20:09 2014 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1995, 2013, Oracle and/or its affiliates. All rights
reserved.
+ * Copyright (c) 1995, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -760,7 +760,7 @@
* @see
java.net.URLConnection#setContentHandlerFactory(java.net.ContentHandlerFactory)
* @since 1.3
*/
-public Object getContent(Class[] classes) throws IOException {
+public Object getContent(Class[] classes) throws IOException {
// Must call getInputStream before GetHeaderField gets called
// so that FileNotFoundException has a chance to be thrown up
// from here without being caught.
JDK 9 RFR of JDK-8041395: Doclint regression in java.net.SocketOption
Hello,
Please review these straightforward changes to address some doclint
issues in java.net:
JDK-8041395: Doclint regression in java.net.SocketOption
http://cr.openjdk.java.net/~darcy/8041395.0/
Patch below.
Thanks,
-Joe
--- old/src/java.base/share/classes/java/net/DatagramSocket.java
2015-02-09 15:19:25.407396706 -0800
+++ new/src/java.base/share/classes/java/net/DatagramSocket.java
2015-02-09 15:19:25.223399019 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1995, 2013, Oracle and/or its affiliates. All rights
reserved.
+ * Copyright (c) 1995, 2015, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -1308,6 +1308,7 @@
/**
* Sets the value of a socket option.
*
+ * @param The type of the socket option value
* @param name The socket option
* @param value The value of the socket option. A value of {@code
null}
* may be valid for some options.
@@ -1342,6 +1343,7 @@
/**
* Returns the value of a socket option.
*
+ * @param The type of the socket option value
* @param name The socket option
*
* @return The value of the socket option.
--- old/src/java.base/share/classes/java/net/DatagramSocketImpl.java
2015-02-09 15:19:25.855391074 -0800
+++ new/src/java.base/share/classes/java/net/DatagramSocketImpl.java
2015-02-09 15:19:25.695393086 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1996, 2013, Oracle and/or its affiliates. All rights
reserved.
+ * Copyright (c) 1996, 2015, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -267,6 +267,7 @@
/**
* Called to set a socket option.
*
+ * @param The type of the socket option value
* @param name The socket option
*
* @param value The value of the socket option. A value of {@code
null}
@@ -276,7 +277,7 @@
* support the option
*
* @throws NullPointerException if name is {@code null}
- *
+ * @throws IOException if an I/O problem occurs while attempting to
set the option
* @since 1.9
*/
protected void setOption(SocketOption name, T value) throws
IOException {
@@ -308,12 +309,15 @@
/**
* Called to get a socket option.
*
+ * @return the socket option
+ * @param The type of the socket option value
* @param name The socket option
*
* @throws UnsupportedOperationException if the DatagramSocketImpl
does not
* support the option
*
* @throws NullPointerException if name is {@code null}
+ * @throws IOException if an I/O problem occurs while attempting to
set the option
*
* @since 1.9
*/
--- old/src/java.base/share/classes/java/net/ServerSocket.java
2015-02-09 15:19:26.303385442 -0800
+++ new/src/java.base/share/classes/java/net/ServerSocket.java
2015-02-09 15:19:26.131387604 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1995, 2013, Oracle and/or its affiliates. All rights
reserved.
+ * Copyright (c) 1995, 2015, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -924,6 +924,7 @@
/**
* Sets the value of a socket option.
*
+ * @param The type of the socket option value
* @param name The socket option
* @param value The value of the socket option. A value of {@code
null}
* may be valid for some options.
@@ -957,6 +958,7 @@
/**
* Returns the value of a socket option.
*
+ * @param The type of the socket option value
* @param name The socket option
*
* @return The value of the socket option.
--- old/src/java.base/share/classes/java/net/Socket.java 2015-02-09
15:19:26.739379961 -0800
+++ new/src/java.base/share/classes/java/net/Socket.java 2015-02-09
15:19:26.579381972 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1995, 2013, Oracle and/or its affiliates. All rights
reserved.
+ * Copyright (c) 1995, 2015, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -1727,6 +1727,7 @@
/**
* Sets the value of a socket option.
*
+ * @param The type of the socket option value
* @param name The socket option
* @param value The value of the socket option. A value of {@code
null}
* may be valid for some options.
@@ -1758,6 +1759,7 @@
/**
* Returns the value of a socket option.
*
+ * @param The type of the socket option value
* @param name The soc
Re: Temporarily remove java/net/httpclient from jdk_net test group
Looks fine Chris; thanks, -Joe On 10/25/2016 5:55 AM, Chris Hegarty wrote: Hi, There are some intermittent test failures in java/net/httpclient. Since development is ongoing over in the sandbox [1], then it is probably best to exclude these tests from the jdk_net test group, in the JDK 9 mainline, temporarily. diff -r a80fd00b0cd0 test/TEST.groups --- a/test/TEST.groups Tue Oct 25 10:31:49 2016 +0100 +++ b/test/TEST.groups Tue Oct 25 13:51:32 2016 +0100 @@ -158,6 +158,7 @@ jdk_net = \ java/net \ +-java/net/httpclient \ com/sun/net/httpserver \ sun/net \ jdk/net -Chris. [1] http://hg.openjdk.java.net/jdk9/sandbox/jdk/branches [http-client-branch]
JDK 12 RFR of JDK-8213911: Use example.com in java.net and other examples
Hello,
Please review a simple doc-only change to address:
JDK-8213911: Use example.com in java.net and other examples
http://cr.openjdk.java.net/~darcy/8213911.0/
Patch below.
Thanks,
-Joe
--- old/src/java.base/share/classes/java/net/HostPortrange.java
2018-11-26 13:32:47.07800 -0800
+++ new/src/java.base/share/classes/java/net/HostPortrange.java
2018-11-26 13:32:46.90200 -0800
@@ -60,7 +60,7 @@
HostPortrange(String scheme, String str) {
// Parse the host name. A name has up to three components, the
// hostname, a port number, or two numbers representing a port
- // range. "www.sun.com:8080-9090" is a valid host name.
+ // range. "www.example.com:8080-9090" is a valid host name.
// With IPv6 an address can be 2010:836B:4179::836B:4179
// An IPv6 address needs to be enclose in []
--- old/src/java.base/share/classes/java/net/InetAddress.java 2018-11-26
13:32:47.47400 -0800
+++ new/src/java.base/share/classes/java/net/InetAddress.java 2018-11-26
13:32:47.29800 -0800
@@ -1168,7 +1168,7 @@
* No name service is checked for the validity of the address.
*
* The host name can either be a machine name, such as
- * "{@code java.sun.com}", or a textual representation of its IP
+ * "{@code www.example.com}", or a textual representation of its IP
* address.
* No validity checking is done on the host name either.
*
@@ -1213,7 +1213,7 @@
* Determines the IP address of a host, given the host's name.
*
* The host name can either be a machine name, such as
- * "{@code java.sun.com}", or a textual representation of its
+ * "{@code www.example.com}", or a textual representation of its
* IP address. If a literal IP address is supplied, only the
* validity of the address format is checked.
*
@@ -1259,7 +1259,7 @@
* based on the configured name service on the system.
*
* The host name can either be a machine name, such as
- * "{@code java.sun.com}", or a textual representation of its IP
+ * "{@code www.example.com}", or a textual representation of its IP
* address. If a literal IP address is supplied, only the
* validity of the address format is checked.
*
--- old/src/java.base/share/classes/java/net/SocketPermission.java
2018-11-26 13:32:47.85000 -0800
+++ new/src/java.base/share/classes/java/net/SocketPermission.java
2018-11-26 13:32:47.67800 -0800
@@ -63,7 +63,7 @@
* or as "localhost" (for the local machine).
* The wildcard "*" may be included once in a DNS name host
* specification. If it is included, it must be in the leftmost
- * position, as in "*.sun.com".
+ * position, as in "*.example.com".
*
* The format of the IPv6reference should follow that specified in http://www.ietf.org/rfc/rfc2732.txt";>RFC 2732: Format
@@ -115,11 +115,11 @@
* note that if the following permission:
*
*
- * p1 = new SocketPermission("puffin.eng.sun.com:",
"connect,accept");
+ * p1 = new SocketPermission("foo.example.com:", "connect,accept");
*
*
* is granted to some code, it allows that code to connect to port on
- * {@code puffin.eng.sun.com}, and to accept connections on that port.
+ * {@code foo.example.com}, and to accept connections on that port.
*
* Similarly, if the following permission:
*
@@ -211,7 +211,7 @@
// all the IP addresses of the host
private transient InetAddress[] addresses;
- // true if the hostname is a wildcard (e.g. "*.sun.com")
+ // true if the hostname is a wildcard (e.g. "*.example.com")
private transient boolean wildcard;
// true if we were initialized with a single numeric IP address
@@ -274,9 +274,9 @@
*
* Examples of SocketPermission instantiation are the following:
*
- * nr = new SocketPermission("www.catalog.com", "connect");
- * nr = new SocketPermission("www.sun.com:80", "connect");
- * nr = new SocketPermission("*.sun.com", "connect");
+ * nr = new SocketPermission("www.example.com", "connect");
+ * nr = new SocketPermission("www.example.com:80", "connect");
+ * nr = new SocketPermission("*.example.com", "connect");
* nr = new SocketPermission("*.edu", "resolve");
* nr = new SocketPermission("204.160.241.0", "connect");
* nr = new SocketPermission("localhost:1024-65535", "listen");
@@ -400,7 +400,7 @@
// Parse the host name. A name has up to three components, the
// hostname, a port number, or two numbers representing a port
- // range. "www.sun.com:8080-9090" is a valid host name.
+ // range. "www.example.com:8080-9090" is a valid host name.
// With IPv6 an address can be 2010:836B:4179::836B:4179
// An IPv6 address needs to be enclose in []
@@ -835,10 +835,10 @@
*
* If this object was initialized with a single IP address
and one of p'
Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma
Hello, At least from a quick reading, either the spec change or the behavior change would seem to merit a CSR. Cheers, -Joe On 10/2/2019 4:26 PM, Ivan Gerasimov wrote: Hi Chris! Thank you very much for review! I agree that it makes sense to update the javadoc for consistency. I don't think CSR is required in this case, is it? (IAE is unchecked anyway, and the fix doesn't really change the behavior.) Here's the updated webrev: http://cr.openjdk.java.net/~igerasim/8230407/01/webrev/ With kind regards, Ivan On 10/2/19 6:44 AM, Chris Hegarty wrote: Ivan, On 01/10/2019 21:26, Ivan Gerasimov wrote: Hello! The constructors of SocketPermission and FilePermission expect a String argument with comma-separated list of actions. If the list is malformed, then the constructors throw IllegalArgumentException. It turns out that the current implementation fails to throw IAE if the list starts with a leading comma. Would you please help review a simple fix, which will make the behavior more consistent? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8230407 WEBREV: http://cr.openjdk.java.net/~igerasim/8230407/00/webrev/ The implementation changes look ok. The SocketPermission constructor should be updated to specify IAE too, right? -Chris.
JDK 16 RFR of JDK-8250244: Address reliance on default constructors in java.net
Hello, Please review the replacement of default constructors in various abstract classes in java.net with explicit constructors: webrev: http://cr.openjdk.java.net/~darcy/8250244.0/ CSR: https://bugs.openjdk.java.net/browse/JDK-8250245 (This is part of a larger effort to remove default constructor usage from the JDK in preparation for enabling a new lint warning.) Thanks, -Joe
Re: JDK 16 RFR of JDK-8250244: Address reliance on default constructors in java.net
Hi Alan, On 7/24/2020 3:34 AM, Alan Bateman wrote: On 24/07/2020 01:33, Joe Darcy wrote: Hello, Please review the replacement of default constructors in various abstract classes in java.net with explicit constructors: webrev: http://cr.openjdk.java.net/~darcy/8250244.0/ CSR: https://bugs.openjdk.java.net/browse/JDK-8250245 (This is part of a larger effort to remove default constructor usage from the JDK in preparation for enabling a new lint warning.) Could we use the opportunity to change some of these to be protected? For some of these then I don't think there is any compatibility impact. At least from a few minutes thinking, I don't see a meaningful compatibility issue in replacing 1) a public constructor in an abstract class with 2) a protected constructor in an abstract class It is source compatible, subclasses would have access to the constructor in either case, and should also be binary compatible as linkage shouldn't be impacted (because subclasses would still have access to the constructor). That said, for this exercise I'd prefer to replace the implicit default constructors with equivalent explicit ones, but would be open to future refinements to make the constructors protected. Thanks, -Joe
Re: RFR: JDK-8255262: Remove use of legacy custom @spec tag
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote: > The change is (just) to remove legacy usages of a JDK-private custom tag. Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/814
RFR: 8250564: Remove terminally deprecated constructor in GSSUtil
Back in JDK 16, two unintended default constructors were identified and deprecated for removal. The time has come to remove them. Please also review the corresponding CSRs: JDK-8258521 Remove terminally deprecated constructor in GSSUtil https://bugs.openjdk.java.net/browse/JDK-8258521 JDK-8258522 Remove terminally deprecated constructor in java.net.URLDecoder https://bugs.openjdk.java.net/browse/JDK-8258522 Calling a static method using an instance of a class, as done in the test B6463990.java, is a coding anti-pattern that generates a lint warning; that warning in enabled in the JDK build. Thanks, - Commit messages: - 8250564: Remove terminally deprecated constructor in GSSUti Changes: https://git.openjdk.java.net/jdk/pull/1948/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1948&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8250564 Stats: 7 lines in 3 files changed: 0 ins; 3 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/1948.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1948/head:pull/1948 PR: https://git.openjdk.java.net/jdk/pull/1948
Integrated: 8250564: Remove terminally deprecated constructor in GSSUtil
On Tue, 5 Jan 2021 21:02:21 GMT, Joe Darcy wrote: > Back in JDK 16, two unintended default constructors were identified and > deprecated for removal. The time has come to remove them. > > Please also review the corresponding CSRs: > > JDK-8258521 Remove terminally deprecated constructor in GSSUtil > https://bugs.openjdk.java.net/browse/JDK-8258521 > > JDK-8258522 Remove terminally deprecated constructor in java.net.URLDecoder > https://bugs.openjdk.java.net/browse/JDK-8258522 > > Calling a static method using an instance of a class, as done in the test > B6463990.java, is a coding anti-pattern that generates a lint warning; that > warning in enabled in the JDK build. > > Thanks, This pull request has now been integrated. Changeset: 80544e4d Author:Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/80544e4d Stats: 7 lines in 3 files changed: 0 ins; 3 del; 4 mod 8250564: Remove terminally deprecated constructor in GSSUtil 8250565: Remove terminally deprecated constructor in java.net.URLDecoder Reviewed-by: bpb, smarks, alanb, mullan - PR: https://git.openjdk.java.net/jdk/pull/1948
Re: RFR: JDK-8262875: doccheck: empty paragraphs, etc in java.base module
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote: > Please review some minor doc fixes, for issues found by _doccheck_.There > are two kinds of errors that are addressed. > > 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a > paragraph. It is not a terminator, to mark the end of a paragraph, or a > separator to mark the boundary between paragraphs. In particular, it should > not be used at the end of a description before a javadoc block tag, such as > `@param` or before other HTML block tags, like `` or ``. > > 2. References to the id `package-description`, following the recent > standardization of all ids generated by javadoc, Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2795
Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. > https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1 > The essential change for this JEP, including the `@Deprecate` annotations > and spec change. It also update the default value of the > `java.security.manager` system property to "disallow", and necessary test > change following this update. > 2. > https://github.com/openjdk/jdk/commit/26a54a835e9f84aa528740a7c5c35d07355a8a66 > Manual changes to several files so that the next commit can be generated > programatically. > 3. > https://github.com/openjdk/jdk/commit/eb6c566ff9207974a03a53335e0e697cffcf0950 > Automatic changes to other source files to avoid javac warnings on > deprecation for removal > > The 1st and 2nd commits should be reviewed carefully. The 3rd one is > generated programmatically, see the comment below for more details. If you > are only interested in a portion of the 3rd commit and would like to review > it as a separate file, please comment here and I'll generate an individual > webrev. > > Due to the size of this PR, no attempt is made to update copyright years for > any file to minimize unnecessary merge conflict. > > Furthermore, since the default value of `java.security.manager` system > property is now "disallow", most of the tests calling > `System.setSecurityManager()` need to launched with > `-Djava.security.manager=allow`. This is covered in a different PR at > https://github.com/openjdk/jdk/pull/4071. Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4073
Re: RFR: 8272626: Avoid C-style array declarations in java.*
On 8/18/2021 6:20 AM, Roger Riggs wrote: On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: C-style array declarations generate noisy warnings in IDEs, et.c. This patch cleans up all java.* packages. (Copyrights intentionally not updated due the triviality of most changes) 34 Minutes from proposed to integrated! Its hard to argue with the efficiency, but only 1 timezone of developers had a chance to review or even be aware of the change. I don't think removing use of this archaic language feature, which doesn't change semantics, should be in any way controversial and is long overdue. -Joe
RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields
This is an initial PR for expanded lint warnings done under two bugs:
8202056: Expand serial warning to check for bad overloads of serial-related
methods and ineffectual fields
8160675: Issue lint warning for non-serializable non-transient instance fields
in serializable type
to get feedback on the general approach and test strategy before further
polishing the implementation.
The implementation initially started as an annotation processor I wrote several
years ago. The refined version being incorporated into Attr has been
refactored, had its checks expanded, and been partially ported to idiomatic
javac coding style rather than using the javax.lang.model API from annotation
processing.
Subsequent versions of this PR are expected to move the implementation closer
to idiomatic javac, in particular to use javac flags rather than
javax.lang.model.Modifier's. Additional resources keys will be defined for the
serialization-related fields and methods not having the expected modifiers,
types, etc. The resource keys for the existing checks related to
serialVersionUID and reused.
Please also review the corresponding CSRs:
https://bugs.openjdk.java.net/browse/JDK-8274335
https://bugs.openjdk.java.net/browse/JDK-8274336
Informative serialization-related warning messages must take into account
whether a class, interface, annotation, record, and enum is being analyzed.
Enum classes and record classes have special handling in serialization. This
implementation under review has been augmented with checks for interface types
recommended by Chris Hegarty in an attachment on 8202056.
The JDK build has the Xlint:serial check enabled. The build did not pass with
the augmented checks. For most modules, this PR contains the library changes
necessary for the build to pass. I will start separate PRs in those library
areas to get the needed SuppressWarning("serial") or other changes in place.
For one module, I temporarily disabled the Xlint:serial check.
In terms of performance, I have not done benchmarks of the JDK build with and
without these changes, but informally the build seems to take about as long as
before.
-
Commit messages:
- Appease jcheck
- Implement checks chegar recommended for interfaces.
- Update comment.
- Add tests for instance field checks.
- Clean build with instance field checks in place.
- Merge branch 'master' into JDK-8202056
- Put Externalizable checks last.
- Add checks for constructor access in Serializable classes.
- Add no-arg ctor check for Externalizable classes.
- Improve Externalization warnings.
- ... and 19 more: https://git.openjdk.java.net/jdk/compare/5756385c...d498ff5f
Changes: https://git.openjdk.java.net/jdk/pull/5709/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5709&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8202056
Stats: 1519 lines in 79 files changed: 1511 ins; 1 del; 7 mod
Patch: https://git.openjdk.java.net/jdk/pull/5709.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5709/head:pull/5709
PR: https://git.openjdk.java.net/jdk/pull/5709
RFR: 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net
Augmentations to javac's Xlint:serial checking are out for review (#5709) and the sun.net classes in this PR would need some changes to pass under the expanded checks. The changes are to suppress warnings where non-transient fields in serializable types are not declared with a type statically known to be serializable. That isn't necessarily a correctness issues, but it does merit further scrutiny. The changes in the PR are consistent with similar changes made in JDK libraries under the umbrella issue JDK-8231641. - Commit messages: - 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net Changes: https://git.openjdk.java.net/jdk/pull/5826/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5826&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274793 Stats: 3 lines in 2 files changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/5826.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5826/head:pull/5826 PR: https://git.openjdk.java.net/jdk/pull/5826
Integrated: 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net
On Tue, 5 Oct 2021 18:55:09 GMT, Joe Darcy wrote: > Augmentations to javac's Xlint:serial checking are out for review (#5709) and > the sun.net classes in this PR would need some changes to pass under the > expanded checks. > > The changes are to suppress warnings where non-transient fields in > serializable types are not declared with a type statically known to be > serializable. That isn't necessarily a correctness issues, but it does merit > further scrutiny. > > The changes in the PR are consistent with similar changes made in JDK > libraries under the umbrella issue JDK-8231641. This pull request has now been integrated. Changeset: d34ec6cc Author:Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/d34ec6ccfc27d9401acce0e03595b910764fbfaf Stats: 3 lines in 2 files changed: 3 ins; 0 del; 0 mod 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net Reviewed-by: alanb - PR: https://git.openjdk.java.net/jdk/pull/5826
Re: RFR: 8274835: Remove unnecessary castings in java.base
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov wrote: > Redundant castings make code harder to read. > Found them by IntelliJ IDEA. > I tried to select only casts which are definitely safe to remove. Also didn't > touch primitive types casts. Curious. The JDK build is done with javac -Xlint:cast warning enabled (JDK-8032734) which is intended to catch issues like this. Perhaps IntelliJ is using a different (or sharper) analysis. - PR: https://git.openjdk.java.net/jdk/pull/5454
Re: RFR: 8276348: Use blessed modifier order in java.base
On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote: > This PR follows up one of the recent PRs, where I used a non-canonical > modifier order. Since the problem was noticed [^1], why not to address it at > mass? > > As far as I remember, the first mass-canonicalization of modifiers took place > in JDK-8136583 in 2015 [^2]. That change affected 1780 lines spanning 453 > files. Since then modifiers have become a bit lose, and it makes sense to > re-bless (using the JDK-8136583 terminology) them. > > This change was produced by running the below command followed by updating > the copyright years on the affected files where necessary: > > $ sh ./bin/blessed-modifier-order.sh src/java.base > > The resulting change is much smaller than that of 2015: 39 lines spanning 21 > files. > > [^1]: > https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-November/082987.html > (or https://github.com/openjdk/jdk/pull/6191#pullrequestreview-79465) > [^2]: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035217.html Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6213
Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec for
> JEP 421. It also updates the relevant @SuppressWarning annotations.
>
> The CSR has been approved.
> An automated test build+test run passes cleanly (FWIW :D ).
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6465
RFR: JDK-8280492: Address remaining doclint issues in JDK build
Use presumed syntax that will be introduced by JDK-8280488. - Commit messages: - JDK-8280492: Address remaining doclint issues in JDK build Changes: https://git.openjdk.java.net/jdk/pull/7189/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7189&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280492 Stats: 57 lines in 17 files changed: 0 ins; 0 del; 57 mod Patch: https://git.openjdk.java.net/jdk/pull/7189.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7189/head:pull/7189 PR: https://git.openjdk.java.net/jdk/pull/7189
Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. This should be the (near) final step to fully enable all doclint checks during the javac portion of the build. The "reference" doclint check is currently disabled in the build command for several modules. The problematic references are cross-module @see and @link tags. This PR changes those tags to use a to a new proposed syntax for cross-module references. Before this PR is pushed, the javadoc changes need to be made and I'll update the make files to enable the "reference" warning category. - PR: https://git.openjdk.java.net/jdk/pull/7189
Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build
On Mon, 24 Jan 2022 11:33:18 GMT, Pavel Rappo wrote: > > Use presumed syntax that will be introduced by JDK-8280488. > > Is that a wrong bug? If you are talking about module-prefix syntax for links, > then it was introduced in JDK 15; JDK-8164408: Add module support for @see, > @link and @linkplain javadoc tags. Ah; thanks Pavel for the additional context. Bug JDK-8280488 will allow (i.e. ignore) cross-module @see/@link references during javac compilation. So while the syntax in this PR is already valid per JDK-8164408, I cannot (yet) enable the "reference" doctlint check in the javac build due to the cross-module situation. I'll double-check the syntax in this PR generates the expected links in the result of the docs builds, give the bug a more descriptive title, and get these changes pushed. Enabling the reference warning can be done under another bug. - PR: https://git.openjdk.java.net/jdk/pull/7189
Re: RFR: JDK-8280492: Use cross-module syntax for cross-module links [v2]
> Use presumed syntax that will be introduced by JDK-8280488. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Update copyrigths. - Merge branch 'master' into JDK-8280492 - JDK-8280492: Address remaining doclint issues in JDK build - Changes: - all: https://git.openjdk.java.net/jdk/pull/7189/files - new: https://git.openjdk.java.net/jdk/pull/7189/files/b74e7d85..6f3bd429 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7189&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7189&range=00-01 Stats: 664 lines in 55 files changed: 433 ins; 128 del; 103 mod Patch: https://git.openjdk.java.net/jdk/pull/7189.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7189/head:pull/7189 PR: https://git.openjdk.java.net/jdk/pull/7189
Integrated: JDK-8280492: Use cross-module syntax for cross-module links
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. This pull request has now been integrated. Changeset: 8e82d002 Author: Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/8e82d0021c119b7793870811fad37d7659c1174d Stats: 72 lines in 17 files changed: 0 ins; 0 del; 72 mod 8280492: Use cross-module syntax for cross-module links Reviewed-by: iris, serb, lancea, dfuchs, aivanov - PR: https://git.openjdk.java.net/jdk/pull/7189
Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v13]
On Fri, 28 Jan 2022 16:58:55 GMT, Michael McMahon wrote: >> Hi, >> >> This change adds Channel Binding Token (CBT) support to HTTPS >> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, >> Kerberos) authentication scheme. When enabled, the implementation >> preemptively includes a CBT with authentication requests over Kerberos. The >> feature is enabled as follows: >> >> A system property "jdk.spnego.cbt" is defined which can have the values >> "never" (default), which means the feature is disabled, "always", which >> means the CBT is included for all https Negotiate authentications, or it can >> take the form "domain:a,b.c,*.d.com" which is a comma separated list of >> domains/hosts where the feature is enabled, and disabled everywhere else. In >> the given example, the CBT would be included in authentication requests for >> hosts "a", "b.c" and all hosts under the domain "d.com" and all of its >> sub-domains. >> >> A test will be added separately to the implementation. >> >> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842 >> >> Thanks, >> Michael > > Michael McMahon has updated the pull request incrementally with one > additional commit since the last revision: > > spec update from CSR Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7065
RFR: JDK-8282686: Add constructors taking a cause to SocketException
Please review this small API enhancement to add the usual constructors taking a cause to SocketException and then update uses of initiCause on creating SocketException to instead pass the cause via the constructor. Please also review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282688 - Commit messages: - JDK-8282686: Add constructors take a cause to SocketException Changes: https://git.openjdk.java.net/jdk/pull/7705/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7705&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282686 Stats: 48 lines in 6 files changed: 23 ins; 12 del; 13 mod Patch: https://git.openjdk.java.net/jdk/pull/7705.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7705/head:pull/7705 PR: https://git.openjdk.java.net/jdk/pull/7705
Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7268
Re: RFR: JDK-8282686: Add constructors taking a cause to SocketException [v2]
> Please review this small API enhancement to add the usual constructors taking > a cause to SocketException and then update uses of initiCause on creating > SocketException to instead pass the cause via the constructor. > > Please also review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282688 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Add regression test. - Merge branch 'master' into JDK-8282686 - JDK-8282686: Add constructors take a cause to SocketException - Changes: - all: https://git.openjdk.java.net/jdk/pull/7705/files - new: https://git.openjdk.java.net/jdk/pull/7705/files/e65f9ae5..978b379d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7705&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7705&range=00-01 Stats: 8268 lines in 175 files changed: 6072 ins; 1565 del; 631 mod Patch: https://git.openjdk.java.net/jdk/pull/7705.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7705/head:pull/7705 PR: https://git.openjdk.java.net/jdk/pull/7705
Re: RFR: JDK-8282686: Add constructors taking a cause to SocketException [v3]
> Please review this small API enhancement to add the usual constructors taking > a cause to SocketException and then update uses of initiCause on creating > SocketException to instead pass the cause via the constructor. > > Please also review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282688 Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Improve test. - Changes: - all: https://git.openjdk.java.net/jdk/pull/7705/files - new: https://git.openjdk.java.net/jdk/pull/7705/files/978b379d..da863692 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7705&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7705&range=01-02 Stats: 11 lines in 1 file changed: 8 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/7705.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7705/head:pull/7705 PR: https://git.openjdk.java.net/jdk/pull/7705
Integrated: JDK-8282686: Add constructors taking a cause to SocketException
On Fri, 4 Mar 2022 21:17:01 GMT, Joe Darcy wrote: > Please review this small API enhancement to add the usual constructors taking > a cause to SocketException and then update uses of initiCause on creating > SocketException to instead pass the cause via the constructor. > > Please also review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282688 This pull request has now been integrated. Changeset: 1faa5c80 Author:Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/1faa5c8092f8baec3ca08ed059653876ec46db46 Stats: 102 lines in 7 files changed: 77 ins; 12 del; 13 mod 8282686: Add constructors taking a cause to SocketException Reviewed-by: alanb, xuelei, lancea, dfuchs - PR: https://git.openjdk.java.net/jdk/pull/7705
Re: RFR: 8284567: Collapse identical catch branches in java.base
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov wrote: > Let's take advantage of Java 7 language feature - "Catching Multiple > Exception Types". > It simplifies code. Reduces duplication. > Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try' > statement Core libs changes look okay. I assume the docs build also works fine with the import statements removed. - Marked as reviewed by darcy (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8081
network tests
Greetings. Recently Mark Wielaard started an effort to run the regression tests on OpenJDK builds and publish the results (http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-May/001921.html). Certain tests in the nio and networking area assume Sun-internal hosts like javaweb are available; the shell test test/java/net/InetAddress/ptr/lookup.sh has a string for javaweb and test/java/nio/channels/TestUtil.java has the following constants used by other tests: // Test hosts used by the channels tests - change these when // executing in a different network. public static final String HOST = "javaweb.sfbay.sun.com"; public static final String REFUSING_HOST = "jano.sfbay.sun.com"; public static final String FAR_HOST = "theclub.ireland.sun.com"; public static final String UNRESOLVABLE_HOST = "blah-blah.blah-blah.blah"; Mark observed these three hosts are needed: With daytime and echo available. The only wrinkle is that some tests expect to be able to use quick timeouts from HOST, but to need long timeouts from FAR_HOST. I think we could provide something public for this. But I might have missed some tests that need other services. Do you have a full overview? (http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-May/001972.html) First, is this all the networking configuration information that is used in the regression tests? Second, it would be helpful is this host information could be configured without changing the sources of the test each time. I've spoken briefly to Jon about ways this kind of information can be passed into a jtreg run. Environment variables can be used, as can system properties. A system property could also be used to specify a file from which the information was read. With a bit of jtreg hacking, it is feasible portions of the jtharness interview procedure could be exposed to configure information that way too. -Joe
Re: network tests
Alan Bateman wrote: Joe Darcy wrote: Greetings. Recently Mark Wielaard started an effort to run the regression tests on OpenJDK builds and publish the results (http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-May/001921.html). Certain tests in the nio and networking area assume Sun-internal hosts like javaweb are available; the shell test test/java/net/InetAddress/ptr/lookup.sh has a string for javaweb and test/java/nio/channels/TestUtil.java has the following constants used by other tests: // Test hosts used by the channels tests - change these when // executing in a different network. public static final String HOST = "javaweb.sfbay.sun.com"; public static final String REFUSING_HOST = "jano.sfbay.sun.com"; public static final String FAR_HOST = "theclub.ireland.sun.com"; public static final String UNRESOLVABLE_HOST = "blah-blah.blah-blah.blah"; Mark observed these three hosts are needed: With daytime and echo available. The only wrinkle is that some tests expect to be able to use quick timeouts from HOST, but to need long timeouts from FAR_HOST. I think we could provide something public for this. But I might have missed some tests that need other services. Do you have a full overview? (http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-May/001972.html) First, is this all the networking configuration information that is used in the regression tests? For the tests in the java/nio and sun/nio tree then the dependencies are centralized in TestUtil.java. When we moved these tests from closed->open we did talk about moving this configuration into a properties/configuration file but figured there wasn't much difference between editing a config file vs. a source file. I think being able to pass in your own config file would be useful for this use case; it is awkward to have to edit the source to the tests to get them to pass :-) If -Dnetworking.test.config.file were defined, the test could use those values instead of the defaults... For the classic networking, the dependencies are scattered. I believe some of the tests weren't moved from closed->open for this reason. Some of the tests uses an embedded HTTP or FTP server but there are others that depend on DNS, proxy, etc. Michael or Jessie may have more to say on this. Could the classic networking tests be refactored a bit to be centralized like the nio tests? Would it be natural for classic networking and nio to get their host information from the same place? BTW: I briefly scanned the summary and most of the java/nio failures appear to be *HOST related. Now that folks are running these tests outside Sun it is time to own up to a few intermittent/timing related failures with 4 or 5 of these tests. I've been meaning to fix these test issues for a while but I haven't had the cycles. I'll dig up my notes on these. One other thing - I notice test/java/nio/channels/DatagramChannel/NotBound.java on the list - that test is failing because it is missing the public modifier. The test is bogus anyway so it might be best to just remove this test from jdk6 and open6. For jdk7/OpenJDK I have spec clarification in the works to fix the spec hole and as part of that work the test will be replaced (see 6621689). Yes, fixing the intermittent failures and removing the invalid test in OpenJDK 6 sounds good. Second, it would be helpful is this host information could be configured without changing the sources of the test each time. I've spoken briefly to Jon about ways this kind of information can be passed into a jtreg run. Environment variables can be used, as can system properties. A system property could also be used to specify a file from which the information was read. With a bit of jtreg hacking, it is feasible portions of the jtharness interview procedure could be exposed to configure information that way too. I would be concerned with a solution that requires environment variables or jtreg requiring configuration from somewhere other than the test suite. At least in Sun (sorry for being selfish), these tests are run by various teams on hundreds of machines. I don't think we'd want to require the javatest interview be run or have .jti files stored in various places with configuration information that will quickly go stale. If you mean that the configuration can be overridden via some input to jtreg that might be okay but would require the distributions and others to maintain that configuration. Anyway, I'm interested to hear the outcome of the discussion. Even if the Sun-internal settings remain baked in, I think an easy way to pass in a limited number of configuration settings is appropriate and shouldn't be too hard to accommodate in the test code. Presumably an interface like "openjtreg -Dmy.config.options=foo ..." wouldn't be too awkward to use. -Joe
hg: jdk7/tl/jdk: 6792545: Typo in java.util.Collection JavaDoc; ...
Changeset: 7f6969c09075 Author:darcy Date: 2009-01-14 16:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7f6969c09075 6792545: Typo in java.util.Collection JavaDoc 6655123: Incorrect ref to The Art of Computer Programming in doc for java.util.Random Summary: Fix a pair of typos. Reviewed-by: jjg ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/Random.java
hg: jdk7/tl/langtools: 6583626: Improve serialization support in javax.lang.model.type exception classes
Changeset: 18c433be7aa7 Author:darcy Date: 2009-01-16 14:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/18c433be7aa7 6583626: Improve serialization support in javax.lang.model.type exception classes Reviewed-by: jjg ! src/share/classes/javax/lang/model/type/MirroredTypeException.java ! src/share/classes/javax/lang/model/type/MirroredTypesException.java
hg: jdk7/tl/jdk: 6604864: Double.valueOf(String) does not specify behaviour for overflow and underflow
Changeset: cb641d17bbb3 Author:darcy Date: 2009-01-23 10:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cb641d17bbb3 6604864: Double.valueOf(String) does not specify behaviour for overflow and underflow Reviewed-by: emcmanus ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java
hg: jdk7/tl/jdk: 6601457: Move wrapper class tests from closed to open; ...
Changeset: f3ad2ee4600b Author:darcy Date: 2009-01-26 19:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f3ad2ee4600b 6601457: Move wrapper class tests from closed to open 6601458: Move java.math tests from closed to open 6740185: Move java/lang/annotations tests to open 6759433: Move Math and StrictMath regression tests from closed to open Summary: Move some more regression tests to the open Reviewed-by: jjg + test/java/lang/Boolean/Factory.java + test/java/lang/Boolean/GetBoolean.java + test/java/lang/Boolean/MakeBooleanComparable.java + test/java/lang/Boolean/ParseBoolean.java + test/java/lang/Byte/Decode.java + test/java/lang/Double/BitwiseConversion.java + test/java/lang/Double/Constants.java + test/java/lang/Double/Extrema.java + test/java/lang/Double/NaNInfinityParsing.java + test/java/lang/Double/ParseDouble.java + test/java/lang/Double/ParseHexFloatingPoint.java + test/java/lang/Double/ToHexString.java + test/java/lang/Float/BitwiseConversion.java + test/java/lang/Float/Constants.java + test/java/lang/Float/Extrema.java + test/java/lang/Float/NaNInfinityParsing.java + test/java/lang/Float/ParseFloat.java + test/java/lang/Integer/BitTwiddle.java + test/java/lang/Integer/Decode.java + test/java/lang/Integer/GetInteger.java + test/java/lang/Integer/ParsingTest.java + test/java/lang/Long/BitTwiddle.java + test/java/lang/Long/Decode.java + test/java/lang/Long/GetLong.java + test/java/lang/Long/ParsingTest.java + test/java/lang/Math/AbsPositiveZero.java + test/java/lang/Math/Atan2Tests.java + test/java/lang/Math/CubeRootTests.java + test/java/lang/Math/Expm1Tests.java + test/java/lang/Math/HyperbolicTests.java + test/java/lang/Math/HypotTests.java + test/java/lang/Math/IeeeRecommendedTests.java + test/java/lang/Math/Log10Tests.java + test/java/lang/Math/Log1pTests.java + test/java/lang/Math/MinMax.java + test/java/lang/Math/PowTests.java + test/java/lang/Math/Rint.java + test/java/lang/Math/TanTests.java + test/java/lang/Math/Tests.java + test/java/lang/Short/ByteSwap.java + test/java/lang/Short/Decode.java + test/java/lang/StrictMath/CubeRootTests.java + test/java/lang/StrictMath/Expm1Tests.java + test/java/lang/StrictMath/HyperbolicTests.java + test/java/lang/StrictMath/HypotTests.java + test/java/lang/StrictMath/Log10Tests.java + test/java/lang/StrictMath/Log1pTests.java + test/java/lang/StrictMath/Tests.java + test/java/lang/ToString.java + test/java/lang/annotation/AnnotationTypeMismatchException/FoundType.java + test/java/lang/annotation/Missing/A.java + test/java/lang/annotation/Missing/B.java + test/java/lang/annotation/Missing/C.java + test/java/lang/annotation/Missing/D.java + test/java/lang/annotation/Missing/Marker.java + test/java/lang/annotation/Missing/Missing.java + test/java/lang/annotation/Missing/MissingTest.java + test/java/lang/annotation/Missing/MissingWrapper.java + test/java/lang/annotation/PackageMain.java + test/java/lang/annotation/RecursiveAnnotation.java + test/java/lang/annotation/UnitTest.java + test/java/lang/annotation/loaderLeak/A.java + test/java/lang/annotation/loaderLeak/B.java + test/java/lang/annotation/loaderLeak/C.java + test/java/lang/annotation/loaderLeak/LoaderLeak.sh + test/java/lang/annotation/loaderLeak/Main.java + test/java/lang/annotation/package-info.java + test/java/math/BigDecimal/AddTests.java + test/java/math/BigDecimal/CompareToTests.java + test/java/math/BigDecimal/Constructor.java + test/java/math/BigDecimal/DivideTests.java + test/java/math/BigDecimal/FloatDoubleValueTests.java + test/java/math/BigDecimal/IntegralDivisionTests.java + test/java/math/BigDecimal/NegateTests.java + test/java/math/BigDecimal/PowTests.java + test/java/math/BigDecimal/RoundingTests.java + test/java/math/BigDecimal/ScaleByPowerOfTenTests.java + test/java/math/BigDecimal/SerializationTests.java + test/java/math/BigDecimal/StringConstructor.java + test/java/math/BigDecimal/StrippingZerosTest.java + test/java/math/BigDecimal/ToPlainStringTests.java + test/java/math/BigDecimal/ZeroScalingTests.java + test/java/math/BigInteger/BigIntegerTest.java + test/java/math/BigInteger/ModPow.java + test/java/math/BigInteger/ModPow65537.java + test/java/math/BigInteger/ModPowPowersof2.java + test/java/math/BigInteger/OperatorNpeTests.java + test/java/math/BigInteger/ProbablePrime.java + test/java/math/BigInteger/StringConstructor.java + test/java/math/BigInteger/UnicodeConstructor.java + test/java/math/RoundingMode/RoundingModeTests.java
hg: jdk7/tl/langtools: 6707027: langtools/test/tools/javac/processing/model/testgetallmember/Main.java fails
Changeset: edb8d7985cfd Author:darcy Date: 2009-01-27 17:50 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/edb8d7985cfd 6707027: langtools/test/tools/javac/processing/model/testgetallmember/Main.java fails Reviewed-by: jjg ! test/tools/javac/processing/model/testgetallmembers/Main.java
hg: jdk7/tl/jdk: 6704655: Test test/java/lang/reflect/Generics/Probe.java fails under OpenJDK
Changeset: c2d2185a79dd Author:darcy Date: 2009-01-28 10:30 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c2d2185a79dd 6704655: Test test/java/lang/reflect/Generics/Probe.java fails under OpenJDK Reviewed-by: ksrini ! test/java/lang/reflect/Generics/Probe.java
hg: jdk7/tl/jdk: 6719182: update legal notice in java/lang/instrument/package.html
Changeset: 1ebbc958f06a Author:darcy Date: 2009-01-28 12:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1ebbc958f06a 6719182: update legal notice in java/lang/instrument/package.html Reviewed-by: jjh ! src/share/classes/java/lang/instrument/package.html
hg: jdk7/tl/jdk: 6239194: Object.hashCode() should reference System.identityHashCode()
Changeset: 7241bd422542 Author:darcy Date: 2009-01-29 09:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7241bd422542 6239194: Object.hashCode() should reference System.identityHashCode() Reviewed-by: emcmanus ! src/share/classes/java/lang/Object.java
hg: jdk7/tl/jdk: 6327048: Enum javadoc could link to JLS; ...
Changeset: ff9ad99b63cc Author:darcy Date: 2009-01-29 13:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ff9ad99b63cc 6327048: Enum javadoc could link to JLS 6653154: Exception message for bad Enum.valueOf has spurious "class" Reviewed-by: emcmanus ! src/share/classes/java/lang/Enum.java ! src/share/classes/java/lang/annotation/Annotation.java + test/java/lang/Enum/ValueOf.java
hg: jdk7/tl/jdk: 6799343: (fmt) java.util.Formatter uses plainlink instead of linkplain
Changeset: 483e5c97d438 Author:darcy Date: 2009-01-30 12:40 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/483e5c97d438 6799343: (fmt) java.util.Formatter uses plainlink instead of linkplain Reviewed-by: alanb ! src/share/classes/java/util/Formatter.java
hg: jdk7/tl/jdk: 6799462: Minor typo (wrong word) in JavaDoc for InputStream.read(byte[] b) method
Changeset: 948c504d6ef7 Author:darcy Date: 2009-01-30 15:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/948c504d6ef7 6799462: Minor typo (wrong word) in JavaDoc for InputStream.read(byte[] b) method Reviewed-by: sherman, martin ! src/share/classes/java/io/InputStream.java
hg: jdk7/tl/jdk: 6548433: (enum spec) java.lang.Enum docs should explain about values() and valueOf(String)
Changeset: 050da121df16 Author:darcy Date: 2009-02-03 16:29 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/050da121df16 6548433: (enum spec) java.lang.Enum docs should explain about values() and valueOf(String) Reviewed-by: martin ! src/share/classes/java/lang/Enum.java
hg: jdk7/tl/langtools: 6794071: Provide exception superclass for UnknownFooExceptions
Changeset: 58fcba61a77d Author:darcy Date: 2009-02-06 12:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/58fcba61a77d 6794071: Provide exception superclass for UnknownFooExceptions Reviewed-by: jjg + src/share/classes/javax/lang/model/UnknownEntityException.java ! src/share/classes/javax/lang/model/element/UnknownAnnotationValueException.java ! src/share/classes/javax/lang/model/element/UnknownElementException.java ! src/share/classes/javax/lang/model/type/UnknownTypeException.java + test/tools/javac/processing/model/TestExceptions.java
hg: jdk7/tl/langtools: 6460529: Provide mixin interfaces for getQualifiedName and getTypeParameters
Changeset: dab918a1c907 Author:darcy Date: 2009-02-20 11:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/dab918a1c907 6460529: Provide mixin interfaces for getQualifiedName and getTypeParameters Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java ! src/share/classes/javax/lang/model/element/ExecutableElement.java ! src/share/classes/javax/lang/model/element/PackageElement.java + src/share/classes/javax/lang/model/element/Parameterizable.java + src/share/classes/javax/lang/model/element/QualifiedNameable.java ! src/share/classes/javax/lang/model/element/TypeElement.java
hg: jdk7/tl/langtools: 6501749: 6501749 Filer should state connection between created files and root elements
Changeset: 435d5d9bb87d Author:darcy Date: 2009-02-24 17:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/435d5d9bb87d 6501749: 6501749 Filer should state connection between created files and root elements Reviewed-by: jjg ! src/share/classes/javax/annotation/processing/Filer.java
hg: jdk7/tl/langtools: 6498938: Faulty comparison of TypeMirror objects in getElementsAnnotatedWith implementation
Changeset: 1fbc1cc6e260 Author:darcy Date: 2009-02-24 17:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/1fbc1cc6e260 6498938: Faulty comparison of TypeMirror objects in getElementsAnnotatedWith implementation Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java + test/tools/javac/processing/environment/round/Foo.java ! test/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java
hg: jdk7/tl/langtools: 6843761: Update langtools tests to remove unncessary -source and -target options
Changeset: 84061bd68019 Author:darcy Date: 2009-05-27 22:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/84061bd68019 6843761: Update langtools tests to remove unncessary -source and -target options Reviewed-by: jjg ! test/com/sun/javadoc/testIndex/TestIndex.java ! test/com/sun/javadoc/testInterface/TestInterface.java ! test/com/sun/javadoc/testNavagation/TestNavagation.java ! test/com/sun/javadoc/testTagInheritence/TestTagInheritence.java ! test/tools/javac/5005368.java ! test/tools/javac/Ambig3.java ! test/tools/javac/ArrayCast.java ! test/tools/javac/BadCovar.java ! test/tools/javac/ClassLiterals/InitializeOuter.java ! test/tools/javac/ClassLiterals/InitializeTarget.java ! test/tools/javac/ClassToTypeParm.java ! test/tools/javac/Closure1.java ! test/tools/javac/Closure2.java ! test/tools/javac/Closure3.java ! test/tools/javac/Closure4.java ! test/tools/javac/Closure5.java ! test/tools/javac/CompoundBox.java ! test/tools/javac/ConditionalArgTypes_1.java ! test/tools/javac/ConditionalArgTypes_2.java ! test/tools/javac/DefiniteAssignment/DUAssert.java ! test/tools/javac/EarlyAssert.java ! test/tools/javac/Enum1.java ! test/tools/javac/GoodCovar.java ! test/tools/javac/HexFloatLiterals.java ! test/tools/javac/HexThree.java ! test/tools/javac/InterfaceAssert.java ! test/tools/javac/InvalidIntfCast.java ! test/tools/javac/NewGeneric.java ! test/tools/javac/ObjectMethodRefFromInterface.java ! test/tools/javac/PrivateLocalConstructor.java ! test/tools/javac/RawCrash.java ! test/tools/javac/SynthName2.java ! test/tools/javac/T5090006/compiler.sh ! test/tools/javac/T5092545.java ! test/tools/javac/T5105890.java ! test/tools/javac/annotations/default/A.java ! test/tools/javac/annotations/neg/AnnComma.java ! test/tools/javac/annotations/neg/ArrayLit.java ! test/tools/javac/annotations/neg/Constant.java ! test/tools/javac/annotations/neg/Cycle1.java ! test/tools/javac/annotations/neg/Cycle2.java ! test/tools/javac/annotations/neg/Cycle3.java ! test/tools/javac/annotations/neg/Dep.java ! test/tools/javac/annotations/neg/Dup.java ! test/tools/javac/annotations/neg/DupTarget.java ! test/tools/javac/annotations/neg/MemberOver.java ! test/tools/javac/annotations/neg/ObjectMembers.java ! test/tools/javac/annotations/neg/OverrideNo.java ! test/tools/javac/annotations/neg/Package.java ! test/tools/javac/annotations/neg/Recovery.java ! test/tools/javac/annotations/neg/Recovery1.java ! test/tools/javac/annotations/neg/Scope.java ! test/tools/javac/annotations/neg/Syntax1.java ! test/tools/javac/annotations/neg/WrongTarget.java ! test/tools/javac/annotations/neg/WrongTarget2.java ! test/tools/javac/annotations/neg/WrongValue.java ! test/tools/javac/annotations/neg/Z1.java ! test/tools/javac/annotations/neg/Z10.java ! test/tools/javac/annotations/neg/Z11.java ! test/tools/javac/annotations/neg/Z12.java ! test/tools/javac/annotations/neg/Z13.java ! test/tools/javac/annotations/neg/Z14.java ! test/tools/javac/annotations/neg/Z15.java ! test/tools/javac/annotations/neg/Z16.java ! test/tools/javac/annotations/neg/Z2.java ! test/tools/javac/annotations/neg/Z3.java ! test/tools/javac/annotations/neg/Z4.java ! test/tools/javac/annotations/neg/Z5.java ! test/tools/javac/annotations/neg/Z8.java ! test/tools/javac/annotations/neg/Z9.java ! test/tools/javac/annotations/pos/AnnoteElideBraces.java ! test/tools/javac/annotations/pos/ClassA.java ! test/tools/javac/annotations/pos/Dep.java ! test/tools/javac/annotations/pos/Enum1.java ! test/tools/javac/annotations/pos/Local.java ! test/tools/javac/annotations/pos/Members.java ! test/tools/javac/annotations/pos/NType.java ! test/tools/javac/annotations/pos/OverrideCheck.java ! test/tools/javac/annotations/pos/OverrideOK.java ! test/tools/javac/annotations/pos/Parameter.java ! test/tools/javac/annotations/pos/Primitives.java ! test/tools/javac/annotations/pos/RightTarget.java ! test/tools/javac/annotations/pos/Z1.java ! test/tools/javac/annotations/pos/Z2.java ! test/tools/javac/annotations/pos/Z3.java ! test/tools/javac/annotations/pos/Z4.java ! test/tools/javac/annotations/pos/package-info.java ! test/tools/javac/assert/Attach.java ! test/tools/javac/assert/DU1.java ! test/tools/javac/assert/DU2.java ! test/tools/javac/assert/Position.java ! test/tools/javac/boxing/BoxedForeach.java ! test/tools/javac/boxing/Boxing1.java ! test/tools/javac/boxing/Boxing2.java ! test/tools/javac/boxing/Boxing4.java ! test/tools/javac/boxing/BoxingCaching.java ! test/tools/javac/capture/Capture1.java ! test/tools/javac/capture/Capture2.java ! test/tools/javac/capture/Capture3.java ! test/tools/javac/capture/Capture5.java ! test/tools/javac/cast/BoxedArray.java ! test/tools/javac/enum/AbstractEmptyEnum.java ! test/tools/javac/enum/AbstractEnum1.java ! test/tools/javac/enum/DA1.java ! test/tools/javac/enum/DA2.java ! test/tools/javac/enum/DA3.java ! test/tools/javac/enum/Def.java ! test/tools/javac/enum/Enum1.java ! test/tools/javac/enum/Enum2.java ! test/tools/javac/enum/Enum3.jav
hg: jdk7/tl/langtools: 6593082: MirroredTypeException constructor does not throw NPE when type is null
Changeset: ca063536e4a6 Author:darcy Date: 2009-06-26 12:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ca063536e4a6 6593082: MirroredTypeException constructor does not throw NPE when type is null Reviewed-by: jjg ! src/share/classes/javax/lang/model/type/MirroredTypeException.java + test/tools/javac/processing/model/type/MirroredTypeEx/NpeTest.java
hg: jdk7/tl/jdk: 6857803: Missing links to exceptions in javadoc for Class.getGeneric{Superclass, Interfaces}
Changeset: 0a294c066e7a
Author:darcy
Date: 2009-07-07 16:12 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0a294c066e7a
6857803: Missing links to exceptions in javadoc for
Class.getGeneric{Superclass, Interfaces}
Reviewed-by: chegar
! src/share/classes/java/lang/Class.java
hg: jdk7/tl/jdk: 6628737: Specification of wrapper class valueOf static factories should require caching
Changeset: ae60bb671e54 Author:darcy Date: 2009-07-09 12:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ae60bb671e54 6628737: Specification of wrapper class valueOf static factories should require caching Reviewed-by: mr ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java
hg: jdk7/tl/jdk: 6857789: (reflect) Create common superclass of reflective exceptions
Changeset: aaf0cb20646e Author:darcy Date: 2009-07-15 12:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aaf0cb20646e 6857789: (reflect) Create common superclass of reflective exceptions Reviewed-by: martin ! src/share/classes/java/lang/ClassNotFoundException.java ! src/share/classes/java/lang/IllegalAccessException.java ! src/share/classes/java/lang/InstantiationException.java ! src/share/classes/java/lang/NoSuchFieldException.java ! src/share/classes/java/lang/NoSuchMethodException.java + src/share/classes/java/lang/ReflectiveOperationException.java ! src/share/classes/java/lang/reflect/InvocationTargetException.java
hg: jdk7/tl/jdk: 6463998: Undocumented NullPointerExeption from Float.parseFloat and Double.parseDouble
Changeset: 2a1b1075f583 Author:darcy Date: 2009-07-15 14:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2a1b1075f583 6463998: Undocumented NullPointerExeption from Float.parseFloat and Double.parseDouble Reviewed-by: lancea, iris ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java
hg: jdk7/tl/langtools: 6381698: Warn of decommissioning of apt
Changeset: d043adadc8b6 Author:darcy Date: 2009-07-26 21:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d043adadc8b6 6381698: Warn of decommissioning of apt Reviewed-by: jjg ! make/build.properties ! src/share/classes/com/sun/mirror/apt/AnnotationProcessor.java ! src/share/classes/com/sun/mirror/apt/AnnotationProcessorEnvironment.java ! src/share/classes/com/sun/mirror/apt/AnnotationProcessorFactory.java ! src/share/classes/com/sun/mirror/apt/AnnotationProcessorListener.java ! src/share/classes/com/sun/mirror/apt/AnnotationProcessors.java ! src/share/classes/com/sun/mirror/apt/Filer.java ! src/share/classes/com/sun/mirror/apt/Messager.java ! src/share/classes/com/sun/mirror/apt/RoundCompleteEvent.java ! src/share/classes/com/sun/mirror/apt/RoundCompleteListener.java ! src/share/classes/com/sun/mirror/apt/RoundState.java + src/share/classes/com/sun/mirror/apt/package-info.java - src/share/classes/com/sun/mirror/apt/package.html ! src/share/classes/com/sun/mirror/declaration/AnnotationMirror.java ! src/share/classes/com/sun/mirror/declaration/AnnotationTypeDeclaration.java ! src/share/classes/com/sun/mirror/declaration/AnnotationTypeElementDeclaration.java ! src/share/classes/com/sun/mirror/declaration/AnnotationValue.java ! src/share/classes/com/sun/mirror/declaration/ClassDeclaration.java ! src/share/classes/com/sun/mirror/declaration/ConstructorDeclaration.java ! src/share/classes/com/sun/mirror/declaration/Declaration.java ! src/share/classes/com/sun/mirror/declaration/EnumConstantDeclaration.java ! src/share/classes/com/sun/mirror/declaration/EnumDeclaration.java ! src/share/classes/com/sun/mirror/declaration/ExecutableDeclaration.java ! src/share/classes/com/sun/mirror/declaration/FieldDeclaration.java ! src/share/classes/com/sun/mirror/declaration/InterfaceDeclaration.java ! src/share/classes/com/sun/mirror/declaration/MemberDeclaration.java ! src/share/classes/com/sun/mirror/declaration/MethodDeclaration.java ! src/share/classes/com/sun/mirror/declaration/Modifier.java ! src/share/classes/com/sun/mirror/declaration/PackageDeclaration.java ! src/share/classes/com/sun/mirror/declaration/ParameterDeclaration.java ! src/share/classes/com/sun/mirror/declaration/TypeDeclaration.java ! src/share/classes/com/sun/mirror/declaration/TypeParameterDeclaration.java + src/share/classes/com/sun/mirror/declaration/package-info.java - src/share/classes/com/sun/mirror/declaration/package.html ! src/share/classes/com/sun/mirror/type/AnnotationType.java ! src/share/classes/com/sun/mirror/type/ArrayType.java ! src/share/classes/com/sun/mirror/type/ClassType.java ! src/share/classes/com/sun/mirror/type/DeclaredType.java ! src/share/classes/com/sun/mirror/type/EnumType.java ! src/share/classes/com/sun/mirror/type/InterfaceType.java ! src/share/classes/com/sun/mirror/type/MirroredTypeException.java ! src/share/classes/com/sun/mirror/type/MirroredTypesException.java ! src/share/classes/com/sun/mirror/type/PrimitiveType.java ! src/share/classes/com/sun/mirror/type/ReferenceType.java ! src/share/classes/com/sun/mirror/type/TypeMirror.java ! src/share/classes/com/sun/mirror/type/TypeVariable.java ! src/share/classes/com/sun/mirror/type/VoidType.java ! src/share/classes/com/sun/mirror/type/WildcardType.java + src/share/classes/com/sun/mirror/type/package-info.java - src/share/classes/com/sun/mirror/type/package.html ! src/share/classes/com/sun/mirror/util/DeclarationFilter.java ! src/share/classes/com/sun/mirror/util/DeclarationScanner.java ! src/share/classes/com/sun/mirror/util/DeclarationVisitor.java ! src/share/classes/com/sun/mirror/util/DeclarationVisitors.java ! src/share/classes/com/sun/mirror/util/Declarations.java ! src/share/classes/com/sun/mirror/util/SimpleDeclarationVisitor.java ! src/share/classes/com/sun/mirror/util/SimpleTypeVisitor.java ! src/share/classes/com/sun/mirror/util/SourceOrderDeclScanner.java ! src/share/classes/com/sun/mirror/util/SourcePosition.java ! src/share/classes/com/sun/mirror/util/TypeVisitor.java ! src/share/classes/com/sun/mirror/util/Types.java + src/share/classes/com/sun/mirror/util/package-info.java - src/share/classes/com/sun/mirror/util/package.html ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/com/sun/tools/apt/comp/BootstrapAPF.java ! src/share/classes/com/sun/tools/apt/comp/PrintAP.java ! src/share/classes/com/sun/tools/apt/main/JavaCompiler.java ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/apt/mirror/AptEnv.java ! src/share/classes/com/sun/tools/apt/mirror/apt/AnnotationProcessorEnvironmentImpl.java ! src/share/classes/com/sun/tools/apt/mirror/apt/FilerImpl.java ! src/share/classes/com/sun/tools/apt/mirror/apt/MessagerImpl.java ! src/share/classes/com/sun/tools/apt/mirror/apt/RoundCompleteEventImpl.java ! src/share/classes/com/sun/tools/apt/mirror/apt/RoundStateImpl.java ! src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationMirrorImpl.java ! src/share/classes/com/
hg: jdk7/tl/langtools: 6871291: Please clarify javax.tools.JavaCompiler.getTask() "classes" parameter
Changeset: 2ce3597237f0 Author:darcy Date: 2009-08-19 17:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2ce3597237f0 6871291: Please clarify javax.tools.JavaCompiler.getTask() "classes" parameter Reviewed-by: jjg ! src/share/classes/javax/tools/JavaCompiler.java
hg: jdk7/tl/jdk: 6378701: (enum) Unclear purpose of EnumConstantNotPresentException
Changeset: 3992a43bb0a5 Author:darcy Date: 2009-08-21 11:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3992a43bb0a5 6378701: (enum) Unclear purpose of EnumConstantNotPresentException Reviewed-by: lancea, andrew, alanb ! src/share/classes/java/lang/EnumConstantNotPresentException.java ! src/share/classes/java/lang/TypeNotPresentException.java ! src/share/classes/java/lang/annotation/AnnotationFormatError.java ! src/share/classes/java/lang/annotation/AnnotationTypeMismatchException.java ! src/share/classes/java/lang/annotation/IncompleteAnnotationException.java ! src/share/classes/java/lang/reflect/AnnotatedElement.java
hg: jdk7/tl/langtools: 6872011: Update printing processor to support JSR 308
Changeset: 40aca381dcaf Author:darcy Date: 2009-08-25 16:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/40aca381dcaf 6872011: Update printing processor to support JSR 308 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java
hg: jdk7/tl/langtools: 6548708: Annotation processing should free service loader if there are no processors
Changeset: 25f15fdd168a Author:darcy Date: 2009-08-26 19:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/25f15fdd168a 6548708: Annotation processing should free service loader if there are no processors Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
hg: jdk7/tl/jdk: 6876628: @throw instead of @throws in two ParagraphView classes
Changeset: 25371bf31658 Author:darcy Date: 2009-08-27 11:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/25371bf31658 6876628: @throw instead of @throws in two ParagraphView classes Reviewed-by: peterz ! src/share/classes/javax/swing/text/ParagraphView.java ! src/share/classes/javax/swing/text/html/ParagraphView.java
hg: jdk7/tl/jdk: 6877122: Many javadoc warnings from java.awt.Window, other awt classes
Changeset: 4a5f2147f953 Author:darcy Date: 2009-08-28 11:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4a5f2147f953 6877122: Many javadoc warnings from java.awt.Window, other awt classes Reviewed-by: anthony ! src/share/classes/java/awt/Cursor.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/dnd/DragSourceContext.java
hg: jdk7/tl/jdk: 6261502: (reflect) Add the functionality to screen out the "inappropriate" modifier bits
Changeset: e0f79982edd2 Author:darcy Date: 2009-08-28 14:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e0f79982edd2 6261502: (reflect) Add the functionality to screen out the "inappropriate" modifier bits Reviewed-by: alanb ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Method.java ! src/share/classes/java/lang/reflect/Modifier.java
hg: jdk7/tl/jdk: 6873951: test/java/lang/reflect/Generics/Probe.java fails.
Changeset: c34f92a47245 Author:darcy Date: 2009-09-04 13:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c34f92a47245 6873951: test/java/lang/reflect/Generics/Probe.java fails. Reviewed-by: alanb ! test/java/lang/reflect/Generics/Probe.java
hg: jdk7/tl/langtools: 6884227: Clarify ordering requirements of javax.lang.model.TypeElement.getEnclosedElements
Changeset: 789ee1acf107 Author:darcy Date: 2009-09-21 21:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/789ee1acf107 6884227: Clarify ordering requirements of javax.lang.model.TypeElement.getEnclosedElements Reviewed-by: ahe ! src/share/classes/javax/lang/model/element/TypeElement.java
hg: jdk7/tl/jdk: 6468534: (reflect) Exception types cannot be parameterized, rephrase getGenericExceptionTypes.
Changeset: c715b68cdcaf Author:darcy Date: 2009-09-22 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c715b68cdcaf 6468534: (reflect) Exception types cannot be parameterized, rephrase getGenericExceptionTypes. Reviewed-by: alanb ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Method.java
hg: jdk7/tl/langtools: 6517779: javax.lang.model.util.Elements.getConstantExpression() doesn't throw any exception; ...
Changeset: e992e602788e Author:darcy Date: 2009-09-23 18:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e992e602788e 6517779: javax.lang.model.util.Elements.getConstantExpression() doesn't throw any exception 6517907: javax.lang.model.util.Elements.getConstantExpression() with negative byte value fails Summary: Fix various problems with Elements.getConstantExpression() Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/Constants.java ! src/share/classes/com/sun/tools/javac/util/Convert.java + test/tools/javac/processing/model/util/elements/Foo.java + test/tools/javac/processing/model/util/elements/TestGetConstantExpression.java
hg: jdk7/tl/langtools: 6337964: should ignore last comma in annotation array
Changeset: d0f541480556 Author:darcy Date: 2009-09-24 16:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d0f541480556 6337964: should ignore last comma in annotation array Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/annotations/pos/TrailingComma.java
hg: jdk7/tl/jdk: 5062288: (reflect) Core reflection uses raw types when it could be using wildcards
Changeset: 572791538be5 Author:darcy Date: 2009-10-06 13:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/572791538be5 5062288: (reflect) Core reflection uses raw types when it could be using wildcards Reviewed-by: alanb ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/reflect/AccessibleObject.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Method.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/java/lang/reflect/ReflectAccess.java ! src/share/classes/sun/reflect/LangReflectAccess.java ! src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java ! src/share/classes/sun/reflect/annotation/AnnotationParser.java ! src/share/classes/sun/reflect/annotation/AnnotationType.java
hg: jdk7/tl/jdk: 6480728: Byte.valueOf(byte) returns a cached value but Byte.valueOf(String); ...
Changeset: e7ad502130ba Author:darcy Date: 2009-10-07 14:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e7ad502130ba 6480728: Byte.valueOf(byte) returns a cached value but Byte.valueOf(String) 6655735: Integer.toString() and String.valueOf(int) contain slow delegations Reviewed-by: lancea ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java ! src/share/classes/java/lang/String.java
hg: jdk7/tl/jdk: 6797535: Add shared two argument static equals method to the platform
Changeset: 3b45b809d8ff Author:darcy Date: 2009-10-09 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3b45b809d8ff 6797535: Add shared two argument static equals method to the platform Reviewed-by: sherman ! make/java/java/FILES_java.gmk + src/share/classes/java/util/Objects.java + test/java/util/Objects/BasicObjectsTest.java
hg: jdk7/tl/jdk: 6648344: (reflect spec) State default of isAccessible for reflective objects
Changeset: 9d240dbadaa3 Author:darcy Date: 2009-10-13 14:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9d240dbadaa3 6648344: (reflect spec) State default of isAccessible for reflective objects Reviewed-by: alanb ! src/share/classes/java/lang/reflect/AccessibleObject.java + test/java/lang/reflect/DefaultAccessibility.java
hg: jdk7/tl/jdk: 6349921: (enum) Include links from java.lang.Enum to EnumSet and EnumMap
Changeset: 151baf5e19ca Author:darcy Date: 2009-10-13 17:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/151baf5e19ca 6349921: (enum) Include links from java.lang.Enum to EnumSet and EnumMap Reviewed-by: martin ! src/share/classes/java/lang/Enum.java
hg: jdk7/tl/langtools: 6558804: Specification for Elements.getDocComment(Element e) should be clarified
Changeset: b8936a7930fe Author:darcy Date: 2009-10-14 18:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b8936a7930fe 6558804: Specification for Elements.getDocComment(Element e) should be clarified Reviewed-by: jjg ! src/share/classes/javax/lang/model/util/Elements.java
hg: jdk7/tl/jdk: 4428022: System.out.println(0.001) outputs 0.0010
Changeset: f85aa3aedf41 Author:darcy Date: 2009-10-15 18:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f85aa3aedf41 4428022: System.out.println(0.001) outputs 0.0010 Reviewed-by: darcy Contributed-by: a...@redhat.com ! src/share/classes/sun/misc/FloatingDecimal.java + test/java/lang/Double/ToString.java
hg: jdk7/tl/jdk: 6889858: Add nonNull methods to java.util.Objects
Changeset: 1602e8848bde Author:darcy Date: 2009-10-19 16:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1602e8848bde 6889858: Add nonNull methods to java.util.Objects Reviewed-by: darcy Contributed-by: j...@google.com ! src/share/classes/java/util/Objects.java ! test/java/util/Objects/BasicObjectsTest.java
hg: jdk7/tl/jdk: 6371401: java.math.BigInteger.shift(Integer.MIN_VALUE) throws StackOverflowError
Changeset: 0dd3d16e8183 Author:darcy Date: 2009-10-20 09:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0dd3d16e8183 6371401: java.math.BigInteger.shift(Integer.MIN_VALUE) throws StackOverflowError Reviewed-by: alanb ! src/share/classes/java/math/BigInteger.java + test/java/math/BigInteger/ExtremeShiftingTests.java
hg: jdk7/tl/jdk: 6560935: BigInteger.modPow() throws ArithmeticException for negative exponent
Changeset: 98558a60c555 Author:darcy Date: 2009-10-21 09:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98558a60c555 6560935: BigInteger.modPow() throws ArithmeticException for negative exponent Reviewed-by: alanb ! src/share/classes/java/math/BigInteger.java
hg: jdk7/tl/jdk: 6891113: More methods for java.util.Objects: deepEquals, hash, toString with default
Changeset: 80102c165e09 Author:darcy Date: 2009-10-23 11:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/80102c165e09 6891113: More methods for java.util.Objects: deepEquals, hash, toString with default Reviewed-by: alanb, gafter ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/Objects.java ! test/java/util/Objects/BasicObjectsTest.java
hg: jdk7/tl/jdk: 6897550: BigInteger constructor should use local cached String length
Changeset: e740080fd1a4 Author:darcy Date: 2009-11-03 15:01 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e740080fd1a4 6897550: BigInteger constructor should use local cached String length Reviewed-by: andrew, chegar ! src/share/classes/java/math/BigInteger.java
