Re: Socket InputStream.available may return a positive value after shutdown
On 06/07/11 10:05, Jing LV wrote: Hello, Alan (or anyone else), do we have time to discuss these postponed defects? Or do you have a outlook for this? Thank you. Hi Jimmy - it may be that everyone is very busy with the Java 7 launch and, probably, collapsing in a heap after all their great work :-) Also it might be worth reposting a summary of the defects you want to discuss just to remind people. δΊ 2011-4-27 18:35, Alan Bateman ει: Jing LV wrote: Hello, Currently I don't see any patch available so I am trying to create one by myself. I see the problem occurs in AbstractPlainSocketImpl.available() and it seems it is design to return 0 when meed a closed socket - this may not be correct according to the spec, thus change it like this. Would someone review please? I don't think I understand your proposed change as the connection isn't reset in this case. Maybe you meant to change available to check shut_rd? In any case, I think we need to be cautious as it would change the behavior for the EOF case and so could cause problems for existing applications. There is also a concern for custom SocketImpl implementations that I mentioned previously. I think that whatever approach is decided on will also require adding clarification to the javadoc. So if it's okay with you, I think we should postpone this to 8. -Alan
Re: UrlEncodedQueryString (RFE 6306820):a painless addition?
On Sun, 2011-10-16 at 20:41 -0700, kennardconsulting wrote: > Hi guys, > > So I'm just back from JavaOne 2011 and I'm all fired up about Open JDK again > :) > > I thought it may be worth revisiting RFE 6306820? All the hard work for this > RFE has already been done. There is a solid implementation, approved by 5 > out of 6 CCC members, and in real-world use for over 4 years: > >http://java.net/projects/urlencodedquerystring > > Can I pique anyone's interests in getting this resolved? It seems an easy > win. > Hi - perhaps if you were to provide a patch of the proposed new class with updated copyright and package name etc then you might get a bite. > Regards, > > Richard. > >
Re: java.net.NetworkInterface.getNetworkInterfaces does not work properly on AIX with IPv6
On Mon, 2011-10-17 at 15:14 +0800, Jonathan Lu wrote: > Hi net-devs, > > I've got a problem on AIX operating system when IPv6 is enabled,which > can be easily reproduced by attached test case NetworkInterfaceTest.java. > On AIX paltform, the /proc file system behaves differently from Linux, > so we cannot just read required lines from /proc/net/if_inet6 but to > call ioctl to get needed information. A patch is available for OpenJDK8 > code base, see attachment patch.diff. > > Is anybody interested in this topic? > > I'm quite aware of the fact that so far there's no publicly available > building scripts for OpenJDK8 on AIX operating system, but before > everything settles down, is anybody willing to review the patch? any > ideas about how to integrate it? > > Best regards! > Hi Jonathan - can you add a copyright header to the testcase and see if you can make the testcase fit into a jtreg test format?
Re: java.net.NetworkInterface.getNetworkInterfaces does not work properly on AIX with IPv6
On Mon, 2011-10-17 at 15:14 +0800, Jonathan Lu wrote: > Hi net-devs, > > I've got a problem on AIX operating system when IPv6 is enabled,which > can be easily reproduced by attached test case NetworkInterfaceTest.java. > On AIX paltform, the /proc file system behaves differently from Linux, > so we cannot just read required lines from /proc/net/if_inet6 but to > call ioctl to get needed information. A patch is available for OpenJDK8 > code base, see attachment patch.diff. > > Is anybody interested in this topic? > > I'm quite aware of the fact that so far there's no publicly available > building scripts for OpenJDK8 on AIX operating system, but before > everything settles down, is anybody willing to review the patch? any > ideas about how to integrate it? > > Best regards! > Hi - another thought. If this patch is about dealing with the fact that there is no /proc/net on AIX isn't that true for Solaris as well? (my Solaris box doesn't have a /proc/net folder either) I wonder if we have patch here that should either be made to work for Solaris & AIX or is not required as there is Solaris code somewhere that does the same thing? I haven't looked into this in detail so take the comment for what it's worth. Steve
Re: java.net.NetworkInterface.getNetworkInterfaces does not work properly on AIX with IPv6
On Thu, 2011-10-20 at 13:24 +0800, Jonathan Lu wrote: > On 10/19/2011 06:03 PM, Steve Poole wrote: > > On Mon, 2011-10-17 at 15:14 +0800, Jonathan Lu wrote: > >> Hi net-devs, > >> > >> I've got a problem on AIX operating system when IPv6 is enabled,which > >> can be easily reproduced by attached test case NetworkInterfaceTest.java. > >> On AIX paltform, the /proc file system behaves differently from Linux, > >> so we cannot just read required lines from /proc/net/if_inet6 but to > >> call ioctl to get needed information. A patch is available for OpenJDK8 > >> code base, see attachment patch.diff. > >> > >> Is anybody interested in this topic? > >> > >> I'm quite aware of the fact that so far there's no publicly available > >> building scripts for OpenJDK8 on AIX operating system, but before > >> everything settles down, is anybody willing to review the patch? any > >> ideas about how to integrate it? > >> > >> Best regards! > >> > > Hi Jonathan - can you add a copyright header to the testcase and see if > > you can make the testcase fit into a jtreg test format? > > > > > > > Hi Steve, > Thanks for your suggestion. > I've updated the test case to fit into a jtreg format, see the > attachment NetworkInterfaceTest.java. Cool - at a quick glance it looks fine - except your're missing the IBM attribution comment. I'll send you the details. > > - Jonathan
