RFR: 8255675: Typo in java.net.HttpURLConnection
8255675: Typo in java.net.HttpURLConnection - Commit messages: - Merge pull request #1 from anupamdev20/JDK-8255675 - 8255675: Typo in java.net.HttpURLConnection Changes: https://git.openjdk.java.net/jdk/pull/1250/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1250&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8255675 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/1250.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1250/head:pull/1250 PR: https://git.openjdk.java.net/jdk/pull/1250
Re: RFR: 8255675: Typo in java.net.HttpURLConnection
On Tue, 17 Nov 2020 07:50:10 GMT, ANUPAM DEV wrote: > 8255675: Typo in java.net.HttpURLConnection Hello All, Could you please review this fix? Bug: https://bugs.openjdk.java.net/browse/JDK-8255675 Problem description: In the getResponseCode method, the following comment was unclear: "If we can't a status-line then re-throw any exception" Fix: Comment is changed to "If we can't find a status-line then re-throw any exception" Apart from that there was another small typo which I fixed: "We're got the response code already" is changed to "We've got the response code already" - PR: https://git.openjdk.java.net/jdk/pull/1250
Integrated: 8255675: Typo in java.net.HttpURLConnection
On Tue, 17 Nov 2020 07:50:10 GMT, ANUPAM DEV wrote: > 8255675: Typo in java.net.HttpURLConnection This pull request has now been integrated. Changeset: 895cc4f0 Author: ANUPAM DEV <73814169+anupamde...@users.noreply.github.com> Committer: Julia Boes URL: https://git.openjdk.java.net/jdk/commit/895cc4f0 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8255675: Typo in java.net.HttpURLConnection Reviewed-by: chegar - PR: https://git.openjdk.java.net/jdk/pull/1250
RFR: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList
Updated sun.awt.util.IdentityArrayList and sun.awt.util.IdentityLinkedList - Commit messages: - Javadoc incorrect for IdentityArrayList, IdentityLinkedList - Merge pull request #1 from anupamdev20/JDK-8255675 - 8255675: Typo in java.net.HttpURLConnection Changes: https://git.openjdk.java.net/jdk/pull/6691/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6691&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8247973 Stats: 19 lines in 3 files changed: 8 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/6691.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6691/head:pull/6691 PR: https://git.openjdk.java.net/jdk/pull/6691
Withdrawn: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList
On Fri, 3 Dec 2021 06:33:45 GMT, ANUPAM DEV wrote: > The following methods were having improper improper as they mentioned > 'equals()' while comparing two objects. The comments have been changed to > reflect the comparison of two objects using == operator. > > sun.awt.util.IdentityLinkedList#contains > sun.awt.util.IdentityArrayList#contains > sun.awt.util.IdentityArrayList#indexOf > sun.awt.util.IdentityArrayList#lastIndexOf > sun.awt.util.IdentityArrayList#remove(java.lang.Object) > > Please review the changes. > Thanks! This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/6691
RFR: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList
The documentation for following methods used equals() for object equality: sun.awt.util.IdentityLinkedList#contains sun.awt.util.IdentityArrayList#contains sun.awt.util.IdentityArrayList#indexOf sun.awt.util.IdentityArrayList#lastIndexOf sun.awt.util.IdentityArrayList#remove(java.lang.Object) I have updated the comments to use "==" operator for object equality. Kindly review the changes for the same. - Commit messages: - 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList - Merge pull request #1 from anupamdev20/JDK-8255675 - 8255675: Typo in java.net.HttpURLConnection Changes: https://git.openjdk.java.net/jdk/pull/6694/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6694&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8247973 Stats: 19 lines in 3 files changed: 8 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/6694.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6694/head:pull/6694 PR: https://git.openjdk.java.net/jdk/pull/6694
Withdrawn: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList
On Fri, 3 Dec 2021 07:30:43 GMT, ANUPAM DEV wrote: > The documentation for following methods used equals() for object equality: > > sun.awt.util.IdentityLinkedList#contains > sun.awt.util.IdentityArrayList#contains > sun.awt.util.IdentityArrayList#indexOf > sun.awt.util.IdentityArrayList#lastIndexOf > sun.awt.util.IdentityArrayList#remove(java.lang.Object) > > I have updated the comments to use "==" operator for object equality. Kindly > review the changes for the same. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/6694
