Re: RFR: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources [v2]

2022-05-07 Thread Daniel Fuchs 
> Hi,
> 
> Please find here a simple test fix that re-architecture ShortResponseBody for 
> better resource usage.
> The test is split to test GET and POST separately and avoids testing GET 
> twice.

Daniel Fuchs has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains two additional commits since the 
last revision:

 - Merge branch 'master' into ShortResponseBody
 - 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use 
less resources

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8569/files
  - new: https://git.openjdk.java.net/jdk/pull/8569/files/b212c007..11959ee8

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8569&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8569&range=00-01

  Stats: 109734 lines in 1343 files changed: 97735 ins; 5210 del; 6789 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8569.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8569/head:pull/8569

PR: https://git.openjdk.java.net/jdk/pull/8569

Re: RFR: 8286194: ExecutorShutdown test fails intermittently [v3]

2022-05-07 Thread Daniel Fuchs 
> Hi, please find here a patch that solves a rare intermittent test failure 
> observed in the test `java/net/httpclient/ExecutorShutdown.java`
> 
> A race condition coupled with some too eager synchronization was causing a 
> deadlock between an Http2Connection close, a thread trying to shutdown the 
> HttpClient due to a RejectedTaskException, and the SelectorManager thread 
> trying to exit.
> 
> The fix comprises several cleanup - in particular:
> 
> - `Http2Connection`: no need to try to send a `GOAWAY` frame if the 
> underlying TCP connection is already closed
> - `SSLFlowDelegate`/`SubscriberWrapper`: no need to trigger code that will 
> request more data from upstream if the sequential scheduler that is supposed 
> to handle that data once it arrives is already closed
> - `Http1Exchange`/`Http1Request`: proper cancellation of subscription if an 
> exception is raised before `onSubscribe()` has been called
> - `HttpClientImpl`: avoid calling callbacks from within synchronized blocks 
> when not necessary
> - `ReferenceTracker`: better thread dumps in case where the selector is still 
> alive at the end of the test (remove the limit that limited the stack traces 
> to 8 element max by no longer relying on `ThreadInfo::toString`)

Daniel Fuchs has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains three additional commits since 
the last revision:

 - Merge branch 'master' into ExecutorShutdown-intermittent-8286194
 - Added a comment to ReferenceTracker.java as suggested in the review
 - 8286194: ExecutorShutdown test fails intermittently

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8562/files
  - new: https://git.openjdk.java.net/jdk/pull/8562/files/ce8ad93d..12bf40b0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8562&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8562&range=01-02

  Stats: 102369 lines in 1228 files changed: 93484 ins; 3845 del; 5040 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8562.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8562/head:pull/8562

PR: https://git.openjdk.java.net/jdk/pull/8562

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults

2022-05-07 Thread Phil Race 
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers  wrote:

> JDK-6725221 Standardize obtaining boolean properties with defaults

I did wonder why it has security-libs as the sub-category and if the intent was 
not what we see here.

-

PR: https://git.openjdk.java.net/jdk/pull/8559

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults

2022-05-07 Thread Alan Bateman 
On Sun, 8 May 2022 02:22:08 GMT, Phil Race  wrote:

> I did wonder why it has security-libs as the sub-category and if the intent 
> was not what we see here.

I suspect the JBS issue was initially created to to look at the usages of 
getProperty in the security code but it has been extended. The issue is that it 
changes the meaning of the empty value case in at least two places so each one 
will require careful attention.

-

PR: https://git.openjdk.java.net/jdk/pull/8559