Re: RFR: 8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders

2021-08-16 Thread Michael McMahon 
On Thu, 12 Aug 2021 13:44:23 GMT, Julia Boes  wrote:

> This is a doc-only fix that improves the wording of the API doc of 
> `getRequestHeaders()`. The other changes are trivial cleanup.

Marked as reviewed by michaelm (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5100

Re: RFR: 8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders

2021-08-16 Thread Chris Hegarty 
On Thu, 12 Aug 2021 13:44:23 GMT, Julia Boes  wrote:

> This is a doc-only fix that improves the wording of the API doc of 
> `getRequestHeaders()`. The other changes are trivial cleanup.

Marked as reviewed by chegar (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5100

Re: RFR: 8253178: Replace LinkedList Impl in net.http.FilterFactory [v3]

2021-08-16 Thread Sergei Ustimenko 
On Mon, 19 Jul 2021 10:24:27 GMT, Sergei Ustimenko 
 wrote:

>> This patch replaces a LinkedList data structure used in the 
>> net.http.FilterFactory class with an ArrayList. This issue relates to 
>> [JDK-8246048: Replace LinkedList with ArrayLists in 
>> java.net.](https://bugs.openjdk.java.net/browse/JDK-8246048).
>> 
>> The list created once per HttpClient and filled with upfront known values (3 
>> of them in the jdk.internal.net.http.HttpClientImpl#initFilters: 
>> AuthenticationFilter.class, RedirectFilter.class and depending on the 
>> presence of a cookieHandler - a CookieFilter.class).
>
> Sergei Ustimenko has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains two commits:
> 
>  - 8253178: Trim the size for list with headers
>  - 8253178: Replace LinkedList Impl in net.http.FilterFactory

Hi, it would be great if anyone would have time to take a quick look on this 
pull request. I hope this change is still relevant and I am happy to have any 
feedback from you. Thanks!

-

PR: https://git.openjdk.java.net/jdk/pull/4721