Re: RFR: 8255584: `HttpPrincipal::getName` returns incorrect name [v2]
On Fri, 30 Oct 2020 15:59:57 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8255584: fixed ordering of realm and username in name > > Marked as reviewed by dfuchs (Reviewer). > /csr needed Link to CSR: https://bugs.openjdk.java.net/browse/JDK-8255692 - PR: https://git.openjdk.java.net/jdk/pull/958
Re: HttpClient InputStream general advice?
Hi Joshua, On 31/10/2020 00:15, Joshua Anderson wrote: Is this checking and reviewing necessary? Should I have written a background task that reviews all InputStream’s created by the HttpClient and calls .close() if the user forgets. The intent here is to free up these resources. Without tracking and reviewing the InputsStream objects created by the HttpClient, If the user forgets to call .close() on the InputStream objects they request, it eventually affects the stability of the core library due to the fact it cannot get new Http connections to perform other work. What’s your take? With the current implementation, an application should drain or close the InputStream if it wants to avoid leaks. This is clearly stated in the API documentation: https://docs.oracle.com/en/java/javase/15/docs/api/java.net.http/java/net/http/HttpResponse.BodySubscribers.html#ofInputStream() Hope this helps, -- daniel
RFR: 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders`
Hi, Could someone please review my fix for JDK-8253005: 'Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ? The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is unspecified in its javadoc. This fix adds an `@throws IOException` to its specification and a description of the conditions under which the exception is thrown. Kind regards, Patrick - Commit messages: - Merge remote-tracking branch 'origin/master' into JDK-8253005 - Merge remote-tracking branch 'origin/master' into JDK-8253005 - 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders` Changes: https://git.openjdk.java.net/jdk/pull/1014/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1014&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253005 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/1014.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1014/head:pull/1014 PR: https://git.openjdk.java.net/jdk/pull/1014
Re: RFR: 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders`
On Mon, 2 Nov 2020 17:14:28 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my fix for JDK-8253005: 'Add `@throws > IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ? > > The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is > unspecified in its javadoc. This fix adds an `@throws IOException` to its > specification and a description of the conditions under which the exception > is thrown. > > Kind regards, > Patrick Marked as reviewed by dfuchs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1014
Re: RFR: 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders`
On Mon, 2 Nov 2020 17:14:28 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my fix for JDK-8253005: 'Add `@throws > IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ? > > The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is > unspecified in its javadoc. This fix adds an `@throws IOException` to its > specification and a description of the conditions under which the exception > is thrown. > > Kind regards, > Patrick Marked as reviewed by chegar (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1014
Re: RFR: 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders`
On Mon, 2 Nov 2020 17:46:27 GMT, Chris Hegarty wrote: >> Hi, >> >> Could someone please review my fix for JDK-8253005: 'Add `@throws >> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ? >> >> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is >> unspecified in its javadoc. This fix adds an `@throws IOException` to its >> specification and a description of the conditions under which the exception >> is thrown. >> >> Kind regards, >> Patrick > > Marked as reviewed by chegar (Reviewer). > /csr needed CSR can be viewed here: https://bugs.openjdk.java.net/browse/JDK-8255778 - PR: https://git.openjdk.java.net/jdk/pull/1014
