Re: RFR: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator [v3]
> Hi, > > Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean > up in Authenticator and BasicAuthenicator' > ? > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.Authenticator` > `com.sun.net.httpserver.Authenticator.Result` > `com.sun.net.httpserver.Authenticator.Failure` > `com.sun.net.httpserver.Authenticator.Success` > `com.sun.net.httpserver.Authenticator.Retry` > > `com.sun.net.httpserver.BasicAuthenticator` > > This issue is a sub-task of > [JDK-8252822](https://bugs.openjdk.java.net/browse/JDK-8252822) > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - 8253053: fixed typo - 8253053: fixed typos; added tags - 8253053: Javadoc clean up in Authenticator and BasicAuthenicator - Changes: - all: https://git.openjdk.java.net/jdk/pull/301/files - new: https://git.openjdk.java.net/jdk/pull/301/files/604ea45c..5d900461 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=301&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=301&range=01-02 Stats: 25269 lines in 520 files changed: 2746 ins; 21422 del; 1101 mod Patch: https://git.openjdk.java.net/jdk/pull/301.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/301/head:pull/301 PR: https://git.openjdk.java.net/jdk/pull/301
Re: RFR: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator [v2]
On Wed, 23 Sep 2020 09:10:09 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8253053: fixed typos; added tags > > src/jdk.httpserver/share/classes/com/sun/net/httpserver/BasicAuthenticator.java > line 136: > >> 134: * Called for each incoming request to verify the >> 135: * given name and password in the context of this >> 136: * Authenticator's realm. Any caching of credentials > > Maybe remove the uppercase in "this Authenticator's realm" Change made in https://github.com/openjdk/jdk/pull/301/commits/5d9004612a60da62af3b30502ef2a1d8dfce2826 - PR: https://git.openjdk.java.net/jdk/pull/301
Re: RFR: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator [v3]
On Fri, 25 Sep 2020 17:32:41 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean >> up in Authenticator and BasicAuthenicator' >> ? >> This fix is set of formatting changes intended to clean up the javadoc of >> the following classes : >> >> `com.sun.net.httpserver.Authenticator` >> `com.sun.net.httpserver.Authenticator.Result` >> `com.sun.net.httpserver.Authenticator.Failure` >> `com.sun.net.httpserver.Authenticator.Success` >> `com.sun.net.httpserver.Authenticator.Retry` >> >> `com.sun.net.httpserver.BasicAuthenticator` >> >> This issue is a sub-task of >> [JDK-8252822](https://bugs.openjdk.java.net/browse/JDK-8252822) >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request with a new target base due to > a merge or a rebase. The pull request now > contains three commits: > - 8253053: fixed typo > - 8253053: fixed typos; added tags > - 8253053: Javadoc clean up in Authenticator and BasicAuthenicator Looks good Patrick! - Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/301
Re: RFR: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator [v3]
On Fri, 25 Sep 2020 17:32:41 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253053 - 'Javadoc clean >> up in Authenticator and BasicAuthenicator' >> ? >> This fix is set of formatting changes intended to clean up the javadoc of >> the following classes : >> >> `com.sun.net.httpserver.Authenticator` >> `com.sun.net.httpserver.Authenticator.Result` >> `com.sun.net.httpserver.Authenticator.Failure` >> `com.sun.net.httpserver.Authenticator.Success` >> `com.sun.net.httpserver.Authenticator.Retry` >> >> `com.sun.net.httpserver.BasicAuthenticator` >> >> This issue is a sub-task of >> [JDK-8252822](https://bugs.openjdk.java.net/browse/JDK-8252822) >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request with a new target base due to > a merge or a rebase. The incremental > webrev excludes the unrelated changes brought in by the merge/rebase. The > pull request contains three additional > commits since the last revision: > - 8253053: fixed typo > - 8253053: fixed typos; added tags > - 8253053: Javadoc clean up in Authenticator and BasicAuthenicator fyi, the trailing can be omitted. It is not required and the source is more readable without it. - Marked as reviewed by rriggs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/301
