RFR: JDK-8241138: http.nonProxyHosts=* causes StringIndexOutOfBoundsException in DefaultProxySelector
Can I please get a review and a sponsor for a patch which fixes the issue reported in JDK-8241138[1]? The patch is hosted as a webrev at [2]. The change in the patch now adds an explicit equals check for "*" before checking it for various other possible patterns. The patch also updates an existing testcase to include test for this specific scenario. [1] https://bugs.openjdk.java.net/browse/JDK-8241138 [2] https://cr.openjdk.java.net/~jpai/webrev/8241138/1/webrev/ -Jaikiran
Re: RFR: JDK-8241138: http.nonProxyHosts=* causes StringIndexOutOfBoundsException in DefaultProxySelector
Hi Jaikiran, This looks reasonable to me. I will happily sponsor it - unless there are other takers. best regards, -- daniel On 18/03/2020 11:18, Jaikiran Pai wrote: Can I please get a review and a sponsor for a patch which fixes the issue reported in JDK-8241138[1]? The patch is hosted as a webrev at [2]. The change in the patch now adds an explicit equals check for "*" before checking it for various other possible patterns. The patch also updates an existing testcase to include test for this specific scenario. [1] https://bugs.openjdk.java.net/browse/JDK-8241138 [2] https://cr.openjdk.java.net/~jpai/webrev/8241138/1/webrev/ -Jaikiran
Re: RFR: JDK-8241138: http.nonProxyHosts=* causes StringIndexOutOfBoundsException in DefaultProxySelector
> On 18 Mar 2020, at 11:18, Jaikiran Pai wrote: > ... > > [2] https://cr.openjdk.java.net/~jpai/webrev/8241138/1/webrev/ LGTM. -Chris.
Re: RFR: JDK-8241138: http.nonProxyHosts=* causes StringIndexOutOfBoundsException in DefaultProxySelector
Thank you Chris and Daniel for the reviews and the sponsoring. -Jaikiran On 18/03/20 5:33 pm, Daniel Fuchs wrote: > Hi Jaikiran, > > This looks reasonable to me. > I will happily sponsor it - unless there are other takers. > > best regards, > > -- daniel > > On 18/03/2020 11:18, Jaikiran Pai wrote: >> Can I please get a review and a sponsor for a patch which fixes the >> issue reported in JDK-8241138[1]? >> >> The patch is hosted as a webrev at [2]. The change in the patch now adds >> an explicit equals check for "*" before checking it for various other >> possible patterns. The patch also updates an existing testcase to >> include test for this specific scenario. >> >> >> [1] https://bugs.openjdk.java.net/browse/JDK-8241138 >> >> [2] https://cr.openjdk.java.net/~jpai/webrev/8241138/1/webrev/ >> >> -Jaikiran >> >
