RE: RFR[15] JDK-8183369 : RFC unconformity of HttpURLConnection with proxy
Hi, Please do review the below webrev. Thanks, Ravi From: Ravi Reddy Sent: Wednesday, February 5, 2020 6:13 PM To: net-dev@openjdk.java.net Subject: RFR[15] JDK-8183369 : RFC unconformity of HttpURLConnection with proxy Hello All, Could you please review this patch. This patch fixes the RFC unconformity of HttpURLConnection with proxy issue. 1.Change in HttpURLConnection.java is to make sure we do retry with proxy as mentioned in RFC 2.Change is test case HttpURLConWithProxy.java is to make sure we don't throw an error "Can't use direct connection" even when the connection is made through proxy. Webrev: http://cr.openjdk.java.net/~coffeys/webrev.8183369/index.html Issue: https://bugs.openjdk.java.net/browse/JDK-8183369 Thanks, Ravi
Re: RFR: JDK-8238386: (sctp) jdk.sctp/unix/native/libsctp/SctpNet.c "multiple definition" link errors with GCC10
> On 7 Feb 2020, at 14:20, Chris Hegarty wrote: > > >> On 7 Feb 2020, at 14:08, Patrick Zhang OS >> wrote: >> >> Agree, I was wondering where to place them, SctpNet.c or SctpChannelImpl.c. >> Here is the update: http://cr.openjdk.java.net/~qpzhang/8238386/webrev.02/ >> (smoke tested the build only) >> And, thanks for your double-check with the modified Lib-jdk.sctp.gmk. :) > > > I will run this through our internal build and test system, then report back > here. All clear. Pushed: https://hg.openjdk.java.net/jdk/sandbox/rev/8e6fa89397ca -Chris.
