Re: RFR: 8225499: InetSocketAddress::toString not friendly to IPv6 literal addresses
Hi, One test case had failed with preferIPv6Addresses=true due to an expected return value that was set incorrectly. This is fixed in the webrev below. Updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8225499/webrev.02/ Regards, Julia On 16/10/2019 11:25, Daniel Fuchs wrote: Looks good! best regards, -- daniel On 16/10/2019 10:38, Julia Boes wrote: Hi Daniel, Thanks for reviewing the change. I added a test case as per your suggestion. Updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8225499/webrev.01/index.html Regards, Julia
RFR: 8231632: HttpURLConnection::usingProxy could specify that it may lazily evaluate the fact
Hi, This fix involves HttpURLConnection::usingProxy. Previously, the method would return true only once the connection was established (once the underlying socket was connected) and would switch back to false when as the input stream was fully read. The new implementation checks whether an explicit proxy is set and if not, it invokes the ProxySelector to determine if a proxy is used. This widens the window in which the method returns a meaningful value. This is a best-effort as it might not always be able to determine if a proxy is actually used before the connection is established, as the ProxySelector might return different results when connect is called. An apinote is added to clarify the behaviour. Bug: https://bugs.openjdk.java.net/browse/JDK-8231632 Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8231632/webrev.00/index.html I'll create a CSR for this once I gathered some feedback on this solution. The fix was tested with JCK java_net and tier 1 - 3. Regards, Julia
Re: RFR: 8225499: InetSocketAddress::toString not friendly to IPv6 literal addresses
Looks good to me Julia! best regards, -- daniel On 17/10/2019 10:00, Julia Boes wrote: Hi, One test case had failed with preferIPv6Addresses=true due to an expected return value that was set incorrectly. This is fixed in the webrev below. Updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8225499/webrev.02/ Regards, Julia
