Re: [teststabilization] RFR: 8225430: Replace wildcard address with loopback or local host in tests - part 14

2019-08-08 Thread Chris Hegarty
Aleksei,

> On 7 Aug 2019, at 19:46, Aleks Efimov  wrote:
> 
> Hi Daniel,
> HandleContentTypeWithAttrs correction - removed bind and used three-args 
> constructor instead - looks much nicer.
> The webrev location is same: http://cr.openjdk.java.net/~aefimov/8225430/01


LGTM.

-Chris.

Re: [teststabilization] RFR: 8225430: Replace wildcard address with loopback or local host in tests - part 14

2019-08-08 Thread Daniel Fuchs

Thanks Aleksei!

Looks good.

-- daniel

On 07/08/2019 19:46, Aleks Efimov wrote:

Hi Daniel,
HandleContentTypeWithAttrs correction - removed bind and used three-args 
constructor instead - looks much nicer.

The webrev location is same: http://cr.openjdk.java.net/~aefimov/8225430/01




Re: [teststabilization] RFR: 8225430: Replace wildcard address with loopback or local host in tests - part 14

2019-08-08 Thread Aleks Efimov

Daniel, Chris,

Thanks for your reviews!

With Best Regards,
Aleksei

On 08/08/2019 11:59, Daniel Fuchs wrote:

Thanks Aleksei!

Looks good.

-- daniel

On 07/08/2019 19:46, Aleks Efimov wrote:

Hi Daniel,
HandleContentTypeWithAttrs correction - removed bind and used 
three-args constructor instead - looks much nicer.
The webrev location is same: 
http://cr.openjdk.java.net/~aefimov/8225430/01