RE: [RFR] 8194231: java/net/DatagramSocket/ReuseAddressTest.java failed with java.net.BindException: Address already in use: Cannot bind

2019-06-03 Thread Zeller, Arno
Hi Chris,

thanks for testing and review.

Regards,
Arno

-Original Message-
From: Chris Hegarty  
Sent: Freitag, 31. Mai 2019 16:06
To: Zeller, Arno 
Cc: net-dev@openjdk.java.net
Subject: Re: [RFR] 8194231: java/net/DatagramSocket/ReuseAddressTest.java 
failed with java.net.BindException: Address already in use: Cannot bind


> On 28 May 2019, at 16:20, Chris Hegarty  wrote:
> 
> ..
> 
> I would like to run it through our internal build and test infra, after which
> I’ll post the results here.

All clear ( this test passes successfully in our build and test environment ).

-Chris.


RE: [RFR] 8194231: java/net/DatagramSocket/ReuseAddressTest.java failed with java.net.BindException: Address already in use: Cannot bind

2019-06-03 Thread Zeller, Arno
Hi Christoph,

Thanks for review and pushing.

Regards,
Arno

-Original Message-
From: Langer, Christoph 
Sent: Freitag, 31. Mai 2019 16:56
To: Chris Hegarty 
Cc: net-dev@openjdk.java.net; Zeller, Arno 
Subject: RE: [RFR] 8194231: java/net/DatagramSocket/ReuseAddressTest.java 
failed with java.net.BindException: Address already in use: Cannot bind

Thanks, Chris. I pushed it then on behalf of Arno.

> -Original Message-
> From: net-dev  On Behalf Of Chris
> Hegarty
> Sent: Freitag, 31. Mai 2019 16:06
> To: Zeller, Arno 
> Cc: net-dev@openjdk.java.net
> Subject: Re: [RFR] 8194231:
> java/net/DatagramSocket/ReuseAddressTest.java failed with
> java.net.BindException: Address already in use: Cannot bind
> 
> 
> > On 28 May 2019, at 16:20, Chris Hegarty 
> wrote:
> >
> > ..
> >
> > I would like to run it through our internal build and test infra, after 
> > which
> > I’ll post the results here.
> 
> All clear ( this test passes successfully in our build and test environment ).
> 
> -Chris.


Re: [RFR] 8224645: Test java/nio/channels/DatagramChannel/BasicMulticastTests.java fails with NoSuchElementException

2019-06-03 Thread Arthur Eubanks
Ping on the updated webrev.

On Wed, May 29, 2019 at 1:08 PM Arthur Eubanks  wrote:

> Moved NetworkConfiguration.printSystemConfiguration() to the beginning,
>> removed counting and printing the number of interfaces/throwing
>> SkippedException.
>> new webrev: http://cr.openjdk.java.net/~aeubanks/8224645/webrev.02/
>>
>> This looks okay to me, the only thing is that the NetworkConfiguration is
>> sent to System.err whereas the test proper sends its output to System.out.
>> Can you check the .jtr file to see how it looks? I suspect it may be easier
>> to read if you send the network configuration to System.out.
>>
>> -Alan
>>
> I don't think it's a big difference either way, but changed it to
> System.out. Also added some extra info to the "Exception Tests" log to show
> the addresses it's testing. Now it looks like:
>
> --System.out:(33/801)--
> *** all system network interface configuration ***
> Display name: eth0
> Name: eth0
> InetAddress: /2620:15c:2ce:200:fb70:ba8c:5c39:dd96%eth0
> InetAddress: /fe80:0:0:0:3745:855d:754c:c782%eth0
> InetAddress: /100.117.216.36
> Up? true
> Loopback? false
> PointToPoint? false
> Supports multicast? true
> Virtual? false
> Hardware address: [112, 90, 15, 47, 36, 82]
> MTU: 1500
> Index: 2
>
> Display name: lo
> Name: lo
> InetAddress: /0:0:0:0:0:0:0:1%lo
> InetAddress: /127.0.0.1
> Up? true
> Loopback? true
> PointToPoint? false
> Supports multicast? false
> Virtual? false
> Hardware address: null
> MTU: 65536
> Index: 1
>
> *** end ***
> MembershipKey test using 225.4.5.6 @ eth0
> Exception Tests using 225.4.5.6, 1.2.3.4 @ eth0
> MembershipKey test using ff02:0:0:0:0:0:0:a @ eth0
> Exception Tests using ff02:0:0:0:0:0:0:a, fe80:0:0:0:0:0:0:1234 @ eth0
> --System.err:(1/15)--
> STATUS:Passed.
>
> http://cr.openjdk.java.net/~aeubanks/8224645/webrev.03
>