RFR [13] 8225037: java.net.JarURLConnection::getJarEntry() throws NullPointerException
The implementation of java.net.JarURLConnection has a private String, `entryName`, that is used to hold the optional jar file entry name. If the JAR file URL corresponding to the JarURLConnection points to a JAR file and not a JAR file entry, then `entryName` will be `null` ( which should be ok ). The default implementation of JarURLConnection::getJarEntry should only invoke `getJarEntry(entryName)` if the name is non-null. ( This is not an issue in the built-in JarURLConnection handler implementation, as it already correctly handles a null `entryName` ) https://cr.openjdk.java.net/~chegar/8225037/webrev.00/ -Chris.
Re: RFR [13] 8225037: java.net.JarURLConnection::getJarEntry() throws NullPointerException
Hi Chris, Change looks OK to me as method specifications tells " This method returns null if the JAR file URL corresponding to this connection points to a JAR file and not a JAR file entry." Thanks, Vyom - Original message -From: Chris Hegarty Sent by: "net-dev" To: OpenJDK Network Dev list Cc:Subject: [EXTERNAL] RFR [13] 8225037: java.net.JarURLConnection::getJarEntry() throws NullPointerExceptionDate: Fri, May 31, 2019 4:29 PM The implementation of java.net.JarURLConnection has a private String,`entryName`, that is used to hold the optional jar file entry name. Ifthe JAR file URL corresponding to the JarURLConnection points to a JARfile and not a JAR file entry, then `entryName` will be `null` ( whichshould be ok ).The default implementation of JarURLConnection::getJarEntry should onlyinvoke `getJarEntry(entryName)` if the name is non-null. ( This is notan issue in the built-in JarURLConnection handler implementation, as italready correctly handles a null `entryName` )https://cr.openjdk.java.net/~chegar/8225037/webrev.00/-Chris.
Re: [RFR] 8194231: java/net/DatagramSocket/ReuseAddressTest.java failed with java.net.BindException: Address already in use: Cannot bind
> On 28 May 2019, at 16:20, Chris Hegarty wrote: > > .. > > I would like to run it through our internal build and test infra, after which > I’ll post the results here. All clear ( this test passes successfully in our build and test environment ). -Chris.
RE: [RFR] 8194231: java/net/DatagramSocket/ReuseAddressTest.java failed with java.net.BindException: Address already in use: Cannot bind
Thanks, Chris. I pushed it then on behalf of Arno. > -Original Message- > From: net-dev On Behalf Of Chris > Hegarty > Sent: Freitag, 31. Mai 2019 16:06 > To: Zeller, Arno > Cc: net-dev@openjdk.java.net > Subject: Re: [RFR] 8194231: > java/net/DatagramSocket/ReuseAddressTest.java failed with > java.net.BindException: Address already in use: Cannot bind > > > > On 28 May 2019, at 16:20, Chris Hegarty > wrote: > > > > .. > > > > I would like to run it through our internal build and test infra, after > > which > > I’ll post the results here. > > All clear ( this test passes successfully in our build and test environment ). > > -Chris.
