Re: RFR [13] 8220719: Allow other named NetPermissions to be used

[Chris Hegarty]

> On 15 Mar 2019, at 15:22, Sean Mullan  wrote:
> 
> Looks good to me.
> 
> —Sean

Additionally, as noted in the CSR comments, an implNote ( similar to
that of what was added by 8077055 ) could be added, to clearly spell
out the possibility of, and guidance for, other non-standard target
names. It seems worth adding to `NetPermission`, if only to keep these
`BasicPermission` subclasses consistent.

Here is the updated change ( the implNote is non-normative so not
required to be part of the CSR ).

diff --git a/src/java.base/share/classes/java/net/NetPermission.java 
b/src/java.base/share/classes/java/net/NetPermission.java
--- a/src/java.base/share/classes/java/net/NetPermission.java
+++ b/src/java.base/share/classes/java/net/NetPermission.java
@@ -43,7 +43,7 @@
  * signify a wildcard match. For example: "foo.*" and "*" signify a wildcard
  * match, while "*foo" and "a*b" do not.
  * 
- * The following table lists all the possible NetPermission target names,
+ * The following table lists the standard NetPermission target names,
  * and for each provides a description of what the permission allows
  * and a discussion of the risks of granting code the permission.
  *
@@ -158,6 +158,10 @@

  * 
  *
+ * @implNote
+ * Implementations may define additional target names, but should use naming
+ * conventions such as reverse domain name notation to avoid name clashes.
+ *
  * @see java.security.BasicPermission
  * @see java.security.Permission
  * @see java.security.Permissions

-Chris.

Re: 8220493: Prepare Socket/ServerSocket for alternative platform SocketImpl

[Chris Hegarty]

> ...
> 
> The webrev with the corresponding changes is here:
>http://cr.openjdk.java.net/~alanb/8220493/0/webrev/ 
> I exchanged a few 
> messages offline with Alan regarding review comments
relating to this change. I'm happy to see it move forward and it has my
Review.

Onward, to the new platform SocketImpl and related technical debt
cleanup!

-Chris.

Re: RFR [13] 8220719: Allow other named NetPermissions to be used

[Alan Bateman]

On 16/03/2019 11:32, Chris Hegarty wrote:

*
+ * @implNote
+ * Implementations may define additional target names, but should use 
naming
+ * conventions such as reverse domain name notation to avoid name 
clashes.

+ *
* @see java.security.BasicPermission
* @see java.security.Permission
* @see java.security.Permissions

This looks okay to me, it's consistent with the wording in the other 
permission classes.


-Alan