RFR (testbug): 8210130: java/net/httpclient/UnknownBodyLengthTest.java failed

2019-01-28 Thread Daniel Fuchs 

Hi,

Please find below a test for:

8210130: java/net/httpclient/UnknownBodyLengthTest.java failed
https://bugs.openjdk.java.net/browse/JDK-8210130

webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8210130/webrev.00/

This test has been seen failing from time to time, often
Caused by: java.io.IOException: An established connection was
   aborted by the software in your host machine

The fix makes the test retry the operation once.
As far as my testing goes this does seem to make it more
robust.

best regards,

-- daniel

Re: RFR (testbug): 8210130: java/net/httpclient/UnknownBodyLengthTest.java failed

2019-01-28 Thread Chris Hegarty 



On 28/01/2019 12:03, Daniel Fuchs wrote:

Hi,

Please find below a test for:

8210130: java/net/httpclient/UnknownBodyLengthTest.java failed
https://bugs.openjdk.java.net/browse/JDK-8210130

webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8210130/webrev.00/


Looks good Daniel.

-Chris.

RFR (testbug): 8217882: java/net/httpclient/MaxStreams.java failed once

2019-01-28 Thread Daniel Fuchs 

Hi,

Please find below a patch for:

8217882: java/net/httpclient/MaxStreams.java failed once
https://bugs.openjdk.java.net/browse/JDK-8217882

webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8217882/webrev.00/

The patch simply instruments the test with
some more traces so that we might have a better
diagnosis next time it fails.

best regards,

-- daniel

Re: RFR (testbug): 8217882: java/net/httpclient/MaxStreams.java failed once

2019-01-28 Thread Brian Burkhalter 
Hi Daniel,

Perhaps consistently capitalize the first word in each message? Otherwise OK.

No need to refresh.

Thanks,

Brian

> On Jan 28, 2019, at 9:42 AM, Daniel Fuchs  wrote:
> 
> Please find below a patch for:
> 
> 8217882: java/net/httpclient/MaxStreams.java failed once
> https://bugs.openjdk.java.net/browse/JDK-8217882 
> 
> 
> webrev:
> http://cr.openjdk.java.net/~dfuchs/webrev_8217882/webrev.00/ 
> 
> 
> The patch simply instruments the test with
> some more traces so that we might have a better
> diagnosis next time it fails.

RFR: (testbug) 8217903: java/net/httpclient/Response204.java fails with 404

2019-01-28 Thread Daniel Fuchs 

Hi,

Please find below a test for:

8217903: java/net/httpclient/Response204.java fails with 404
https://bugs.openjdk.java.net/browse/JDK-8217903

webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8217903/webrev.00/

This is most certainly a port reuse issue.
This test should be using the loopback address but doesn't.

best regards,

-- daniel

Re: RFR (testbug): 8217882: java/net/httpclient/MaxStreams.java failed once

2019-01-28 Thread Daniel Fuchs 

Thanks Brian.
Done.

Also added a missing volatile.
http://cr.openjdk.java.net/~dfuchs/webrev_8217882/webrev.01

On 28/01/2019 17:45, Brian Burkhalter wrote:

Hi Daniel,

Perhaps consistently capitalize the first word in each message? 
Otherwise OK.


No need to refresh.

Thanks,

Brian

On Jan 28, 2019, at 9:42 AM, Daniel Fuchs > wrote:


Please find below a patch for:

8217882: java/net/httpclient/MaxStreams.java failed once
https://bugs.openjdk.java.net/browse/JDK-8217882

webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8217882/webrev.00/

The patch simply instruments the test with
some more traces so that we might have a better
diagnosis next time it fails.

Re: RFR: (testbug) 8217903: java/net/httpclient/Response204.java fails with 404

2019-01-28 Thread Chris Hegarty 



On 28/01/2019 17:57, Daniel Fuchs wrote:

Hi,

Please find below a test for:

8217903: java/net/httpclient/Response204.java fails with 404
https://bugs.openjdk.java.net/browse/JDK-8217903

webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8217903/webrev.00/


Ship it!

-Chris.