RFR 8215008: Clear confusion between URL/URI paths and file system paths
Hi, Please find below a fix for 8215008: Clear confusion between URL/URI paths and file system paths https://bugs.openjdk.java.net/browse/JDK-8215008 It adds a small non normative @apiNote to java.net.URL and java.net.URI. http://cr.openjdk.java.net/~dfuchs/webrev_8215008/webrev.00/ best regards, -- daniel
Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths
On 07/12/2018 15:13, Daniel Fuchs wrote: Hi, Please find below a fix for 8215008: Clear confusion between URL/URI paths and file system paths https://bugs.openjdk.java.net/browse/JDK-8215008 It adds a small non normative @apiNote to java.net.URL and java.net.URI. http://cr.openjdk.java.net/~dfuchs/webrev_8215008/webrev.00/ I've come across dozens of cases where code has been trying to use a URL path as a file path so an API note is a good idea. On the wording then "there is not necessarily any direct relationship ..." is a bit confusing to read, at least for file URIs where the file path is encoded as a URI. I also think it would be useful to link to the APIs that do the encoding/decoding, as in File(URI), File::toURI, Path.of(URI), Path::toUri. -Alan
Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths
Thanks for the feedback Alan! I have updated the webrev accordingly: http://cr.openjdk.java.net/~dfuchs/webrev_8215008/webrev.01/ best regards, -- daniel On 07/12/2018 15:20, Alan Bateman wrote: I've come across dozens of cases where code has been trying to use a URL path as a file path so an API note is a good idea. On the wording then "there is not necessarily any direct relationship ..." is a bit confusing to read, at least for file URIs where the file path is encoded as a URI. I also think it would be useful to link to the APIs that do the encoding/decoding, as in File(URI), File::toURI, Path.of(URI), Path::toUri. On 07/12/2018 15:13, Daniel Fuchs wrote: Please find below a fix for 8215008: Clear confusion between URL/URI paths and file system paths https://bugs.openjdk.java.net/browse/JDK-8215008 It adds a small non normative @apiNote to java.net.URL and java.net.URI.
Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths
> On 7 Dec 2018, at 16:16, Daniel Fuchs wrote: > > Thanks for the feedback Alan! > > I have updated the webrev accordingly: > > http://cr.openjdk.java.net/~dfuchs/webrev_8215008/webrev.01/ Looks good. Maybe userinfo. -Chris.
Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths
Thanks Chris. Will do. -- daniel On 07/12/2018 16:21, Chris Hegarty wrote: On 7 Dec 2018, at 16:16, Daniel Fuchs wrote: Thanks for the feedback Alan! I have updated the webrev accordingly: http://cr.openjdk.java.net/~dfuchs/webrev_8215008/webrev.01/ Looks good. Maybe userinfo. -Chris.
