Re: RFR 8181635/10, sun/net/www/protocol/jar/B6449504.java fails at Windows platform (after JDK-8181414)
> On 6 Jun 2017, at 05:52, Felix Yang wrote: > > Hi, > > please review the patch to make the test run with othervm mode. It has been > observed to be failing in agentvm mode, because Jar connection is not closed > in prior test. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8181635 > > Patch: > > --- old/test/sun/net/www/protocol/jar/B6449504.java 2017-06-05 > 21:32:37.163040164 -0700 > +++ new/test/sun/net/www/protocol/jar/B6449504.java 2017-06-05 > 21:32:36.992604088 -0700 > @@ -24,8 +24,8 @@ > /** > * @test > * @bug 6449504 > - * @run main B6449504 caching > - * @run main B6449504 no_caching > + * @run main/othervm B6449504 caching > + * @run main/othervm B6449504 no_caching > * @summary REGRESSION: ZipException throws when try to read a XML file > */ Looks ok. -Chris.
(9 jdk.incubator.httpclient) RFR: 8180044: java/net/httpclient/ManyRequests.java failed due to timeout
Hi, Please find below a patch that fixes several race conditions observed in the jdk.incubator.httpclient module. In particular this fixes: 8180044: java/net/httpclient/ManyRequests.java failed due to timeout https://bugs.openjdk.java.net/browse/JDK-8180044 and 8181430: HTTP/2 client might deadlock when receiving data during the initial handshake https://bugs.openjdk.java.net/browse/JDK-8181430 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8180044%2b8181430/webrev.00/ Testing: I have run the tests in a loop all week end. More info on the fix: https://bugs.openjdk.java.net/browse/JDK-8180044?focusedCommentId=14090708&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14090708 https://bugs.openjdk.java.net/browse/JDK-8181430?focusedCommentId=14089704&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14089704 https://bugs.openjdk.java.net/browse/JDK-8181430?focusedCommentId=14090734&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14090734 best regards, -- daniel
Re: Ping~ Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests
On 06/06/2017 01:43 PM, Felix Yang wrote: Missed "Add back read access" before trying to delete it? Based on my test results (local and JPRT), it deleted w/o any exceptions. This was originally added by Max in https://bugs.openjdk.java.net/browse/JDK-7078355. TO Max, could you comment if such chmod is still necessary? I'm not sure now. Re-read JDK-7078355, it seems once upon a time there existed such a system that you have to chmod u+r. If yes, since this is just for test clean-up rather than a part of test logic, is it enough with "File.setReadable(...)"? My opinion today is to just remove the tearDown() method at all and let jtreg do any cleanup/retain work. Jtreg should do this even if it's a testng test, right? Thanks Max
