RE: RFR (xxs): 8180424: Another build issue on AIX after 8034174

2017-05-17 Thread Langer, Christoph 
Hi Thomas,

this looks good and should definitely be downported to JDK9 as soon as possible.

Best regards
Christoph

From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-boun...@openjdk.java.net] On 
Behalf Of Thomas Stüfe
Sent: Dienstag, 16. Mai 2017 14:51
To: ppc-aix-port-...@openjdk.java.net; net-dev 
Subject: RFR (xxs): 8180424: Another build issue on AIX after 8034174

Hi all,

may I have a review for this tiny fix:

Issue: https://bugs.openjdk.java.net/browse/JDK-8180424
webrev: 
http://cr.openjdk.java.net/~stuefe/webrevs/8180424-another-build-issue-on-aix-after-8034174/webrev.00/webrev/

The prototypes for NET_RecvFrom and NET_Accept do not match their 
implementations for AIX since 8034174. This did not lead to an error in jdk9 
because there, the header (net_util_md.h) was not included by aix_close.c. In 
JDK10, it is included and therefore does not build.

I believe this did not lead to a runtime error on jdk9, at least not for the 
typical values involved; the mismatch is between int* and unsigned int* (native 
socklen_t).

Kind Regards, Thomas

Re: RFR (xxs): 8180424: Another build issue on AIX after 8034174

2017-05-17 Thread Vyom Tewari 

Hi Thomas,

fix look good to me, but i am not jdk10 reviewer.

Thanks,

Vyom


On Tuesday 16 May 2017 06:20 PM, Thomas Stüfe wrote:

Hi all,

may I have a review for this tiny fix:

Issue: https://bugs.openjdk.java.net/browse/JDK-8180424
webrev: 
http://cr.openjdk.java.net/~stuefe/webrevs/8180424-another-build-issue-on-aix-after-8034174/webrev.00/webrev/ 



The prototypes for NET_RecvFrom and NET_Accept do not match their 
implementations for AIX since 8034174. This did not lead to an error 
in jdk9 because there, the header (net_util_md.h) was not included by 
aix_close.c. In JDK10, it is included and therefore does not build.


I believe this did not lead to a runtime error on jdk9, at least not 
for the typical values involved; the mismatch is between int* and 
unsigned int* (native socklen_t).


Kind Regards, Thomas