RFR(S): 8171075: Inet4AddressImpl: Remove duplicate and (no longer used ?) native coding for BSD

2016-12-12 Thread Langer, Christoph 
Michael, Chris,

please have a look at this. This is the subset from 8167420 that removes the 
obsolete BSD coding.

Bug: https://bugs.openjdk.java.net/browse/JDK-8171075
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8171075.0/

Thanks,
Christoph

RFR (M): 8171077: Use getaddrinfo/getnameinfo in Windows Inet4AddresImpl native code

2016-12-12 Thread Langer, Christoph 
Hi again,

this is the Windows part.

Bug: https://bugs.openjdk.java.net/browse/JDK-8171077
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8171077.0/

Best regards
Christoph

RFR: 8171081: Put TimeoutOrderingTest in ProblemList for solaris-all

2016-12-12 Thread Daniel Fuchs 

Hi,


Please find below a trivial fix for:

https://bugs.openjdk.java.net/browse/JDK-8171081
8171081: Put TimeoutOrderingTest in ProblemList for solaris-all

The test is also marked intermittent.

http://cr.openjdk.java.net/~dfuchs/webrev_8171081/webrev.00/


best regards,

-- daniel

Re: RFR: 8171081: Put TimeoutOrderingTest in ProblemList for solaris-all

2016-12-12 Thread Chris Hegarty 

On 12/12/16 11:14, Daniel Fuchs wrote:

Hi,


Please find below a trivial fix for:

https://bugs.openjdk.java.net/browse/JDK-8171081
8171081: Put TimeoutOrderingTest in ProblemList for solaris-all

The test is also marked intermittent.

http://cr.openjdk.java.net/~dfuchs/webrev_8171081/webrev.00/


Thank you Daniel. Reviewed.

-Chris.

Re: RFR (S): 8164057: Fix @since for java.net.Inet[46]Address

2016-12-12 Thread Chris Hegarty 


On 07/12/16 13:05, Langer, Christoph wrote:

Hi Chris,

Ok, thanks. Let me know when ccc is processed and it can be pushed.


You have a green light to push these changes.

-Chris.



Best regards
Christoph


-Original Message-
From: Chris Hegarty [mailto:chris.hega...@oracle.com]
Sent: Mittwoch, 7. Dezember 2016 11:52
To: Langer, Christoph 
Cc: net-dev@openjdk.java.net
Subject: Re: RFR (S): 8164057: Fix @since for java.net.Inet[46]Address

Hi Christoph,


On 7 Dec 2016, at 08:38, Langer, Christoph 

wrote:


Hi,

please review this small fix.

Bug: https://bugs.openjdk.java.net/browse/JDK-8164057
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8164057.0/

The root cause of the wrong “@since” tags probably is that the classes

Inet[46]Address had been created as copy of InetAddress. InetAddress itself
obviously exists since 1.0 and methods have been added over time. The copying
of InetAddress towards Inet[46]Adress has been done for Java 1.4 and hence all
Javadoc that was tagged @since <1.4 is not correct for the new classes.

I suspect that you’re right. This looks like an oversight during the addition of
these classes in 1.4.


I suggest to remove all @since <= 1.4 since the classes themselves are

annotated “@since 1.4” which would imply all unannotated methods exist from
1.4 onwards. Alternatively we could a) remove only occurences of @since < 1.4
or b) change all @since < 1.4 to @since 1.4.

I think I favour the approach that you have taken in the webrev, remove all
occurrences of @since <= 1.4. This can be considered as a Review, from me.

I will shepherd this through the CCC process and let you know when it is
complete, or if any issues arise.

-Chris.

RE: RFR (S): 8164057: Fix @since for java.net.Inet[46]Address

2016-12-12 Thread Langer, Christoph 
Done: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/03d7bdec12fe


> -Original Message-
> From: Chris Hegarty [mailto:chris.hega...@oracle.com]
> Sent: Montag, 12. Dezember 2016 15:30
> To: Langer, Christoph 
> Cc: net-dev@openjdk.java.net; Volker Simonis 
> Subject: Re: RFR (S): 8164057: Fix @since for java.net.Inet[46]Address
> 
> 
> On 07/12/16 13:05, Langer, Christoph wrote:
> > Hi Chris,
> >
> > Ok, thanks. Let me know when ccc is processed and it can be pushed.
> 
> You have a green light to push these changes.
> 
> -Chris.
> 
> 
> > Best regards
> > Christoph
> >
> >> -Original Message-
> >> From: Chris Hegarty [mailto:chris.hega...@oracle.com]
> >> Sent: Mittwoch, 7. Dezember 2016 11:52
> >> To: Langer, Christoph 
> >> Cc: net-dev@openjdk.java.net
> >> Subject: Re: RFR (S): 8164057: Fix @since for java.net.Inet[46]Address
> >>
> >> Hi Christoph,
> >>
> >>> On 7 Dec 2016, at 08:38, Langer, Christoph 
> >> wrote:
> >>>
> >>> Hi,
> >>>
> >>> please review this small fix.
> >>>
> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8164057
> >>> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8164057.0/
> >>>
> >>> The root cause of the wrong “@since” tags probably is that the classes
> >> Inet[46]Address had been created as copy of InetAddress. InetAddress itself
> >> obviously exists since 1.0 and methods have been added over time. The
> copying
> >> of InetAddress towards Inet[46]Adress has been done for Java 1.4 and hence
> all
> >> Javadoc that was tagged @since <1.4 is not correct for the new classes.
> >>
> >> I suspect that you’re right. This looks like an oversight during the 
> >> addition of
> >> these classes in 1.4.
> >>
> >>> I suggest to remove all @since <= 1.4 since the classes themselves are
> >> annotated “@since 1.4” which would imply all unannotated methods exist
> from
> >> 1.4 onwards. Alternatively we could a) remove only occurences of @since <
> 1.4
> >> or b) change all @since < 1.4 to @since 1.4.
> >>
> >> I think I favour the approach that you have taken in the webrev, remove all
> >> occurrences of @since <= 1.4. This can be considered as a Review, from me.
> >>
> >> I will shepherd this through the CCC process and let you know when it is
> >> complete, or if any issues arise.
> >>
> >> -Chris.
> >>
> >

RFR 8168840: InetAddress.getByName() throws java.net.UnknownHostException no such interface when used with virtual interfaces on Solaris

2016-12-12 Thread Vyom Tewari 

Hi,

Please review the code changes for below issue.

BugId: https://bugs.openjdk.java.net/browse/JDK-8168840

webrev : 
http://cr.openjdk.java.net/~vtewari/8168840/webrev0.0/index.html 



Thanks,

Vyom