Re: RFR(s): 8166791: Fix module dependencies for networking component tests
Resending this for review 27.09.16 18:44, Sergei Kovalev wrote: Hi team, Could you please review small fix for regression tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8166791 WebRev: http://cr.openjdk.java.net/~skovalev/8166791/webrev.00/ Issue: Severl network related tests failed in case of using "--limit-modules java.base" command line option. The test java/net/httpclient/http2/ErrorTest.java should declare dependencies on 'jdk.security.auth' module. java/net/httpclient/security/Driver.java should depend oh 'java.httpclient' and 'jdk.httpserver'. java/net/spi/URLStreamHandlerProvider/Basic.java and sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java have declaration of dependency on 'java.compiler' but should be 'jdk.compiler'. From the test java/net/httpclient/http2/HpackDriver.java extracted one part that depends on 'jdk.localedata': java/net/httpclient/http2/HpackDriverHeaderTable.java because other part don't have any extra dependencies and could be executed in general case. -- With best regards, Sergei
Re: RFR(s): 8166791: Fix module dependencies for networking component tests
Sergei, On 03/10/16 11:08, Sergei Kovalev wrote: Resending this for review 27.09.16 18:44, Sergei Kovalev wrote: Hi team, Could you please review small fix for regression tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8166791 WebRev: http://cr.openjdk.java.net/~skovalev/8166791/webrev.00/ Issue: Severl network related tests failed in case of using "--limit-modules java.base" command line option. The test java/net/httpclient/http2/ErrorTest.java should declare dependencies on 'jdk.security.auth' module. I cannot find the reason why you think this module needs jdk.security.auth, can you please explain. java/net/httpclient/security/Driver.java should depend oh 'java.httpclient' and 'jdk.httpserver'. java/net/spi/URLStreamHandlerProvider/Basic.java and sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java have declaration of dependency on 'java.compiler' but should be 'jdk.compiler'. They should require both java.compiler and jdk.compiler, no? From the test java/net/httpclient/http2/HpackDriver.java extracted one part that depends on 'jdk.localedata': java/net/httpclient/http2/HpackDriverHeaderTable.java because other part don't have any extra dependencies and could be executed in general case. -Chris.
Re: RFR(s): 8166791: Fix module dependencies for networking component tests
Hi Chris, Thank you for looking this. 03.10.16 16:05, Chris Hegarty wrote: Sergei, On 03/10/16 11:08, Sergei Kovalev wrote: Resending this for review 27.09.16 18:44, Sergei Kovalev wrote: Hi team, Could you please review small fix for regression tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8166791 WebRev: http://cr.openjdk.java.net/~skovalev/8166791/webrev.00/ Issue: Severl network related tests failed in case of using "--limit-modules java.base" command line option. The test java/net/httpclient/http2/ErrorTest.java should declare dependencies on 'jdk.security.auth' module. I cannot find the reason why you think this module needs jdk.security.auth, can you please explain. SSL engin requires security provider. Its implementation located in jdk.security.auth. In case no jdk module added we getting an exception: test ErrorTest.test(): failure java.lang.IllegalArgumentException: Cannot support TLS_KRB5_WITH_3DES_EDE_CBC_SHA with currently installed providers at sun.security.ssl.CipherSuiteList.(java.base@9-ea/CipherSuiteList.java:81) at sun.security.ssl.SSLEngineImpl.setEnabledCipherSuites(java.base@9-ea/SSLEngineImpl.java:2087) at javax.net.ssl.SSLEngine.setSSLParameters(java.base@9-ea/SSLEngine.java:1269) at sun.security.ssl.SSLEngineImpl.setSSLParameters(java.base@9-ea/SSLEngineImpl.java:2166) ... java/net/httpclient/security/Driver.java should depend oh 'java.httpclient' and 'jdk.httpserver'. java/net/spi/URLStreamHandlerProvider/Basic.java and sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java have declaration of dependency on 'java.compiler' but should be 'jdk.compiler'. They should require both java.compiler and jdk.compiler, no? You are right. The tests requires java.compiler for compilation and jdk.compiler for execution. I've done appropriate changes. Please take a look at: http://cr.openjdk.java.net/~skovalev/8166791/webrev.01/ From the test java/net/httpclient/http2/HpackDriver.java extracted one part that depends on 'jdk.localedata': java/net/httpclient/http2/HpackDriverHeaderTable.java because other part don't have any extra dependencies and could be executed in general case. -Chris. -- With best regards, Sergei
Re: RFR(s): 8166791: Fix module dependencies for networking component tests
On 03/10/2016 14:33, Sergei Kovalev wrote: SSL engin requires security provider. Its implementation located in jdk.security.auth. In case no jdk module added we getting an exception: test ErrorTest.test(): failure java.lang.IllegalArgumentException: Cannot support TLS_KRB5_WITH_3DES_EDE_CBC_SHA with currently installed providers at sun.security.ssl.CipherSuiteList.(java.base@9-ea/CipherSuiteList.java:81) at sun.security.ssl.SSLEngineImpl.setEnabledCipherSuites(java.base@9-ea/SSLEngineImpl.java:2087) at javax.net.ssl.SSLEngine.setSSLParameters(java.base@9-ea/SSLEngine.java:1269) at sun.security.ssl.SSLEngineImpl.setSSLParameters(java.base@9-ea/SSLEngineImpl.java:2166) The Kerberos ciphers are in java.security.jgss so that might be what you need here. -Alan
Re: RFR(s): 8166791: Fix module dependencies for networking component tests
Fixed http://cr.openjdk.java.net/~skovalev/8166791/webrev.02/ 03.10.16 16:36, Alan Bateman wrote: On 03/10/2016 14:33, Sergei Kovalev wrote: SSL engin requires security provider. Its implementation located in jdk.security.auth. In case no jdk module added we getting an exception: test ErrorTest.test(): failure java.lang.IllegalArgumentException: Cannot support TLS_KRB5_WITH_3DES_EDE_CBC_SHA with currently installed providers at sun.security.ssl.CipherSuiteList.(java.base@9-ea/CipherSuiteList.java:81) at sun.security.ssl.SSLEngineImpl.setEnabledCipherSuites(java.base@9-ea/SSLEngineImpl.java:2087) at javax.net.ssl.SSLEngine.setSSLParameters(java.base@9-ea/SSLEngine.java:1269) at sun.security.ssl.SSLEngineImpl.setSSLParameters(java.base@9-ea/SSLEngineImpl.java:2166) The Kerberos ciphers are in java.security.jgss so that might be what you need here. -Alan -- With best regards, Sergei
Re: RFR(s): 8166791: Fix module dependencies for networking component tests
On 03/10/16 14:43, Sergei Kovalev wrote: Fixed http://cr.openjdk.java.net/~skovalev/8166791/webrev.02/ java.compiler already exports javax.tools so no need for the explicit export in the @modules tag. Otherwise this is fine. -Chris. 03.10.16 16:36, Alan Bateman wrote: On 03/10/2016 14:33, Sergei Kovalev wrote: SSL engin requires security provider. Its implementation located in jdk.security.auth. In case no jdk module added we getting an exception: test ErrorTest.test(): failure java.lang.IllegalArgumentException: Cannot support TLS_KRB5_WITH_3DES_EDE_CBC_SHA with currently installed providers at sun.security.ssl.CipherSuiteList.(java.base@9-ea/CipherSuiteList.java:81) at sun.security.ssl.SSLEngineImpl.setEnabledCipherSuites(java.base@9-ea/SSLEngineImpl.java:2087) at javax.net.ssl.SSLEngine.setSSLParameters(java.base@9-ea/SSLEngine.java:1269) at sun.security.ssl.SSLEngineImpl.setSSLParameters(java.base@9-ea/SSLEngineImpl.java:2166) The Kerberos ciphers are in java.security.jgss so that might be what you need here. -Alan
Re: RFR(s): 8166791: Fix module dependencies for networking component tests
Such notation (module/package) helps to jtreg to understand that the module required on compilation stage. Jtreg adding "--add-exports module/package=ALL-UNNAMED" for each record of this type. In our case id adds a string: --add-exports java.compiler/javax.tools=ALL-UNNAMED. -- With best regards, Sergei 03.10.16 16:59, Chris Hegarty wrote: On 03/10/16 14:43, Sergei Kovalev wrote: Fixed http://cr.openjdk.java.net/~skovalev/8166791/webrev.02/ java.compiler already exports javax.tools so no need for the explicit export in the @modules tag. Otherwise this is fine. -Chris. 03.10.16 16:36, Alan Bateman wrote: On 03/10/2016 14:33, Sergei Kovalev wrote: SSL engin requires security provider. Its implementation located in jdk.security.auth. In case no jdk module added we getting an exception: test ErrorTest.test(): failure java.lang.IllegalArgumentException: Cannot support TLS_KRB5_WITH_3DES_EDE_CBC_SHA with currently installed providers at sun.security.ssl.CipherSuiteList.(java.base@9-ea/CipherSuiteList.java:81) at sun.security.ssl.SSLEngineImpl.setEnabledCipherSuites(java.base@9-ea/SSLEngineImpl.java:2087) at javax.net.ssl.SSLEngine.setSSLParameters(java.base@9-ea/SSLEngine.java:1269) at sun.security.ssl.SSLEngineImpl.setSSLParameters(java.base@9-ea/SSLEngineImpl.java:2166) The Kerberos ciphers are in java.security.jgss so that might be what you need here. -Alan
Re: RFR(s): 8166791: Fix module dependencies for networking component tests
On 03/10/2016 15:05, Sergei Kovalev wrote: Such notation (module/package) helps to jtreg to understand that the module required on compilation stage. Jtreg adding "--add-exports module/package=ALL-UNNAMED" for each record of this type. In our case id adds a string: --add-exports java.compiler/javax.tools=ALL-UNNAMED. Chris is right, there is no need for "/javax.tools" here. -Alan
Re: RFR(s): 8166791: Fix module dependencies for networking component tests
Changed http://cr.openjdk.java.net/~skovalev/8166791/webrev.03/ 03.10.16 17:07, Alan Bateman wrote: On 03/10/2016 15:05, Sergei Kovalev wrote: Such notation (module/package) helps to jtreg to understand that the module required on compilation stage. Jtreg adding "--add-exports module/package=ALL-UNNAMED" for each record of this type. In our case id adds a string: --add-exports java.compiler/javax.tools=ALL-UNNAMED. Chris is right, there is no need for "/javax.tools" here. -Alan -- With best regards, Sergei
Re: RFR(s): 8166791: Fix module dependencies for networking component tests
On 03/10/16 15:19, Sergei Kovalev wrote: Changed http://cr.openjdk.java.net/~skovalev/8166791/webrev.03/ This looks fine. Reviewed. No need to generate the webrev, but can you please check that you list the java.* modules before the jdk.* ones. Thanks, -Chris. 03.10.16 17:07, Alan Bateman wrote: On 03/10/2016 15:05, Sergei Kovalev wrote: Such notation (module/package) helps to jtreg to understand that the module required on compilation stage. Jtreg adding "--add-exports module/package=ALL-UNNAMED" for each record of this type. In our case id adds a string: --add-exports java.compiler/javax.tools=ALL-UNNAMED. Chris is right, there is no need for "/javax.tools" here. -Alan
Re: RFR(s): 8166791: Fix module dependencies for networking component tests
Ok. Will do 03.10.16 17:22, Chris Hegarty wrote: On 03/10/16 15:19, Sergei Kovalev wrote: Changed http://cr.openjdk.java.net/~skovalev/8166791/webrev.03/ This looks fine. Reviewed. No need to generate the webrev, but can you please check that you list the java.* modules before the jdk.* ones. Thanks, -Chris. -- With best regards, Sergei
